Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/android-platform-system-tools-hidl-9.0.0+r45/AST.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/AST.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Annotation.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Annotation.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/ArrayType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/ArrayType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/CompoundType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/CompoundType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/ConstantExpression.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/ConstantExpression.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Coordinator.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/DeathRecipientType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/DeathRecipientType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/DocComment.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/DocComment.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/EnumType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/FmqType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/FmqType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/HandleType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/HandleType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Hash.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/HidlTypeAssertion.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Interface.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Interface.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Location.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Location.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/MemoryType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/MemoryType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Method.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Method.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/NamedType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/NamedType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/PointerType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/PointerType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/RefType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/RefType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Reference.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/ScalarType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/ScalarType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Scope.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Scope.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/StringType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/StringType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Type.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Type.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/TypeDef.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/TypeDef.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/VectorType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/VectorType.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/AST.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/AST.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/CompositeDeclaration.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/CompositeDeclaration.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Declaration.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Declaration.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Define.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Define.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/EnumVarDeclaration.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/EnumVarDeclaration.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Expression.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Expression.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/FunctionDeclaration.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/FunctionDeclaration.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Include.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Include.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Note.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Note.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Scope.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Type.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/Type.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/TypeDef.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/TypeDef.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/VarDeclaration.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/VarDeclaration.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/main.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/test/simple.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/test/test.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/generateCpp.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/generateCppAdapter.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/generateCppImpl.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/generateJava.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/generateVts.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/hidl-gen_l.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/include_hash/hidl-hash/Hash.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/export_test/test.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/FooCallback.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/FooCallback.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test_client.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test_servers.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/static_test.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/host_test/main.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/java_test/hidl_test_java_native.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/utils_test/main.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/test/vendor/1.0/vendor-base.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/utils/FQName.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/utils/Formatter.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/utils/FqInstance.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/utils/StringHelper.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/utils/include/hidl-util/FQName.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/utils/include/hidl-util/Formatter.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/utils/include/hidl-util/FqInstance.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/utils/include/hidl-util/StringHelper.h
Examining data/android-platform-system-tools-hidl-9.0.0+r45/Coordinator.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/EnumType.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/HidlTypeAssertion.cpp
Examining data/android-platform-system-tools-hidl-9.0.0+r45/main.cpp
FINAL RESULTS:
data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/main.cpp:117:19: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((res = getopt(argc, argv, "ghvo:p:r:")) >= 0) {
data/android-platform-system-tools-hidl-9.0.0+r45/main.cpp:1221:19: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((res = getopt(argc, argv, "hp:o:O:r:L:vd:")) >= 0) {
data/android-platform-system-tools-hidl-9.0.0+r45/main.cpp:1314:41: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* ANDROID_BUILD_TOP = getenv("ANDROID_BUILD_TOP");
data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test_client.cpp:2218:19: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((res = getopt_long(argc, argv, "hbpd", longopts, NULL)) >= 0) {
data/android-platform-system-tools-hidl-9.0.0+r45/test/java_test/hidl_test_java_native.cpp:588:19: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((res = getopt(argc, argv, "chs")) >= 0) {
data/android-platform-system-tools-hidl-9.0.0+r45/Coordinator.cpp:122:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* file = fopen(filepath.c_str(), "w");
data/android-platform-system-tools-hidl-9.0.0+r45/Coordinator.cpp:194:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* file = fopen(mDepFile.c_str(), "w");
data/android-platform-system-tools-hidl-9.0.0+r45/Coordinator.cpp:272:60: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
std::unique_ptr<FILE, std::function<void(FILE*)>> file(fopen(path.c_str(), "rb"), fclose);
data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/AST.cpp:260:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *file = fopen((getFileDir() + fileName).c_str(), "w");
data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/AST.cpp:281:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *file = fopen((getFileDir() + "types.hal").c_str(), "w");
data/android-platform-system-tools-hidl-9.0.0+r45/c2hal/test/simple.h:74:29: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
return module->methods->open(module,
data/android-platform-system-tools-hidl-9.0.0+r45/Coordinator.cpp:469:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const auto suffix_len = std::strlen(suffix);
data/android-platform-system-tools-hidl-9.0.0+r45/Coordinator.cpp:470:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const auto d_namelen = strlen(ent->d_name);
data/android-platform-system-tools-hidl-9.0.0+r45/main.cpp:294:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
limitToType = fqName.name().substr(strlen("types."));
data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test_client.cpp:818:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
memory->read();
data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test_client.cpp:833:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
memory->read();
data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test_client.cpp:852:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
memory->read();
data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test_client.cpp:896:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
memory->read();
data/android-platform-system-tools-hidl-9.0.0+r45/test/hidl_test/hidl_test_client.cpp:1034:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
EXPECT_EQ(strlen("Hello, world"), something.size());
ANALYSIS SUMMARY:
Hits = 19
Lines analyzed = 27218 in approximately 0.68 seconds (40060 lines/second)
Physical Source Lines of Code (SLOC) = 19501
Hits@level = [0] 74 [1] 8 [2] 6 [3] 5 [4] 0 [5] 0
Hits@level+ = [0+] 93 [1+] 19 [2+] 11 [3+] 5 [4+] 0 [5+] 0
Hits/KSLOC@level+ = [0+] 4.76899 [1+] 0.974309 [2+] 0.564074 [3+] 0.256397 [4+] 0 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.