Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/bamf-0.5.4/src/bamf-legacy-window.h
Examining data/bamf-0.5.4/src/bamf-control.h
Examining data/bamf-0.5.4/src/bamf-view.h
Examining data/bamf-0.5.4/src/bamf-tab.c
Examining data/bamf-0.5.4/src/bamf-window.c
Examining data/bamf-0.5.4/src/bamf-application.c
Examining data/bamf-0.5.4/src/bamf-xutils.h
Examining data/bamf-0.5.4/src/bamf-legacy-window-test.h
Examining data/bamf-0.5.4/src/bamf-legacy-screen-private.h
Examining data/bamf-0.5.4/src/main.h
Examining data/bamf-0.5.4/src/bamf-daemon.c
Examining data/bamf-0.5.4/src/main.c
Examining data/bamf-0.5.4/src/bamf-matcher-private.h
Examining data/bamf-0.5.4/src/bamf-daemon.h
Examining data/bamf-0.5.4/src/bamf-tab.h
Examining data/bamf-0.5.4/src/bamf-application.h
Examining data/bamf-0.5.4/src/bamf-control.c
Examining data/bamf-0.5.4/src/bamf-legacy-window.c
Examining data/bamf-0.5.4/src/bamf-legacy-screen.c
Examining data/bamf-0.5.4/src/bamf-xutils.c
Examining data/bamf-0.5.4/src/bamf-legacy-window-test.c
Examining data/bamf-0.5.4/src/bamf-view.c
Examining data/bamf-0.5.4/src/bamf-window.h
Examining data/bamf-0.5.4/src/bamf-matcher.c
Examining data/bamf-0.5.4/src/bamf-matcher.h
Examining data/bamf-0.5.4/src/bamf-legacy-screen.h
Examining data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c
Examining data/bamf-0.5.4/tests/bamfdaemon/test-window.c
Examining data/bamf-0.5.4/tests/bamfdaemon/test-view.c
Examining data/bamf-0.5.4/tests/bamfdaemon/test-application.c
Examining data/bamf-0.5.4/tests/bamfdaemon/test-bamf.c
Examining data/bamf-0.5.4/tests/libbamf/test-matcher.c
Examining data/bamf-0.5.4/tests/libbamf/test-application.c
Examining data/bamf-0.5.4/tests/libbamf/test-libbamf.c
Examining data/bamf-0.5.4/lib/libbamf/bamf-factory.c
Examining data/bamf-0.5.4/lib/libbamf/bamf-view-private.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-control.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-view.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-application-private.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-window.c
Examining data/bamf-0.5.4/lib/libbamf/bamf-application.c
Examining data/bamf-0.5.4/lib/libbamf/libbamf.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-factory.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-tab.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-application.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-control.c
Examining data/bamf-0.5.4/lib/libbamf/bamf-view.c
Examining data/bamf-0.5.4/lib/libbamf/bamf-window.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-matcher.c
Examining data/bamf-0.5.4/lib/libbamf/bamf-matcher.h
Examining data/bamf-0.5.4/lib/libbamf/bamf-tab.c
Examining data/bamf-0.5.4/lib/libbamf-private/bamf-private.h
FINAL RESULTS:
data/bamf-0.5.4/src/bamf-legacy-window-test.c:510:15: [3] (random) g_random_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
self->pid = g_random_int_range (1, 100000);
data/bamf-0.5.4/src/bamf-matcher.c:1160:28: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
path = g_build_filename (g_get_home_dir (), ".local/share/applications", NULL);
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:227:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint pid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:254:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint pid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:271:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint pid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:289:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint pid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:503:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:579:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:586:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:608:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:693:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:705:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:718:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:759:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:760:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint pid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:807:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:835:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:843:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:852:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:880:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:889:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:898:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:926:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:935:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:945:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:973:15: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:981:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:992:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:1026:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:1037:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/tests/bamfdaemon/test-matcher.c:1236:9: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
xid = g_random_int ();
data/bamf-0.5.4/src/bamf-legacy-screen.c:112:19: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
xid = (guint32) atol (parts[1]);
data/bamf-0.5.4/src/bamf-legacy-screen.c:174:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int x = atoi (parts[2]);
data/bamf-0.5.4/src/bamf-legacy-screen.c:175:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int y = atoi (parts[3]);
data/bamf-0.5.4/src/bamf-legacy-screen.c:176:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int width = atoi (parts[4]);
data/bamf-0.5.4/src/bamf-legacy-screen.c:177:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int height = atoi (parts[5]);
data/bamf-0.5.4/src/bamf-window.c:292:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (sandboxed_app_id, contents_start, security_label_contents_size);
data/bamf-0.5.4/src/bamf-matcher.c:577:71: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = 0; i < file_len && environ && environ[i] != '\0'; i += strlen (environ + i) + 1)
data/bamf-0.5.4/src/bamf-matcher.c:1953:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int max_chars = strlen (win_class_name);
data/bamf-0.5.4/src/bamf-xutils.c:179:71: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
type, 8, PropModeReplace, (unsigned char *) value, strlen (value));
data/bamf-0.5.4/tests/bamfdaemon/test-application.c:57:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!g_output_stream_write_all (output, data, strlen (data), NULL, NULL, NULL))
ANALYSIS SUMMARY:
Hits = 41
Lines analyzed = 20581 in approximately 0.41 seconds (50788 lines/second)
Physical Source Lines of Code (SLOC) = 14656
Hits@level = [0] 0 [1] 4 [2] 6 [3] 31 [4] 0 [5] 0
Hits@level+ = [0+] 41 [1+] 41 [2+] 37 [3+] 31 [4+] 0 [5+] 0
Hits/KSLOC@level+ = [0+] 2.79749 [1+] 2.79749 [2+] 2.52456 [3+] 2.11517 [4+] 0 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.