Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/bino-1.6.6/src/NvSDIout.cpp
Examining data/bino-1.6.6/src/NvSDIout.h
Examining data/bino-1.6.6/src/NvSDIutils.cpp
Examining data/bino-1.6.6/src/NvSDIutils.h
Examining data/bino-1.6.6/src/audio_output.cpp
Examining data/bino-1.6.6/src/audio_output.h
Examining data/bino-1.6.6/src/audiodialog.cpp
Examining data/bino-1.6.6/src/audiodialog.h
Examining data/bino-1.6.6/src/base/blb.h
Examining data/bino-1.6.6/src/base/chk.h
Examining data/bino-1.6.6/src/base/dbg.cpp
Examining data/bino-1.6.6/src/base/dbg.h
Examining data/bino-1.6.6/src/base/exc.cpp
Examining data/bino-1.6.6/src/base/exc.h
Examining data/bino-1.6.6/src/base/gettext.h
Examining data/bino-1.6.6/src/base/msg.cpp
Examining data/bino-1.6.6/src/base/msg.h
Examining data/bino-1.6.6/src/base/opt.cpp
Examining data/bino-1.6.6/src/base/opt.h
Examining data/bino-1.6.6/src/base/pth.cpp
Examining data/bino-1.6.6/src/base/pth.h
Examining data/bino-1.6.6/src/base/ser.cpp
Examining data/bino-1.6.6/src/base/ser.h
Examining data/bino-1.6.6/src/base/str.cpp
Examining data/bino-1.6.6/src/base/str.h
Examining data/bino-1.6.6/src/base/tmr.cpp
Examining data/bino-1.6.6/src/base/tmr.h
Examining data/bino-1.6.6/src/color_matrix.cpp
Examining data/bino-1.6.6/src/color_matrix.h
Examining data/bino-1.6.6/src/colordialog.cpp
Examining data/bino-1.6.6/src/colordialog.h
Examining data/bino-1.6.6/src/command_file.cpp
Examining data/bino-1.6.6/src/command_file.h
Examining data/bino-1.6.6/src/controlswidget.cpp
Examining data/bino-1.6.6/src/controlswidget.h
Examining data/bino-1.6.6/src/crosstalkdialog.cpp
Examining data/bino-1.6.6/src/crosstalkdialog.h
Examining data/bino-1.6.6/src/dispatch.cpp
Examining data/bino-1.6.6/src/dispatch.h
Examining data/bino-1.6.6/src/fullscreendialog.cpp
Examining data/bino-1.6.6/src/fullscreendialog.h
Examining data/bino-1.6.6/src/gui.cpp
Examining data/bino-1.6.6/src/gui.h
Examining data/bino-1.6.6/src/gui_common.h
Examining data/bino-1.6.6/src/inoutwidget.cpp
Examining data/bino-1.6.6/src/inoutwidget.h
Examining data/bino-1.6.6/src/lib_versions.cpp
Examining data/bino-1.6.6/src/lib_versions.h
Examining data/bino-1.6.6/src/lirc.cpp
Examining data/bino-1.6.6/src/lirc.h
Examining data/bino-1.6.6/src/main.cpp
Examining data/bino-1.6.6/src/mainwindow.cpp
Examining data/bino-1.6.6/src/mainwindow.h
Examining data/bino-1.6.6/src/media_data.cpp
Examining data/bino-1.6.6/src/media_data.h
Examining data/bino-1.6.6/src/media_input.cpp
Examining data/bino-1.6.6/src/media_input.h
Examining data/bino-1.6.6/src/media_object.h
Examining data/bino-1.6.6/src/opendevicedialog.cpp
Examining data/bino-1.6.6/src/opendevicedialog.h
Examining data/bino-1.6.6/src/player.cpp
Examining data/bino-1.6.6/src/player.h
Examining data/bino-1.6.6/src/player_equalizer.cpp
Examining data/bino-1.6.6/src/player_equalizer.h
Examining data/bino-1.6.6/src/preferences.cpp
Examining data/bino-1.6.6/src/preferences.h
Examining data/bino-1.6.6/src/qualitydialog.cpp
Examining data/bino-1.6.6/src/qualitydialog.h
Examining data/bino-1.6.6/src/sdioutputdialog.cpp
Examining data/bino-1.6.6/src/sdioutputdialog.h
Examining data/bino-1.6.6/src/subtitle_renderer.cpp
Examining data/bino-1.6.6/src/subtitle_renderer.h
Examining data/bino-1.6.6/src/subtitledialog.cpp
Examining data/bino-1.6.6/src/subtitledialog.h
Examining data/bino-1.6.6/src/video_output.cpp
Examining data/bino-1.6.6/src/video_output.h
Examining data/bino-1.6.6/src/video_output_qt.cpp
Examining data/bino-1.6.6/src/video_output_qt.h
Examining data/bino-1.6.6/src/videodialog.cpp
Examining data/bino-1.6.6/src/videodialog.h
Examining data/bino-1.6.6/src/zoomdialog.cpp
Examining data/bino-1.6.6/src/zoomdialog.h
Examining data/bino-1.6.6/src/media_object.cpp
FINAL RESULTS:
data/bino-1.6.6/src/NvSDIutils.cpp:91:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (gpuDevice.deviceName, str);
data/bino-1.6.6/src/base/dbg.cpp:99:19: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
FILE *f = popen(cmd_buf, "r");
data/bino-1.6.6/src/base/msg.h:33:48: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# define MSG_AFP(a, b) __attribute__ ((format (printf, a, b)))
data/bino-1.6.6/src/base/str.cpp:74:18: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int length = vsnprintf(NULL, 0, format, args);
data/bino-1.6.6/src/base/str.cpp:80:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(*strp, length + 1, format, args);
data/bino-1.6.6/src/base/str.h:36:48: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# define STR_AFP(a, b) __attribute__ ((format (printf, a, b)))
data/bino-1.6.6/src/base/msg.cpp:78:20: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((s = ::getenv("COLUMNS")))
data/bino-1.6.6/src/base/opt.cpp:159:26: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
int optval = getopt_long(argc, argv, shortopts, longopts, NULL);
data/bino-1.6.6/src/lib_versions.cpp:142:31: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *display = getenv("DISPLAY");
data/bino-1.6.6/src/main.cpp:206:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *display = getenv("DISPLAY");
data/bino-1.6.6/src/subtitle_renderer.cpp:149:9: [3] (tmpfile) GetTempFileName:
Temporary file race condition in certain cases (e.g., if run as SYSTEM in
many versions of Windows) (CWE-377).
if (GetTempFileName(tmppathname, "fonts_conf", 0, tmpfilename) == 0)
data/bino-1.6.6/src/video_output.cpp:838:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
|| std::getenv("SRGB_TEXTURES_ARE_BROKEN") // XXX: Hack: work around broken SRGB texture implementations
data/bino-1.6.6/src/NvSDIutils.h:38:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char deviceName[256];
data/bino-1.6.6/src/base/blb.h:104:18: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(_ptr, b._ptr, _size);
data/bino-1.6.6/src/base/blb.h:116:18: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(ptr, b.ptr(), b.size());
data/bino-1.6.6/src/base/dbg.cpp:95:9: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(cmd_buf, "addr2line -e ");
data/bino-1.6.6/src/base/dbg.cpp:105:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line_buf[512];
data/bino-1.6.6/src/base/gettext.h:210:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg_ctxt_id[msgctxt_len + msgid_len];
data/bino-1.6.6/src/base/gettext.h:212:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/bino-1.6.6/src/base/gettext.h:220:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (msg_ctxt_id, msgctxt, msgctxt_len - 1);
data/bino-1.6.6/src/base/gettext.h:222:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (msg_ctxt_id + msgctxt_len, msgid, msgid_len);
data/bino-1.6.6/src/base/gettext.h:256:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg_ctxt_id[msgctxt_len + msgid_len];
data/bino-1.6.6/src/base/gettext.h:258:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/bino-1.6.6/src/base/gettext.h:266:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (msg_ctxt_id, msgctxt, msgctxt_len - 1);
data/bino-1.6.6/src/base/gettext.h:268:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (msg_ctxt_id + msgctxt_len, msgid, msgid_len);
data/bino-1.6.6/src/base/msg.cpp:80:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int c = ::atoi(s);
data/bino-1.6.6/src/base/str.cpp:338:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[size];
data/bino-1.6.6/src/base/str.cpp:353:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[size];
data/bino-1.6.6/src/base/str.cpp:394:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[startsize];
data/bino-1.6.6/src/base/str.cpp:917:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rfc2822_timestamp[32];
data/bino-1.6.6/src/base/str.cpp:965:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char charset[2 + 10 + 1];
data/bino-1.6.6/src/command_file.cpp:61:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_fd = ::open(_filename.c_str(), O_RDONLY | O_NONBLOCK);
data/bino-1.6.6/src/command_file.cpp:113:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char readbuf[readbuf_size];
data/bino-1.6.6/src/controlswidget.cpp:325:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
case notification::open:
data/bino-1.6.6/src/dispatch.cpp:174:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_gui->open(input_data);
data/bino-1.6.6/src/dispatch.cpp:187:43: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
controller::send_cmd(command::open, v.str());
data/bino-1.6.6/src/dispatch.cpp:394:27: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_media_input->open(_input_data.urls, _input_data.dev_request);
data/bino-1.6.6/src/dispatch.cpp:429:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
case command::open:
data/bino-1.6.6/src/dispatch.cpp:436:27: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_media_input->open(_input_data.urls, _input_data.dev_request);
data/bino-1.6.6/src/dispatch.cpp:518:34: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
notify_all(notification::open);
data/bino-1.6.6/src/dispatch.cpp:523:34: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
notify_all(notification::open);
data/bino-1.6.6/src/dispatch.cpp:564:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_player->open();
data/bino-1.6.6/src/dispatch.cpp:1043:31: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
*c = command(command::open, v.str());
data/bino-1.6.6/src/dispatch.h:85:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open, // open_input_data
data/bino-1.6.6/src/dispatch.h:217:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open,
data/bino-1.6.6/src/gui.cpp:59:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void gui::open(const open_input_data& input_data)
data/bino-1.6.6/src/gui.cpp:70:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_main_window->open(urls, input_data.dev_request, initial_params);
data/bino-1.6.6/src/gui.h:47:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(const open_input_data& input_data);
data/bino-1.6.6/src/inoutwidget.cpp:613:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
case notification::open:
data/bino-1.6.6/src/main.cpp:79:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buffer[MAX_PATH + 10]; // leave space to append rel_locale
data/bino-1.6.6/src/main.cpp:90:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(backslash + 1, "..\\locale");
data/bino-1.6.6/src/main.cpp:96:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buffer[PATH_MAX];
data/bino-1.6.6/src/main.cpp:399:24: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
logfile = std::fopen(log_file.value().c_str(), "a");
data/bino-1.6.6/src/mainwindow.cpp:428:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(action->data().toStringList());
data/bino-1.6.6/src/mainwindow.cpp:545:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(urls);
data/bino-1.6.6/src/mainwindow.cpp:577:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(QStringList(static_cast<QFileOpenEvent *>(event)->file()));
data/bino-1.6.6/src/mainwindow.cpp:599:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void main_window::open(QStringList filenames,
data/bino-1.6.6/src/mainwindow.cpp:676:39: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
controller::send_cmd(command::open, v.str());
data/bino-1.6.6/src/mainwindow.cpp:738:5: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(file_names);
data/bino-1.6.6/src/mainwindow.cpp:776:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(url_edit->text().split(" ", QString::SkipEmptyParts));
data/bino-1.6.6/src/mainwindow.cpp:855:5: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(devices, dev_request);
data/bino-1.6.6/src/mainwindow.cpp:972:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
team_file.open(QIODevice::ReadOnly | QIODevice::Text);
data/bino-1.6.6/src/mainwindow.cpp:979:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
license_file.open(QIODevice::ReadOnly | QIODevice::Text);
data/bino-1.6.6/src/mainwindow.h:106:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(QStringList urls, const device_request &dev_request = device_request(),
data/bino-1.6.6/src/media_data.cpp:1178:14: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(dst, src + src_offset, lines * src_row_size);
data/bino-1.6.6/src/media_data.cpp:1185:18: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(dst + dst_offset, src + src_offset, dst_row_width * type_size);
data/bino-1.6.6/src/media_input.cpp:111:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void media_input::open(const std::vector<std::string> &urls, const device_request &dev_request)
data/bino-1.6.6/src/media_input.cpp:120:27: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_media_objects[i].open(urls[i], dev_request);
data/bino-1.6.6/src/media_input.h:75:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(const std::vector<std::string> &urls, const device_request &dev_request = device_request());
data/bino-1.6.6/src/media_object.cpp:777:20: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void media_object::open(const std::string &url, const device_request &dev_request)
data/bino-1.6.6/src/media_object.cpp:1598:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, &(_ffmpeg->audio_buffers[_audio_stream][0]), remaining);
data/bino-1.6.6/src/media_object.cpp:1675:34: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(out, audioframe.extended_data[c] + s * sample_size, sample_size);
data/bino-1.6.6/src/media_object.cpp:1682:26: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(&(_ffmpeg->audio_tmpbufs[_audio_stream][0]), audioframe.extended_data[0], plane_size);
data/bino-1.6.6/src/media_object.cpp:1704:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&(_ffmpeg->audio_buffers[_audio_stream][old_size]), _ffmpeg->audio_tmpbufs[_audio_stream], tmpbuf_size);
data/bino-1.6.6/src/media_object.cpp:1846:26: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(&(box.images.back().palette[0]), rect->pict.data[1],
data/bino-1.6.6/src/media_object.cpp:1850:26: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(&(box.images.back().data[0]), rect->pict.data[0],
data/bino-1.6.6/src/media_object.h:64:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(const std::string &url, const device_request &dev_request);
data/bino-1.6.6/src/player.cpp:84:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void player::open()
data/bino-1.6.6/src/player.h:106:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
virtual void open();
data/bino-1.6.6/src/player_equalizer.cpp:85:26: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_media_input.open(input.urls, input.dev_request);
data/bino-1.6.6/src/player_equalizer.cpp:91:21: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
player::open();
data/bino-1.6.6/src/player_equalizer.cpp:226:14: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(vp[0], viewport, 4 * sizeof(int));
data/bino-1.6.6/src/player_equalizer.cpp:227:14: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(vp[1], viewport, 4 * sizeof(int));
data/bino-1.6.6/src/player_equalizer.cpp:1068:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void player_equalizer::open()
data/bino-1.6.6/src/player_equalizer.h:44:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
virtual void open();
data/bino-1.6.6/src/subtitle_renderer.cpp:143:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmppathname[MAX_PATH];
data/bino-1.6.6/src/subtitle_renderer.cpp:144:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char tmpfilename[MAX_PATH];
data/bino-1.6.6/src/subtitle_renderer.cpp:151:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(tmpfilename, "w")))
data/bino-1.6.6/src/subtitle_renderer.cpp:374:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *ass_overrides[overrides.size() + 1];
data/bino-1.6.6/src/video_output.cpp:257:10: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(tc, full_tex_coords[0], 4 * 2 * sizeof(float));
data/bino-1.6.6/src/video_output.cpp:1703:22: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(pboptr, ptr, size);
data/bino-1.6.6/src/base/dbg.cpp:96:9: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(cmd_buf, executable, executable_len);
data/bino-1.6.6/src/base/dbg.cpp:97:9: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(cmd_buf, " ");
data/bino-1.6.6/src/base/dbg.cpp:98:9: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(cmd_buf, addr, addr_len);
data/bino-1.6.6/src/base/gettext.h:206:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t msgctxt_len = strlen (msgctxt) + 1;
data/bino-1.6.6/src/base/gettext.h:207:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t msgid_len = strlen (msgid) + 1;
data/bino-1.6.6/src/base/gettext.h:252:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t msgctxt_len = strlen (msgctxt) + 1;
data/bino-1.6.6/src/base/gettext.h:253:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t msgid_len = strlen (msgid) + 1;
data/bino-1.6.6/src/base/ser.cpp:437:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:447:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:458:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:468:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:478:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:488:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:498:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:508:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:518:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:528:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:538:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:548:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:558:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:568:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:578:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&x), sizeof(x));
data/bino-1.6.6/src/base/ser.cpp:590:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(x), n);
data/bino-1.6.6/src/base/ser.cpp:632:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(reinterpret_cast<char*>(&s), sizeof(s));
data/bino-1.6.6/src/base/ser.cpp:634:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(buf, s);
data/bino-1.6.6/src/command_file.cpp:116:23: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t r = ::read(_fd, readbuf, readbuf_size);
data/bino-1.6.6/src/dispatch.cpp:215:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(1000);
data/bino-1.6.6/src/main.cpp:120:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t subdirlen = std::strlen(subdir) + 1;
data/bino-1.6.6/src/main.cpp:126:14: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
std::strncpy(pch, subdir, subdirlen);
data/bino-1.6.6/src/player.cpp:515:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(allowed_sleep);
data/bino-1.6.6/src/player_equalizer.cpp:173:21: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(10000);
data/bino-1.6.6/src/video_output.cpp:246:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t l = std::strlen(str);
data/bino-1.6.6/src/video_output_qt.cpp:219:17: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(1000);
data/bino-1.6.6/src/video_output_qt.cpp:702:13: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(10000);
ANALYSIS SUMMARY:
Hits = 125
Lines analyzed = 27178 in approximately 0.75 seconds (36221 lines/second)
Physical Source Lines of Code (SLOC) = 21288
Hits@level = [0] 17 [1] 34 [2] 79 [3] 6 [4] 6 [5] 0
Hits@level+ = [0+] 142 [1+] 125 [2+] 91 [3+] 12 [4+] 6 [5+] 0
Hits/KSLOC@level+ = [0+] 6.67042 [1+] 5.87185 [2+] 4.27471 [3+] 0.563698 [4+] 0.281849 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.