Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/binpac-0.56.0/src/pac_id.h
Examining data/binpac-0.56.0/src/pac_exttype.cc
Examining data/binpac-0.56.0/src/pac_field.cc
Examining data/binpac-0.56.0/src/pac_output.cc
Examining data/binpac-0.56.0/src/pac_typedecl.h
Examining data/binpac-0.56.0/src/pac_record.h
Examining data/binpac-0.56.0/src/pac_embedded.cc
Examining data/binpac-0.56.0/src/pac_ctype.h
Examining data/binpac-0.56.0/src/pac_inputbuf.h
Examining data/binpac-0.56.0/src/pac_primitive.cc
Examining data/binpac-0.56.0/src/pac_inputbuf.cc
Examining data/binpac-0.56.0/src/pac_utils.h
Examining data/binpac-0.56.0/src/pac_func.cc
Examining data/binpac-0.56.0/src/pac_func.h
Examining data/binpac-0.56.0/src/pac_cclass.h
Examining data/binpac-0.56.0/src/pac_primitive.h
Examining data/binpac-0.56.0/src/pac_expr.cc
Examining data/binpac-0.56.0/src/pac_datadep.cc
Examining data/binpac-0.56.0/src/pac_case.h
Examining data/binpac-0.56.0/src/pac_conn.h
Examining data/binpac-0.56.0/src/pac_type.h
Examining data/binpac-0.56.0/src/pac_case.cc
Examining data/binpac-0.56.0/src/pac_dataptr.h
Examining data/binpac-0.56.0/src/pac_datadep.h
Examining data/binpac-0.56.0/src/pac_exception.cc
Examining data/binpac-0.56.0/src/pac_enum.h
Examining data/binpac-0.56.0/src/pac_output.h
Examining data/binpac-0.56.0/src/pac_main.cc
Examining data/binpac-0.56.0/src/pac_param.h
Examining data/binpac-0.56.0/src/pac_dataunit.cc
Examining data/binpac-0.56.0/src/pac_dataunit.h
Examining data/binpac-0.56.0/src/pac_redef.h
Examining data/binpac-0.56.0/src/pac_redef.cc
Examining data/binpac-0.56.0/src/pac_conn.cc
Examining data/binpac-0.56.0/src/pac_flow.h
Examining data/binpac-0.56.0/src/pac_regex.h
Examining data/binpac-0.56.0/src/pac_exttype.h
Examining data/binpac-0.56.0/src/pac_array.h
Examining data/binpac-0.56.0/src/pac_context.h
Examining data/binpac-0.56.0/src/pac_dataptr.cc
Examining data/binpac-0.56.0/src/pac_btype.cc
Examining data/binpac-0.56.0/src/pac_btype.h
Examining data/binpac-0.56.0/src/pac_dbg.h
Examining data/binpac-0.56.0/src/pac_exception.h
Examining data/binpac-0.56.0/src/pac_withinput.cc
Examining data/binpac-0.56.0/src/pac_attr.cc
Examining data/binpac-0.56.0/src/pac_action.cc
Examining data/binpac-0.56.0/src/pac_flow.cc
Examining data/binpac-0.56.0/src/pac_varfield.h
Examining data/binpac-0.56.0/src/pac_expr.h
Examining data/binpac-0.56.0/src/pac_attr.h
Examining data/binpac-0.56.0/src/pac_enum.cc
Examining data/binpac-0.56.0/src/pac_field.h
Examining data/binpac-0.56.0/src/pac_array.cc
Examining data/binpac-0.56.0/src/pac_embedded.h
Examining data/binpac-0.56.0/src/pac_typedecl.cc
Examining data/binpac-0.56.0/src/pac_decl.cc
Examining data/binpac-0.56.0/src/pac_common.h
Examining data/binpac-0.56.0/src/pac_paramtype.cc
Examining data/binpac-0.56.0/src/pac_decl-inl.h
Examining data/binpac-0.56.0/src/pac_analyzer.h
Examining data/binpac-0.56.0/src/pac_cstr.cc
Examining data/binpac-0.56.0/src/pac_analyzer.cc
Examining data/binpac-0.56.0/src/pac_type.cc
Examining data/binpac-0.56.0/src/pac_record.cc
Examining data/binpac-0.56.0/src/pac_utils.cc
Examining data/binpac-0.56.0/src/pac_let.h
Examining data/binpac-0.56.0/src/pac_action.h
Examining data/binpac-0.56.0/src/pac_state.h
Examining data/binpac-0.56.0/src/pac_cstr.h
Examining data/binpac-0.56.0/src/pac_param.cc
Examining data/binpac-0.56.0/src/pac_paramtype.h
Examining data/binpac-0.56.0/src/pac_withinput.h
Examining data/binpac-0.56.0/src/pac_regex.cc
Examining data/binpac-0.56.0/src/pac_ctype.cc
Examining data/binpac-0.56.0/src/pac_id.cc
Examining data/binpac-0.56.0/src/pac_state.cc
Examining data/binpac-0.56.0/src/pac_decl.h
Examining data/binpac-0.56.0/src/pac_let.cc
Examining data/binpac-0.56.0/src/pac_strtype.cc
Examining data/binpac-0.56.0/src/pac_context.cc
Examining data/binpac-0.56.0/src/pac_varfield.cc
Examining data/binpac-0.56.0/src/pac_strtype.h
Examining data/binpac-0.56.0/src/pac_number.h
Examining data/binpac-0.56.0/lib/binpac_buffer.h
Examining data/binpac-0.56.0/lib/binpac_analyzer.h
Examining data/binpac-0.56.0/lib/binpac_regex.cc
Examining data/binpac-0.56.0/lib/binpac_exception.h
Examining data/binpac-0.56.0/lib/binpac_bytestring.cc
Examining data/binpac-0.56.0/lib/binpac_bytestring.h
Examining data/binpac-0.56.0/lib/binpac_buffer.cc
Examining data/binpac-0.56.0/lib/binpac_regex.h
FINAL RESULTS:
data/binpac-0.56.0/src/pac_dbg.h:10:48: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DEBUG_MSG(x...) if ( FLAGS_pac_debug ) fprintf(stderr, x)
data/binpac-0.56.0/src/pac_output.cc:34:10: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
int r = vfprintf(fp, fmt, ap);
data/binpac-0.56.0/src/pac_utils.cc:10:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(c, s);
data/binpac-0.56.0/src/pac_utils.cc:19:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf, sizeof(buf), format, ap);
data/binpac-0.56.0/src/pac_main.cc:240:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ( (o = getopt(argc, argv, "DqI:d:h")) != -1 )
data/binpac-0.56.0/lib/binpac_buffer.cc:558:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer_ + buffer_n_, data, len);
data/binpac-0.56.0/lib/binpac_bytestring.cc:16:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return atoi((const char *) s->begin());
data/binpac-0.56.0/lib/binpac_bytestring.h:158:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data_, data, sizeof(T) * len);
data/binpac-0.56.0/src/pac_main.cc:91:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char t[1024];
data/binpac-0.56.0/src/pac_main.cc:103:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* fp_input = fopen(filename, "r");
data/binpac-0.56.0/src/pac_output.cc:20:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(filename.c_str(), "w");
data/binpac-0.56.0/src/pac_utils.cc:18:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[1024];
data/binpac-0.56.0/src/pac_cstr.cc:87:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(text) + 1;
data/binpac-0.56.0/src/pac_type.cc:197:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(a->expr()->orig()) != 6 )
data/binpac-0.56.0/src/pac_utils.cc:9:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char* c = new char[strlen(s)+1];
ANALYSIS SUMMARY:
Hits = 15
Lines analyzed = 13740 in approximately 0.30 seconds (46266 lines/second)
Physical Source Lines of Code (SLOC) = 10779
Hits@level = [0] 20 [1] 3 [2] 7 [3] 1 [4] 4 [5] 0
Hits@level+ = [0+] 35 [1+] 15 [2+] 12 [3+] 5 [4+] 4 [5+] 0
Hits/KSLOC@level+ = [0+] 3.24705 [1+] 1.39159 [2+] 1.11328 [3+] 0.463865 [4+] 0.371092 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.