Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/ephoto-1.5/src/bin/ephoto_thumbnailer.c
Examining data/ephoto-1.5/src/bin/ephoto_main.c
Examining data/ephoto-1.5/src/bin/ephoto_color.c
Examining data/ephoto-1.5/src/bin/ephoto_single_browser.c
Examining data/ephoto-1.5/src/bin/ephoto_scale.c
Examining data/ephoto-1.5/src/bin/ephoto_editor.c
Examining data/ephoto-1.5/src/bin/ephoto.c
Examining data/ephoto-1.5/src/bin/ephoto_red_eye.c
Examining data/ephoto-1.5/src/bin/ephoto_hsv.c
Examining data/ephoto-1.5/src/bin/ephoto_thumb.c
Examining data/ephoto-1.5/src/bin/ephoto_file.c
Examining data/ephoto-1.5/src/bin/ephoto_cropper.c
Examining data/ephoto-1.5/src/bin/ephoto_directory_browser.c
Examining data/ephoto-1.5/src/bin/ephoto_filters.c
Examining data/ephoto-1.5/src/bin/ephoto_config.c
Examining data/ephoto-1.5/src/bin/ephoto_slideshow.c
Examining data/ephoto-1.5/src/bin/ephoto_ipc.c
Examining data/ephoto-1.5/src/bin/ephoto_bcg.c
Examining data/ephoto-1.5/src/bin/ephoto_thumb_browser.c
Examining data/ephoto-1.5/src/bin/ephoto.h
FINAL RESULTS:
data/ephoto-1.5/src/bin/ephoto_ipc.c:3:30: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define ERR(...) do { printf(__VA_ARGS__); putc('\n', stdout); } while(0)
data/ephoto-1.5/src/bin/ephoto_thumb.c:311:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buf, file);
data/ephoto-1.5/src/bin/ephoto_thumb.c:312:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
if (key) strcpy(buf + l1 + 1, key);
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:313:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat((char *) drag_data, FILESEP);
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:314:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat((char *) drag_data, e->path);
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:703:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((char *)buf, file);
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:704:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
if (key) strcpy((char *)(buf + lenf + 1), key);
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:117:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *port_str = getenv("EPHOTO_IPC_PORT");
data/ephoto-1.5/src/bin/ephoto.h:224:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
const char *open;
data/ephoto-1.5/src/bin/ephoto_bcg.c:31:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, image_data, sizeof(unsigned int) * ebcg->w * ebcg->h);
data/ephoto-1.5/src/bin/ephoto_bcg.c:33:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, ebcg->original_im_data,
data/ephoto-1.5/src/bin/ephoto_bcg.c:83:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, image_data, sizeof(unsigned int) * ebcg->w * ebcg->h);
data/ephoto-1.5/src/bin/ephoto_bcg.c:85:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, ebcg->original_im_data,
data/ephoto-1.5/src/bin/ephoto_bcg.c:137:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, image_data, sizeof(unsigned int) * ebcg->w * ebcg->h);
data/ephoto-1.5/src/bin/ephoto_bcg.c:139:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, ebcg->original_im_data,
data/ephoto-1.5/src/bin/ephoto_bcg.c:322:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ebcg->original_im_data, im_data,
data/ephoto-1.5/src/bin/ephoto_color.c:38:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, image_data, sizeof(unsigned int) * eco->w * eco->h);
data/ephoto-1.5/src/bin/ephoto_color.c:40:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, eco->original_im_data,
data/ephoto-1.5/src/bin/ephoto_color.c:235:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(eco->original_im_data, im_data,
data/ephoto-1.5/src/bin/ephoto_config.c:29:49: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
eina_stringshare_replace(&ephoto->config->open, path);
data/ephoto-1.5/src/bin/ephoto_config.c:83:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_config.c:166:50: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
elm_object_text_set(hoversel, ephoto->config->open);
data/ephoto-1.5/src/bin/ephoto_config.c:199:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_config.c:238:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_config.c:335:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_config.c:352:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_config.c:477:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ver[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_config.c:537:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(PACKAGE_DATA_DIR "/AUTHORS", "r");
data/ephoto-1.5/src/bin/ephoto_config.c:540:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_config.c:610:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096], buf2[4096];
data/ephoto-1.5/src/bin/ephoto_config.c:649:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096], buf2[4096];
data/ephoto-1.5/src/bin/ephoto_config.c:805:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
C_VAL(D, T, open, EET_T_STRING);
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:782:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char file[PATH_MAX], dir[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:784:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:927:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX], file[PATH_MAX], dir[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:1231:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[PATH_MAX], *dir, *end_dir;
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:1235:31: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (strcmp(ephoto->config->open, ephoto->config->directory))
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:1237:38: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!strncmp(ephoto->config->open, ephoto->config->directory, strlen(ephoto->config->open)))
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:1237:94: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!strncmp(ephoto->config->open, ephoto->config->directory, strlen(ephoto->config->open)))
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:1242:49: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
while (strcmp(dir, ephoto->config->open))
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:1329:70: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ephoto_directory_browser_top_dir_set(ephoto, ephoto->config->open);
data/ephoto-1.5/src/bin/ephoto_file.c:134:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:274:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX], link[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:339:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char new_file_name[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:431:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char new_file_name[PATH_MAX], dir[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:482:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX], *bn, *string;
data/ephoto-1.5/src/bin/ephoto_file.c:586:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:619:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dest[PATH_MAX], fp[PATH_MAX], extra[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:681:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dest[PATH_MAX], fp[PATH_MAX], extra[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:745:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dest[PATH_MAX], fp[PATH_MAX], extra[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:816:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fp[PATH_MAX], dest[PATH_MAX], extra[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:911:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:922:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(entry->path, "rb");
data/ephoto-1.5/src/bin/ephoto_file.c:1012:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:1308:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char move_dir[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_file.c:1359:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char copy_dir[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_filters.c:73:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ef->im_data, im_data, sizeof(unsigned int) * w * h);
data/ephoto-1.5/src/bin/ephoto_filters.c:167:14: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ef->im_data_two, ef->im_data,
data/ephoto-1.5/src/bin/ephoto_filters.c:174:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ef->im_data, ef->im_data_new,
data/ephoto-1.5/src/bin/ephoto_filters.c:497:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ef->im_data_new, ef->im_data,
data/ephoto-1.5/src/bin/ephoto_filters.c:1060:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ef->im_data_orig, ef->im_data,
data/ephoto-1.5/src/bin/ephoto_filters.c:1077:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ef->im_data_new, ef->im_data,
data/ephoto-1.5/src/bin/ephoto_hsv.c:31:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, image_data, sizeof(unsigned int) * ehsv->w * ehsv->h);
data/ephoto-1.5/src/bin/ephoto_hsv.c:33:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, ehsv->original_im_data,
data/ephoto-1.5/src/bin/ephoto_hsv.c:87:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, image_data, sizeof(unsigned int) * ehsv->w * ehsv->h);
data/ephoto-1.5/src/bin/ephoto_hsv.c:89:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, ehsv->original_im_data,
data/ephoto-1.5/src/bin/ephoto_hsv.c:143:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, image_data, sizeof(unsigned int) * ehsv->w * ehsv->h);
data/ephoto-1.5/src/bin/ephoto_hsv.c:145:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, ehsv->original_im_data,
data/ephoto-1.5/src/bin/ephoto_hsv.c:329:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ehsv->original_im_data, im_data,
data/ephoto-1.5/src/bin/ephoto_ipc.c:21:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char port_str[sizeof("2147483648")] = "";
data/ephoto-1.5/src/bin/ephoto_main.c:357:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX], config[PATH_MAX], trash[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_main.c:565:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (ephoto->config->open)
data/ephoto-1.5/src/bin/ephoto_main.c:567:35: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!strcmp(ephoto->config->open, "Last"))
data/ephoto-1.5/src/bin/ephoto_main.c:570:26: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
path = ephoto->config->open;
data/ephoto-1.5/src/bin/ephoto_main.c:574:35: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
else if (!ephoto->config->open || path)
data/ephoto-1.5/src/bin/ephoto_main.c:647:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024] = "Ephoto";
data/ephoto-1.5/src/bin/ephoto_main.c:839:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char file[PATH_MAX], dir[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_main.c:857:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_red_eye.c:50:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, er->edited_im_data,
data/ephoto-1.5/src/bin/ephoto_red_eye.c:53:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, er->original_im_data,
data/ephoto-1.5/src/bin/ephoto_red_eye.c:196:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(er->original_im_data, im_data,
data/ephoto-1.5/src/bin/ephoto_scale.c:143:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(im_data, image_data, sizeof(unsigned int) * w * h);
data/ephoto-1.5/src/bin/ephoto_scale.c:187:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_scale.c:212:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(es->original_im_data, im_data,
data/ephoto-1.5/src/bin/ephoto_single_browser.c:112:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char image_info[PATH_MAX], *tmp;
data/ephoto-1.5/src/bin/ephoto_single_browser.c:133:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char isize[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_single_browser.c:214:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dd[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_single_browser.c:503:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_single_browser.c:532:18: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
eh->im_data = memcpy(eh->im_data, evas_object_image_data_get(v->image, EINA_FALSE),
data/ephoto-1.5/src/bin/ephoto_single_browser.c:2215:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(eh->im_data, evas_object_image_data_get(v->image, EINA_FALSE),
data/ephoto-1.5/src/bin/ephoto_single_browser.c:2307:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_single_browser.c:2339:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(eh->im_data, image_data,
data/ephoto-1.5/src/bin/ephoto_slideshow.c:383:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_thumb.c:131:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/ephoto-1.5/src/bin/ephoto_thumb.c:361:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/ephoto-1.5/src/bin/ephoto_thumb.c:370:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/ephoto-1.5/src/bin/ephoto_thumb.c:380:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/ephoto-1.5/src/bin/ephoto_thumb.c:433:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:1067:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:1068:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char isize[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:1069:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char image_info[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:1156:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pattern[PATH_MAX];
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:46:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char _thumbdir[4096] = "";
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:75:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (nice(atoi(val)) < 0) perror("nice");
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:119:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((!port_str) || ((port = atoi(port_str)) == 0))
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:269:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096], dbuf[4096], *id, *td, *ext = NULL;
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:458:14: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data1, data, ww * hh * sizeof(unsigned int));
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:469:19: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data2, data, ww * hh * sizeof(unsigned int));
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:478:33: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char id2[(21 * 4) + 1];
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:496:24: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data3, data, sizeof(unsigned int));
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:595:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[64], *d;
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:679:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst, digest, 5 * 4);
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:687:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[64];
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:689:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char *buf, id[20];
data/ephoto-1.5/src/bin/ephoto_config.c:219:19: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(t, b, s - b);
data/ephoto-1.5/src/bin/ephoto_config.c:359:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf, strlen(buf));
data/ephoto-1.5/src/bin/ephoto_config.c:546:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(buf);
data/ephoto-1.5/src/bin/ephoto_directory_browser.c:1237:71: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(ephoto->config->open, ephoto->config->directory, strlen(ephoto->config->open)))
data/ephoto-1.5/src/bin/ephoto_file.c:303:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp("link>", content, strlen("link>")))
data/ephoto-1.5/src/bin/ephoto_file.c:322:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
eina_simple_xml_parse(string, strlen(string) + 1, EINA_TRUE,
data/ephoto-1.5/src/bin/ephoto_thumb.c:307:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l1 = strlen(file);
data/ephoto-1.5/src/bin/ephoto_thumb.c:309:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (key) l2 = strlen(key);
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:301:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(e->path);
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:306:2: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy((char *) drag_data, "");
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:315:19: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat((char *) drag_data, "\n");
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:1735:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((strlen(tb->ephoto->trash_path)) == (strlen(tb->ephoto->config->directory)))
data/ephoto-1.5/src/bin/ephoto_thumb_browser.c:1735:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((strlen(tb->ephoto->trash_path)) == (strlen(tb->ephoto->config->directory)))
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:188:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
key = file + strlen(file) + 1;
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:441:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
eth->file, strlen(eth->file), 1);
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:444:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
eth->key, strlen(eth->key), 1);
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:588:92: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ecore_ipc_server_send(_e_ipc_server, EPHOTO_IPC_DOMAIN_THUMB, 2, eth->objid, 0, 0, buf, strlen(buf) + 1);
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:693:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
lenf = strlen(file);
data/ephoto-1.5/src/bin/ephoto_thumbnailer.c:698:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
key += strlen(key);
ANALYSIS SUMMARY:
Hits = 133
Lines analyzed = 16329 in approximately 0.43 seconds (37747 lines/second)
Physical Source Lines of Code (SLOC) = 14327
Hits@level = [0] 98 [1] 19 [2] 106 [3] 1 [4] 7 [5] 0
Hits@level+ = [0+] 231 [1+] 133 [2+] 114 [3+] 8 [4+] 7 [5+] 0
Hits/KSLOC@level+ = [0+] 16.1234 [1+] 9.28317 [2+] 7.957 [3+] 0.558386 [4+] 0.488588 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.