Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/firetools-0.9.62/src/firejail-ui/main.cpp
Examining data/firetools-0.9.62/src/firejail-ui/home_widget.cpp
Examining data/firetools-0.9.62/src/firejail-ui/firejail_ui.h
Examining data/firetools-0.9.62/src/firejail-ui/help_widget.cpp
Examining data/firetools-0.9.62/src/firejail-ui/network.cpp
Examining data/firetools-0.9.62/src/firejail-ui/appdb.cpp
Examining data/firetools-0.9.62/src/firejail-ui/wizard.h
Examining data/firetools-0.9.62/src/firejail-ui/help_widget.h
Examining data/firetools-0.9.62/src/firejail-ui/home_widget.h
Examining data/firetools-0.9.62/src/firejail-ui/appdb.h
Examining data/firetools-0.9.62/src/firejail-ui/wizard.cpp
Examining data/firetools-0.9.62/src/fstats/dbstorage.h
Examining data/firetools-0.9.62/src/fstats/dbpid.cpp
Examining data/firetools-0.9.62/src/fstats/graph.h
Examining data/firetools-0.9.62/src/fstats/main.cpp
Examining data/firetools-0.9.62/src/fstats/stats_dialog.h
Examining data/firetools-0.9.62/src/fstats/config.cpp
Examining data/firetools-0.9.62/src/fstats/pid_thread.cpp
Examining data/firetools-0.9.62/src/fstats/graph.cpp
Examining data/firetools-0.9.62/src/fstats/dbpid.h
Examining data/firetools-0.9.62/src/fstats/fstats.h
Examining data/firetools-0.9.62/src/fstats/db.h
Examining data/firetools-0.9.62/src/fstats/pid_thread.h
Examining data/firetools-0.9.62/src/fstats/db.cpp
Examining data/firetools-0.9.62/src/fstats/stats_dialog.cpp
Examining data/firetools-0.9.62/src/firetools/applications.cpp
Examining data/firetools-0.9.62/src/firetools/edit_dialog.h
Examining data/firetools-0.9.62/src/firetools/edit_dialog.cpp
Examining data/firetools-0.9.62/src/firetools/main.cpp
Examining data/firetools-0.9.62/src/firetools/mainwindow.h
Examining data/firetools-0.9.62/src/firetools/firetools.h
Examining data/firetools-0.9.62/src/firetools/mainwindow.cpp
Examining data/firetools-0.9.62/src/firetools/applications.h
Examining data/firetools-0.9.62/src/common/hyperlink.cpp
Examining data/firetools-0.9.62/src/common/hyperlink.h
Examining data/firetools-0.9.62/src/common/pid.h
Examining data/firetools-0.9.62/src/common/pid.cpp
Examining data/firetools-0.9.62/src/common/utils.cpp
Examining data/firetools-0.9.62/src/common/utils.h
Examining data/firetools-0.9.62/src/common/common.h
Examining data/firetools-0.9.62/src/fmgr/fs.cpp
Examining data/firetools-0.9.62/src/fmgr/topwidget.h
Examining data/firetools-0.9.62/src/fmgr/main.cpp
Examining data/firetools-0.9.62/src/fmgr/config.cpp
Examining data/firetools-0.9.62/src/fmgr/mainwindow.h
Examining data/firetools-0.9.62/src/fmgr/fs.h
Examining data/firetools-0.9.62/src/fmgr/fmgr.h
Examining data/firetools-0.9.62/src/fmgr/mainwindow.cpp
Examining data/firetools-0.9.62/src/fmgr/topwidget.cpp
FINAL RESULTS:
data/firetools-0.9.62/src/common/common.h:36:48: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
#define errExit(msg) do { char msgout[500]; sprintf(msgout, "Error %s:%s(%d)", msg, __FUNCTION__, __LINE__); perror(msgout); exit(1);} while (0)
data/firetools-0.9.62/src/common/utils.cpp:37:7: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
fp = popen(prog, "r");
data/firetools-0.9.62/src/firejail-ui/wizard.cpp:255:12: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system(PACKAGE_LIBDIR "/fstats &");
data/firetools-0.9.62/src/firejail-ui/wizard.cpp:383:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(cmd, X_OK))
data/firetools-0.9.62/src/firetools/mainwindow.cpp:161:12: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system(exec.toStdString().c_str());
data/firetools-0.9.62/src/firetools/mainwindow.cpp:172:11: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system(PACKAGE_LIBDIR "/fstats &");
data/firetools-0.9.62/src/firetools/mainwindow.cpp:179:11: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system("firejail-ui &");
data/firetools-0.9.62/src/firetools/mainwindow.cpp:270:13: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system(exec.toStdString().c_str());
data/firetools-0.9.62/src/fstats/dbpid.cpp:52:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(cmd_, cmd);
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:533:8: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
str.sprintf("%s (parent device %s", child_dev, parent_dev);
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1044:14: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system(cmd);
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1056:13: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system(cmd);
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1064:13: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system(cmd);
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1099:12: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int rv = system("firetools &");
data/firetools-0.9.62/src/fmgr/mainwindow.cpp:282:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* username = getenv("USER");
data/firetools-0.9.62/src/common/common.h:36:30: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
#define errExit(msg) do { char msgout[500]; sprintf(msgout, "Error %s:%s(%d)", msg, __FUNCTION__, __LINE__); perror(msgout); exit(1);} while (0)
data/firetools-0.9.62/src/common/pid.cpp:44:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(file, "r");
data/firetools-0.9.62/src/common/pid.cpp:69:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(file, "r");
data/firetools-0.9.62/src/common/pid.cpp:76:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[PIDS_BUFLEN];
data/firetools-0.9.62/src/common/pid.cpp:103:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(file, "r");
data/firetools-0.9.62/src/common/pid.cpp:110:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[PIDS_BUFLEN];
data/firetools-0.9.62/src/common/pid.cpp:148:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(file, "r");
data/firetools-0.9.62/src/common/pid.cpp:155:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PIDS_BUFLEN];
data/firetools-0.9.62/src/common/pid.cpp:165:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rv = atoi(ptr);
data/firetools-0.9.62/src/common/pid.cpp:183:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen("/proc/sys/kernel/pid_max", "r");
data/firetools-0.9.62/src/common/pid.cpp:227:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(file, "r");
data/firetools-0.9.62/src/common/pid.cpp:234:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PIDS_BUFLEN];
data/firetools-0.9.62/src/common/pid.cpp:272:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
unsigned parent = atoi(ptr);
data/firetools-0.9.62/src/common/pid.cpp:289:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pids[pid].uid = atoi(ptr);
data/firetools-0.9.62/src/common/pid.cpp:370:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(fname, O_RDONLY)) < 0) {
data/firetools-0.9.62/src/common/pid.cpp:377:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[BUFLEN];
data/firetools-0.9.62/src/common/pid.cpp:406:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(fname, O_RDONLY)) < 0) {
data/firetools-0.9.62/src/common/pid.cpp:413:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[BUFLEN];
data/firetools-0.9.62/src/common/pid.cpp:494:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/common/pid.cpp:500:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXBUF];
data/firetools-0.9.62/src/common/pid.cpp:550:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(fname, O_RDONLY)) < 0) {
data/firetools-0.9.62/src/common/pid.cpp:557:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[BUFLEN];
data/firetools-0.9.62/src/common/utils.cpp:31:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char outbuf[MAXBUF + 1];
data/firetools-0.9.62/src/common/utils.cpp:158:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *sargv[SARG_MAX];
data/firetools-0.9.62/src/common/utils.h:47:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char *sargv[SARG_MAX];
data/firetools-0.9.62/src/firejail-ui/appdb.cpp:117:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/firejail-ui/appdb.cpp:125:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXBUF];
data/firetools-0.9.62/src/firejail-ui/help_widget.cpp:39:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/firejail-ui/help_widget.cpp:44:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXBUF];
data/firetools-0.9.62/src/firejail-ui/network.cpp:41:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen("/proc/self/net/route", "r");
data/firetools-0.9.62/src/firejail-ui/network.cpp:46:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZE];
data/firetools-0.9.62/src/firejail-ui/wizard.cpp:95:12: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
int fd = mkstemp(profname);
data/firetools-0.9.62/src/firetools/applications.cpp:58:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/firetools/applications.cpp:67:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXBUF];
data/firetools-0.9.62/src/firetools/applications.cpp:99:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "w");
data/firetools-0.9.62/src/firetools/main.cpp:92:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(autofile, "w");
data/firetools-0.9.62/src/fmgr/config.cpp:40:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/fmgr/config.cpp:46:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZE];
data/firetools-0.9.62/src/fmgr/config.cpp:82:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "w");
data/firetools-0.9.62/src/fmgr/main.cpp:50:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int pid = atoi(str);
data/firetools-0.9.62/src/fmgr/main.cpp:87:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pid_t pid = (pid_t) atoi(argv[i]);
data/firetools-0.9.62/src/fstats/config.cpp:40:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/fstats/config.cpp:46:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZE];
data/firetools-0.9.62/src/fstats/config.cpp:82:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "w");
data/firetools-0.9.62/src/fstats/graph.cpp:27:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char *id_label[4] = {
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:513:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:515:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:708:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:712:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:846:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:848:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1141:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(uidmap, "r");
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1166:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1168:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[250];
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1184:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1186:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[250];
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:1202:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *fp = fopen(fname, "r");
data/firetools-0.9.62/src/fstats/stats_dialog.h:39:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[MAX_HEADER];
data/firetools-0.9.62/src/fstats/stats_dialog.h:43:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char logentry[MAX_LOG_ENTRIES][MAX_ENTRY_LEN];
data/firetools-0.9.62/src/common/pid.cpp:379:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((len = read(fd, buffer, sizeof(buffer) - 1)) <= 0) {
data/firetools-0.9.62/src/common/pid.cpp:393:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(rv) == 0) {
data/firetools-0.9.62/src/common/pid.cpp:415:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((len = read(fd, buffer, sizeof(buffer) - 1)) <= 0) {
data/firetools-0.9.62/src/common/pid.cpp:431:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(rv) == 0) {
data/firetools-0.9.62/src/common/pid.cpp:559:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((len = read(fd, buffer, sizeof(buffer) - 1)) <= 0) {
data/firetools-0.9.62/src/common/pid.cpp:590:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i += strlen(arg);
data/firetools-0.9.62/src/firejail-ui/network.cpp:78:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(pwrq.ifr_name, ifname, IFNAMSIZ);
data/firetools-0.9.62/src/firejail-ui/network.cpp:87:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(protocol, pwrq.u.name, IFNAMSIZ);
data/firetools-0.9.62/src/firetools/applications.cpp:525:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(entry->d_name);
data/firetools-0.9.62/src/fstats/dbpid.cpp:51:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cmd_ = new char[strlen(cmd) + 1];
data/firetools-0.9.62/src/fstats/stats_dialog.cpp:810:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pid_apparmor_ = QString(ptr + strlen(tofind));
ANALYSIS SUMMARY:
Hits = 85
Lines analyzed = 7826 in approximately 0.28 seconds (27567 lines/second)
Physical Source Lines of Code (SLOC) = 5368
Hits@level = [0] 178 [1] 11 [2] 59 [3] 1 [4] 14 [5] 0
Hits@level+ = [0+] 263 [1+] 85 [2+] 74 [3+] 15 [4+] 14 [5+] 0
Hits/KSLOC@level+ = [0+] 48.994 [1+] 15.8346 [2+] 13.7854 [3+] 2.79434 [4+] 2.60805 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.