Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/fldiff-1.1+0/FavoritesMenu.cxx
Examining data/fldiff-1.1+0/FavoritesMenu.h
Examining data/fldiff-1.1+0/PtProcess.cxx
Examining data/fldiff-1.1+0/DiffChooser.cxx
Examining data/fldiff-1.1+0/FavoritesWindow.h
Examining data/fldiff-1.1+0/DiffWindow.cxx
Examining data/fldiff-1.1+0/FavoritesWindow.cxx
Examining data/fldiff-1.1+0/DiffOpenWindow.h
Examining data/fldiff-1.1+0/DiffChooser.h
Examining data/fldiff-1.1+0/fldiff.cxx
Examining data/fldiff-1.1+0/DiffView.h
Examining data/fldiff-1.1+0/DiffOpenWindow.cxx
Examining data/fldiff-1.1+0/PtProcess.h
Examining data/fldiff-1.1+0/DiffView.cxx
Examining data/fldiff-1.1+0/DiffWindow.h
FINAL RESULTS:
data/fldiff-1.1+0/DiffChooser.cxx:172:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(dc->directory_, matchname);
data/fldiff-1.1+0/DiffChooser.cxx:331:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(directory_, filename_);
data/fldiff-1.1+0/DiffChooser.cxx:342:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(directory_, filename_);
data/fldiff-1.1+0/DiffChooser.h:28:9: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/fldiff-1.1+0/DiffChooser.h:28:18: [4] (format) _snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/fldiff-1.1+0/DiffChooser.h:29:9: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
#define access _access
data/fldiff-1.1+0/DiffView.cxx:560:9: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(number, linefmt_, firstline);
data/fldiff-1.1+0/DiffView.cxx:567:9: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(number, linefmt_, secondline);
data/fldiff-1.1+0/DiffView.cxx:953:10: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(line, 0))
data/fldiff-1.1+0/DiffView.cxx:966:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(line, 0))
data/fldiff-1.1+0/DiffView.cxx:990:10: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(line, 0))
data/fldiff-1.1+0/DiffView.cxx:1002:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(line, 0))
data/fldiff-1.1+0/DiffView.cxx:1018:14: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (!pdiff.popen(command))
data/fldiff-1.1+0/DiffView.cxx:1030:11: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
pfp.popen(command, "r");
data/fldiff-1.1+0/DiffView.cxx:1038:9: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
pfp.popen(command, "r");
data/fldiff-1.1+0/DiffView.cxx:1483:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ptr, lines_[i]->right);
data/fldiff-1.1+0/DiffView.cxx:1485:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ptr, lines_[i]->left);
data/fldiff-1.1+0/DiffWindow.cxx:63:9: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/fldiff-1.1+0/DiffWindow.cxx:63:18: [4] (format) _snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/fldiff-1.1+0/DiffWindow.cxx:64:9: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
#define access _access
data/fldiff-1.1+0/DiffWindow.cxx:834:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(title_, sizeof(title_), "%s <-> %s - " VERSION, file1_, file2_);
data/fldiff-1.1+0/DiffWindow.cxx:836:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(title_, sizeof(title_), "r%s <-> %s - " VERSION, file2_ + 1, file1_);
data/fldiff-1.1+0/DiffWindow.cxx:838:5: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(title_, sizeof(title_), "repos <-> %s - " VERSION, file1_);
data/fldiff-1.1+0/PtProcess.cxx:72:20: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
FILE * CPtProcess::popen(const char *cmd, const char *mode) {
data/fldiff-1.1+0/PtProcess.cxx:112:10: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
_fpt=::popen(cmd,mode);
data/fldiff-1.1+0/PtProcess.h:28:9: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
FILE * popen (const char *cmd, const char *mode="r");
data/fldiff-1.1+0/FavoritesMenu.cxx:103:15: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((home = getenv("HOME")) != NULL)
data/fldiff-1.1+0/PtProcess.cxx:99:8: [3] (shell) CreateProcess:
This causes a new process to execute and is difficult to use safely
(CWE-78). Specify the application path in the first argument, NOT as part
of the second, or embedded spaces could allow an attacker to force a
different program to run.
if ( CreateProcess(NULL, (LPTSTR) cmd,NULL,NULL,TRUE,
data/fldiff-1.1+0/PtProcess.cxx:99:8: [3] (shell) CreateProcess:
This causes a new process to execute and is difficult to use safely
(CWE-78). Specify the application path in the first argument, NOT as part
of the second, or embedded spaces could allow an attacker to force a
different program to run.
if ( CreateProcess(NULL, (LPTSTR) cmd,NULL,NULL,TRUE,
data/fldiff-1.1+0/DiffChooser.cxx:76:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[1024]; // Filename
data/fldiff-1.1+0/DiffChooser.cxx:133:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char matchname[1024], // Matching filename
data/fldiff-1.1+0/DiffChooser.h:40:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char directory_[1024];// Directory name
data/fldiff-1.1+0/DiffChooser.h:41:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename_[1024];// Cached filename
data/fldiff-1.1+0/DiffView.cxx:143:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(temp, lines_, count_ * sizeof(DiffLine *));
data/fldiff-1.1+0/DiffView.cxx:305:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char number[255]; // Line number
data/fldiff-1.1+0/DiffView.cxx:882:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char command[1024]; // Diff command
data/fldiff-1.1+0/DiffView.cxx:1033:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
pfp.fopen(file2, "r");
data/fldiff-1.1+0/DiffView.cxx:1041:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
pfp.fopen(file1, "r");
data/fldiff-1.1+0/DiffView.cxx:1192:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(temp, lines_, count_ * sizeof(DiffLine *));
data/fldiff-1.1+0/DiffView.cxx:1304:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
procFile1.fopen(file1, "r");
data/fldiff-1.1+0/DiffView.cxx:1305:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
procFile2.fopen(file2, "r");
data/fldiff-1.1+0/DiffView.cxx:1308:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lineFile1[10240],lineFile2[10240];
data/fldiff-1.1+0/DiffView.cxx:1345:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(line, "%d", count_);
data/fldiff-1.1+0/DiffView.cxx:1347:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(linefmt_, "%%%dd ", linenum_);
data/fldiff-1.1+0/DiffView.h:61:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char linefmt_[16]; // Line number format
data/fldiff-1.1+0/DiffWindow.cxx:331:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dw->open(f1, f2);
data/fldiff-1.1+0/DiffWindow.cxx:341:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dw->open(f1, f2);
data/fldiff-1.1+0/DiffWindow.cxx:364:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dw->open(f2, f1);
data/fldiff-1.1+0/DiffWindow.cxx:382:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dw->open(f1, f2);
data/fldiff-1.1+0/DiffWindow.cxx:409:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nfile1[1024], // New first file
data/fldiff-1.1+0/DiffWindow.cxx:428:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dw->open(nfile1, nfptr2);
data/fldiff-1.1+0/DiffWindow.cxx:630:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[1024]; // Real second file
data/fldiff-1.1+0/DiffWindow.cxx:673:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *files[100]; // Files
data/fldiff-1.1+0/DiffWindow.cxx:782:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[1024]; // Real second file
data/fldiff-1.1+0/DiffWindow.cxx:918:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
DiffWindow::open(const char *f1, // I - First file
data/fldiff-1.1+0/DiffWindow.h:40:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char search_[1024], // Search text
data/fldiff-1.1+0/DiffWindow.h:51:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(const char *f1, const char *f2);
data/fldiff-1.1+0/FavoritesMenu.cxx:41:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[255], // Preference name
data/fldiff-1.1+0/FavoritesMenu.cxx:50:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(name, "favorite%02d", i);
data/fldiff-1.1+0/FavoritesMenu.cxx:89:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[255], // Preference name
data/fldiff-1.1+0/FavoritesMenu.cxx:111:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(name, "favorite%02d", i);
data/fldiff-1.1+0/FavoritesWindow.cxx:182:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[32], // Preference name
data/fldiff-1.1+0/FavoritesWindow.cxx:195:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(name, "favorite%02d", i);
data/fldiff-1.1+0/FavoritesWindow.cxx:238:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[32], // Preference name
data/fldiff-1.1+0/FavoritesWindow.cxx:248:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(name, "favorite%02d", i);
data/fldiff-1.1+0/FavoritesWindow.cxx:257:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(name, "favorite%02d", i);
data/fldiff-1.1+0/PtProcess.cxx:62:20: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE * CPtProcess::fopen(const char *cmd, const char *mode) {
data/fldiff-1.1+0/PtProcess.cxx:67:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
_fpt = ::fopen(cmd,mode);
data/fldiff-1.1+0/PtProcess.h:29:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE * fopen (const char *file, const char *mode="r");
data/fldiff-1.1+0/DiffChooser.cxx:91:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
filename[strlen(filename) - 1] = '\0';
data/fldiff-1.1+0/DiffChooser.cxx:144:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(val);
data/fldiff-1.1+0/DiffChooser.cxx:166:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(matchname, val, sizeof(matchname) - 1);
data/fldiff-1.1+0/DiffChooser.cxx:184:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
min_match = strlen(val);
data/fldiff-1.1+0/DiffChooser.cxx:200:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(matchname, file, sizeof(matchname) - 1);
data/fldiff-1.1+0/DiffChooser.cxx:201:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
max_match = strlen(matchname);
data/fldiff-1.1+0/DiffChooser.cxx:315:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = filename_ + strlen(filename_) - 3;
data/fldiff-1.1+0/DiffChooser.cxx:328:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (filename_[strlen(filename_) - 1] != '/')
data/fldiff-1.1+0/DiffView.cxx:183:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (line->dleft && (leftlen = strlen(line->dleft)) > maxwidth_)
data/fldiff-1.1+0/DiffView.cxx:188:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (line->dright && (rightlen = strlen(line->dright)) > maxwidth_)
data/fldiff-1.1+0/DiffView.cxx:780:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Fl::copy(buf, strlen(buf), 0);
data/fldiff-1.1+0/DiffView.cxx:980:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(line, file1, sizeof(line) - 1);
data/fldiff-1.1+0/DiffView.cxx:988:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(ptr, "CVS", sizeof(line) - 1 - (ptr - line));
data/fldiff-1.1+0/DiffView.cxx:1000:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(ptr, ".svn", sizeof(line) - 1 - (ptr - line));
data/fldiff-1.1+0/DiffView.cxx:1058:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = line + strlen(line) - 1;
data/fldiff-1.1+0/DiffView.cxx:1081:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
filename[strlen(filename) - 1] = '\0';
data/fldiff-1.1+0/DiffView.cxx:1130:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = filename + strlen(filename) - 1;
data/fldiff-1.1+0/DiffView.cxx:1145:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = filename + strlen(filename) - 1;
data/fldiff-1.1+0/DiffView.cxx:1159:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = filename + strlen(filename) - 1;
data/fldiff-1.1+0/DiffView.cxx:1207:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
line->end = strlen(line->dleft);
data/fldiff-1.1+0/DiffView.cxx:1346:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
linenum_ = (int)strlen(line);
data/fldiff-1.1+0/DiffView.cxx:1458:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Fl::copy(buf, strlen(buf), 0);
data/fldiff-1.1+0/DiffView.cxx:1481:69: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (ptr = buf, i = select_start_; i <= select_end_; i ++, ptr += strlen(ptr))
data/fldiff-1.1+0/DiffView.cxx:1507:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(lines_[i]->right);
data/fldiff-1.1+0/DiffView.cxx:1509:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(lines_[i]->left);
data/fldiff-1.1+0/DiffWindow.cxx:319:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(f2);
data/fldiff-1.1+0/DiffWindow.cxx:320:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
j = strlen(dow->dc1()->directory());
data/fldiff-1.1+0/DiffWindow.cxx:352:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(f1);
data/fldiff-1.1+0/DiffWindow.cxx:353:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
j = strlen(dow->dc2()->directory());
data/fldiff-1.1+0/DiffWindow.cxx:451:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Fl::copy(buf, strlen(buf), 1);
data/fldiff-1.1+0/DiffWindow.cxx:559:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dw->search_, s, sizeof(dw->search_) - 1);
data/fldiff-1.1+0/DiffWindow.cxx:639:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (f2[strlen(f2) - 1] == '/')
data/fldiff-1.1+0/DiffWindow.cxx:647:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(filename, f2, sizeof(filename) - 1);
data/fldiff-1.1+0/DiffWindow.cxx:650:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(filename, f2, sizeof(filename) - 1);
data/fldiff-1.1+0/DiffWindow.cxx:806:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (file2[strlen(file2) - 1] == '/')
data/fldiff-1.1+0/DiffWindow.cxx:814:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(filename, file2, sizeof(filename) - 1);
data/fldiff-1.1+0/DiffWindow.cxx:817:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(filename, file2, sizeof(filename) - 1);
ANALYSIS SUMMARY:
Hits = 106
Lines analyzed = 4614 in approximately 0.37 seconds (12437 lines/second)
Physical Source Lines of Code (SLOC) = 3002
Hits@level = [0] 27 [1] 37 [2] 40 [3] 3 [4] 26 [5] 0
Hits@level+ = [0+] 133 [1+] 106 [2+] 69 [3+] 29 [4+] 26 [5+] 0
Hits/KSLOC@level+ = [0+] 44.3038 [1+] 35.3098 [2+] 22.9847 [3+] 9.66023 [4+] 8.66089 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.