Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/freebsd-glue-0.2.22/include/readpassphrase.h
Examining data/freebsd-glue-0.2.22/include/vis.h
Examining data/freebsd-glue-0.2.22/include/linux/sysctl.h
Examining data/freebsd-glue-0.2.22/include/linux/icmp.h
Examining data/freebsd-glue-0.2.22/include/embed/sys/elf_common.h
Examining data/freebsd-glue-0.2.22/include/grp.h
Examining data/freebsd-glue-0.2.22/include/machine/elf.h
Examining data/freebsd-glue-0.2.22/include/machine/_types.h
Examining data/freebsd-glue-0.2.22/include/machine/endian.h
Examining data/freebsd-glue-0.2.22/include/termios.h
Examining data/freebsd-glue-0.2.22/include/stdlib.h
Examining data/freebsd-glue-0.2.22/include/timeconv.h
Examining data/freebsd-glue-0.2.22/include/fcntl.h
Examining data/freebsd-glue-0.2.22/include/paths.h
Examining data/freebsd-glue-0.2.22/include/netinet6/in6.h
Examining data/freebsd-glue-0.2.22/include/libgen.h
Examining data/freebsd-glue-0.2.22/include/bits/utmp.h
Examining data/freebsd-glue-0.2.22/include/bits/utmpx.h
Examining data/freebsd-glue-0.2.22/include/bits/stat.h
Examining data/freebsd-glue-0.2.22/include/net/ethernet.h
Examining data/freebsd-glue-0.2.22/include/net/if_dl.h
Examining data/freebsd-glue-0.2.22/include/pthread_np.h
Examining data/freebsd-glue-0.2.22/include/netinet/in.h
Examining data/freebsd-glue-0.2.22/include/netinet/ip.h
Examining data/freebsd-glue-0.2.22/include/netinet/tcp.h
Examining data/freebsd-glue-0.2.22/include/netinet/udp.h
Examining data/freebsd-glue-0.2.22/include/bsdxml.h
Examining data/freebsd-glue-0.2.22/include/md5.h
Examining data/freebsd-glue-0.2.22/include/osreldate.h
Examining data/freebsd-glue-0.2.22/include/stdint.h
Examining data/freebsd-glue-0.2.22/include/ctype.h
Examining data/freebsd-glue-0.2.22/include/__want_lseek.h
Examining data/freebsd-glue-0.2.22/include/fstab.h
Examining data/freebsd-glue-0.2.22/include/string.h
Examining data/freebsd-glue-0.2.22/include/nlist.h
Examining data/freebsd-glue-0.2.22/include/sys/elf64.h
Examining data/freebsd-glue-0.2.22/include/sys/elf_common.h
Examining data/freebsd-glue-0.2.22/include/sys/limits.h
Examining data/freebsd-glue-0.2.22/include/sys/cdefs.h
Examining data/freebsd-glue-0.2.22/include/sys/time.h
Examining data/freebsd-glue-0.2.22/include/sys/sysctl.h
Examining data/freebsd-glue-0.2.22/include/sys/stdint.h
Examining data/freebsd-glue-0.2.22/include/sys/param.h
Examining data/freebsd-glue-0.2.22/include/sys/errno.h
Examining data/freebsd-glue-0.2.22/include/sys/types.h
Examining data/freebsd-glue-0.2.22/include/sys/proc.h
Examining data/freebsd-glue-0.2.22/include/sys/user.h
Examining data/freebsd-glue-0.2.22/include/sys/_types.h
Examining data/freebsd-glue-0.2.22/include/sys/ttycom.h
Examining data/freebsd-glue-0.2.22/include/sys/_stdint.h
Examining data/freebsd-glue-0.2.22/include/sys/stat.h
Examining data/freebsd-glue-0.2.22/include/sys/endian.h
Examining data/freebsd-glue-0.2.22/include/sys/file.h
Examining data/freebsd-glue-0.2.22/include/sys/elf32.h
Examining data/freebsd-glue-0.2.22/include/sys/elf.h
Examining data/freebsd-glue-0.2.22/include/sys/socket.h
Examining data/freebsd-glue-0.2.22/include/sys/queue.h
Examining data/freebsd-glue-0.2.22/include/sys/fcntl.h
Examining data/freebsd-glue-0.2.22/include/sys/ioccom.h
Examining data/freebsd-glue-0.2.22/include/rpc/xdr.h
Examining data/freebsd-glue-0.2.22/include/ndbm.h
Examining data/freebsd-glue-0.2.22/include/limits.h
Examining data/freebsd-glue-0.2.22/include/asm/stat.h
Examining data/freebsd-glue-0.2.22/include/db.h
Examining data/freebsd-glue-0.2.22/include/err.h
Examining data/freebsd-glue-0.2.22/include/unistd.h
Examining data/freebsd-glue-0.2.22/include/netdb.h
Examining data/freebsd-glue-0.2.22/include/aio.h
Examining data/freebsd-glue-0.2.22/include/stdio.h
Examining data/freebsd-glue-0.2.22/src/z/zopen.c
Examining data/freebsd-glue-0.2.22/src/crypt/crypt.c
Examining data/freebsd-glue-0.2.22/src/get_elf_arch.c
Examining data/freebsd-glue-0.2.22/src/host_elf_arch.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/basename.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/linkaddr.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/feature_present.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/disklabel.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/login_class.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/capability.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/getosreldate.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/getcap.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/exec.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/fstab.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/socket.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/cpuset.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/random.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/getbsize.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/mac_set.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/strnstr.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/sysarch.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/getbootfile.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/subr_capability.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/sendfile.c
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/namespace.h
Examining data/freebsd-glue-0.2.22/src/freebsd-glue/un-namespace.h
FINAL RESULTS:
data/freebsd-glue-0.2.22/src/freebsd-glue/exec.c:8:9: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
return execvp(name, argv);
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:353:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((*mac)->m_string, elements);
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:430:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(mibname, policyname);
data/freebsd-glue-0.2.22/include/unistd.h:14:9: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
#define getopt(argc, argv, options) bsd_getopt(argc, argv, options)
data/freebsd-glue-0.2.22/src/freebsd-glue/getbsize.c:56:11: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((p = getenv("BLOCKSIZE")) != NULL && *p != '\0') {
data/freebsd-glue-0.2.22/src/freebsd-glue/getosreldate.c:43:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((temp = getenv("OSVERSION"))) {
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:178:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (!issetugid() && getenv("MAC_CONFFILE") != NULL)
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:179:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
filename = getenv("MAC_CONFFILE");
data/freebsd-glue-0.2.22/src/freebsd-glue/random.c:47:3: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom (seed);
data/freebsd-glue-0.2.22/include/fcntl.h:11:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
#define _open open
data/freebsd-glue-0.2.22/include/sys/elf32.h:63:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char e_ident[EI_NIDENT]; /* File identification. */
data/freebsd-glue-0.2.22/include/sys/elf64.h:74:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char e_ident[EI_NIDENT]; /* File identification. */
data/freebsd-glue-0.2.22/src/freebsd-glue/getbootfile.c:44:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char name[MAXPATHLEN];
data/freebsd-glue-0.2.22/src/freebsd-glue/getbsize.c:46:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char header[20];
data/freebsd-glue-0.2.22/src/freebsd-glue/getosreldate.c:44:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
value = atoi(temp);
data/freebsd-glue-0.2.22/src/freebsd-glue/linkaddr.c:126:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char obuf[64];
data/freebsd-glue-0.2.22/src/freebsd-glue/linkaddr.c:134:3: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
bcopy(sdl->sdl_data, obuf, sdl->sdl_nlen);
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:170:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_MAX];
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:182:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file = fopen(filename, "re");
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:429:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mibname, "security.mac.");
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:431:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(mibname, ".enabled");
data/freebsd-glue-0.2.22/src/freebsd-glue/random.c:40:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open ("/dev/random", O_RDONLY);
data/freebsd-glue-0.2.22/src/get_elf_arch.c:12:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open (argv[1], O_RDONLY);
data/freebsd-glue-0.2.22/include/fcntl.h:12:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#define _read read
data/freebsd-glue-0.2.22/src/freebsd-glue/basename.c:34:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (bname, path, MAXPATHLEN);
data/freebsd-glue-0.2.22/src/freebsd-glue/getbsize.c:103:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*headerlenp = strlen(header);
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:189:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (line[strlen(line)-1] == '\n')
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:190:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
line[strlen(line)-1] = '\0';
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:320:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(*mac)->m_buflen = strlen((*mac)->m_string)+1;
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:339:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(elements) >= MAC_MAX_LABEL_BUF_LEN)
data/freebsd-glue-0.2.22/src/freebsd-glue/mac.c:426:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(policyname) + sizeof(".enabled"));
data/freebsd-glue-0.2.22/src/freebsd-glue/random.c:44:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (fd, &seed, sizeof (seed)) != sizeof (seed))
data/freebsd-glue-0.2.22/src/freebsd-glue/strnstr.c:53:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(find);
data/freebsd-glue-0.2.22/src/get_elf_arch.c:16:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (fd, &ehdr, sizeof (ehdr)) != sizeof (ehdr))
ANALYSIS SUMMARY:
Hits = 34
Lines analyzed = 4965 in approximately 0.20 seconds (25447 lines/second)
Physical Source Lines of Code (SLOC) = 3226
Hits@level = [0] 3 [1] 11 [2] 14 [3] 6 [4] 3 [5] 0
Hits@level+ = [0+] 37 [1+] 34 [2+] 23 [3+] 9 [4+] 3 [5+] 0
Hits/KSLOC@level+ = [0+] 11.4693 [1+] 10.5394 [2+] 7.12957 [3+] 2.78983 [4+] 0.929944 [5+] 0
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.