Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/freesweep-1.0.1/acconfig.h
Examining data/freesweep-1.0.1/clear.c
Examining data/freesweep-1.0.1/defaults.h
Examining data/freesweep-1.0.1/drawing.c
Examining data/freesweep-1.0.1/error.c
Examining data/freesweep-1.0.1/fgui.c
Examining data/freesweep-1.0.1/image.c
Examining data/freesweep-1.0.1/pbests.c
Parsing failed to find end of parameter list; semicolon terminated it in (mbuf[i].buf, maxsize, "%s(a%um%ut%u)%s\n",
#else
sprintf(mbuf[i].buf, "%s(a%um%ut%u)%s\n",
#endif
b->name, b->area, b->mines, b->time, b->date);
mbuf[i].len = strlen(mbuf[i].buf);
/* e
Examining data/freesweep-1.0.1/play.c
Examining data/freesweep-1.0.1/sl.c
Examining data/freesweep-1.0.1/stats.c
Examining data/freesweep-1.0.1/tick.c
Examining data/freesweep-1.0.1/utils.c
Examining data/freesweep-1.0.1/gpl.c
Examining data/freesweep-1.0.1/game.c
Examining data/freesweep-1.0.1/files.c
Examining data/freesweep-1.0.1/main.c
FINAL RESULTS:
data/freesweep-1.0.1/error.c:38:3: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(NewErrMsg,41,format,args);
data/freesweep-1.0.1/error.c:40:3: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
vsprintf(NewErrMsg,format,args);
data/freesweep-1.0.1/error.c:122:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(NewErrMsg,41,format,args);
data/freesweep-1.0.1/error.c:124:3: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
vsprintf(NewErrMsg,format,args);
data/freesweep-1.0.1/fgui.c:68:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tmp->fpath, path);
data/freesweep-1.0.1/fgui.c:74:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(tmp->fpath, dp->d_name);
data/freesweep-1.0.1/files.c:175:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(Pathname, "%s/%s", Buffer, DFL_PREFS_FILE);
data/freesweep-1.0.1/pbests.c:162:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf((char *)p, "%[^(](a%dm%dt%d)%s",
data/freesweep-1.0.1/pbests.c:328:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(mbuf[i].buf, "%s(a%um%ut%u)%s\n",
data/freesweep-1.0.1/pbests.c:388:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(b->name, buf);
data/freesweep-1.0.1/pbests.c:406:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(b->date, buf);
data/freesweep-1.0.1/pbests.c:440:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(fp, "%s/%s", home, DFL_BESTS_FILE);
data/freesweep-1.0.1/pbests.c:459:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(fp, "%s/sweeptimes", mkstr2(SCORESDIR));
data/freesweep-1.0.1/utils.c:38:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(c, s);
data/freesweep-1.0.1/files.c:102:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((Buffer=getenv("HOME"))==NULL)
data/freesweep-1.0.1/files.c:166:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((Buffer=getenv("HOME"))==NULL)
data/freesweep-1.0.1/game.c:187:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(time(NULL));
data/freesweep-1.0.1/game.c:268:14: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((Opt=getopt_long(Argc,Argv,"%:abdfgh:im:svw:",long_options, NULL))!=EOF)
data/freesweep-1.0.1/game.c:274:14: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((Opt=getopt(Argc,Argv,"%:abdfgh:im:svw:"))!=EOF)
data/freesweep-1.0.1/game.c:501:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(time(NULL));
data/freesweep-1.0.1/pbests.c:379:8: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
buf = getenv("USER");
data/freesweep-1.0.1/pbests.c:424:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
home = getenv("HOME");
data/freesweep-1.0.1/drawing.c:67:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ValueBuffer[(L_MAX_W+L_MAX_H+3)];
data/freesweep-1.0.1/drawing.c:100:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/drawing.c:140:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/drawing.c:206:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/error.c:25:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char NewErrMsg[42];
data/freesweep-1.0.1/error.c:110:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char NewErrMsg[42];
data/freesweep-1.0.1/files.c:15:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char RawBuffer[MAX_LINE];
data/freesweep-1.0.1/files.c:32:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/files.c:37:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/files.c:42:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/files.c:47:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/files.c:52:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/files.c:57:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/files.c:62:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(ValueBuffer);
data/freesweep-1.0.1/files.c:113:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((PrefsFile=fopen(Pathname,"r"))==NULL)
data/freesweep-1.0.1/files.c:140:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((PrefsFile=fopen(GLOBAL_PREFS_FILE,"r"))==NULL)
data/freesweep-1.0.1/files.c:164:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *Buffer, Pathname[MAX_LINE+1];
data/freesweep-1.0.1/files.c:178:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((PrefsFile=fopen(Pathname,"w"))==NULL)
data/freesweep-1.0.1/game.c:281:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(optarg);
data/freesweep-1.0.1/game.c:305:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(optarg);
data/freesweep-1.0.1/game.c:313:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(optarg);
data/freesweep-1.0.1/game.c:327:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Value=atoi(optarg);
data/freesweep-1.0.1/image.c:19:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( (fo = fopen(fname, "w") ) == NULL )
data/freesweep-1.0.1/main.c:26:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((DebugLog=fopen("debug.log","a"))==0)
data/freesweep-1.0.1/pbests.c:88:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
abyss = fopen(truename, "r+");
data/freesweep-1.0.1/pbests.c:91:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
abyss = fopen(truename, "w");
data/freesweep-1.0.1/pbests.c:277:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(name, "w");
data/freesweep-1.0.1/sl.c:17:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( ( fo = fopen(fname, "w") ) == NULL )
data/freesweep-1.0.1/sl.c:52:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (( fi = fopen(fname, "r") ) == NULL )
data/freesweep-1.0.1/fgui.c:61:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp->fpath = xmalloc(strlen(dp->d_name) + strlen(path) + 2);
data/freesweep-1.0.1/fgui.c:61:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp->fpath = xmalloc(strlen(dp->d_name) + strlen(path) + 2);
data/freesweep-1.0.1/fgui.c:66:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tmp->fpath, path, (strlen(dp->d_name) + strlen(path) + 2));
data/freesweep-1.0.1/fgui.c:66:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(tmp->fpath, path, (strlen(dp->d_name) + strlen(path) + 2));
data/freesweep-1.0.1/fgui.c:66:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(tmp->fpath, path, (strlen(dp->d_name) + strlen(path) + 2));
data/freesweep-1.0.1/fgui.c:72:4: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(tmp->fpath, "/");
data/freesweep-1.0.1/fgui.c:312:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p = fb[find+i].fpath + strlen(fb[find+i].fpath) - 1;
data/freesweep-1.0.1/pbests.c:250:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(bfd->ents[i].name, n->name, MAX_NAME);
data/freesweep-1.0.1/pbests.c:251:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(bfd->ents[i].date, n->date, MAX_DATE);
data/freesweep-1.0.1/pbests.c:268:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(bfd->ents[bfd->numents].name, n->name, MAX_NAME);
data/freesweep-1.0.1/pbests.c:269:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(bfd->ents[bfd->numents].date, n->date, MAX_DATE);
data/freesweep-1.0.1/pbests.c:332:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbuf[i].len = strlen(mbuf[i].buf);
data/freesweep-1.0.1/pbests.c:386:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(b->name, buf, MAX_NAME);
data/freesweep-1.0.1/pbests.c:404:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(b->date, buf, MAX_DATE);
data/freesweep-1.0.1/pbests.c:434:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fp = (char*)xmalloc(strlen(home) + strlen(DFL_BESTS_FILE) + 2);
data/freesweep-1.0.1/pbests.c:434:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fp = (char*)xmalloc(strlen(home) + strlen(DFL_BESTS_FILE) + 2);
data/freesweep-1.0.1/pbests.c:438:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
snprintf(fp, strlen(home) + strlen(DFL_BESTS_FILE) + 2, "%s/%s", home, DFL_BESTS_FILE);
data/freesweep-1.0.1/pbests.c:438:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
snprintf(fp, strlen(home) + strlen(DFL_BESTS_FILE) + 2, "%s/%s", home, DFL_BESTS_FILE);
data/freesweep-1.0.1/pbests.c:453:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fp = (char*)xmalloc(strlen(mkstr2(SCORESDIR)) + 11);
data/freesweep-1.0.1/pbests.c:457:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
snprintf(fp, (strlen(mkstr2(SCORESDIR)) + 11), "%s/sweeptimes", mkstr2(SCORESDIR));
data/freesweep-1.0.1/utils.c:33:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
c = (char*)xmalloc(strlen(s) + 1);
data/freesweep-1.0.1/utils.c:36:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(c, s, strlen(s) + 1);
data/freesweep-1.0.1/utils.c:36:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(c, s, strlen(s) + 1);
ANALYSIS SUMMARY:
Hits = 74
Lines analyzed = 5183 in approximately 0.17 seconds (31194 lines/second)
Physical Source Lines of Code (SLOC) = 4143
Hits@level = [0] 99 [1] 23 [2] 29 [3] 8 [4] 14 [5] 0
Hits@level+ = [0+] 173 [1+] 74 [2+] 51 [3+] 22 [4+] 14 [5+] 0
Hits/KSLOC@level+ = [0+] 41.7572 [1+] 17.8615 [2+] 12.3099 [3+] 5.31016 [4+] 3.37919 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.