Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/gbsplay-0.0.93/gbhw.c
Examining data/gbsplay-0.0.93/common.h
Examining data/gbsplay-0.0.93/impulsegen.h
Examining data/gbsplay-0.0.93/gbcpu.c
Examining data/gbsplay-0.0.93/plugout_stdout.h
Examining data/gbsplay-0.0.93/gbhw.h
Examining data/gbsplay-0.0.93/plugout_nas.c
Examining data/gbsplay-0.0.93/test_gbs.c
Examining data/gbsplay-0.0.93/cfgparser.h
Examining data/gbsplay-0.0.93/plugout_midi.c
Examining data/gbsplay-0.0.93/plugout_pulse.c
Examining data/gbsplay-0.0.93/plugout.c
Examining data/gbsplay-0.0.93/impulsegen.c
Examining data/gbsplay-0.0.93/gbs.c
Examining data/gbsplay-0.0.93/plugout_devdsp.h
Examining data/gbsplay-0.0.93/crc32.c
Examining data/gbsplay-0.0.93/plugout_stdout.c
Examining data/gbsplay-0.0.93/plugout_nas.h
Examining data/gbsplay-0.0.93/crc32.h
Examining data/gbsplay-0.0.93/cfgparser.c
Examining data/gbsplay-0.0.93/plugout_dsound.c
Examining data/gbsplay-0.0.93/util.c
Examining data/gbsplay-0.0.93/plugout.h
Examining data/gbsplay-0.0.93/test.h
Examining data/gbsplay-0.0.93/gbcpu.h
Examining data/gbsplay-0.0.93/gbsxmms.c
Examining data/gbsplay-0.0.93/util.h
Examining data/gbsplay-0.0.93/gbsinfo.c
Examining data/gbsplay-0.0.93/gbs.h
Examining data/gbsplay-0.0.93/gbsplay.c
Examining data/gbsplay-0.0.93/plugout_devdsp.c
Examining data/gbsplay-0.0.93/plugout_alsa.c
FINAL RESULTS:
data/gbsplay-0.0.93/gbcpu.h:30:22: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define DPRINTF(...) printf(__VA_ARGS__)
data/gbsplay-0.0.93/gbsxmms.c:49:2: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, __VA_ARGS__); \
data/gbsplay-0.0.93/gbsxmms.c:572:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(file_info_title, filename);
data/gbsplay-0.0.93/cfgparser.c:211:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
homedir = getenv("HOME");
data/gbsplay-0.0.93/gbsinfo.c:44:16: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((res = getopt(*argc, *argv, "hV")) != -1) {
data/gbsplay-0.0.93/gbsplay.c:215:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(random_seed);
data/gbsplay-0.0.93/gbsplay.c:386:16: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((res = getopt(*argc, *argv, "1234c:E:f:g:hlo:qr:R:t:T:vVzZ")) != -1) {
data/gbsplay-0.0.93/gbsplay.c:657:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(random_seed);
data/gbsplay-0.0.93/util.c:41:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(0);
data/gbsplay-0.0.93/cfgparser.c:95:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[200];
data/gbsplay-0.0.93/cfgparser.c:117:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char num[20];
data/gbsplay-0.0.93/cfgparser.c:131:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*((long*)ptr) = atoi(num);
data/gbsplay-0.0.93/cfgparser.c:139:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char option[200] = "";
data/gbsplay-0.0.93/cfgparser.c:142:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
cfg_file = fopen(fname, "r");
data/gbsplay-0.0.93/gbcpu.c:18:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char regnames[12] = "BCDEHLFASPPC";
data/gbsplay-0.0.93/gbcpu.c:19:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char *regnamech16[6] = {
data/gbsplay-0.0.93/gbcpu.c:22:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char *conds[4] = {
data/gbsplay-0.0.93/gbhw.c:28:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char dutylookup[4] = {
data/gbsplay-0.0.93/gbs.c:277:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pad[16];
data/gbsplay-0.0.93/gbs.c:278:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strings[65536];
data/gbsplay-0.0.93/gbs.c:284:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmpname, name, namelen);
data/gbsplay-0.0.93/gbs.c:285:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(&tmpname[namelen], ".tmp");
data/gbsplay-0.0.93/gbs.c:288:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(tmpname, O_WRONLY|O_CREAT|O_TRUNC, 0644)) == -1) {
data/gbsplay-0.0.93/gbs.c:309:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(strings+stringofs, gbs->title, len+1);
data/gbsplay-0.0.93/gbs.c:314:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(strings+stringofs, gbs->author, len+1);
data/gbsplay-0.0.93/gbs.c:319:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(strings+stringofs, gbs->copyright, len+1);
data/gbsplay-0.0.93/gbs.c:330:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(strings+stringofs, gbs->subsong_info[i].title, len);
data/gbsplay-0.0.93/gbs.c:336:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(gbs->buf + newlen, strings, stringofs);
data/gbsplay-0.0.93/gbs.c:379:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(name, O_RDONLY)) == -1) {
data/gbsplay-0.0.93/gbs.c:418:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(gbs->v1strings, &buf[0x10], 32);
data/gbsplay-0.0.93/gbs.c:419:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(gbs->v1strings+33, &buf[0x30], 32);
data/gbsplay-0.0.93/gbs.c:420:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(gbs->v1strings+66, &buf[0x50], 30);
data/gbsplay-0.0.93/gbs.c:452:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(gbs->v1strings+66, &buf[0x50], 32);
data/gbsplay-0.0.93/gbs.c:493:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&gbs->rom[gbs->load - 0x70], buf, 0x70 + gbs->codelen);
data/gbsplay-0.0.93/gbs.c:494:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&gbs->rom[0x50], playercode, sizeof(playercode));
data/gbsplay-0.0.93/gbs.h:49:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char v1strings[33*3];
data/gbsplay-0.0.93/gbsplay.c:44:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char notelookup[4*MAXOCTAVE*12];
data/gbsplay-0.0.93/gbsplay.c:45:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char vollookup[5*16];
data/gbsplay-0.0.93/gbsplay.c:46:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char vols[5] = " -=#%";
data/gbsplay-0.0.93/gbsplay.c:147:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[5];
data/gbsplay-0.0.93/gbsplay.c:633:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
sound_open = plugout->open;
data/gbsplay-0.0.93/gbsxmms.c:571:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(file_info_title, _("File Info: "));
data/gbsplay-0.0.93/gbsxmms.c:618:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[5];
data/gbsplay-0.0.93/gbsxmms.c:666:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
long fd = open(filename, O_RDONLY);
data/gbsplay-0.0.93/gbsxmms.c:668:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char id[4];
data/gbsplay-0.0.93/plugout.h:37:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
plugout_open_fn open;
data/gbsplay-0.0.93/plugout_devdsp.c:31:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open("/dev/dsp", O_WRONLY|O_NONBLOCK)) == -1) {
data/gbsplay-0.0.93/plugout_dsound.c:139:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pBuf1, buf, nBuf1);
data/gbsplay-0.0.93/plugout_dsound.c:142:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pBuf2, (void*)((char*)buf + nBuf1), nBuf2);
data/gbsplay-0.0.93/plugout_midi.c:114:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file = fopen(filename, "wb");
data/gbsplay-0.0.93/plugout_nas.c:60:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char s[100];
data/gbsplay-0.0.93/cfgparser.c:33:12: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((c = fgetc(cfg_file)) == EOF) return 0;
data/gbsplay-0.0.93/cfgparser.c:214:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(homedir) + strlen(cfgfile) + 2;
data/gbsplay-0.0.93/cfgparser.c:214:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(homedir) + strlen(cfgfile) + 2;
data/gbsplay-0.0.93/gbhw.c:659:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
(void)usleep(time_to_work*1000);
data/gbsplay-0.0.93/gbs.c:281:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
long namelen = strlen(name);
data/gbsplay-0.0.93/gbs.c:306:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(gbs->exthdr, GBS_EXTHDR_MAGIC, 4);
data/gbsplay-0.0.93/gbs.c:308:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((len = strlen(gbs->title)) > 32) {
data/gbsplay-0.0.93/gbs.c:313:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((len = strlen(gbs->author)) > 32) {
data/gbsplay-0.0.93/gbs.c:318:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((len = strlen(gbs->copyright)) > 30) {
data/gbsplay-0.0.93/gbs.c:329:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(gbs->subsong_info[i].title)+1;
data/gbsplay-0.0.93/gbs.c:385:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(fd, buf, st.st_size) != st.st_size) {
data/gbsplay-0.0.93/gbsplay.c:464:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(STDIN_FILENO, &c, 1) != -1) {
data/gbsplay-0.0.93/gbsxmms.c:134:58: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
while (gbs_ip.output->buffer_playing() && !stopthread) usleep(10000);
data/gbsplay-0.0.93/gbsxmms.c:176:4: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(workunit*1000);
data/gbsplay-0.0.93/gbsxmms.c:197:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
long len = 13 + strlen(gbs->title) + strlen(gbs->author) + strlen(gbs->copyright);
data/gbsplay-0.0.93/gbsxmms.c:197:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
long len = 13 + strlen(gbs->title) + strlen(gbs->author) + strlen(gbs->copyright);
data/gbsplay-0.0.93/gbsxmms.c:197:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
long len = 13 + strlen(gbs->title) + strlen(gbs->author) + strlen(gbs->copyright);
data/gbsplay-0.0.93/gbsxmms.c:239:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(gbs->title) +
data/gbsplay-0.0.93/gbsxmms.c:240:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(gbs->author) +
data/gbsplay-0.0.93/gbsxmms.c:241:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(gbs->copyright);
data/gbsplay-0.0.93/gbsxmms.c:564:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
long titlelen = strlen(filename) + 12;
data/gbsplay-0.0.93/gbsxmms.c:671:2: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read(fd, id, sizeof(id));
data/gbsplay-0.0.93/plugout_nas.c:207:10: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
(void)usleep(1000);
ANALYSIS SUMMARY:
Hits = 74
Lines analyzed = 6873 in approximately 0.23 seconds (30411 lines/second)
Physical Source Lines of Code (SLOC) = 5583
Hits@level = [0] 100 [1] 23 [2] 42 [3] 6 [4] 3 [5] 0
Hits@level+ = [0+] 174 [1+] 74 [2+] 51 [3+] 9 [4+] 3 [5+] 0
Hits/KSLOC@level+ = [0+] 31.166 [1+] 13.2545 [2+] 9.13487 [3+] 1.61204 [4+] 0.537346 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.