Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/globus-xio-udt-driver-2.2/ice.c
Examining data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp
Examining data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.h
Examining data/globus-xio-udt-driver-2.2/libnice/globus_libnice_mingw.h
Examining data/globus-xio-udt-driver-2.2/ice.h
Examining data/globus-xio-udt-driver-2.2/udt/globus_udt_config.h
FINAL RESULTS:
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:536:40: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:542:40: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:566:40: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:585:40: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/udt/globus_udt_config.h:48:34: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
#error Unknown operating system
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:194:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
globus_l_xio_udt_stunserver = getenv("GLOBUS_XIO_UDT_STUNSERVER");
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:246:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst_attr, src_attr, sizeof(xio_l_udt_ref_attr_t));
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:322:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
stunport = atoi(ptr);
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:530:40: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:548:40: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:554:40: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:560:40: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:573:40: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:579:40: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:592:40: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
string_opts_len += sprintf(
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:788:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
min = atoi(contact_info->port);
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:789:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
max = atoi(contact_info->port);
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:817:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&server_handle->addr, &my_addr, sizeof(my_addr));
data/globus-xio-udt-driver-2.2/globus_xio_udt_ref.cpp:1326:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
handle->sock, (char *)iovec[0].iov_base, iovec[0].iov_len, 0);
data/globus-xio-udt-driver-2.2/ice.c:616:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char foundation[33], ipaddr[46], type[7];
data/globus-xio-udt-driver-2.2/ice.c:232:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ufraglen = strlen(local_ufrag);
data/globus-xio-udt-driver-2.2/ice.c:233:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
passwordlen = strlen(local_password);
data/globus-xio-udt-driver-2.2/ice.c:313:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ufrag, rdata[0], sizeof(ufrag));
data/globus-xio-udt-driver-2.2/ice.c:314:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(password, rdata[1], sizeof(password));
data/globus-xio-udt-driver-2.2/ice.c:624:11: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
cnt = sscanf(scand, "%32[^,],%u,%45[^,],%d,%6s", foundation, &prio, ipaddr,
data/globus-xio-udt-driver-2.2/ice.c:644:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(out->foundation, foundation, NICE_CANDIDATE_MAX_FOUNDATION);
ANALYSIS SUMMARY:
Hits = 26
Lines analyzed = 2483 in approximately 0.07 seconds (36443 lines/second)
Physical Source Lines of Code (SLOC) = 1964
Hits@level = [0] 16 [1] 6 [2] 14 [3] 1 [4] 5 [5] 0
Hits@level+ = [0+] 42 [1+] 26 [2+] 20 [3+] 6 [4+] 5 [5+] 0
Hits/KSLOC@level+ = [0+] 21.3849 [1+] 13.2383 [2+] 10.1833 [3+] 3.05499 [4+] 2.54582 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.