Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/gnome-screensaver-3.6.1/src/test-fade.c
Examining data/gnome-screensaver-3.6.1/src/bus.h
Examining data/gnome-screensaver-3.6.1/src/gnome-screensaver-command.c
Examining data/gnome-screensaver-3.6.1/src/gs-grab.h
Examining data/gnome-screensaver-3.6.1/src/gs-debug.c
Examining data/gnome-screensaver-3.6.1/src/subprocs.h
Examining data/gnome-screensaver-3.6.1/src/setuid.c
Examining data/gnome-screensaver-3.6.1/src/gnome-screensaver.c
Examining data/gnome-screensaver-3.6.1/src/setuid.h
Examining data/gnome-screensaver-3.6.1/src/gs-window.h
Examining data/gnome-screensaver-3.6.1/src/gs-lock-plug.h
Examining data/gnome-screensaver-3.6.1/src/gs-marshal.h
Examining data/gnome-screensaver-3.6.1/src/gs-fade.h
Examining data/gnome-screensaver-3.6.1/src/gs-prefs.c
Examining data/gnome-screensaver-3.6.1/src/gs-prefs.h
Examining data/gnome-screensaver-3.6.1/src/test-window.c
Examining data/gnome-screensaver-3.6.1/src/gs-debug.h
Examining data/gnome-screensaver-3.6.1/src/gs-marshal.c
Examining data/gnome-screensaver-3.6.1/src/gs-monitor.h
Examining data/gnome-screensaver-3.6.1/src/gs-window-x11.c
Examining data/gnome-screensaver-3.6.1/src/subprocs.c
Examining data/gnome-screensaver-3.6.1/src/gnome-screensaver-dialog.c
Examining data/gnome-screensaver-3.6.1/src/gs-auth-pam.c
Examining data/gnome-screensaver-3.6.1/src/gnome-screensaver.h
Examining data/gnome-screensaver-3.6.1/src/gs-watcher.h
Examining data/gnome-screensaver-3.6.1/src/test-passwd.c
Examining data/gnome-screensaver-3.6.1/src/gs-manager.h
Examining data/gnome-screensaver-3.6.1/src/gs-grab-x11.c
Examining data/gnome-screensaver-3.6.1/src/gs-fade.c
Examining data/gnome-screensaver-3.6.1/src/test-watcher.c
Examining data/gnome-screensaver-3.6.1/src/gs-auth.h
Examining data/gnome-screensaver-3.6.1/src/gs-watcher-x11.c
Examining data/gnome-screensaver-3.6.1/src/gs-listener-dbus.c
Examining data/gnome-screensaver-3.6.1/src/gs-listener-dbus.h
Examining data/gnome-screensaver-3.6.1/src/gs-monitor.c
Examining data/gnome-screensaver-3.6.1/src/gs-lock-plug.c
Examining data/gnome-screensaver-3.6.1/src/gs-manager.c
FINAL RESULTS:
data/gnome-screensaver-3.6.1/src/gs-listener-dbus.c:362:9: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf (buf, sizeof (buf), format, args);
data/gnome-screensaver-3.6.1/src/gs-listener-dbus.c:1511:41: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
listener->priv->have_systemd = (access("/run/systemd/seats/", F_OK) >= 0);
data/gnome-screensaver-3.6.1/src/gnome-screensaver-dialog.c:510:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv ("RUNNING_UNDER_GDM")) {
data/gnome-screensaver-3.6.1/src/gs-lock-plug.c:1184:24: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
g_spawn_async (g_get_home_dir (),
data/gnome-screensaver-3.6.1/src/test-passwd.c:102:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv ("RUNNING_UNDER_GDM")) {
data/gnome-screensaver-3.6.1/src/gs-auth-pam.c:749:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[255];
data/gnome-screensaver-3.6.1/src/gs-debug.c:51:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer [1025];
data/gnome-screensaver-3.6.1/src/gs-debug.c:96:23: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char path [50] = "gnome_screensaver_debug_XXXXXX";
data/gnome-screensaver-3.6.1/src/gs-grab-x11.c:74:32: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char foo [255];
data/gnome-screensaver-3.6.1/src/gs-grab-x11.c:75:25: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (foo, "unknown status: %d", status);
data/gnome-screensaver-3.6.1/src/gs-listener-dbus.c:357:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[512];
data/gnome-screensaver-3.6.1/src/gs-listener-dbus.c:393:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf [512];
data/gnome-screensaver-3.6.1/src/subprocs.c:36:16: [2] (race) vfork:
On some old systems, vfork() permits race conditions, and it's very
difficult to use correctly (CWE-362). Use fork() instead.
# define fork vfork
data/gnome-screensaver-3.6.1/src/subprocs.c:112:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf [1024];
data/gnome-screensaver-3.6.1/src/test-passwd.c:141:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf [255];
data/gnome-screensaver-3.6.1/src/gs-lock-plug.c:333:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
local_text = g_locale_from_utf8 (typed_text, strlen (typed_text), NULL, NULL, NULL);
data/gnome-screensaver-3.6.1/src/gs-lock-plug.c:335:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
null_text = g_strnfill (strlen (typed_text) + 1, '\b');
data/gnome-screensaver-3.6.1/src/gs-window-x11.c:403:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (envp[env_len], "DISPLAY", strlen ("DISPLAY")) == 0)
data/gnome-screensaver-3.6.1/src/test-passwd.c:166:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (pass [strlen (pass) - 1] == '\n') {
data/gnome-screensaver-3.6.1/src/test-passwd.c:167:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pass [strlen (pass) - 1] = 0;
data/gnome-screensaver-3.6.1/src/test-passwd.c:172:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset (pass, '\b', strlen (pass));
ANALYSIS SUMMARY:
Hits = 21
Lines analyzed = 14461 in approximately 0.32 seconds (45580 lines/second)
Physical Source Lines of Code (SLOC) = 10551
Hits@level = [0] 24 [1] 6 [2] 10 [3] 3 [4] 2 [5] 0
Hits@level+ = [0+] 45 [1+] 21 [2+] 15 [3+] 5 [4+] 2 [5+] 0
Hits/KSLOC@level+ = [0+] 4.265 [1+] 1.99033 [2+] 1.42167 [3+] 0.473889 [4+] 0.189555 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.