Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/gnome-software-3.38.0/contrib/gs-plugin-example.c
Examining data/gnome-software-3.38.0/lib/gnome-software-private.h
Examining data/gnome-software-3.38.0/lib/gnome-software.h
Examining data/gnome-software-3.38.0/lib/gs-app-collation.h
Examining data/gnome-software-3.38.0/lib/gs-app-list-private.h
Examining data/gnome-software-3.38.0/lib/gs-app-list.c
Examining data/gnome-software-3.38.0/lib/gs-app-list.h
Examining data/gnome-software-3.38.0/lib/gs-app-private.h
Examining data/gnome-software-3.38.0/lib/gs-app.c
Examining data/gnome-software-3.38.0/lib/gs-app.h
Examining data/gnome-software-3.38.0/lib/gs-autocleanups.h
Examining data/gnome-software-3.38.0/lib/gs-category-private.h
Examining data/gnome-software-3.38.0/lib/gs-category.c
Examining data/gnome-software-3.38.0/lib/gs-category.h
Examining data/gnome-software-3.38.0/lib/gs-cmd.c
Examining data/gnome-software-3.38.0/lib/gs-debug.c
Examining data/gnome-software-3.38.0/lib/gs-debug.h
Examining data/gnome-software-3.38.0/lib/gs-ioprio.c
Examining data/gnome-software-3.38.0/lib/gs-ioprio.h
Examining data/gnome-software-3.38.0/lib/gs-metered.c
Examining data/gnome-software-3.38.0/lib/gs-metered.h
Examining data/gnome-software-3.38.0/lib/gs-os-release.c
Examining data/gnome-software-3.38.0/lib/gs-os-release.h
Examining data/gnome-software-3.38.0/lib/gs-plugin-event.c
Examining data/gnome-software-3.38.0/lib/gs-plugin-event.h
Examining data/gnome-software-3.38.0/lib/gs-plugin-job-private.h
Examining data/gnome-software-3.38.0/lib/gs-plugin-job.c
Examining data/gnome-software-3.38.0/lib/gs-plugin-job.h
Examining data/gnome-software-3.38.0/lib/gs-plugin-loader-sync.c
Examining data/gnome-software-3.38.0/lib/gs-plugin-loader-sync.h
Examining data/gnome-software-3.38.0/lib/gs-plugin-loader.c
Examining data/gnome-software-3.38.0/lib/gs-plugin-loader.h
Examining data/gnome-software-3.38.0/lib/gs-plugin-private.h
Examining data/gnome-software-3.38.0/lib/gs-plugin-types.h
Examining data/gnome-software-3.38.0/lib/gs-plugin-vfuncs.h
Examining data/gnome-software-3.38.0/lib/gs-plugin.c
Examining data/gnome-software-3.38.0/lib/gs-plugin.h
Examining data/gnome-software-3.38.0/lib/gs-self-test.c
Examining data/gnome-software-3.38.0/lib/gs-test.c
Examining data/gnome-software-3.38.0/lib/gs-test.h
Examining data/gnome-software-3.38.0/lib/gs-utils.c
Examining data/gnome-software-3.38.0/lib/gs-utils.h
Examining data/gnome-software-3.38.0/plugins/core/gs-appstream.c
Examining data/gnome-software-3.38.0/plugins/core/gs-appstream.h
Examining data/gnome-software-3.38.0/plugins/core/gs-desktop-common.c
Examining data/gnome-software-3.38.0/plugins/core/gs-desktop-common.h
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-appstream.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-desktop-categories.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-desktop-menu-path.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-generic-updates.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-hardcoded-blocklist.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-hardcoded-popular.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-icons.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-key-colors-metadata.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-key-colors.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-os-release.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-provenance-license.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-provenance.c
Examining data/gnome-software-3.38.0/plugins/core/gs-plugin-rewrite-resource.c
Examining data/gnome-software-3.38.0/plugins/core/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/dpkg/gs-plugin-dpkg.c
Examining data/gnome-software-3.38.0/plugins/dpkg/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/dummy/gs-plugin-dummy.c
Examining data/gnome-software-3.38.0/plugins/dummy/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/eos-updater/gs-plugin-eos-updater.c
Examining data/gnome-software-3.38.0/plugins/external-appstream/gs-external-appstream-utils.c
Examining data/gnome-software-3.38.0/plugins/external-appstream/gs-external-appstream-utils.h
Examining data/gnome-software-3.38.0/plugins/external-appstream/gs-install-appstream.c
Examining data/gnome-software-3.38.0/plugins/external-appstream/gs-plugin-external-appstream.c
Examining data/gnome-software-3.38.0/plugins/fedora-langpacks/gs-plugin-fedora-langpacks.c
Examining data/gnome-software-3.38.0/plugins/fedora-langpacks/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/fedora-pkgdb-collections/gs-plugin-fedora-pkgdb-collections.c
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-flatpak-app.c
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-flatpak-app.h
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-flatpak-transaction.c
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-flatpak-transaction.h
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-flatpak-utils.c
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-flatpak-utils.h
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-flatpak.c
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-flatpak.h
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-plugin-flatpak.c
Examining data/gnome-software-3.38.0/plugins/flatpak/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/fwupd/gs-fwupd-app.c
Examining data/gnome-software-3.38.0/plugins/fwupd/gs-fwupd-app.h
Examining data/gnome-software-3.38.0/plugins/fwupd/gs-plugin-fwupd.c
Examining data/gnome-software-3.38.0/plugins/fwupd/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/malcontent/gs-plugin-malcontent.c
Examining data/gnome-software-3.38.0/plugins/modalias/gs-plugin-modalias.c
Examining data/gnome-software-3.38.0/plugins/modalias/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/odrs/gs-plugin-odrs.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-markdown.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-markdown.h
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-packagekit-helper.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-packagekit-helper.h
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-history.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-local.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-offline.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-proxy.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-refine-repos.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-refine.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-refresh.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-upgrade.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-url-to-app.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-systemd-updates.c
Examining data/gnome-software-3.38.0/plugins/packagekit/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/packagekit/packagekit-common.c
Examining data/gnome-software-3.38.0/plugins/packagekit/packagekit-common.h
Examining data/gnome-software-3.38.0/plugins/repos/gs-plugin-repos.c
Examining data/gnome-software-3.38.0/plugins/repos/gs-self-test.c
Examining data/gnome-software-3.38.0/plugins/rpm-ostree/gs-plugin-rpm-ostree.c
Examining data/gnome-software-3.38.0/plugins/snap/gs-plugin-snap.c
Examining data/gnome-software-3.38.0/plugins/snap/gs-self-test.c
Examining data/gnome-software-3.38.0/src/gs-app-addon-row.c
Examining data/gnome-software-3.38.0/src/gs-app-addon-row.h
Examining data/gnome-software-3.38.0/src/gs-app-row.c
Examining data/gnome-software-3.38.0/src/gs-app-row.h
Examining data/gnome-software-3.38.0/src/gs-app-tile.c
Examining data/gnome-software-3.38.0/src/gs-app-tile.h
Examining data/gnome-software-3.38.0/src/gs-application.c
Examining data/gnome-software-3.38.0/src/gs-application.h
Examining data/gnome-software-3.38.0/src/gs-basic-auth-dialog.c
Examining data/gnome-software-3.38.0/src/gs-basic-auth-dialog.h
Examining data/gnome-software-3.38.0/src/gs-category-page.c
Examining data/gnome-software-3.38.0/src/gs-category-page.h
Examining data/gnome-software-3.38.0/src/gs-category-tile.c
Examining data/gnome-software-3.38.0/src/gs-category-tile.h
Examining data/gnome-software-3.38.0/src/gs-common.c
Examining data/gnome-software-3.38.0/src/gs-common.h
Examining data/gnome-software-3.38.0/src/gs-content-rating.c
Examining data/gnome-software-3.38.0/src/gs-content-rating.h
Examining data/gnome-software-3.38.0/src/gs-css.c
Examining data/gnome-software-3.38.0/src/gs-css.h
Examining data/gnome-software-3.38.0/src/gs-dbus-helper.c
Examining data/gnome-software-3.38.0/src/gs-dbus-helper.h
Examining data/gnome-software-3.38.0/src/gs-details-page.c
Examining data/gnome-software-3.38.0/src/gs-details-page.h
Examining data/gnome-software-3.38.0/src/gs-extras-page.c
Examining data/gnome-software-3.38.0/src/gs-extras-page.h
Examining data/gnome-software-3.38.0/src/gs-feature-tile.c
Examining data/gnome-software-3.38.0/src/gs-feature-tile.h
Examining data/gnome-software-3.38.0/src/gs-first-run-dialog.c
Examining data/gnome-software-3.38.0/src/gs-first-run-dialog.h
Examining data/gnome-software-3.38.0/src/gs-fixed-size-bin.c
Examining data/gnome-software-3.38.0/src/gs-fixed-size-bin.h
Examining data/gnome-software-3.38.0/src/gs-folders.c
Examining data/gnome-software-3.38.0/src/gs-folders.h
Examining data/gnome-software-3.38.0/src/gs-hiding-box.c
Examining data/gnome-software-3.38.0/src/gs-hiding-box.h
Examining data/gnome-software-3.38.0/src/gs-history-dialog.c
Examining data/gnome-software-3.38.0/src/gs-history-dialog.h
Examining data/gnome-software-3.38.0/src/gs-info-bar.c
Examining data/gnome-software-3.38.0/src/gs-info-bar.h
Examining data/gnome-software-3.38.0/src/gs-installed-page.c
Examining data/gnome-software-3.38.0/src/gs-installed-page.h
Examining data/gnome-software-3.38.0/src/gs-language.c
Examining data/gnome-software-3.38.0/src/gs-language.h
Examining data/gnome-software-3.38.0/src/gs-loading-page.c
Examining data/gnome-software-3.38.0/src/gs-loading-page.h
Examining data/gnome-software-3.38.0/src/gs-main.c
Examining data/gnome-software-3.38.0/src/gs-metered-data-dialog.c
Examining data/gnome-software-3.38.0/src/gs-metered-data-dialog.h
Examining data/gnome-software-3.38.0/src/gs-moderate-page.c
Examining data/gnome-software-3.38.0/src/gs-moderate-page.h
Examining data/gnome-software-3.38.0/src/gs-origin-popover-row.c
Examining data/gnome-software-3.38.0/src/gs-origin-popover-row.h
Examining data/gnome-software-3.38.0/src/gs-overview-page.c
Examining data/gnome-software-3.38.0/src/gs-overview-page.h
Examining data/gnome-software-3.38.0/src/gs-page.c
Examining data/gnome-software-3.38.0/src/gs-page.h
Examining data/gnome-software-3.38.0/src/gs-popular-tile.c
Examining data/gnome-software-3.38.0/src/gs-popular-tile.h
Examining data/gnome-software-3.38.0/src/gs-prefs-dialog.c
Examining data/gnome-software-3.38.0/src/gs-prefs-dialog.h
Examining data/gnome-software-3.38.0/src/gs-progress-button.c
Examining data/gnome-software-3.38.0/src/gs-progress-button.h
Examining data/gnome-software-3.38.0/src/gs-removal-dialog.c
Examining data/gnome-software-3.38.0/src/gs-removal-dialog.h
Examining data/gnome-software-3.38.0/src/gs-repo-row.c
Examining data/gnome-software-3.38.0/src/gs-repo-row.h
Examining data/gnome-software-3.38.0/src/gs-repos-dialog.c
Examining data/gnome-software-3.38.0/src/gs-repos-dialog.h
Examining data/gnome-software-3.38.0/src/gs-restarter.c
Examining data/gnome-software-3.38.0/src/gs-review-bar.c
Examining data/gnome-software-3.38.0/src/gs-review-bar.h
Examining data/gnome-software-3.38.0/src/gs-review-dialog.c
Examining data/gnome-software-3.38.0/src/gs-review-dialog.h
Examining data/gnome-software-3.38.0/src/gs-review-histogram.c
Examining data/gnome-software-3.38.0/src/gs-review-histogram.h
Examining data/gnome-software-3.38.0/src/gs-review-row.c
Examining data/gnome-software-3.38.0/src/gs-review-row.h
Examining data/gnome-software-3.38.0/src/gs-screenshot-image.c
Examining data/gnome-software-3.38.0/src/gs-screenshot-image.h
Examining data/gnome-software-3.38.0/src/gs-search-page.c
Examining data/gnome-software-3.38.0/src/gs-search-page.h
Examining data/gnome-software-3.38.0/src/gs-self-test.c
Examining data/gnome-software-3.38.0/src/gs-shell-search-provider.c
Examining data/gnome-software-3.38.0/src/gs-shell-search-provider.h
Examining data/gnome-software-3.38.0/src/gs-shell.c
Examining data/gnome-software-3.38.0/src/gs-shell.h
Examining data/gnome-software-3.38.0/src/gs-star-widget.c
Examining data/gnome-software-3.38.0/src/gs-star-widget.h
Examining data/gnome-software-3.38.0/src/gs-summary-tile.c
Examining data/gnome-software-3.38.0/src/gs-summary-tile.h
Examining data/gnome-software-3.38.0/src/gs-third-party-repo-row.c
Examining data/gnome-software-3.38.0/src/gs-third-party-repo-row.h
Examining data/gnome-software-3.38.0/src/gs-update-dialog.c
Examining data/gnome-software-3.38.0/src/gs-update-dialog.h
Examining data/gnome-software-3.38.0/src/gs-update-list.c
Examining data/gnome-software-3.38.0/src/gs-update-list.h
Examining data/gnome-software-3.38.0/src/gs-update-monitor.c
Examining data/gnome-software-3.38.0/src/gs-update-monitor.h
Examining data/gnome-software-3.38.0/src/gs-updates-page.c
Examining data/gnome-software-3.38.0/src/gs-updates-page.h
Examining data/gnome-software-3.38.0/src/gs-updates-section.c
Examining data/gnome-software-3.38.0/src/gs-updates-section.h
Examining data/gnome-software-3.38.0/src/gs-upgrade-banner.c
Examining data/gnome-software-3.38.0/src/gs-upgrade-banner.h
Examining data/gnome-software-3.38.0/src/gs-vendor.c
Examining data/gnome-software-3.38.0/src/gs-vendor.h
FINAL RESULTS:
data/gnome-software-3.38.0/src/gs-content-rating.c:38:56: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
gs_content_rating_system_to_str (GsContentRatingSystem system)
data/gnome-software-3.38.0/src/gs-content-rating.c:40:13: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if ((gint) system < GS_CONTENT_RATING_SYSTEM_UNKNOWN ||
data/gnome-software-3.38.0/src/gs-content-rating.c:41:13: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
(gint) system >= GS_CONTENT_RATING_SYSTEM_LAST)
data/gnome-software-3.38.0/src/gs-content-rating.c:44:29: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
return rating_system_names[system];
data/gnome-software-3.38.0/src/gs-content-rating.c:417:59: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
gs_utils_content_rating_age_to_str (GsContentRatingSystem system, guint age)
data/gnome-software-3.38.0/src/gs-content-rating.h:62:66: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
gchar *gs_utils_content_rating_age_to_str (GsContentRatingSystem system,
data/gnome-software-3.38.0/src/gs-content-rating.h:67:69: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
const gchar *gs_content_rating_system_to_str (GsContentRatingSystem system);
data/gnome-software-3.38.0/src/gs-details-page.c:1726:24: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
GsContentRatingSystem system;
data/gnome-software-3.38.0/src/gs-details-page.c:1735:37: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
gs_content_rating_system_to_str (system),
data/gnome-software-3.38.0/src/gs-details-page.c:1742:49: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
display = gs_utils_content_rating_age_to_str (system, age);
data/gnome-software-3.38.0/lib/gs-app-list.c:687:25: [3] (random) g_rand_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
sort_key[0] = (gchar) g_rand_int_range (rand, (gint32) 'A', (gint32) 'Z');
data/gnome-software-3.38.0/lib/gs-app-list.c:688:25: [3] (random) g_rand_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
sort_key[1] = (gchar) g_rand_int_range (rand, (gint32) 'A', (gint32) 'Z');
data/gnome-software-3.38.0/lib/gs-app-list.c:689:25: [3] (random) g_rand_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
sort_key[2] = (gchar) g_rand_int_range (rand, (gint32) 'A', (gint32) 'Z');
data/gnome-software-3.38.0/lib/gs-test.c:21:8: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
tmp = realpath (path, full_tmp);
data/gnome-software-3.38.0/plugins/snap/gs-plugin-snap.c:58:27: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
path = g_build_filename (g_get_home_dir (), ".snap", "auth.json", NULL);
data/gnome-software-3.38.0/src/gs-overview-page.c:603:24: [3] (random) g_rand_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint rnd1 = (guint) g_rand_int_range (rand, 0, (gint32) cats->len);
data/gnome-software-3.38.0/src/gs-overview-page.c:604:24: [3] (random) g_rand_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
guint rnd2 = (guint) g_rand_int_range (rand, 0, (gint32) cats->len);
data/gnome-software-3.38.0/lib/gs-cmd.c:175:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[64];
data/gnome-software-3.38.0/lib/gs-test.c:17:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char full_tmp[PATH_MAX];
data/gnome-software-3.38.0/plugins/core/gs-plugin-icons.c:204:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (found, ".png", 4);
data/gnome-software-3.38.0/plugins/flatpak/gs-plugin-flatpak.c:527:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *args[3] = { NULL, url, NULL };
data/gnome-software-3.38.0/plugins/packagekit/packagekit-common.c:424:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (no_data, package_id, last_semicolon + 1);
data/gnome-software-3.38.0/lib/gs-app.c:2615:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
origin_hostname += strlen (prefixes[i]);
data/gnome-software-3.38.0/lib/gs-cmd.c:50:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = strlen (text); i < length; i++)
data/gnome-software-3.38.0/lib/gs-cmd.c:180:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen (buffer) == sizeof (buffer) - 1)
data/gnome-software-3.38.0/lib/gs-plugin-loader.c:1772:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen (names[i]) == 0)
data/gnome-software-3.38.0/lib/gs-utils.c:1072:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (host != NULL && (strlen (host) > 0))
data/gnome-software-3.38.0/lib/gs-utils.c:1117:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen (key) + 2;
data/gnome-software-3.38.0/plugins/external-appstream/gs-install-appstream.c:170:2: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask (022);
data/gnome-software-3.38.0/plugins/odrs/gs-plugin-odrs.c:559:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SOUP_MEMORY_COPY, data, strlen (data));
data/gnome-software-3.38.0/plugins/odrs/gs-plugin-odrs.c:770:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SOUP_MEMORY_COPY, data, strlen (data));
data/gnome-software-3.38.0/plugins/packagekit/gs-markdown.c:97:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = (guint) strlen (line);
data/gnome-software-3.38.0/plugins/packagekit/gs-markdown.c:174:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = (guint) strlen (line);
data/gnome-software-3.38.0/plugins/packagekit/gs-markdown.c:237:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = (guint) strlen (formatter);
data/gnome-software-3.38.0/plugins/packagekit/gs-markdown.c:392:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = (guint) strlen (text);
data/gnome-software-3.38.0/plugins/packagekit/gs-plugin-packagekit-local.c:94:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen (basename) < basename_best->len)
data/gnome-software-3.38.0/plugins/snap/gs-plugin-snap.c:152:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
name_and_id = g_strdup (gs_app_get_id (app) + strlen ("io.snapcraft."));
data/gnome-software-3.38.0/src/gs-basic-auth-dialog.c:67:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
valid_user = user != NULL && strlen (user) != 0;
data/gnome-software-3.38.0/src/gs-basic-auth-dialog.c:71:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
valid_password = password != NULL && strlen (password) != 0;
data/gnome-software-3.38.0/src/gs-main.c:43:2: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask (022);
data/gnome-software-3.38.0/src/gs-shell.c:843:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen (text) > 2) {
ANALYSIS SUMMARY:
Hits = 41
Lines analyzed = 78840 in approximately 1.76 seconds (44793 lines/second)
Physical Source Lines of Code (SLOC) = 58417
Hits@level = [0] 1 [1] 19 [2] 5 [3] 7 [4] 10 [5] 0
Hits@level+ = [0+] 42 [1+] 41 [2+] 22 [3+] 17 [4+] 10 [5+] 0
Hits/KSLOC@level+ = [0+] 0.718969 [1+] 0.70185 [2+] 0.376603 [3+] 0.291011 [4+] 0.171183 [5+] 0
Symlinks skipped = 4 (--allowlink overrides but see doc for security issue)
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.