Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/goo-0.155+ds/c/dlgrt.h
Examining data/goo-0.155+ds/c/dllentry.c
Examining data/goo-0.155+ds/c/mini-prt.h
Examining data/goo-0.155+ds/c/unexelf.c
Examining data/goo-0.155+ds/c/unexw32.c
Examining data/goo-0.155+ds/c/g2c/g2c-init.c
Examining data/goo-0.155+ds/c/g2c/goo.c
Examining data/goo-0.155+ds/c/g2c/cols/pipe.c
Examining data/goo-0.155+ds/c/g2c/eval/ast-eval.c
Examining data/goo-0.155+ds/c/g2c/eval/ast-linearize.c
Examining data/goo-0.155+ds/c/g2c/eval/ast.c
Examining data/goo-0.155+ds/c/g2c/eval/dependency.c
Examining data/goo-0.155+ds/c/g2c/eval/g2c.c
Examining data/goo-0.155+ds/c/g2c/eval/main.c
Examining data/goo-0.155+ds/c/g2c/eval/module.c
Examining data/goo-0.155+ds/c/g2c/eval/optimize.c
Examining data/goo-0.155+ds/c/g2c/eval/syntax.c
Examining data/goo-0.155+ds/c/g2c/eval/top.c
Examining data/goo-0.155+ds/c/g2c/eval/typist.c
Examining data/goo-0.155+ds/c/g2c/goo/%math.c
Examining data/goo-0.155+ds/c/g2c/goo/any.c
Examining data/goo-0.155+ds/c/g2c/goo/app.c
Examining data/goo-0.155+ds/c/g2c/goo/chr.c
Examining data/goo-0.155+ds/c/g2c/goo/class.c
Examining data/goo-0.155+ds/c/g2c/goo/cols.c
Examining data/goo-0.155+ds/c/g2c/goo/conditions.c
Examining data/goo-0.155+ds/c/g2c/goo/eval.c
Examining data/goo-0.155+ds/c/g2c/goo/fun.c
Examining data/goo-0.155+ds/c/g2c/goo/functional.c
Examining data/goo-0.155+ds/c/g2c/goo/late-macros.c
Examining data/goo-0.155+ds/c/g2c/goo/loc.c
Examining data/goo-0.155+ds/c/g2c/goo/log.c
Examining data/goo-0.155+ds/c/g2c/goo/macros.c
Examining data/goo-0.155+ds/c/g2c/goo/mag.c
Examining data/goo-0.155+ds/c/g2c/goo/math.c
Examining data/goo-0.155+ds/c/g2c/goo/packer.c
Examining data/goo-0.155+ds/c/g2c/goo/random.c
Examining data/goo-0.155+ds/c/g2c/goo/runtime.c
Examining data/goo-0.155+ds/c/g2c/goo/sym.c
Examining data/goo-0.155+ds/c/g2c/goo/types.c
Examining data/goo-0.155+ds/c/g2c/goo/user.c
Examining data/goo-0.155+ds/c/g2c/goo/x.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/col.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/colx.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/cycle.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/flat.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/lst.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/map.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/opts.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/range.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/rep.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/seq.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/seqx.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/step.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/str.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/tab.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/tup.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/vec.c
Examining data/goo-0.155+ds/c/g2c/goo/cols/zip.c
Examining data/goo-0.155+ds/c/g2c/goo/io/%port.c
Examining data/goo-0.155+ds/c/g2c/goo/io/port.c
Examining data/goo-0.155+ds/c/g2c/goo/io/read.c
Examining data/goo-0.155+ds/c/g2c/goo/io/write.c
Examining data/goo-0.155+ds/c/g2c/goo/%system.c
Examining data/goo-0.155+ds/c/g2c/goo/bignum.c
Examining data/goo-0.155+ds/c/g2c/goo/boot.c
Examining data/goo-0.155+ds/c/g2c/goo/system.c
Examining data/goo-0.155+ds/c/g2c/time/event.c
Examining data/goo-0.155+ds/c/g2c/time/lock.c
Examining data/goo-0.155+ds/c/g2c/time/threads.c
Examining data/goo-0.155+ds/c/g2c/time/%event.c
Examining data/goo-0.155+ds/c/g2c/time/%lock.c
Examining data/goo-0.155+ds/c/g2c/time/%threads.c
Examining data/goo-0.155+ds/c/grt.c
Examining data/goo-0.155+ds/c/grt.h
Examining data/goo-0.155+ds/acconfig.h
Examining data/goo-0.155+ds/src/goo/%math.c
Examining data/goo-0.155+ds/src/goo/bignum/%gmp.c
Examining data/goo-0.155+ds/src/goo/io/%net.c
Examining data/goo-0.155+ds/src/goo/io/%port.c
Examining data/goo-0.155+ds/src/goo/%system.c
Examining data/goo-0.155+ds/src/samurui/gtk.swig.c
Examining data/goo-0.155+ds/src/samurui/treegoo.c
Examining data/goo-0.155+ds/src/samurui/treegoo.h
Examining data/goo-0.155+ds/src/time/event.c
Examining data/goo-0.155+ds/src/time/timer.c
Examining data/goo-0.155+ds/src/time/%event.c
Examining data/goo-0.155+ds/src/time/%lock.c
Examining data/goo-0.155+ds/src/time/%threads.c
FINAL RESULTS:
data/goo-0.155+ds/c/unexelf.c:1223:7: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
if (chmod (new_name, stat_buf.st_mode) == -1)
data/goo-0.155+ds/c/g2c/goo/%system.c:103:5: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp("rm", "rm", "-rf", goo_temp_dir_name, NULL);
data/goo-0.155+ds/c/g2c/goo/%system.c:113:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(s, "%s/.", tmproot);
data/goo-0.155+ds/c/g2c/goo/%system.c:114:11: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(s, R_OK | W_OK | X_OK) != 0) {
data/goo-0.155+ds/c/g2c/goo/%system.c:122:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(goo_temp_dir_name, "%s%s", tmproot, tmptail);
data/goo-0.155+ds/c/g2c/goo/%system.c:154:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buffer, "%s=%s", (PSTR)name, (PSTR)value);
data/goo-0.155+ds/c/g2c/goo/%system.c:196:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(command, (char*)sofile);
data/goo-0.155+ds/c/g2c/goo/%system.c:198:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(command, (char*)cfile);
data/goo-0.155+ds/c/g2c/goo/%system.c:201:3: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(command);
data/goo-0.155+ds/c/g2c/goo/%system.c:212:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(rbuf, "-I%s/lib", YPsu(YgooSsystemYTgoo_rootT));
data/goo-0.155+ds/c/g2c/goo/%system.c:215:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(lbuf, libs);
data/goo-0.155+ds/c/g2c/goo/%system.c:216:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ibuf, incs);
data/goo-0.155+ds/c/g2c/goo/%system.c:228:5: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp("cc", v);
data/goo-0.155+ds/c/g2c/goo/io/%port.c:88:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(str, strbuf);
data/goo-0.155+ds/c/grt.c:214:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(dat, str);
data/goo-0.155+ds/c/unexelf.c:408:24: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define fatal(args...) fprintf (stderr, ##args ), exit (1)
data/goo-0.155+ds/c/unexw32.c:563:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (msg, "Copying raw data for %s...", section->Name);
data/goo-0.155+ds/c/unexw32.c:726:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (in_filename, old_name);
data/goo-0.155+ds/c/unexw32.c:731:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (out_filename, new_name);
data/goo-0.155+ds/src/goo/%system.c:103:5: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp("rm", "rm", "-rf", goo_temp_dir_name, NULL);
data/goo-0.155+ds/src/goo/%system.c:113:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(s, "%s/.", tmproot);
data/goo-0.155+ds/src/goo/%system.c:114:11: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(s, R_OK | W_OK | X_OK) != 0) {
data/goo-0.155+ds/src/goo/%system.c:122:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(goo_temp_dir_name, "%s%s", tmproot, tmptail);
data/goo-0.155+ds/src/goo/%system.c:154:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buffer, "%s=%s", (PSTR)name, (PSTR)value);
data/goo-0.155+ds/src/goo/%system.c:196:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(command, (char*)sofile);
data/goo-0.155+ds/src/goo/%system.c:198:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(command, (char*)cfile);
data/goo-0.155+ds/src/goo/%system.c:201:3: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(command);
data/goo-0.155+ds/src/goo/%system.c:212:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(rbuf, "-I%s/lib", YPsu(YgooSsystemYTgoo_rootT));
data/goo-0.155+ds/src/goo/%system.c:215:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(lbuf, libs);
data/goo-0.155+ds/src/goo/%system.c:216:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ibuf, incs);
data/goo-0.155+ds/src/goo/%system.c:228:5: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp("cc", v);
data/goo-0.155+ds/src/goo/io/%port.c:88:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(str, strbuf);
data/goo-0.155+ds/src/samurui/gtk.swig.c:4909:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(arg1->name,arg2);
data/goo-0.155+ds/src/samurui/gtk.swig.c:14289:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(arg1->string,arg2);
data/goo-0.155+ds/src/samurui/gtk.swig.c:17898:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(arg1->name,arg2);
data/goo-0.155+ds/c/g2c/goo/%system.c:110:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* tmproot = getenv("TMPDIR");
data/goo-0.155+ds/c/g2c/goo/%system.c:144:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
PSTR value = (PSTR)getenv((char *)name);
data/goo-0.155+ds/c/g2c/goo/%system.c:286:12: [3] (misc) LoadLibrary:
Ensure that the full path to the library is specified, or current directory
may be used (CWE-829, CWE-20). Use registry entry or GetWindowsDirectory to
find library path, if you aren't already.
module = LoadLibrary(name);
data/goo-0.155+ds/c/g2c/time/%event.c:92:3: [3] (misc) EnterCriticalSection:
On some versions of Windows, exceptions can be thrown in low-memory
situations. Use InitializeCriticalSectionAndSpinCount instead.
EnterCriticalSection((CRITICAL_SECTION*)lock);
data/goo-0.155+ds/c/g2c/time/%event.c:109:3: [3] (misc) EnterCriticalSection:
On some versions of Windows, exceptions can be thrown in low-memory
situations. Use InitializeCriticalSectionAndSpinCount instead.
EnterCriticalSection((CRITICAL_SECTION*)lock);
data/goo-0.155+ds/c/g2c/time/%lock.c:37:3: [3] (misc) InitializeCriticalSection:
Exceptions can be thrown in low-memory situations. Use
InitializeCriticalSectionAndSpinCount instead.
InitializeCriticalSection(cs);
data/goo-0.155+ds/c/g2c/time/%lock.c:42:3: [3] (misc) EnterCriticalSection:
On some versions of Windows, exceptions can be thrown in low-memory
situations. Use InitializeCriticalSectionAndSpinCount instead.
EnterCriticalSection((CRITICAL_SECTION*)handle);
data/goo-0.155+ds/c/unexw32.c:775:25: [3] (misc) LoadLibrary:
Ensure that the full path to the library is specified, or current directory
may be used (CWE-829, CWE-20). Use registry entry or GetWindowsDirectory to
find library path, if you aren't already.
HANDLE hImagehelp = LoadLibrary ("imagehlp.dll");
data/goo-0.155+ds/src/goo/%system.c:110:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char* tmproot = getenv("TMPDIR");
data/goo-0.155+ds/src/goo/%system.c:144:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
PSTR value = (PSTR)getenv((char *)name);
data/goo-0.155+ds/src/goo/%system.c:286:12: [3] (misc) LoadLibrary:
Ensure that the full path to the library is specified, or current directory
may be used (CWE-829, CWE-20). Use registry entry or GetWindowsDirectory to
find library path, if you aren't already.
module = LoadLibrary(name);
data/goo-0.155+ds/src/samurui/treegoo.c:294:25: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
tree_goo->stamp = g_random_int ();
data/goo-0.155+ds/src/time/%event.c:92:3: [3] (misc) EnterCriticalSection:
On some versions of Windows, exceptions can be thrown in low-memory
situations. Use InitializeCriticalSectionAndSpinCount instead.
EnterCriticalSection((CRITICAL_SECTION*)lock);
data/goo-0.155+ds/src/time/%event.c:109:3: [3] (misc) EnterCriticalSection:
On some versions of Windows, exceptions can be thrown in low-memory
situations. Use InitializeCriticalSectionAndSpinCount instead.
EnterCriticalSection((CRITICAL_SECTION*)lock);
data/goo-0.155+ds/src/time/%lock.c:37:3: [3] (misc) InitializeCriticalSection:
Exceptions can be thrown in low-memory situations. Use
InitializeCriticalSectionAndSpinCount instead.
InitializeCriticalSection(cs);
data/goo-0.155+ds/src/time/%lock.c:42:3: [3] (misc) EnterCriticalSection:
On some versions of Windows, exceptions can be thrown in low-memory
situations. Use InitializeCriticalSectionAndSpinCount instead.
EnterCriticalSection((CRITICAL_SECTION*)handle);
data/goo-0.155+ds/c/g2c/goo/%system.c:112:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[strlen(tmproot) + 3];
data/goo-0.155+ds/c/g2c/goo/%system.c:153:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buffer[1024];
data/goo-0.155+ds/c/g2c/goo/%system.c:193:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(command, "cl /O2 /D MSVC_THREAD /D WITH_THREADS /D BUILD_DLL");
data/goo-0.155+ds/c/g2c/goo/%system.c:194:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(command, " /I../c /I.");
data/goo-0.155+ds/c/g2c/goo/%system.c:195:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(command, " /Fe");
data/goo-0.155+ds/c/g2c/goo/%system.c:199:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(command, " dllentry.c /LD /link ./gc.lib ./goovc.lib kernel32.lib");
data/goo-0.155+ds/c/g2c/goo/%system.c:204:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rbuf[4096];
data/goo-0.155+ds/c/g2c/goo/%system.c:205:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lbuf[4096];
data/goo-0.155+ds/c/g2c/goo/%system.c:206:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ibuf[4096];
data/goo-0.155+ds/c/g2c/goo/%system.c:210:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *v[100], *lptr;
data/goo-0.155+ds/c/g2c/goo/io/%port.c:8:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* fd = fopen((PSTR)name, "r");
data/goo-0.155+ds/c/g2c/goo/io/%port.c:15:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* fd = fopen((PSTR)name, "w");
data/goo-0.155+ds/c/g2c/goo/io/%port.c:82:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strbuf[MAXSTRSIZ];
data/goo-0.155+ds/c/grt.c:225:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dat, str, len);
data/goo-0.155+ds/c/unexelf.c:664:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
old_file = open (old_name, O_RDONLY);
data/goo-0.155+ds/c/unexelf.c:757:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
new_file = open (new_name, O_RDWR | O_CREAT, 0666);
data/goo-0.155+ds/c/unexelf.c:786:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (new_file_h, old_file_h, old_file_h->e_ehsize);
data/goo-0.155+ds/c/unexelf.c:787:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (new_program_h, old_program_h,
data/goo-0.155+ds/c/unexelf.c:887:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&NEW_SECTION_H (nn), &OLD_SECTION_H (old_data_index),
data/goo-0.155+ds/c/unexelf.c:899:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (NEW_SECTION_H (nn).sh_offset + new_base,
data/goo-0.155+ds/c/unexelf.c:905:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&NEW_SECTION_H (nn), &OLD_SECTION_H (n),
data/goo-0.155+ds/c/unexelf.c:999:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (NEW_SECTION_H (nn).sh_offset + new_base, src,
data/goo-0.155+ds/c/unexelf.c:1091:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (n_phdrr->cbLineOffset + new_base,
data/goo-0.155+ds/c/unexelf.c:1143:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&symp->st_value, &new_bss_addr, sizeof (new_bss_addr));
data/goo-0.155+ds/c/unexelf.c:1186:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (new_base + addr, old_base + addr, sizeof(ElfW(Addr)));
data/goo-0.155+ds/c/unexw32.c:505:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (dst, s, count); \
data/goo-0.155+ds/c/unexw32.c:517:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (dst, s, count); \
data/goo-0.155+ds/c/unexw32.c:562:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[100];
data/goo-0.155+ds/c/unexw32.c:720:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char out_filename[MAX_PATH], in_filename[MAX_PATH];
data/goo-0.155+ds/c/unexw32.c:729:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (in_filename, ".exe");
data/goo-0.155+ds/c/unexw32.c:734:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (out_filename, ".exe");
data/goo-0.155+ds/src/goo/%system.c:112:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[strlen(tmproot) + 3];
data/goo-0.155+ds/src/goo/%system.c:153:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buffer[1024];
data/goo-0.155+ds/src/goo/%system.c:193:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(command, "cl /O2 /D MSVC_THREAD /D WITH_THREADS /D BUILD_DLL");
data/goo-0.155+ds/src/goo/%system.c:194:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(command, " /I../c /I.");
data/goo-0.155+ds/src/goo/%system.c:195:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(command, " /Fe");
data/goo-0.155+ds/src/goo/%system.c:199:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(command, " dllentry.c /LD /link ./gc.lib ./goovc.lib kernel32.lib");
data/goo-0.155+ds/src/goo/%system.c:204:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rbuf[4096];
data/goo-0.155+ds/src/goo/%system.c:205:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lbuf[4096];
data/goo-0.155+ds/src/goo/%system.c:206:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ibuf[4096];
data/goo-0.155+ds/src/goo/%system.c:210:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *v[100], *lptr;
data/goo-0.155+ds/src/goo/io/%net.c:94:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *) &target.sin_addr.s_addr, h->h_addr_list[0], h->h_length);
data/goo-0.155+ds/src/goo/io/%net.c:173:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/goo-0.155+ds/src/goo/io/%net.c:198:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1];
data/goo-0.155+ds/src/goo/io/%net.c:223:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1];
data/goo-0.155+ds/src/goo/io/%net.c:248:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1];
data/goo-0.155+ds/src/goo/io/%port.c:8:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* fd = fopen((PSTR)name, "r");
data/goo-0.155+ds/src/goo/io/%port.c:15:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* fd = fopen((PSTR)name, "w");
data/goo-0.155+ds/src/goo/io/%port.c:82:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strbuf[MAXSTRSIZ];
data/goo-0.155+ds/src/samurui/gtk.swig.c:662:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[20];
data/goo-0.155+ds/c/g2c/goo/%system.c:112:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char s[strlen(tmproot) + 3];
data/goo-0.155+ds/c/g2c/goo/%system.c:121:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
goo_temp_dir_name = malloc(strlen(tmproot) + strlen(tmptail) + 1);
data/goo-0.155+ds/c/g2c/goo/%system.c:121:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
goo_temp_dir_name = malloc(strlen(tmproot) + strlen(tmptail) + 1);
data/goo-0.155+ds/c/g2c/goo/%system.c:197:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(command, " ");
data/goo-0.155+ds/c/g2c/goo/io/%port.c:61:19: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return (P)(PINT)fgetc((FILE*)YPlu(s));
data/goo-0.155+ds/c/g2c/goo/io/%port.c:65:12: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
PINT c = fgetc((FILE*)YPlu(s)); ungetc(c, (FILE*)YPlu(s)); return (P)c;
data/goo-0.155+ds/c/g2c/goo/io/%port.c:87:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
str = (char*)allocate_atomic(strlen(strbuf) + 1);
data/goo-0.155+ds/c/g2c/time/%threads.c:62:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
res = usleep((unsigned long)(x.f * 1000000.0));
data/goo-0.155+ds/c/grt.c:210:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
PINT len = strlen(str);
data/goo-0.155+ds/c/grt.c:236:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buflen = strlen(cstr) + 1;
data/goo-0.155+ds/c/grt.c:237:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
raw_pstr = allocate_atomic(strlen(cstr));
data/goo-0.155+ds/c/grt.c:238:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(raw_pstr, cstr, buflen);
data/goo-0.155+ds/c/grt.c:782:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = 0; i < strlen(filename); i++)
data/goo-0.155+ds/c/unexelf.c:1220:7: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
n = umask (777);
data/goo-0.155+ds/c/unexelf.c:1221:3: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask (n);
data/goo-0.155+ds/c/unexw32.c:727:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = in_filename + strlen (in_filename) - 4;
data/goo-0.155+ds/c/unexw32.c:732:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr = out_filename + strlen (out_filename) - 4;
data/goo-0.155+ds/src/goo/%system.c:112:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char s[strlen(tmproot) + 3];
data/goo-0.155+ds/src/goo/%system.c:121:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
goo_temp_dir_name = malloc(strlen(tmproot) + strlen(tmptail) + 1);
data/goo-0.155+ds/src/goo/%system.c:121:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
goo_temp_dir_name = malloc(strlen(tmproot) + strlen(tmptail) + 1);
data/goo-0.155+ds/src/goo/%system.c:197:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(command, " ");
data/goo-0.155+ds/src/goo/io/%port.c:61:19: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return (P)(PINT)fgetc((FILE*)YPlu(s));
data/goo-0.155+ds/src/goo/io/%port.c:65:12: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
PINT c = fgetc((FILE*)YPlu(s)); ungetc(c, (FILE*)YPlu(s)); return (P)c;
data/goo-0.155+ds/src/goo/io/%port.c:87:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
str = (char*)allocate_atomic(strlen(strbuf) + 1);
data/goo-0.155+ds/src/samurui/gtk.swig.c:4908:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
arg1->name = (char *) malloc(strlen(arg2)+1);
data/goo-0.155+ds/src/samurui/gtk.swig.c:14288:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
arg1->string = (char *) malloc(strlen(arg2)+1);
data/goo-0.155+ds/src/samurui/gtk.swig.c:17464:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
retval = YPPsfab((P)strlen(result), (P)0);
data/goo-0.155+ds/src/samurui/gtk.swig.c:17897:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
arg1->name = (char *) malloc(strlen(arg2)+1);
data/goo-0.155+ds/src/time/%threads.c:62:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
res = usleep((unsigned long)(x.f * 1000000.0));
ANALYSIS SUMMARY:
Hits = 130
Lines analyzed = 273172 in approximately 7.79 seconds (35063 lines/second)
Physical Source Lines of Code (SLOC) = 254242
Hits@level = [0] 101 [1] 29 [2] 50 [3] 16 [4] 34 [5] 1
Hits@level+ = [0+] 231 [1+] 130 [2+] 101 [3+] 51 [4+] 35 [5+] 1
Hits/KSLOC@level+ = [0+] 0.908583 [1+] 0.511324 [2+] 0.397259 [3+] 0.200596 [4+] 0.137664 [5+] 0.00393326
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.