Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/growl-for-linux-0.8.5/compatibility.h
Examining data/growl-for-linux-0.8.5/subscribe/tweets/tweets.c
Examining data/growl-for-linux-0.8.5/subscribe/rhythmbox/rhythmbox.c
Examining data/growl-for-linux-0.8.5/plugins/from_url.c
Examining data/growl-for-linux-0.8.5/plugins/from_url.h
Examining data/growl-for-linux-0.8.5/plugins/memfile.h
Examining data/growl-for-linux-0.8.5/plugins/memfile.c
Examining data/growl-for-linux-0.8.5/display/balloon/balloon.c
Examining data/growl-for-linux-0.8.5/display/fog/fog.c
Examining data/growl-for-linux-0.8.5/display/libnotify/notify.c
Examining data/growl-for-linux-0.8.5/display/nico2/nico2.c
Examining data/growl-for-linux-0.8.5/gol.h
Examining data/growl-for-linux-0.8.5/gol.c
FINAL RESULTS:
data/growl-for-linux-0.8.5/display/balloon/balloon.c:78:16: [4] (shell) ShellExecute:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
return (int) ShellExecute(NULL, "open", url, NULL, NULL, SW_SHOW) > 32;
data/growl-for-linux-0.8.5/display/fog/fog.c:75:16: [4] (shell) ShellExecute:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
return (int) ShellExecute(NULL, "open", url, NULL, NULL, SW_SHOW) > 32;
data/growl-for-linux-0.8.5/display/nico2/nico2.c:74:16: [4] (shell) ShellExecute:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
return (int) ShellExecute(NULL, "open", url, NULL, NULL, SW_SHOW) > 32;
data/growl-for-linux-0.8.5/gol.c:2310:16: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((ch = getopt(argc, argv, "h")) != -1) {
data/growl-for-linux-0.8.5/plugins/from_url.c:77:5: [3] (tmpfile) GetTempFileName:
Temporary file race condition in certain cases (e.g., if run as SYSTEM in
many versions of Windows) (CWE-377).
GetTempFileName(temp_path, "growl-for-linux-", 0, temp_filename);
data/growl-for-linux-0.8.5/compatibility.h:30:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, src, n);
data/growl-for-linux-0.8.5/gol.c:1173:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, "\0", 2);
data/growl-for-linux-0.8.5/gol.c:1292:20: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
length = atol(value);
data/growl-for-linux-0.8.5/gol.c:1343:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data, ptr, datalen);
data/growl-for-linux-0.8.5/gol.c:1388:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char digest[32] = {0};
data/growl-for-linux-0.8.5/gol.c:1459:35: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
notifications_count = atol(value);
data/growl-for-linux-0.8.5/gol.c:2138:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZ] = {0};
data/growl-for-linux-0.8.5/gol.c:2159:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char digest[GOL_PP_CAT(_hash_algorithm, _DIGEST_LENGTH)] = {0}; \
data/growl-for-linux-0.8.5/plugins/from_url.c:74:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char temp_path[MAX_PATH];
data/growl-for-linux-0.8.5/plugins/from_url.c:75:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char temp_filename[MAX_PATH];
data/growl-for-linux-0.8.5/plugins/from_url.c:78:22: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* const fp = fopen(temp_filename, "wb");
data/growl-for-linux-0.8.5/plugins/memfile.c:43:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(memfdata(mf) + orig_size, ptr, block);
data/growl-for-linux-0.8.5/subscribe/rhythmbox/rhythmbox.c:69:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[3] = {0};
data/growl-for-linux-0.8.5/compatibility.h:26:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t srclen = strlen(src);
data/growl-for-linux-0.8.5/gol.c:263:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (sqlite3_prepare(db, sql, strlen(sql), &stmt, NULL) != SQLITE_OK)
data/growl-for-linux-0.8.5/gol.c:983:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sqlite3_prepare(db, sql, strlen(sql), &stmt, NULL);
data/growl-for-linux-0.8.5/gol.c:1101:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sqlite3_prepare(db, sql, strlen(sql), &stmt, NULL);
data/growl-for-linux-0.8.5/gol.c:1183:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp = str + strlen(str);
data/growl-for-linux-0.8.5/gol.c:1218:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(ci.sock, cmd_result, strlen(cmd_result), 0);
data/growl-for-linux-0.8.5/gol.c:1378:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t saltlen = strlen(salt) / 2;
data/growl-for-linux-0.8.5/gol.c:1381:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t keylen = strlen(key) / 2;
data/growl-for-linux-0.8.5/gol.c:1384:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t ivlen = strlen(iv) / 2;
data/growl-for-linux-0.8.5/gol.c:1392:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5_Update(&ctx, password, strlen(password));
data/growl-for-linux-0.8.5/gol.c:1399:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SHA1_Update(&ctx, password, strlen(password));
data/growl-for-linux-0.8.5/gol.c:1406:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SHA256_Update(&ctx, password, strlen(password));
data/growl-for-linux-0.8.5/gol.c:1538:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(sock, ptr, strlen(ptr), 0);
data/growl-for-linux-0.8.5/gol.c:1631:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(sock, ptr, strlen(ptr), 0);
data/growl-for-linux-0.8.5/gol.c:1640:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(sock, ptr, strlen(ptr), 0);
data/growl-for-linux-0.8.5/gol.c:1994:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sqlite3_prepare(db, sql, strlen(sql), &stmt, NULL);
data/growl-for-linux-0.8.5/gol.c:2164:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
GOL_PP_CAT(_hash_algorithm, _Update)(&ctx, _password, strlen(_password));\
data/growl-for-linux-0.8.5/subscribe/rhythmbox/rhythmbox.c:61:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t len = strlen(url);
ANALYSIS SUMMARY:
Hits = 36
Lines analyzed = 4627 in approximately 0.14 seconds (32502 lines/second)
Physical Source Lines of Code (SLOC) = 3750
Hits@level = [0] 5 [1] 18 [2] 13 [3] 2 [4] 3 [5] 0
Hits@level+ = [0+] 41 [1+] 36 [2+] 18 [3+] 5 [4+] 3 [5+] 0
Hits/KSLOC@level+ = [0+] 10.9333 [1+] 9.6 [2+] 4.8 [3+] 1.33333 [4+] 0.8 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.