Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/hstr-2.2+ds/src/hashset.c
Examining data/hstr-2.2+ds/src/hstr.c
Parsing failed to find end of parameter list; semicolon terminated it in (screenLine, width, "- HISTORY - view:%s (C-w) - match:%s (C-e) - case:%s (C-t) - %d/%d/%d ",
#else
snprintf(screenLine, width, "- HISTORY - view:%s (C-/) - match:%s (C-e) - case:%s (C-t) - %d/%d/
Examining data/hstr-2.2+ds/src/hstr_blacklist.c
Examining data/hstr-2.2+ds/src/hstr_curses.c
Examining data/hstr-2.2+ds/src/hstr_favorites.c
Examining data/hstr-2.2+ds/src/hstr_history.c
Examining data/hstr-2.2+ds/src/hstr_regexp.c
Examining data/hstr-2.2+ds/src/hstr_utils.c
Examining data/hstr-2.2+ds/src/include/hashset.h
Examining data/hstr-2.2+ds/src/include/hstr.h
Examining data/hstr-2.2+ds/src/include/hstr_blacklist.h
Examining data/hstr-2.2+ds/src/include/hstr_curses.h
Examining data/hstr-2.2+ds/src/include/hstr_favorites.h
Examining data/hstr-2.2+ds/src/include/hstr_history.h
Examining data/hstr-2.2+ds/src/include/hstr_regexp.h
Examining data/hstr-2.2+ds/src/include/hstr_utils.h
Examining data/hstr-2.2+ds/src/include/radixsort.h
Examining data/hstr-2.2+ds/src/main.c
Examining data/hstr-2.2+ds/src/radixsort.c
Examining data/hstr-2.2+ds/test/src/test.c
Examining data/hstr-2.2+ds/test/src/test_curses_keyb.c
Examining data/hstr-2.2+ds/test/src/test_history_generator.c
Examining data/hstr-2.2+ds/test/src/test_keyb.c
Examining data/hstr-2.2+ds/test/src/test_runner.c
Examining data/hstr-2.2+ds/test/src/test_utf8.c
Examining data/hstr-2.2+ds/test/unity/src/c/unity.c
Examining data/hstr-2.2+ds/test/unity/src/c/unity.h
Examining data/hstr-2.2+ds/test/unity/src/c/unity_config.h
Examining data/hstr-2.2+ds/test/unity/src/c/unity_internals.h
FINAL RESULTS:
data/hstr-2.2+ds/src/hashset.c:74:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(newNode->key, key);
data/hstr-2.2+ds/src/hstr.c:1107:21: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(screenLine, pattern);
data/hstr-2.2+ds/src/hstr.c:1142:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buffer, pattern);
data/hstr-2.2+ds/src/hstr.c:1274:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(pattern, hstr->cmdline);
data/hstr-2.2+ds/src/hstr.c:1315:17: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(msg, almostDead);
data/hstr-2.2+ds/src/hstr.c:1602:21: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(pattern, (char*)(&c));
data/hstr-2.2+ds/src/hstr.c:1641:13: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(hstr->cmdline, argv[i]);
data/hstr-2.2+ds/src/hstr_blacklist.c:39:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(fileName, home);
data/hstr-2.2+ds/src/hstr_blacklist.c:41:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(fileName, FILE_HSTR_BLACKLIST);
data/hstr-2.2+ds/src/hstr_blacklist.c:60:16: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(fileName, F_OK) != -1) {
data/hstr-2.2+ds/src/hstr_blacklist.c:157:20: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(fileName, F_OK) != -1) {
data/hstr-2.2+ds/src/hstr_favorites.c:50:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(fileName, home);
data/hstr-2.2+ds/src/hstr_favorites.c:52:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(fileName, FILE_HSTR_FAVORITES);
data/hstr-2.2+ds/src/hstr_favorites.c:61:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(fileName, F_OK) != -1) {
data/hstr-2.2+ds/src/hstr_favorites.c:133:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(fileName, F_OK) != -1) {
data/hstr-2.2+ds/src/hstr_history.c:54:16: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(historyFile, F_OK) == -1) {
data/hstr-2.2+ds/src/hstr_utils.c:86:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buffer, s);
data/hstr-2.2+ds/src/hstr_utils.c:155:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(PROC_HOSTNAME, F_OK) != -1) {
data/hstr-2.2+ds/src/hstr_utils.c:171:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(strcat(strcpy(path, home), "/"), filename);
data/hstr-2.2+ds/src/hstr_utils.c:171:19: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcat(strcat(strcpy(path, home), "/"), filename);
data/hstr-2.2+ds/test/src/test.c:65:13: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(line, argv[i]);
data/hstr-2.2+ds/test/src/test_history_generator.c:41:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(line,"%s%c",line,i);
data/hstr-2.2+ds/test/src/test_utf8.c:158:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(pattern, (char*)(&c));
data/hstr-2.2+ds/src/hstr.c:516:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *hstr_config=getenv(HSTR_ENV_VAR_CONFIG);
data/hstr-2.2+ds/src/hstr.c:621:20: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *prompt = getenv(HSTR_ENV_VAR_PROMPT);
data/hstr-2.2+ds/src/hstr.c:626:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *user = getenv(ENV_VAR_USER);
data/hstr-2.2+ds/src/hstr.c:1236:32: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char* isSubshellHintText = getenv(HSTR_ENV_VAR_IS_SUBSHELL);
data/hstr-2.2+ds/src/hstr.c:1671:18: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
int option = getopt_long(argc, argv, "fkVhnszb", long_options, &option_index);
data/hstr-2.2+ds/src/hstr_blacklist.c:37:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *home = getenv(ENV_VAR_HOME);
data/hstr-2.2+ds/src/hstr_favorites.c:48:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char* home = getenv(ENV_VAR_HOME);
data/hstr-2.2+ds/src/hstr_history.c:50:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char* historyFile = getenv(ENV_VAR_HISTFILE);
data/hstr-2.2+ds/src/hstr_utils.c:169:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char* home = getenv(ENV_VAR_HOME);
data/hstr-2.2+ds/src/hstr_utils.c:215:21: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char* shell = getenv("SHELL");
data/hstr-2.2+ds/test/src/test.c:103:13: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
c = getopt_long(argc, argv, "abc:d:012", long_options, &option_index);
data/hstr-2.2+ds/src/hstr.c:299:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmdline[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:666:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:676:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:698:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:720:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:737:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:759:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:846:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char regexpErrorMessage[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:957:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:958:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:1046:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:1048:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:1091:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char screenLine[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:1132:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[CMDLINE_LNG];
data/hstr-2.2+ds/src/hstr.c:1270:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pattern[SELECTION_PREFIX_MAX_LNG];
data/hstr-2.2+ds/src/hstr_blacklist.c:63:30: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *file = fopen(fileName, "rb");
data/hstr-2.2+ds/src/hstr_blacklist.c:139:36: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *outputFile = fopen(fileName, "wb");
data/hstr-2.2+ds/src/hstr_blacklist.c:158:40: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *outputFile = fopen(fileName, "wb");
data/hstr-2.2+ds/src/hstr_favorites.c:64:31: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* inputFile = fopen(fileName, "rb");
data/hstr-2.2+ds/src/hstr_favorites.c:116:28: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* outputFile = fopen(fileName, "wb");
data/hstr-2.2+ds/src/hstr_favorites.c:134:33: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *output_file = fopen(fileName, "wb");
data/hstr-2.2+ds/src/hstr_utils.c:36:14: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
return p ? memcpy(p, s, len) : NULL;
data/hstr-2.2+ds/src/hstr_utils.c:156:22: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *file = fopen(PROC_HOSTNAME, "r");
data/hstr-2.2+ds/src/hstr_utils.c:164:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buffer, "localhost");
data/hstr-2.2+ds/src/hstr_utils.c:196:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(name, "/proc/%d/comm",pid);
data/hstr-2.2+ds/src/hstr_utils.c:197:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* f = fopen(name,"r");
data/hstr-2.2+ds/src/hstr_utils.c:199:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(name, "/proc/%d/cmdline",pid);
data/hstr-2.2+ds/src/hstr_utils.c:200:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(name,"r");
data/hstr-2.2+ds/test/src/test.c:57:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINELNG];
data/hstr-2.2+ds/test/src/test.c:265:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char message[100];
data/hstr-2.2+ds/test/src/test.c:307:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1000];
data/hstr-2.2+ds/test/src/test_history_generator.c:31:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char line[MAX_CHARACTER_CODE];
data/hstr-2.2+ds/test/src/test_history_generator.c:35:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *file = fopen(".bash_history_huge","a");
data/hstr-2.2+ds/test/src/test_history_generator.c:50:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *file = fopen(".bash_history_same","a");
data/hstr-2.2+ds/test/src/test_utf8.c:38:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char symbol[2] = {'0','1'};
data/hstr-2.2+ds/test/src/test_utf8.c:90:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char multibyte[100]; // multi-byte
data/hstr-2.2+ds/test/src/test_utf8.c:132:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char symbol[2] = {'0','1'};
data/hstr-2.2+ds/test/src/test_utf8.c:152:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pattern[512];
data/hstr-2.2+ds/test/src/test_utf8.c:167:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char symbol[2] = {'0','1'};
data/hstr-2.2+ds/test/unity/src/c/unity.c:286:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[16];
data/hstr-2.2+ds/src/hashset.c:73:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newNode->key=malloc(strlen(key)+1);
data/hstr-2.2+ds/src/hstr.c:127:86: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define LOGUTF8(Y,P) mvprintw(Y, 0, "strlen() %zd, mbstowcs() %zd, hstr_strlen() %d",strlen(P),mbstowcs(NULL,P,0),hstr_strlen(P)); clrtoeol()
data/hstr-2.2+ds/src/hstr.c:517:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(hstr_config && strlen(hstr_config)>0) {
data/hstr-2.2+ds/src/hstr.c:624:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
promptLength=strlen(prompt);
data/hstr-2.2+ds/src/hstr.c:631:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
promptLength=strlen(user)+1+strlen(hostname)+1+1;
data/hstr-2.2+ds/src/hstr.c:631:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
promptLength=strlen(user)+1+strlen(hostname)+1+1;
data/hstr-2.2+ds/src/hstr.c:771:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
width -= strlen(screenLine);
data/hstr-2.2+ds/src/hstr.c:774:9: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(screenLine, "-");
data/hstr-2.2+ds/src/hstr.c:855:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!prefix || !strlen(prefix)) {
data/hstr-2.2+ds/src/hstr.c:964:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(pattern && strlen(pattern)) {
data/hstr-2.2+ds/src/hstr.c:982:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
snprintf(buffer, strlen(pattern)+1, "%s", p);
data/hstr-2.2+ds/src/hstr.c:1020:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pp[strlen(keywordsToken)]=0;
data/hstr-2.2+ds/src/hstr.c:1095:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(pattern && strlen(pattern)) {
data/hstr-2.2+ds/src/hstr.c:1102:21: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(screenLine,
data/hstr-2.2+ds/src/hstr.c:1133:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(pattern && strlen(pattern) && hstr->matching==HSTR_MATCH_REGEXP) {
data/hstr-2.2+ds/src/hstr.c:1137:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buffer,
data/hstr-2.2+ds/src/hstr.c:1237:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(isSubshellHintText && strlen(isSubshellHintText)>0) {
data/hstr-2.2+ds/src/hstr.c:1282:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(pattern)) {
data/hstr-2.2+ds/src/hstr.c:1314:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
msg=malloc(strlen(almostDead)+1);
data/hstr-2.2+ds/src/hstr.c:1329:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
move(hstr->promptY, basex+strlen(pattern));
data/hstr-2.2+ds/src/hstr.c:1335:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
move(hstr->promptY, basex+strlen(pattern));
data/hstr-2.2+ds/src/hstr.c:1349:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
move(hstr->promptY, basex+strlen(pattern));
data/hstr-2.2+ds/src/hstr.c:1359:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(pattern)<(width-basex-1)) {
data/hstr-2.2+ds/src/hstr.c:1371:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(pattern)<(width-basex-1)) {
data/hstr-2.2+ds/src/hstr.c:1387:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(pattern)<(width-basex-1)) {
data/hstr-2.2+ds/src/hstr.c:1408:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(pattern)<(width-basex-1)) {
data/hstr-2.2+ds/src/hstr.c:1421:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
move(hstr->promptY, basex+strlen(pattern));
data/hstr-2.2+ds/src/hstr.c:1446:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(pattern)>0) {
data/hstr-2.2+ds/src/hstr.c:1477:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
move(hstr->promptY, basex+strlen(pattern));
data/hstr-2.2+ds/src/hstr.c:1487:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
move(hstr->promptY, basex+strlen(pattern));
data/hstr-2.2+ds/src/hstr.c:1517:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
move(hstr->promptY, basex+strlen(pattern));
data/hstr-2.2+ds/src/hstr.c:1533:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
move(hstr->promptY, basex+strlen(pattern));
data/hstr-2.2+ds/src/hstr.c:1601:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(pattern)<(width-basex-1)) {
data/hstr-2.2+ds/src/hstr.c:1637:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if((strlen(hstr->cmdline)+strlen(argv[i])*2)>CMDLINE_LNG) break;
data/hstr-2.2+ds/src/hstr.c:1637:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if((strlen(hstr->cmdline)+strlen(argv[i])*2)>CMDLINE_LNG) break;
data/hstr-2.2+ds/src/hstr.c:1639:17: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(hstr->cmdline, "\"");
data/hstr-2.2+ds/src/hstr.c:1643:17: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(hstr->cmdline, "\"");
data/hstr-2.2+ds/src/hstr.c:1646:17: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(hstr->cmdline, " ");
data/hstr-2.2+ds/src/hstr_blacklist.c:38:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *fileName = (char*) malloc(strlen(home) + 1 + strlen(FILE_HSTR_BLACKLIST) + 1);
data/hstr-2.2+ds/src/hstr_blacklist.c:38:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *fileName = (char*) malloc(strlen(home) + 1 + strlen(FILE_HSTR_BLACKLIST) + 1);
data/hstr-2.2+ds/src/hstr_blacklist.c:40:5: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(fileName, "/");
data/hstr-2.2+ds/src/hstr_blacklist.c:76:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(fileContent && strlen(fileContent)) {
data/hstr-2.2+ds/src/hstr_blacklist.c:144:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!fwrite(keys[i], sizeof(char), strlen(keys[i]), outputFile)) {
data/hstr-2.2+ds/src/hstr_blacklist.c:149:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!fwrite("\n", sizeof(char), strlen("\n"), outputFile)) {
data/hstr-2.2+ds/src/hstr_favorites.c:49:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char* fileName = (char*) malloc(strlen(home) + 1 + strlen(FILE_HSTR_FAVORITES) + 1);
data/hstr-2.2+ds/src/hstr_favorites.c:49:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char* fileName = (char*) malloc(strlen(home) + 1 + strlen(FILE_HSTR_FAVORITES) + 1);
data/hstr-2.2+ds/src/hstr_favorites.c:51:5: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(fileName, "/");
data/hstr-2.2+ds/src/hstr_favorites.c:77:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(fileContent && strlen(fileContent)) {
data/hstr-2.2+ds/src/hstr_favorites.c:92:58: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!favorites->skipComments || !(strlen(pb) && pb[0]=='#')) {
data/hstr-2.2+ds/src/hstr_favorites.c:120:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!fwrite(favorites->items[i], sizeof(char), strlen(favorites->items[i]), outputFile)) {
data/hstr-2.2+ds/src/hstr_favorites.c:125:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!fwrite("\n", sizeof(char), strlen("\n"), outputFile)) {
data/hstr-2.2+ds/src/hstr_history.c:51:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!historyFile || strlen(historyFile)==0) {
data/hstr-2.2+ds/src/hstr_history.c:156:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(isZsh && strlen(historyList[i]->line) && historyList[i]->line[0]==':') {
data/hstr-2.2+ds/src/hstr_history.c:162:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(historyList[i]->line && strlen(historyList[i]->line)>itemOffset) {
data/hstr-2.2+ds/src/hstr_history.c:173:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
r->rank=history_ranking_function(0, i, strlen(line));
data/hstr-2.2+ds/src/hstr_history.c:189:66: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
r->rank=history_ranking_function(r->rank, i, strlen(line));
data/hstr-2.2+ds/src/hstr_history.c:226:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(isZsh && strlen(item) && item[0]==':') {
data/hstr-2.2+ds/src/hstr_history.c:227:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(item)>ZSH_HISTORY_ITEM_OFFSET) {
data/hstr-2.2+ds/src/hstr_history.c:308:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(l && strlen(l)) {
data/hstr-2.2+ds/src/hstr_utils.c:34:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = 1+strlen(s);
data/hstr-2.2+ds/src/hstr_utils.c:69:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(s)>maxlength && strlen(s)>3) {
data/hstr-2.2+ds/src/hstr_utils.c:69:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(s)>maxlength && strlen(s)>3) {
data/hstr-2.2+ds/src/hstr_utils.c:71:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buffer, s, dotOffset);
data/hstr-2.2+ds/src/hstr_utils.c:80:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i=strlen(s)-1;
data/hstr-2.2+ds/src/hstr_utils.c:98:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i=strlen(s);
data/hstr-2.2+ds/src/hstr_utils.c:122:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(cmd && strlen(cmd)>0) {
data/hstr-2.2+ds/src/hstr_utils.c:127:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t size = strlen(cmd);
data/hstr-2.2+ds/src/hstr_utils.c:160:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
b[strlen(b)-1]=0;
data/hstr-2.2+ds/src/hstr_utils.c:170:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char* path = malloc(strlen(home) + 1 + strlen(filename) + 1);
data/hstr-2.2+ds/src/hstr_utils.c:170:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char* path = malloc(strlen(home) + 1 + strlen(filename) + 1);
data/hstr-2.2+ds/src/hstr_utils.c:171:12: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(strcat(strcpy(path, home), "/"), filename);
data/hstr-2.2+ds/src/hstr_utils.c:176:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(str && strlen(str)>0) {
data/hstr-2.2+ds/src/hstr_utils.c:214:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(name) > 4){
data/hstr-2.2+ds/src/hstr_utils.c:220:15: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(name,shell,sizeof(char)*strlen(shell));
data/hstr-2.2+ds/src/hstr_utils.c:220:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(name,shell,sizeof(char)*strlen(shell));
data/hstr-2.2+ds/test/src/test.c:60:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if((strlen(line)+strlen(argv[i])*2) > LINELNG) break;
data/hstr-2.2+ds/test/src/test.c:60:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if((strlen(line)+strlen(argv[i])*2) > LINELNG) break;
data/hstr-2.2+ds/test/src/test.c:63:17: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(line, "\"");
data/hstr-2.2+ds/test/src/test.c:67:17: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(line, "\"");
data/hstr-2.2+ds/test/src/test.c:69:13: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(line, " ");
data/hstr-2.2+ds/test/src/test_keyb.c:38:13: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = getc(stdin);
data/hstr-2.2+ds/test/src/test_utf8.c:56:11: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = getc(stdin);
data/hstr-2.2+ds/test/src/test_utf8.c:80:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(s),
data/hstr-2.2+ds/test/src/test_utf8.c:82:15: [1] (buffer) wcslen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
wcslen(w)); // OK
data/hstr-2.2+ds/test/src/test_utf8.c:162:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mvprintw(6, 0, "strlen() '%d'", strlen(pattern));
ANALYSIS SUMMARY:
Hits = 159
Lines analyzed = 7858 in approximately 0.34 seconds (22931 lines/second)
Physical Source Lines of Code (SLOC) = 5917
Hits@level = [0] 101 [1] 85 [2] 40 [3] 11 [4] 23 [5] 0
Hits@level+ = [0+] 260 [1+] 159 [2+] 74 [3+] 34 [4+] 23 [5+] 0
Hits/KSLOC@level+ = [0+] 43.9412 [1+] 26.8717 [2+] 12.5063 [3+] 5.74616 [4+] 3.8871 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.