Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/iraf-sptable-1.0~pre20180612/lib/funits.h Examining data/iraf-sptable-1.0~pre20180612/lib/s.h Examining data/iraf-sptable-1.0~pre20180612/lib/smw.h Examining data/iraf-sptable-1.0~pre20180612/lib/units.h Examining data/iraf-sptable-1.0~pre20180612/src/mwcs/imwcs.h Examining data/iraf-sptable-1.0~pre20180612/src/mwcs/mwcs.h Examining data/iraf-sptable-1.0~pre20180612/src/mwcs/mwsv.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/dispcor/dctable.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/dispcor/dispcor.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/dispcor/refspectra.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/ecidentify/ecffit/ecffit.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/ecidentify/ecidentify.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/identify/autoid/autoid.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/identify/identify.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/irsiids/idsmtn.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/odcombine/src/icmask.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/odcombine/src/icombine.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/odcombine/srcwt/icmask.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/odcombine/srcwt/icombine.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/scombine/icombine.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/sensfunc/sensfunc.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/smw/sio/smw.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/smw/sio/tb.h Examining data/iraf-sptable-1.0~pre20180612/src/xonedspec/specplot.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvcomdef.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvcont.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvfilter.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvflags.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvidlines/identify.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvkeywords.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvpackage.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvplots.h Examining data/iraf-sptable-1.0~pre20180612/src/xrv/rvsample.h FINAL RESULTS: data/iraf-sptable-1.0~pre20180612/lib/smw.h:129:22: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. # Spectrum types and access modes. data/iraf-sptable-1.0~pre20180612/src/mwcs/mwcs.h:49:55: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. define MI_NLOGDIM Memi[$1+12] # dimension of logical system data/iraf-sptable-1.0~pre20180612/src/mwcs/mwcs.h:63:48: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. define WCS_NDIM Memi[$1] # dimension of world system data/iraf-sptable-1.0~pre20180612/src/mwcs/mwcs.h:64:47: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. define WCS_SYSTEM Memi[$1+1] # sbuf index of system name data/iraf-sptable-1.0~pre20180612/src/mwcs/mwcs.h:109:47: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. define CT_WCSI Memi[$1+2] # pointer back to system 1 data/iraf-sptable-1.0~pre20180612/src/mwcs/mwcs.h:110:47: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. define CT_WCSO Memi[$1+3] # pointer back to system 2 data/iraf-sptable-1.0~pre20180612/src/xonedspec/smw/sio/smw.h:131:22: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. # Spectrum types and access modes. data/iraf-sptable-1.0~pre20180612/src/mwcs/mwsv.h:23:33: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. define SV_MWSVOFF Memi[$1+3] # char offset of saved MWSV data/iraf-sptable-1.0~pre20180612/src/mwcs/mwsv.h:25:33: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. define SV_DBUFOFF Memi[$1+5] # char offset of saved DBUF data/iraf-sptable-1.0~pre20180612/src/mwcs/mwsv.h:27:33: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. define SV_SBUFOFF Memi[$1+7] # char offset of saved SBUF data/iraf-sptable-1.0~pre20180612/src/xonedspec/irsiids/idsmtn.h:4:57: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). define DUMMY 3 # Value returned if DUMMY IDS record is read data/iraf-sptable-1.0~pre20180612/src/xonedspec/scombine/icombine.h:59:35: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. define TOL 0.001 # Tolerance for equal residuals ANALYSIS SUMMARY: Hits = 12 Lines analyzed = 2355 in approximately 0.26 seconds (8892 lines/second) Physical Source Lines of Code (SLOC) = 1980 Hits@level = [0] 0 [1] 2 [2] 3 [3] 0 [4] 7 [5] 0 Hits@level+ = [0+] 12 [1+] 12 [2+] 10 [3+] 7 [4+] 7 [5+] 0 Hits/KSLOC@level+ = [0+] 6.06061 [1+] 6.06061 [2+] 5.05051 [3+] 3.53535 [4+] 3.53535 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.