Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/jconvolver-1.0.3/source/jconfig.cc Examining data/jconvolver-1.0.3/source/dither.cc Examining data/jconvolver-1.0.3/source/jclient.h Examining data/jconvolver-1.0.3/source/jclient.cc Examining data/jconvolver-1.0.3/source/sstring.cc Examining data/jconvolver-1.0.3/source/prbsgen.h Examining data/jconvolver-1.0.3/source/audiofile.cc Examining data/jconvolver-1.0.3/source/fconfig.cc Examining data/jconvolver-1.0.3/source/jconvolver.cc Examining data/jconvolver-1.0.3/source/audiofile.h Examining data/jconvolver-1.0.3/source/config.h Examining data/jconvolver-1.0.3/source/sstring.h Examining data/jconvolver-1.0.3/source/makemulti.cc Examining data/jconvolver-1.0.3/source/fconvolver.cc Examining data/jconvolver-1.0.3/source/dither.h Examining data/jconvolver-1.0.3/source/config.cc FINAL RESULTS: data/jconvolver-1.0.3/source/config.cc:82:23: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). if (*file == '/') strcpy (path, file); data/jconvolver-1.0.3/source/config.cc:85:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (path, cdir); data/jconvolver-1.0.3/source/config.cc:87:9: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat (path, file); data/jconvolver-1.0.3/source/config.cc:280:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (cdir, dirname ((char *) config)); data/jconvolver-1.0.3/source/jclient.cc:236:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf (s, "%s:%s", _jname, name); data/jconvolver-1.0.3/source/jclient.cc:251:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf (s, "%s:%s", _jname, name); data/jconvolver-1.0.3/source/fconvolver.cc:74:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((k = getopt (ac, av, (char *) clopt)) != -1) data/jconvolver-1.0.3/source/jconvolver.cc:83:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((k = getopt (ac, av, (char *) clopt)) != -1) data/jconvolver-1.0.3/source/makemulti.cc:123:17: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((k = getopt_long (ac, av, "", options, 0)) != -1) data/jconvolver-1.0.3/source/config.cc:54:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char file [1024]; data/jconvolver-1.0.3/source/config.cc:55:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char path [1024]; data/jconvolver-1.0.3/source/config.cc:270:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line [1024]; data/jconvolver-1.0.3/source/config.cc:271:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cdir [1024]; data/jconvolver-1.0.3/source/config.cc:274:16: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (! (F = fopen (config, "r"))) data/jconvolver-1.0.3/source/config.h:32:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. extern char jackname [NAMELEN]; data/jconvolver-1.0.3/source/config.h:33:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. extern char jackserv [NAMELEN]; data/jconvolver-1.0.3/source/fconvolver.cc:44:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char jackname [NAMELEN]; data/jconvolver-1.0.3/source/fconvolver.cc:45:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char jackserv [NAMELEN]; data/jconvolver-1.0.3/source/jclient.cc:217:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (_convproc->inpdata (i), inpp [i], _fragm * sizeof (float)); data/jconvolver-1.0.3/source/jclient.cc:223:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (outp [i], _convproc->outdata (i), _fragm * sizeof (float)); data/jconvolver-1.0.3/source/jclient.cc:230:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char s [512]; data/jconvolver-1.0.3/source/jclient.cc:245:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char s [512]; data/jconvolver-1.0.3/source/jconfig.cc:33:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char *inp_name [Convproc::MAXINP]; data/jconvolver-1.0.3/source/jconfig.cc:34:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char *out_name [Convproc::MAXOUT]; data/jconvolver-1.0.3/source/jconfig.cc:35:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char *inp_conn [Convproc::MAXINP]; data/jconvolver-1.0.3/source/jconfig.cc:36:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char *out_conn [Convproc::MAXOUT]; data/jconvolver-1.0.3/source/jconfig.cc:46:24: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. if (!jackname [0]) strcpy (jackname, "jconvolver"); data/jconvolver-1.0.3/source/jconfig.cc:110:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char s [256]; data/jconvolver-1.0.3/source/jconfig.cc:128:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char s [256]; data/jconvolver-1.0.3/source/jconfig.cc:146:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char s [16]; data/jconvolver-1.0.3/source/jconfig.cc:156:13: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf (s, "in-%d", i + 1); data/jconvolver-1.0.3/source/jconfig.cc:170:13: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf (s, "out-%d", i + 1); data/jconvolver-1.0.3/source/jconvolver.cc:48:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char jackname [NAMELEN]; data/jconvolver-1.0.3/source/jconvolver.cc:49:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char jackserv [NAMELEN]; data/jconvolver-1.0.3/source/jconvolver.cc:96:30: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). case 'L' : latency = atoi (optarg); break; data/jconvolver-1.0.3/source/audiofile.cc:254:16: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). int Audiofile::read (float *data, uint64_t frames) data/jconvolver-1.0.3/source/audiofile.h:110:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). int read (float *data, uint64_t frames); data/jconvolver-1.0.3/source/config.cc:86:9: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. strcat (path, "/"); data/jconvolver-1.0.3/source/config.cc:136:16: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). nfram = audio.read (buff, nfram); data/jconvolver-1.0.3/source/fconvolver.cc:175:11: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). k = Ainp.read (buff, fragm); data/jconvolver-1.0.3/source/jconvolver.cc:100:20: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). case 'N' : strncpy (jackname, optarg, NAMELEN - 1); break; data/jconvolver-1.0.3/source/jconvolver.cc:101:20: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). case 's' : strncpy (jackserv, optarg, NAMELEN - 1); break; data/jconvolver-1.0.3/source/jconvolver.cc:167:2: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep (100000); data/jconvolver-1.0.3/source/makemulti.cc:301:19: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). nf_done = A->read (inp_ptr, nf_todo); ANALYSIS SUMMARY: Hits = 44 Lines analyzed = 2836 in approximately 0.12 seconds (24343 lines/second) Physical Source Lines of Code (SLOC) = 1998 Hits@level = [0] 109 [1] 9 [2] 26 [3] 3 [4] 6 [5] 0 Hits@level+ = [0+] 153 [1+] 44 [2+] 35 [3+] 9 [4+] 6 [5+] 0 Hits/KSLOC@level+ = [0+] 76.5766 [1+] 22.022 [2+] 17.5175 [3+] 4.5045 [4+] 3.003 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.