Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/ktouch-20.08.0/src/x11_helper.cpp
Examining data/ktouch-20.08.0/src/mainwindow.h
Examining data/ktouch-20.08.0/src/models/resourcemodel.h
Examining data/ktouch-20.08.0/src/models/resourcemodel.cpp
Examining data/ktouch-20.08.0/src/models/learningprogressmodel.cpp
Examining data/ktouch-20.08.0/src/models/learningprogressmodel.h
Examining data/ktouch-20.08.0/src/models/lessonmodel.cpp
Examining data/ktouch-20.08.0/src/models/errorsmodel.cpp
Examining data/ktouch-20.08.0/src/models/lessonmodel.h
Examining data/ktouch-20.08.0/src/models/categorizedresourcesortfilterproxymodel.h
Examining data/ktouch-20.08.0/src/models/errorsmodel.h
Examining data/ktouch-20.08.0/src/models/categorizedresourcesortfilterproxymodel.cpp
Examining data/ktouch-20.08.0/src/models/charactersmodel.cpp
Examining data/ktouch-20.08.0/src/models/charactersmodel.h
Examining data/ktouch-20.08.0/src/customlessoneditordialog.cpp
Examining data/ktouch-20.08.0/src/application.cpp
Examining data/ktouch-20.08.0/src/trainingconfigwidget.h
Examining data/ktouch-20.08.0/src/mainwindow.cpp
Examining data/ktouch-20.08.0/src/ktouchcontext.cpp
Examining data/ktouch-20.08.0/src/bindings/utils.h
Examining data/ktouch-20.08.0/src/bindings/utils.cpp
Examining data/ktouch-20.08.0/src/bindings/stringformatter.h
Examining data/ktouch-20.08.0/src/bindings/stringformatter.cpp
Examining data/ktouch-20.08.0/src/ktouchcontext.h
Examining data/ktouch-20.08.0/src/x11_helper.h
Examining data/ktouch-20.08.0/src/undocommands/keyboardlayoutcommands.cpp
Examining data/ktouch-20.08.0/src/undocommands/coursecommands.h
Examining data/ktouch-20.08.0/src/undocommands/keyboardlayoutcommands.h
Examining data/ktouch-20.08.0/src/undocommands/coursecommands.cpp
Examining data/ktouch-20.08.0/src/main.cpp
Examining data/ktouch-20.08.0/src/core/keychar.cpp
Examining data/ktouch-20.08.0/src/core/keyboardlayoutbase.h
Examining data/ktouch-20.08.0/src/core/keyboardlayout.cpp
Examining data/ktouch-20.08.0/src/core/dataindex.h
Examining data/ktouch-20.08.0/src/core/abstractkey.h
Examining data/ktouch-20.08.0/src/core/dataaccess.h
Examining data/ktouch-20.08.0/src/core/keyboardlayout.h
Examining data/ktouch-20.08.0/src/core/dataaccess.cpp
Examining data/ktouch-20.08.0/src/core/lesson.cpp
Examining data/ktouch-20.08.0/src/core/specialkey.cpp
Examining data/ktouch-20.08.0/src/core/abstractkey.cpp
Examining data/ktouch-20.08.0/src/core/coursebase.cpp
Examining data/ktouch-20.08.0/src/core/course.cpp
Examining data/ktouch-20.08.0/src/core/profiledataaccess.cpp
Examining data/ktouch-20.08.0/src/core/key.cpp
Examining data/ktouch-20.08.0/src/core/dataindex.cpp
Examining data/ktouch-20.08.0/src/core/keyboardlayoutbase.cpp
Examining data/ktouch-20.08.0/src/core/lesson.h
Examining data/ktouch-20.08.0/src/core/course.h
Examining data/ktouch-20.08.0/src/core/userdataaccess.h
Examining data/ktouch-20.08.0/src/core/key.h
Examining data/ktouch-20.08.0/src/core/keychar.h
Examining data/ktouch-20.08.0/src/core/trainingstats.h
Examining data/ktouch-20.08.0/src/core/resource.cpp
Examining data/ktouch-20.08.0/src/core/userdataaccess.cpp
Examining data/ktouch-20.08.0/src/core/resourcedataaccess.h
Examining data/ktouch-20.08.0/src/core/resourcedataaccess.cpp
Examining data/ktouch-20.08.0/src/core/resource.h
Examining data/ktouch-20.08.0/src/core/dbaccess.cpp
Examining data/ktouch-20.08.0/src/core/profiledataaccess.h
Examining data/ktouch-20.08.0/src/core/coursebase.h
Examining data/ktouch-20.08.0/src/core/profile.h
Examining data/ktouch-20.08.0/src/core/specialkey.h
Examining data/ktouch-20.08.0/src/core/profile.cpp
Examining data/ktouch-20.08.0/src/core/trainingstats.cpp
Examining data/ktouch-20.08.0/src/core/dbaccess.h
Examining data/ktouch-20.08.0/src/declarativeitems/griditem.cpp
Examining data/ktouch-20.08.0/src/declarativeitems/griditem.h
Examining data/ktouch-20.08.0/src/declarativeitems/lessontexthighlighteritem.h
Examining data/ktouch-20.08.0/src/declarativeitems/kcolorschemeproxy.cpp
Examining data/ktouch-20.08.0/src/declarativeitems/traininglinecore.h
Examining data/ktouch-20.08.0/src/declarativeitems/lessonpainter.h
Examining data/ktouch-20.08.0/src/declarativeitems/lessontexthighlighteritem.cpp
Examining data/ktouch-20.08.0/src/declarativeitems/lessonpainter.cpp
Examining data/ktouch-20.08.0/src/declarativeitems/preferencesproxy.cpp
Examining data/ktouch-20.08.0/src/declarativeitems/traininglinecore.cpp
Examining data/ktouch-20.08.0/src/declarativeitems/scalebackgrounditem.h
Examining data/ktouch-20.08.0/src/declarativeitems/kcolorschemeproxy.h
Examining data/ktouch-20.08.0/src/declarativeitems/scalebackgrounditem.cpp
Examining data/ktouch-20.08.0/src/declarativeitems/preferencesproxy.h
Examining data/ktouch-20.08.0/src/application.h
Examining data/ktouch-20.08.0/src/customlessoneditordialog.h
Examining data/ktouch-20.08.0/src/trainingconfigwidget.cpp
Examining data/ktouch-20.08.0/src/editor/charactersviewdelegate.h
Examining data/ktouch-20.08.0/src/editor/newcoursewidget.h
Examining data/ktouch-20.08.0/src/editor/lessontexthighlighter.h
Examining data/ktouch-20.08.0/src/editor/keyboardlayouteditorview.cpp
Examining data/ktouch-20.08.0/src/editor/resourceeditorwidget.cpp
Examining data/ktouch-20.08.0/src/editor/keyboardlayoutpropertieswidget.h
Examining data/ktouch-20.08.0/src/editor/newresourceassistant.cpp
Examining data/ktouch-20.08.0/src/editor/abstracteditor.h
Examining data/ktouch-20.08.0/src/editor/keyboardlayoutcombobox.cpp
Examining data/ktouch-20.08.0/src/editor/courseeditor.h
Examining data/ktouch-20.08.0/src/editor/keyboardlayoutcombobox.h
Examining data/ktouch-20.08.0/src/editor/resourcetemplatewidget.h
Examining data/ktouch-20.08.0/src/editor/abstracteditor.cpp
Examining data/ktouch-20.08.0/src/editor/keyboardlayouteditor.h
Examining data/ktouch-20.08.0/src/editor/resourcetemplatewidget.cpp
Examining data/ktouch-20.08.0/src/editor/keyboardlayouteditorview.h
Examining data/ktouch-20.08.0/src/editor/lessontexteditor.cpp
Examining data/ktouch-20.08.0/src/editor/resourceeditorwidget.h
Examining data/ktouch-20.08.0/src/editor/resourceeditor.cpp
Examining data/ktouch-20.08.0/src/editor/newresourceassistant.h
Examining data/ktouch-20.08.0/src/editor/newkeyboardlayoutwidget.cpp
Examining data/ktouch-20.08.0/src/editor/lessontexthighlighter.cpp
Examining data/ktouch-20.08.0/src/editor/keyboardlayouteditor.cpp
Examining data/ktouch-20.08.0/src/editor/charactersviewdelegate.cpp
Examining data/ktouch-20.08.0/src/editor/keyboardlayoutpropertieswidget.cpp
Examining data/ktouch-20.08.0/src/editor/resourcetypeswidget.h
Examining data/ktouch-20.08.0/src/editor/resourceeditor.h
Examining data/ktouch-20.08.0/src/editor/newcoursewidget.cpp
Examining data/ktouch-20.08.0/src/editor/lessontexteditor.h
Examining data/ktouch-20.08.0/src/editor/courseeditor.cpp
Examining data/ktouch-20.08.0/src/editor/newkeyboardlayoutwidget.h
Examining data/ktouch-20.08.0/src/editor/resourcetypeswidget.cpp
Examining data/ktouch-20.08.0/src/colorsconfigwidget.h
Examining data/ktouch-20.08.0/src/colorsconfigwidget.cpp
FINAL RESULTS:
data/ktouch-20.08.0/src/models/learningprogressmodel.cpp:245:23: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
ProfileDataAccess access;
data/ktouch-20.08.0/src/models/learningprogressmodel.cpp:251:33: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
const QSqlQuery query = access.learningProgressQuery(m_profile, m_courseFilter, m_lessonFilter);
data/ktouch-20.08.0/src/core/dbaccess.cpp:54:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!db.open())
data/ktouch-20.08.0/src/core/resourcedataaccess.cpp:56:28: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!dataIndexFile.open(QIODevice::ReadOnly))
data/ktouch-20.08.0/src/core/resourcedataaccess.cpp:107:29: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!keyboardLayoutFile.open(QIODevice::ReadOnly))
data/ktouch-20.08.0/src/core/resourcedataaccess.cpp:273:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::WriteOnly))
data/ktouch-20.08.0/src/core/resourcedataaccess.cpp:289:21: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!courseFile.open(QIODevice::ReadOnly))
data/ktouch-20.08.0/src/core/resourcedataaccess.cpp:384:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::WriteOnly))
data/ktouch-20.08.0/src/core/resourcedataaccess.cpp:437:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::ReadOnly))
data/ktouch-20.08.0/src/editor/lessontexteditor.cpp:86:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!textFile.open(QIODevice::ReadOnly))
data/ktouch-20.08.0/src/x11_helper.cpp:272:74: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(char* p=prop_data; p-prop_data < (long)nitems && p != NULL; p += strlen(p)+1) {
data/ktouch-20.08.0/src/x11_helper.cpp:430:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int suffixLen = strlen(LAYOUT_VARIANT_SEPARATOR_SUFFIX);
ANALYSIS SUMMARY:
Hits = 12
Lines analyzed = 16302 in approximately 2.04 seconds (7988 lines/second)
Physical Source Lines of Code (SLOC) = 11791
Hits@level = [0] 0 [1] 2 [2] 8 [3] 0 [4] 2 [5] 0
Hits@level+ = [0+] 12 [1+] 12 [2+] 10 [3+] 2 [4+] 2 [5+] 0
Hits/KSLOC@level+ = [0+] 1.01773 [1+] 1.01773 [2+] 0.848104 [3+] 0.169621 [4+] 0.169621 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.