Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/libapache-mod-musicindex-1.4.1/src/cache-mysql.h
Examining data/libapache-mod-musicindex-1.4.1/src/cache-file.h
Examining data/libapache-mod-musicindex-1.4.1/src/config.h
Examining data/libapache-mod-musicindex-1.4.1/src/html.h
Examining data/libapache-mod-musicindex-1.4.1/src/http.h
Examining data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.h
Examining data/libapache-mod-musicindex-1.4.1/src/playlist.h
Examining data/libapache-mod-musicindex-1.4.1/src/playlist-flac.h
Examining data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.h
Examining data/libapache-mod-musicindex-1.4.1/src/playlist-mp4.h
Examining data/libapache-mod-musicindex-1.4.1/src/playlist-vorbis.h
Examining data/libapache-mod-musicindex-1.4.1/src/sort.h
Examining data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.c
Examining data/libapache-mod-musicindex-1.4.1/src/html.c
Examining data/libapache-mod-musicindex-1.4.1/src/http.c
Examining data/libapache-mod-musicindex-1.4.1/src/sort.c
Examining data/libapache-mod-musicindex-1.4.1/src/config.c
Examining data/libapache-mod-musicindex-1.4.1/src/playlist.c
Examining data/libapache-mod-musicindex-1.4.1/src/playlist-vorbis.c
Examining data/libapache-mod-musicindex-1.4.1/src/playlist-flac.c
Examining data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c
Examining data/libapache-mod-musicindex-1.4.1/src/playlist-mp4.c
Examining data/libapache-mod-musicindex-1.4.1/src/cache-file.c
Examining data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c
Examining data/libapache-mod-musicindex-1.4.1/src/output-tarball.c
FINAL RESULTS:
data/libapache-mod-musicindex-1.4.1/src/cache-file.c:531:9: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if ( (access(csetup, X_OK|W_OK)) || (chdir((char *)(csetup))) ) {
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:267:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(mysql_params.db, temp);
data/libapache-mod-musicindex-1.4.1/src/html.c:408:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(prefix, ap_get_server_name(r));
data/libapache-mod-musicindex-1.4.1/src/html.c:413:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(prefix, ap_http_method(r)); /* 4-5 */
data/libapache-mod-musicindex-1.4.1/src/html.c:443:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(prefix, ap_get_server_name(r));
data/libapache-mod-musicindex-1.4.1/src/html.c:460:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(prefix, str_port); /* 2-8 */
data/libapache-mod-musicindex-1.4.1/src/html.c:586:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(apr_pstrcat(r->pool, r->filename, "/", Gcovericns[i], NULL), R_OK) == 0) {
data/libapache-mod-musicindex-1.4.1/src/html.c:591:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
else if (access(apr_pstrcat(r->pool, r->filename, "/.", Gcovericns[i], NULL), R_OK) == 0) {
data/libapache-mod-musicindex-1.4.1/src/html.c:1089:39: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if ((dirent->d_name[0] != '.') && (access(r->filename, R_OK|X_OK) == 0))
data/libapache-mod-musicindex-1.4.1/src/html.c:1108:39: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if ((dirent->d_name[0] != '.') && (access(r->filename, R_OK|X_OK) == 0))
data/libapache-mod-musicindex-1.4.1/src/html.c:1162:17: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (subreq && !access(apr_pstrcat(r->pool, subreq->filename, "/valid-xhtml11", NULL), R_OK)) {
data/libapache-mod-musicindex-1.4.1/src/html.c:1172:17: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (subreq && !access(apr_pstrcat(r->pool, subreq->filename, "/vcss", NULL), R_OK)) {
data/libapache-mod-musicindex-1.4.1/src/html.c:1182:17: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (subreq && !access(apr_pstrcat(r->pool, subreq->filename, "/valid-rss.png", NULL), R_OK)) {
data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.c:265:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(r->filename, R_OK|X_OK) != 0) {
data/libapache-mod-musicindex-1.4.1/src/playlist.c:324:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(r->filename, R_OK) != 0)
data/libapache-mod-musicindex-1.4.1/src/playlist.c:334:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(names->filename, r->filename);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:335:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(names->uri, r->parsed_uri.path);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:422:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(fn, filename);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:423:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(uri, filename);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:602:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(names.uri, subreq->parsed_uri.path);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:603:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(names.filename, subreq->filename);
data/libapache-mod-musicindex-1.4.1/src/cache-file.c:323:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char title[MAX_STRING];
data/libapache-mod-musicindex-1.4.1/src/cache-file.c:324:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char album[MAX_STRING];
data/libapache-mod-musicindex-1.4.1/src/cache-file.c:325:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char artist[MAX_STRING];
data/libapache-mod-musicindex-1.4.1/src/cache-file.c:326:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char genre[MAX_GENRE];
data/libapache-mod-musicindex-1.4.1/src/cache-file.c:364:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fdesc = open(filename + 1, O_RDONLY|O_NONBLOCK);
data/libapache-mod-musicindex-1.4.1/src/cache-file.c:465:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fdesc = open(filename + 1, O_WRONLY|O_NONBLOCK|O_CREAT, S_IRUSR|S_IWUSR);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:81:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char user[SQL_SMAX_UPD]; /**< mysql db user */
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:82:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pass[SQL_SMAX_UPD]; /**< mysql db user's pass */
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:83:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char db[SQL_SMAX_UPD]; /**< mysql db */
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:84:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char host[SQL_SMAX_H]; /**< mysql db's host */
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:115:23: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->mtime = (unsigned)atol(mysql_row[1]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:116:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->filetype = (signed char)atoi(mysql_row[2]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:117:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->flags = (unsigned char)atoi(mysql_row[3]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:118:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->track = (unsigned char)atoi(mysql_row[4]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:119:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->posn = (unsigned char)atoi(mysql_row[5]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:120:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->date = (unsigned short)atoi(mysql_row[6]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:121:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->freq = (unsigned short)atoi(mysql_row[7]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:122:30: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->length = (unsigned short)atoi(mysql_row[8]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:123:25: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->bitrate = (unsigned)atol(mysql_row[9]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:124:22: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->size = (unsigned)atol(mysql_row[10]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:330:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (((unsigned)atoi(mysql_row[0]) != TABLE_FORMAT_ID)) {
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:610:20: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
test = (unsigned)atol(mysql_row[0]);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:703:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((unlikely(((unsigned short)atoi(mysql_row[0]) < CACHE_VERS))) ||
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:704:26: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
(unlikely((unsigned)atol(mysql_row[1]) < statbuf.st_mtime)) )
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:841:61: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
apr_psprintf(r->pool, " WHERE id='%lu'", (unsigned long)atol(mysql_row[0])), NULL);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:1009:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (unlikely(((unsigned)atoi(mysql_row[0]) < CACHE_VERS))) {
data/libapache-mod-musicindex-1.4.1/src/config.c:112:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->fields, default_fields, sizeof(default_fields));
data/libapache-mod-musicindex-1.4.1/src/config.c:113:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->order, default_order, sizeof(default_order));
data/libapache-mod-musicindex-1.4.1/src/config.c:169:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->order, add->order, sizeof(add->order));
data/libapache-mod-musicindex-1.4.1/src/config.c:170:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->fields, add->fields, sizeof(add->fields));
data/libapache-mod-musicindex-1.4.1/src/config.c:183:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->order, add->order, sizeof(add->order));
data/libapache-mod-musicindex-1.4.1/src/config.c:185:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->order, base->order, sizeof(base->order));
data/libapache-mod-musicindex-1.4.1/src/config.c:188:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->fields, add->fields, sizeof(add->fields));
data/libapache-mod-musicindex-1.4.1/src/config.c:190:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->fields, base->fields, sizeof(base->fields));
data/libapache-mod-musicindex-1.4.1/src/config.c:444:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
d_cfg->cookie_life = atoi(optstr);
data/libapache-mod-musicindex-1.4.1/src/config.c:462:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
d_cfg->dir_per_line = (atoi(optstr) ? atoi(optstr) : CONF_DIRPERLINE);
data/libapache-mod-musicindex-1.4.1/src/config.c:462:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
d_cfg->dir_per_line = (atoi(optstr) ? atoi(optstr) : CONF_DIRPERLINE);
data/libapache-mod-musicindex-1.4.1/src/config.c:492:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(cfg->order, default_order, sizeof(default_order)); /* XXX necessary? */
data/libapache-mod-musicindex-1.4.1/src/html.c:392:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char prefix[MAX_PREFIX];
data/libapache-mod-musicindex-1.4.1/src/html.c:393:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char str_port[7], strtmp[6]; /* (:)65536 + '\0' */
data/libapache-mod-musicindex-1.4.1/src/html.c:404:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(prefix, "http://"); /* 7 */
data/libapache-mod-musicindex-1.4.1/src/html.c:414:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(prefix, "://"); /* 3 */
data/libapache-mod-musicindex-1.4.1/src/html.c:957:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char date_buf[32];
data/libapache-mod-musicindex-1.4.1/src/http.c:136:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conf->order[0] = (atoi(p) % SB_MAX); /* avoid out of bound values */
data/libapache-mod-musicindex-1.4.1/src/http.c:151:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conf->rss_items = atoi(p+6);
data/libapache-mod-musicindex-1.4.1/src/http.c:173:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAX_STRING];
data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.c:340:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char content_disposition[64] = "";
data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.c:342:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(content_disposition, "attachment; ");
data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.c:344:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(content_disposition, "filename=\"playlist.m3u\"");
data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.h:411:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char order[SB_MAX+1]; /**< Sort order. */
data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.h:412:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fields[SB_MAX+1]; /**< Fields to display */
data/libapache-mod-musicindex-1.4.1/src/output-tarball.c:109:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buff[RWBUFSIZE];
data/libapache-mod-musicindex-1.4.1/src/output-tarball.c:144:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file = fopen(q->filename, "r");
data/libapache-mod-musicindex-1.4.1/src/playlist-flac.c:137:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->track = atoi((char *)vc->comments[i].entry+12);
data/libapache-mod-musicindex-1.4.1/src/playlist-flac.c:139:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->posn = atoi((char *)vc->comments[i].entry+11);
data/libapache-mod-musicindex-1.4.1/src/playlist-flac.c:141:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->date = atoi((char *)vc->comments[i].entry+5);
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:55:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char toc[100]; /* 100-point seek table */
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:78:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char tmp[1024];
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:269:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char madinput_buffer[INPUT_BUFFER_SIZE];
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:316:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->date = atoi((char *)utf8);
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:321:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->track = atoi((char *)utf8);
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:326:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->posn = atoi((char *)utf8);
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:331:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((atoi((char *)utf8) / 1000) > 0)
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:332:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->length = atoi((char *)utf8) / 1000;
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:356:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(madinput_buffer, madstream.this_frame, remaining);
data/libapache-mod-musicindex-1.4.1/src/playlist-mp4.c:149:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->date = atoi(mp4tags->releaseDate);
data/libapache-mod-musicindex-1.4.1/src/playlist-vorbis.c:106:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->track = atoi(t);
data/libapache-mod-musicindex-1.4.1/src/playlist-vorbis.c:108:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->date = atoi(t);
data/libapache-mod-musicindex-1.4.1/src/playlist-vorbis.c:110:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
p->posn = atoi(t);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:436:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *in = fopen(names->filename, "r");
data/libapache-mod-musicindex-1.4.1/src/playlist.h:57:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[MAX_STRING]; /**< file path without trailing '/' */
data/libapache-mod-musicindex-1.4.1/src/playlist.h:58:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char uri[MAX_STRING]; /**< file URI with trailing '/' */
data/libapache-mod-musicindex-1.4.1/src/cache-file.c:179:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tempdir, dirpath, m + l);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:229:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(mysql_params.pass, temp+1, len);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:247:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(mysql_params.user, setup_string, len);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:257:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(mysql_params.host, temp, len);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:262:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(temp);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:391:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(mysql_params.user), SQL_SMAX_UPD, strlen(mysql_params.pass),
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:391:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(mysql_params.user), SQL_SMAX_UPD, strlen(mysql_params.pass),
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:392:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
SQL_SMAX_UPD, strlen(mysql_params.db), SQL_SMAX_UPD,
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:393:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(mysql_params.host), SQL_SMAX_H);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:448:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!(sqlstr = apr_palloc(r->pool, 2*strlen(dirpath)+1)))
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:451:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqlstr, dirpath, strlen(dirpath));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:520:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!(sqlstr = apr_palloc(r->pool, 2*strlen(curdir)+1)))
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:523:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqlstr, curdir, strlen(curdir));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:582:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely(!(sqlstr = malloc(2*strlen(path)+1))))
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:585:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqlstr, path, strlen(path));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:673:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sqldirn = malloc(2*strlen(dirn)+1);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:674:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sqlbasen = malloc(2*strlen(basen)+1);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:678:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqldirn, dirn, strlen(dirn));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:679:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqlbasen, basen, strlen(basen));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:767:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sqldirn = malloc(2*strlen(dirn)+1);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:768:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sqlbasen = malloc(2*strlen(basen)+1);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:772:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqldirn, dirn, strlen(dirn));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:773:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqlbasen, basen, strlen(basen));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:777:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely(!(sqlalb = malloc(2*strlen(p->album)+1))))
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:779:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqlalb, p->album, strlen(p->album));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:782:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely(!(sqlart = malloc(2*strlen(p->artist)+1))))
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:784:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqlart, p->artist, strlen(p->artist));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:787:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely(!(sqlgen = malloc(2*strlen(p->genre)+1))))
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:789:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqlgen, p->genre, strlen(p->genre));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:791:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely(!(sqltit = malloc(2*strlen(p->title)+1))))
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:793:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, sqltit, p->title, strlen(p->title));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:931:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t fnlen = strlen(filename);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:951:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sqlstr, strlen(sqlstr)+2);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:984:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char * restrict escsearch = apr_palloc(pool, 2*strlen(conf->search)+1);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:987:60: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mysql_real_escape_string(mysql, escsearch, conf->search, strlen(conf->search));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:1003:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(fullpath, filename, fnlen);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:1023:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fullpath = realloc(fullpath, fnlen + 1 + strlen(mysql_row[SQL_CDATAN]) + 1);
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:1029:5: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(fullpath, mysql_row[SQL_CDATAN], strlen(mysql_row[SQL_CDATAN]));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:1029:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncat(fullpath, mysql_row[SQL_CDATAN], strlen(mysql_row[SQL_CDATAN]));
data/libapache-mod-musicindex-1.4.1/src/cache-mysql.c:1059:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p->file += strlen(r->parsed_uri.path); /* offset the path before the filename relative to request current dir, except for custom playlists */
data/libapache-mod-musicindex-1.4.1/src/html.c:231:67: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
codeduri = (char *)realloc(codeduri, 1 + apr_base64_encode_len(strlen(q->uri)));
data/libapache-mod-musicindex-1.4.1/src/html.c:237:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
apr_base64_encode(codeduri, q->uri, strlen(q->uri));
data/libapache-mod-musicindex-1.4.1/src/html.c:410:3: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(prefix, conf->iceserver, MAX_PREFIX-8); /* 7+'\0'. if overflow -> truncated */
data/libapache-mod-musicindex-1.4.1/src/html.c:426:5: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(prefix, decoded, l); /* we have "user:pass" */
data/libapache-mod-musicindex-1.4.1/src/html.c:430:4: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(prefix, REQUEST_USER(r), MAX_PREFIX-10); /* 5+3+1+'\0' */
data/libapache-mod-musicindex-1.4.1/src/html.c:432:4: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(prefix, "@"); /* 1 */
data/libapache-mod-musicindex-1.4.1/src/html.c:436:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely((strlen(prefix) + strlen(ap_get_server_name(r))) > MAX_PREFIX-10)) { /* 8+'\0'+safe */
data/libapache-mod-musicindex-1.4.1/src/html.c:436:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely((strlen(prefix) + strlen(ap_get_server_name(r))) > MAX_PREFIX-10)) { /* 8+'\0'+safe */
data/libapache-mod-musicindex-1.4.1/src/http.c:389:66: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
codeduri = (char *)realloc(codeduri, 1 + apr_base64_encode_len(strlen(custom->uri)));
data/libapache-mod-musicindex-1.4.1/src/http.c:392:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
apr_base64_encode(codeduri, custom->uri, strlen(custom->uri));
data/libapache-mod-musicindex-1.4.1/src/mod_musicindex.c:272:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (r->uri[0] == '\0' || r->uri[strlen(r->uri) - 1] != '/') {
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:79:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int read, i;
data/libapache-mod-musicindex-1.4.1/src/playlist-mp3.c:87:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
for (i=0; i<read; i++) {
data/libapache-mod-musicindex-1.4.1/src/playlist.c:316:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
uri = r->parsed_uri.path + strlen(r->parsed_uri.path);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:328:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely((strlen(r->filename) >= MAX_STRING) || (strlen(r->parsed_uri.path) >= MAX_STRING))) {
data/libapache-mod-musicindex-1.4.1/src/playlist.c:328:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (unlikely((strlen(r->filename) >= MAX_STRING) || (strlen(r->parsed_uri.path) >= MAX_STRING))) {
data/libapache-mod-musicindex-1.4.1/src/playlist.c:337:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (names->filename[strlen(names->filename)-1] == '/')
data/libapache-mod-musicindex-1.4.1/src/playlist.c:338:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
names->filename[strlen(names->filename)-1] = '\0';
data/libapache-mod-musicindex-1.4.1/src/playlist.c:345:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
uri = names->uri + strlen(names->uri) - 1;
data/libapache-mod-musicindex-1.4.1/src/playlist.c:377:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char * restrict fn = names->filename + strlen(names->filename);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:412:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fn_max -= strlen(names->filename);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:413:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
uri_max -= strlen(names->uri);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:420:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((filename[0] == '.') || (strlen(filename) >= fn_max) || (strlen(filename) >= uri_max))
data/libapache-mod-musicindex-1.4.1/src/playlist.c:420:66: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((filename[0] == '.') || (strlen(filename) >= fn_max) || (strlen(filename) >= uri_max))
data/libapache-mod-musicindex-1.4.1/src/playlist.c:468:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p->filename += strlen(r->parsed_uri.path);
data/libapache-mod-musicindex-1.4.1/src/playlist.c:476:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p->file += strlen(r->parsed_uri.path); /* offset the path before the filename relative to request current dir, except for custom playlists */
data/libapache-mod-musicindex-1.4.1/src/playlist.c:493:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(p->filename));
data/libapache-mod-musicindex-1.4.1/src/playlist.c:523:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const char *const file = names->uri + strlen(r->parsed_uri.path);
ANALYSIS SUMMARY:
Hits = 161
Lines analyzed = 7677 in approximately 0.52 seconds (14693 lines/second)
Physical Source Lines of Code (SLOC) = 4315
Hits@level = [0] 6 [1] 68 [2] 72 [3] 0 [4] 21 [5] 0
Hits@level+ = [0+] 167 [1+] 161 [2+] 93 [3+] 21 [4+] 21 [5+] 0
Hits/KSLOC@level+ = [0+] 38.7022 [1+] 37.3117 [2+] 21.5527 [3+] 4.86674 [4+] 4.86674 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.