Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/libapache2-mod-auth-openid-0.8/src/moid_utils.cpp
Examining data/libapache2-mod-auth-openid-0.8/src/SessionManager.cpp
Examining data/libapache2-mod-auth-openid-0.8/src/mod_auth_openid.h
Examining data/libapache2-mod-auth-openid-0.8/src/http_helpers.h
Examining data/libapache2-mod-auth-openid-0.8/src/MoidConsumer.h
Examining data/libapache2-mod-auth-openid-0.8/src/types.h
Examining data/libapache2-mod-auth-openid-0.8/src/http_helpers.cpp
Examining data/libapache2-mod-auth-openid-0.8/src/moid_utils.h
Examining data/libapache2-mod-auth-openid-0.8/src/SessionManager.h
Examining data/libapache2-mod-auth-openid-0.8/src/config.h
Examining data/libapache2-mod-auth-openid-0.8/src/MoidConsumer.cpp
Examining data/libapache2-mod-auth-openid-0.8/src/db_info.cpp
Examining data/libapache2-mod-auth-openid-0.8/src/mod_auth_openid.cpp
FINAL RESULTS:
data/libapache2-mod-auth-openid-0.8/src/MoidConsumer.cpp:148:7: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, msg.c_str(), sqlite3_errmsg(db));
data/libapache2-mod-auth-openid-0.8/src/SessionManager.cpp:74:7: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, msg.c_str(), sqlite3_errmsg(db));
data/libapache2-mod-auth-openid-0.8/src/db_info.cpp:52:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(argv[1], 0) == -1) {
data/libapache2-mod-auth-openid-0.8/src/moid_utils.cpp:165:7: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, msg.c_str(), sqlite3_errmsg(db));
data/libapache2-mod-auth-openid-0.8/src/moid_utils.cpp:208:7: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(exec_location.c_str(), argv);
data/libapache2-mod-auth-openid-0.8/src/moid_utils.cpp:230:5: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand((unsigned int)(((time_now >> 32) ^ time_now) & 0xffffffff));
data/libapache2-mod-auth-openid-0.8/src/http_helpers.cpp:271:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char expires[200];
data/libapache2-mod-auth-openid-0.8/src/mod_auth_openid.cpp:133:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
s_cfg->cookie_lifespan = atoi(arg);
data/libapache2-mod-auth-openid-0.8/src/moid_utils.cpp:38:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rv[40];
data/libapache2-mod-auth-openid-0.8/src/moid_utils.cpp:225:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[2];
data/libapache2-mod-auth-openid-0.8/src/MoidConsumer.cpp:37:20: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
::mode_t old = umask(S_IRWXO|S_IRWXG);
data/libapache2-mod-auth-openid-0.8/src/MoidConsumer.cpp:39:5: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(old);
data/libapache2-mod-auth-openid-0.8/src/SessionManager.cpp:36:20: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
::mode_t old = umask(S_IRWXO|S_IRWXG);
data/libapache2-mod-auth-openid-0.8/src/SessionManager.cpp:38:5: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(old);
data/libapache2-mod-auth-openid-0.8/src/http_helpers.cpp:41:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
b = apr_bucket_transient_create(c_s, strlen(c_s), c->bucket_alloc);
ANALYSIS SUMMARY:
Hits = 15
Lines analyzed = 2401 in approximately 0.22 seconds (11063 lines/second)
Physical Source Lines of Code (SLOC) = 1605
Hits@level = [0] 5 [1] 5 [2] 4 [3] 1 [4] 5 [5] 0
Hits@level+ = [0+] 20 [1+] 15 [2+] 10 [3+] 6 [4+] 5 [5+] 0
Hits/KSLOC@level+ = [0+] 12.4611 [1+] 9.34579 [2+] 6.23053 [3+] 3.73832 [4+] 3.11526 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.