Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/libsecret-0.20.3/egg/test-dh.c Examining data/libsecret-0.20.3/egg/test-hkdf.c Examining data/libsecret-0.20.3/egg/egg-libgcrypt.c Examining data/libsecret-0.20.3/egg/egg-secure-memory.c Examining data/libsecret-0.20.3/egg/egg-dh.h Examining data/libsecret-0.20.3/egg/egg-secure-memory.h Examining data/libsecret-0.20.3/egg/egg-libgcrypt.h Examining data/libsecret-0.20.3/egg/egg-hkdf.c Examining data/libsecret-0.20.3/egg/test-hex.c Examining data/libsecret-0.20.3/egg/egg-testing.c Examining data/libsecret-0.20.3/egg/egg-testing.h Examining data/libsecret-0.20.3/egg/egg-hex.c Examining data/libsecret-0.20.3/egg/egg-dh.c Examining data/libsecret-0.20.3/egg/test-secmem.c Examining data/libsecret-0.20.3/egg/egg-hex.h Examining data/libsecret-0.20.3/egg/egg-hkdf.h Examining data/libsecret-0.20.3/secret-dbus-generated.h Examining data/libsecret-0.20.3/tool/secret-tool.c Examining data/libsecret-0.20.3/build/valgrind/valgrind.h Examining data/libsecret-0.20.3/build/valgrind/memcheck.h Examining data/libsecret-0.20.3/secret-dbus-generated.c Examining data/libsecret-0.20.3/libsecret/secret-service.h Examining data/libsecret-0.20.3/libsecret/secret-retrievable.h Examining data/libsecret-0.20.3/libsecret/secret-password.c Examining data/libsecret-0.20.3/libsecret/secret-item.h Examining data/libsecret-0.20.3/libsecret/secret-prompt.h Examining data/libsecret-0.20.3/libsecret/secret-file-collection.c Examining data/libsecret-0.20.3/libsecret/secret-backend.c Examining data/libsecret-0.20.3/libsecret/secret-service.c Examining data/libsecret-0.20.3/libsecret/secret-types.h Examining data/libsecret-0.20.3/libsecret/secret-backend.h Examining data/libsecret-0.20.3/libsecret/secret-file-collection.h Examining data/libsecret-0.20.3/libsecret/secret-file-backend.h Examining data/libsecret-0.20.3/libsecret/mock-service.h Examining data/libsecret-0.20.3/libsecret/secret-enum-types.c Examining data/libsecret-0.20.3/libsecret/secret-file-item.c Examining data/libsecret-0.20.3/libsecret/secret-util.c Examining data/libsecret-0.20.3/libsecret/test-value.c Examining data/libsecret-0.20.3/libsecret/test-item.c Examining data/libsecret-0.20.3/libsecret/secret-schema.h Examining data/libsecret-0.20.3/libsecret/secret-item.c Examining data/libsecret-0.20.3/libsecret/secret-collection.c Examining data/libsecret-0.20.3/libsecret/secret.h Examining data/libsecret-0.20.3/libsecret/secret-schemas.h Examining data/libsecret-0.20.3/libsecret/secret-password.h Examining data/libsecret-0.20.3/libsecret/test-attributes.c Examining data/libsecret-0.20.3/libsecret/secret-prompt.c Examining data/libsecret-0.20.3/libsecret/secret-session.c Examining data/libsecret-0.20.3/libsecret/secret-attributes.c Examining data/libsecret-0.20.3/libsecret/test-paths.c Examining data/libsecret-0.20.3/libsecret/secret-paths.c Examining data/libsecret-0.20.3/libsecret/test-file-collection.c Examining data/libsecret-0.20.3/libsecret/test-password.c Examining data/libsecret-0.20.3/libsecret/test-prompt.c Examining data/libsecret-0.20.3/libsecret/secret-schemas.c Examining data/libsecret-0.20.3/libsecret/secret-file-item.h Examining data/libsecret-0.20.3/libsecret/secret-retrievable.c Examining data/libsecret-0.20.3/libsecret/secret-schema.c Examining data/libsecret-0.20.3/libsecret/secret-methods.c Examining data/libsecret-0.20.3/libsecret/secret-private.h Examining data/libsecret-0.20.3/libsecret/secret-enum-types.h Examining data/libsecret-0.20.3/libsecret/test-session.c Examining data/libsecret-0.20.3/libsecret/secret-version.h Examining data/libsecret-0.20.3/libsecret/mock-service.c Examining data/libsecret-0.20.3/libsecret/secret-file-backend.c Examining data/libsecret-0.20.3/libsecret/secret-paths.h Examining data/libsecret-0.20.3/libsecret/secret-value.c Examining data/libsecret-0.20.3/libsecret/secret-attributes.h Examining data/libsecret-0.20.3/libsecret/test-methods.c Examining data/libsecret-0.20.3/libsecret/test-service.c Examining data/libsecret-0.20.3/libsecret/secret-collection.h Examining data/libsecret-0.20.3/libsecret/secret-value.h Examining data/libsecret-0.20.3/libsecret/test-collection.c FINAL RESULTS: data/libsecret-0.20.3/egg/egg-secure-memory.c:1337:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (res, str); data/libsecret-0.20.3/egg/test-secmem.c:143:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy ((gchar*)p, str); data/libsecret-0.20.3/tool/secret-tool.c:270:13: [4] (misc) getpass: This function is obsolete and not portable. It was in SUSv2 but removed by POSIX.2. What it does exactly varies considerably between systems, particularly in where its prompt is displayed and where it gets its data (e.g., /dev/tty, stdin, stderr, etc.). In addition, some implementations overflow buffers. (CWE-676, CWE-120, CWE-20). Make the specific calls to do exactly what you want. If you continue to use it, or write your own, be sure to zero the password as soon as possible to avoid leaving the cleartext password visible in the process' address space. password = getpass ("Password: "); data/libsecret-0.20.3/egg/egg-libgcrypt.c:90:3: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand (seed); data/libsecret-0.20.3/egg/egg-secure-memory.c:949:6: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv ("SECMEM_FORCE_FALLBACK")) data/libsecret-0.20.3/egg/test-secmem.c:177:14: [3] (random) g_random_int_range: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. action = g_random_int_range (0, 3); data/libsecret-0.20.3/egg/test-secmem.c:184:11: [3] (random) g_random_int_range: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. size = g_random_int_range (1, 16384); data/libsecret-0.20.3/egg/test-secmem.c:191:12: [3] (random) g_random_int_range: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. index = g_random_int_range (0, memory->len); data/libsecret-0.20.3/egg/test-secmem.c:194:11: [3] (random) g_random_int_range: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. size = g_random_int_range (1, 16384); data/libsecret-0.20.3/egg/test-secmem.c:201:12: [3] (random) g_random_int_range: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. index = g_random_int_range (0, memory->len); data/libsecret-0.20.3/egg/egg-hkdf.c:95:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (buffer, gcry_md_read (md2, algo), n_buffer); data/libsecret-0.20.3/egg/egg-hkdf.c:98:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (at, buffer, step); data/libsecret-0.20.3/egg/egg-secure-memory.c:654:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (dest, src, length); data/libsecret-0.20.3/egg/egg-secure-memory.c:1359:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (res, str, len); data/libsecret-0.20.3/libsecret/secret-file-collection.c:680:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (data, padded, n_padded); data/libsecret-0.20.3/libsecret/secret-file-collection.c:820:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (p, KEYRING_FILE_HEADER, KEYRING_FILE_HEADER_LEN); data/libsecret-0.20.3/libsecret/secret-session.c:428:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (padded, value, n_padded); data/libsecret-0.20.3/libsecret/secret-session.c:534:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (padded, secret, length); data/libsecret-0.20.3/libsecret/secret-value.c:107:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (copy, secret, length); data/libsecret-0.20.3/egg/egg-hex.c:59:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). n_data = strlen (data); data/libsecret-0.20.3/egg/egg-hex.c:60:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). n_delim = delim ? strlen (delim) : 0; data/libsecret-0.20.3/egg/egg-secure-memory.c:1335:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen (str) + 1; data/libsecret-0.20.3/egg/egg-secure-memory.c:1385:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). egg_secure_clear ((unsigned char*)str, strlen (str)); data/libsecret-0.20.3/egg/test-secmem.c:137:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen (str) + 1; data/libsecret-0.20.3/egg/test-secmem.c:245:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). g_assert_cmpuint (strlen (str), ==, 6); data/libsecret-0.20.3/egg/test-secmem.c:249:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). g_assert_cmpuint (strlen (str), ==, 6); data/libsecret-0.20.3/libsecret/mock-service.c:55:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ret = read (fd, data->str + len, 256); data/libsecret-0.20.3/libsecret/secret-collection.c:2015:29: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). g_slice_free (ReadClosure, read); data/libsecret-0.20.3/libsecret/secret-collection.c:2131:15: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ReadClosure *read; data/libsecret-0.20.3/libsecret/secret-collection.c:2143:52: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). g_simple_async_result_set_op_res_gpointer (async, read, read_closure_free); data/libsecret-0.20.3/libsecret/secret-collection.c:2171:15: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). ReadClosure *read; data/libsecret-0.20.3/libsecret/secret-file-collection.c:454:49: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!do_calculate_mac (self, (guint8 *)value, strlen (value), buffer)) { data/libsecret-0.20.3/libsecret/secret-file-collection.c:497:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!do_calculate_mac (self, value, strlen ((char *)value), buffer)) { data/libsecret-0.20.3/libsecret/secret-value.c:103:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). length = strlen (secret); data/libsecret-0.20.3/libsecret/secret-value.c:138:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). length = strlen (secret); data/libsecret-0.20.3/tool/secret-tool.c:241:7: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). r = read (0, at, remaining); ANALYSIS SUMMARY: Hits = 36 Lines analyzed = 49422 in approximately 1.24 seconds (39856 lines/second) Physical Source Lines of Code (SLOC) = 34099 Hits@level = [0] 12 [1] 17 [2] 9 [3] 7 [4] 3 [5] 0 Hits@level+ = [0+] 48 [1+] 36 [2+] 19 [3+] 10 [4+] 3 [5+] 0 Hits/KSLOC@level+ = [0+] 1.40767 [1+] 1.05575 [2+] 0.557201 [3+] 0.293264 [4+] 0.0879791 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.