Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/luakit-2.2.1/clib/download.c
Examining data/luakit-2.2.1/clib/download.h
Examining data/luakit-2.2.1/clib/ipc.c
Examining data/luakit-2.2.1/clib/luakit.c
Examining data/luakit-2.2.1/clib/luakit.h
Examining data/luakit-2.2.1/clib/msg.c
Examining data/luakit-2.2.1/clib/msg.h
Examining data/luakit-2.2.1/clib/request.c
Examining data/luakit-2.2.1/clib/request.h
Examining data/luakit-2.2.1/clib/soup.c
Examining data/luakit-2.2.1/clib/soup.h
Examining data/luakit-2.2.1/clib/sqlite3.c
Examining data/luakit-2.2.1/clib/sqlite3.h
Examining data/luakit-2.2.1/clib/stylesheet.c
Examining data/luakit-2.2.1/clib/stylesheet.h
Examining data/luakit-2.2.1/clib/unique.c
Examining data/luakit-2.2.1/clib/unique.h
Examining data/luakit-2.2.1/clib/web_module.c
Examining data/luakit-2.2.1/clib/web_module.h
Examining data/luakit-2.2.1/clib/widget.c
Examining data/luakit-2.2.1/clib/widget.h
Examining data/luakit-2.2.1/clib/xdg.c
Examining data/luakit-2.2.1/clib/xdg.h
Examining data/luakit-2.2.1/common/clib/ipc.c
Examining data/luakit-2.2.1/common/clib/ipc.h
Examining data/luakit-2.2.1/common/clib/luakit.c
Examining data/luakit-2.2.1/common/clib/luakit.h
Examining data/luakit-2.2.1/common/clib/msg.h
Examining data/luakit-2.2.1/common/clib/regex.c
Examining data/luakit-2.2.1/common/clib/regex.h
Examining data/luakit-2.2.1/common/clib/soup.h
Examining data/luakit-2.2.1/common/clib/timer.c
Examining data/luakit-2.2.1/common/clib/timer.h
Examining data/luakit-2.2.1/common/clib/utf8.c
Examining data/luakit-2.2.1/common/clib/utf8.h
Examining data/luakit-2.2.1/common/common.h
Examining data/luakit-2.2.1/common/ipc.c
Examining data/luakit-2.2.1/common/ipc.h
Examining data/luakit-2.2.1/common/log.h
Examining data/luakit-2.2.1/common/luaclass.c
Examining data/luakit-2.2.1/common/luaclass.h
Examining data/luakit-2.2.1/common/luah.c
Examining data/luakit-2.2.1/common/luah.h
Examining data/luakit-2.2.1/common/luajs.c
Examining data/luakit-2.2.1/common/luajs.h
Examining data/luakit-2.2.1/common/lualib.c
Examining data/luakit-2.2.1/common/lualib.h
Examining data/luakit-2.2.1/common/luaobject.c
Examining data/luakit-2.2.1/common/luaobject.h
Examining data/luakit-2.2.1/common/luaserialize.c
Examining data/luakit-2.2.1/common/luaserialize.h
Examining data/luakit-2.2.1/common/luauniq.c
Examining data/luakit-2.2.1/common/luauniq.h
Examining data/luakit-2.2.1/common/luautil.c
Examining data/luakit-2.2.1/common/luautil.h
Examining data/luakit-2.2.1/common/luayield.c
Examining data/luakit-2.2.1/common/luayield.h
Examining data/luakit-2.2.1/common/property.c
Examining data/luakit-2.2.1/common/property.h
Examining data/luakit-2.2.1/common/resource.c
Examining data/luakit-2.2.1/common/resource.h
Examining data/luakit-2.2.1/common/signal.h
Examining data/luakit-2.2.1/common/util.c
Examining data/luakit-2.2.1/common/util.h
Examining data/luakit-2.2.1/extension/clib/dom_document.c
Examining data/luakit-2.2.1/extension/clib/dom_document.h
Examining data/luakit-2.2.1/extension/clib/dom_element.c
Examining data/luakit-2.2.1/extension/clib/dom_element.h
Examining data/luakit-2.2.1/extension/clib/ipc.c
Examining data/luakit-2.2.1/extension/clib/luakit.c
Examining data/luakit-2.2.1/extension/clib/luakit.h
Examining data/luakit-2.2.1/extension/clib/msg.c
Examining data/luakit-2.2.1/extension/clib/msg.h
Examining data/luakit-2.2.1/extension/clib/page.c
Examining data/luakit-2.2.1/extension/clib/page.h
Examining data/luakit-2.2.1/extension/clib/soup.c
Examining data/luakit-2.2.1/extension/clib/soup.h
Examining data/luakit-2.2.1/extension/extension.c
Examining data/luakit-2.2.1/extension/extension.h
Examining data/luakit-2.2.1/extension/ipc.c
Examining data/luakit-2.2.1/extension/ipc.h
Examining data/luakit-2.2.1/extension/log.c
Examining data/luakit-2.2.1/extension/luajs.c
Examining data/luakit-2.2.1/extension/luajs.h
Examining data/luakit-2.2.1/extension/script_world.c
Examining data/luakit-2.2.1/extension/script_world.h
Examining data/luakit-2.2.1/extension/scroll.c
Examining data/luakit-2.2.1/extension/scroll.h
Examining data/luakit-2.2.1/globalconf.h
Examining data/luakit-2.2.1/ipc.c
Examining data/luakit-2.2.1/ipc.h
Examining data/luakit-2.2.1/log.c
Examining data/luakit-2.2.1/log.h
Examining data/luakit-2.2.1/luah.c
Examining data/luakit-2.2.1/luah.h
Examining data/luakit-2.2.1/luakit.c
Examining data/luakit-2.2.1/tests/util.c
Examining data/luakit-2.2.1/web_context.c
Examining data/luakit-2.2.1/web_context.h
Examining data/luakit-2.2.1/widgets/box.c
Examining data/luakit-2.2.1/widgets/common.c
Examining data/luakit-2.2.1/widgets/common.h
Examining data/luakit-2.2.1/widgets/drawing_area.c
Examining data/luakit-2.2.1/widgets/entry.c
Examining data/luakit-2.2.1/widgets/eventbox.c
Examining data/luakit-2.2.1/widgets/image.c
Examining data/luakit-2.2.1/widgets/label.c
Examining data/luakit-2.2.1/widgets/notebook.c
Examining data/luakit-2.2.1/widgets/overlay.c
Examining data/luakit-2.2.1/widgets/paned.c
Examining data/luakit-2.2.1/widgets/scrolled.c
Examining data/luakit-2.2.1/widgets/spinner.c
Examining data/luakit-2.2.1/widgets/stack.c
Examining data/luakit-2.2.1/widgets/webview.c
Examining data/luakit-2.2.1/widgets/webview.h
Examining data/luakit-2.2.1/widgets/webview/auth.c
Examining data/luakit-2.2.1/widgets/webview/downloads.c
Examining data/luakit-2.2.1/widgets/webview/find_controller.c
Examining data/luakit-2.2.1/widgets/webview/history.c
Examining data/luakit-2.2.1/widgets/webview/inspector.c
Examining data/luakit-2.2.1/widgets/webview/javascript.c
Examining data/luakit-2.2.1/widgets/webview/scroll.c
Examining data/luakit-2.2.1/widgets/webview/stylesheets.c
Examining data/luakit-2.2.1/widgets/window.c
FINAL RESULTS:
data/luakit-2.2.1/clib/luakit.c:375:5: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(shell, shell, "-c", luaL_checkstring(L, 1), NULL);
data/luakit-2.2.1/common/log.h:55:29: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((format (printf, 3, 4)));
data/luakit-2.2.1/common/luah.h:136:43: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
static inline void __attribute__ ((format(printf, 2, 3)))
data/luakit-2.2.1/common/luautil.c:40:6: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
(snprintf(NULL, 0, fmt, ##__VA_ARGS__))
data/luakit-2.2.1/common/resource.c:58:13: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(full_path, R_OK))
data/luakit-2.2.1/common/util.c:33:13: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
return (access(filename, F_OK) == 0);
data/luakit-2.2.1/extension/ipc.c:159:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(remote.sun_path, socket_path);
data/luakit-2.2.1/ipc.c:125:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(local.sun_path, path);
data/luakit-2.2.1/ipc.c:166:14: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(extension_file, R_OK))
data/luakit-2.2.1/luah.c:271:5: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(escaped_execpath, (gchar**)argv->pdata);
data/luakit-2.2.1/ipc.c:97:17: [3] (random) g_random_int_range:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
int c = g_random_int_range(0, 10+26+26), base = '0';
data/luakit-2.2.1/ipc.c:103:43: [3] (buffer) g_get_tmp_dir:
This function is synonymous with 'getenv("TMP")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
gchar *socket_path = g_build_filename(g_get_tmp_dir(), socket_name, NULL);
data/luakit-2.2.1/log.c:270:33: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *log_dump_file = getenv("LUAKIT_QUEUED_EMISSIONS_FILE");
data/luakit-2.2.1/luah.c:220:19: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *i_str = getenv("LUAKIT_NEXT_CONFIG_INDEX");
data/luakit-2.2.1/common/ipc.c:45:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char payload[0];
data/luakit-2.2.1/common/ipc.c:114:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(msg->payload, data, header->length);
data/luakit-2.2.1/common/luaserialize.c:133:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&(dst), *bytes, (length)); \
data/luakit-2.2.1/ipc.c:94:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char suffix[11] = {0};
data/luakit-2.2.1/luah.c:221:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gint i = i_str ? atoi(i_str) : 0;
data/luakit-2.2.1/clib/web_module.c:41:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
.length = strlen(module_name)+1
data/luakit-2.2.1/clib/widget.c:101:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gtk_css_provider_load_from_data(w->provider, css, strlen(css), NULL);
data/luakit-2.2.1/clib/widget.c:116:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_assert(strlen(prop) > 0);
data/luakit-2.2.1/clib/widget.c:117:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!value || strlen(value) == 0)
data/luakit-2.2.1/clib/xdg.c:29:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gint last = strlen(path) - 1;
data/luakit-2.2.1/common/luautil.c:109:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(message, ar.short_src, strlen(ar.short_src)))
data/luakit-2.2.1/common/luautil.c:112:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const gchar *tail = message + strlen(ar.short_src);
data/luakit-2.2.1/common/luayield.c:71:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
luaL_loadbuffer(L, sched_src, strlen(sched_src), "luakit_yield_handler");
data/luakit-2.2.1/common/util.h:59:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return s ? strlen(s) : 0;
data/luakit-2.2.1/extension/clib/luakit.c:107:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(lua_tostring(L, 1)) == 0)
data/luakit-2.2.1/extension/clib/luakit.c:109:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(lua_tostring(L, 2)) == 0)
data/luakit-2.2.1/extension/ipc.c:45:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
assert(strlen(module_name) > 0);
data/luakit-2.2.1/extension/ipc.c:46:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
assert(strlen(module_name) == length-1);
data/luakit-2.2.1/extension/ipc.c:160:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = offsetof(struct sockaddr_un, sun_path) + strlen(remote.sun_path);
data/luakit-2.2.1/ipc.c:126:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = offsetof(struct sockaddr_un, sun_path) + strlen(local.sun_path);
data/luakit-2.2.1/log.c:50:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gint len = strlen(group);
data/luakit-2.2.1/log.c:86:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fct += strlen(paths->pdata[i]);
data/luakit-2.2.1/log.c:90:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(fct);
data/luakit-2.2.1/log.c:294:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dump += strlen(dump)+1;
data/luakit-2.2.1/log.c:296:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dump += strlen(dump)+1;
data/luakit-2.2.1/luakit.c:219:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(argv[i], 0, strlen(argv[i]));
data/luakit-2.2.1/widgets/entry.c:187:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gtk_css_provider_load_from_data(provider, inputbar_css, strlen(inputbar_css), NULL);
data/luakit-2.2.1/widgets/image.c:50:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const gchar *ext = strrchr(path, '.') ?: &path[strlen(path)];
data/luakit-2.2.1/widgets/webview.c:583:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t textlen = strlen(text);
ANALYSIS SUMMARY:
Hits = 43
Lines analyzed = 18912 in approximately 0.56 seconds (33636 lines/second)
Physical Source Lines of Code (SLOC) = 12287
Hits@level = [0] 0 [1] 24 [2] 5 [3] 4 [4] 10 [5] 0
Hits@level+ = [0+] 43 [1+] 43 [2+] 19 [3+] 14 [4+] 10 [5+] 0
Hits/KSLOC@level+ = [0+] 3.49963 [1+] 3.49963 [2+] 1.54635 [3+] 1.13942 [4+] 0.813868 [5+] 0
Dot directories skipped = 2 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.