Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/desktop_client.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/base_client.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/dockbar_client.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/base_client.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/xml.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/list.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/keys.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/dockbar_client.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/main_client.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/dialog_client.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/composite-engine.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/session.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/main.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/session.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/composite-engine.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme-standalone.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/dialog_client.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/stack.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/select_client.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/xml.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/wm.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/keys.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/desktop_client.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/stack.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/list.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/client_common.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/toolbar_client_alt.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/structs.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/toolbar_client.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/toolbar_client.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme-standalone.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/client_common.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/select_client.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/main_client.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/misc.h
Examining data/matchbox-window-manager-1.2.2+git20200512/src/wm.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/matchbox-remote.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/misc.c
Examining data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c
FINAL RESULTS:
data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c:351:8: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(bin_map_str, str_tmp);
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:326:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(conf_path, "%s/.matchbox/kbdconfig", getenv("HOME"));
data/matchbox-window-manager-1.2.2+git20200512/src/matchbox-remote.c:144:9: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp ("mbdesktop", exec_args);
data/matchbox-window-manager-1.2.2+git20200512/src/misc.c:47:7: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp ("/bin/sh", "sh", "-c", cmd, (char *)NULL);
data/matchbox-window-manager-1.2.2+git20200512/src/structs.h:100:28: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define dbg(txt, args... ) fprintf(stderr, "WM-DEBUG: " txt, ##args )
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:327:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(w->config->display_name, (char *)getenv("DISPLAY"));
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:351:10: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (w->config->display_name, argv[i]);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:514:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(w->config->display_name, (char *)getenv("DISPLAY"));
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:3148:7: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp(bin_name, bin_name, (char *)NULL);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:3223:8: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(prop_str, current_cycle->bin_name);
data/matchbox-window-manager-1.2.2+git20200512/src/xml.c:167:8: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(parser->_current_node->cdata, cdata);
data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c:1152:47: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
XSyncIntsToValue (&client->ewmh_sync_value, random(), 0);
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:323:28: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (conf_path == NULL && getenv("HOME"))
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:325:47: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
conf_path = malloc(sizeof(char)*(strlen(getenv("HOME"))+25));
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:326:52: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
sprintf(conf_path, "%s/.matchbox/kbdconfig", getenv("HOME"));
data/matchbox-window-manager-1.2.2+git20200512/src/main.c:35:8: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv("MB_SYNC"))
data/matchbox-window-manager-1.2.2+git20200512/src/matchbox-remote.c:224:32: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *display_name = (char *)getenv("DISPLAY");
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2451:4: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
getenv("HOME"), theme_name);
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2522:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (!getenv("MB_THEME_ALWAYS_CACHE"))
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:53:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
snprintf (userId, 20, "%s", getenv("USER") ? getenv("USER") : "unknown");
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:53:52: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
snprintf (userId, 20, "%s", getenv("USER") ? getenv("USER") : "unknown");
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:81:34: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
prop5val.value = (char*) ( getenv("HOME") ? getenv("HOME") : "unknown" );
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:81:51: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
prop5val.value = (char*) ( getenv("HOME") ? getenv("HOME") : "unknown" );
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:315:34: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
w->config->ping_handler = getenv("MB_HUNG_APP_HANDLER");
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:316:33: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
w->config->ping_aggressive = getenv("MB_AGGRESSIVE_PING") ? True : False;
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:326:8: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv("DISPLAY") != NULL)
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:327:47: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
strcpy(w->config->display_name, (char *)getenv("DISPLAY"));
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:503:34: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
w->config->ping_handler = getenv("MB_HUNG_APP_HANDLER");
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:504:34: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
w->config->ping_aggressive = getenv("MB_AGGRESSIVE_PING") ? True : False;
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:513:11: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv("DISPLAY") != NULL)
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:514:43: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
strcpy(w->config->display_name, (char *)getenv("DISPLAY"));
data/matchbox-window-manager-1.2.2+git20200512/src/base_client.c:345:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(p->name+strlen(c->name)+2);
data/matchbox-window-manager-1.2.2+git20200512/src/client_common.c:189:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[257];
data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c:346:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str_tmp[256] = "";
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:221:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char gconf_key_cmd_keys[256] = { 0 };
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:222:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char gconf_key_cmd[256] = { 0 };
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:298:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char data[256];
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:336:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(fp = fopen(conf_path, "r")))
data/matchbox-window-manager-1.2.2+git20200512/src/matchbox-remote.c:81:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char atomName[64];
data/matchbox-window-manager-1.2.2+git20200512/src/matchbox-remote.c:270:35: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (argc > i+1) panel_id = atoi(argv[i+1]);
data/matchbox-window-manager-1.2.2+git20200512/src/matchbox-remote.c:287:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
send_input_manager_request(atoi(argv[i+1]));
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:20:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
{ if (get_attr((n), (k))) (v) = atoi(get_attr((n), (k))); else (v) = 0; }
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2436:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char theme_filename[256] = DEFAULTTHEME;
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2443:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char orig_wd[MAXPATHLEN];
data/matchbox-window-manager-1.2.2+git20200512/src/misc.c:82:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[255];
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:40:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char userId[20], pid[20];
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:168:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char error[256], *mb_client_id;
data/matchbox-window-manager-1.2.2+git20200512/src/stack.c:542:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64];
data/matchbox-window-manager-1.2.2+git20200512/src/stack.c:544:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "Client-%i", i);
data/matchbox-window-manager-1.2.2+git20200512/src/structs.h:485:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char display_name[256];
data/matchbox-window-manager-1.2.2+git20200512/src/structs.h:501:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char shadow_color[4];
data/matchbox-window-manager-1.2.2+git20200512/src/xml.c:432:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(fp = fopen(filename, "rb"))) return NULL;
data/matchbox-window-manager-1.2.2+git20200512/src/base_client.c:338:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(p->name, c->name, strlen(c->name)) == 0
data/matchbox-window-manager-1.2.2+git20200512/src/base_client.c:345:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = atoi(p->name+strlen(c->name)+2);
data/matchbox-window-manager-1.2.2+git20200512/src/base_client.c:355:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp_name_sz = strlen(c->name) + 7;;
data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c:213:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(w->config->ping_handler) + 32;
data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c:328:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bin_map_cnt += (strlen(current_cycle->bin_name) + 32);
data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c:363:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(unsigned char *)bin_map_str, strlen(bin_map_str)
data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c:776:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(w->config->ping_handler) + 32;
data/matchbox-window-manager-1.2.2+git20200512/src/ewmh.c:984:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(unsigned char *)app_name, strlen(app_name)+1);
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:325:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
conf_path = malloc(sizeof(char)*(strlen(getenv("HOME"))+25));
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:357:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (val[strlen(val)-1] == '\n') val[strlen(val)-1] = '\0';
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:357:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (val[strlen(val)-1] == '\n') val[strlen(val)-1] = '\0';
data/matchbox-window-manager-1.2.2+git20200512/src/keys.c:387:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(lookup[i].str)))
data/matchbox-window-manager-1.2.2+git20200512/src/matchbox-remote.c:130:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
PropModeReplace, (unsigned char*)data, strlen(data));
data/matchbox-window-manager-1.2.2+git20200512/src/matchbox-remote.c:273:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
else if (strcmp(arg+1,"prev") == 0 || strlen(arg+1) == 1)
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme-standalone.c:550:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
? ewmh_utf8_len(c->name) : strlen(c->name);
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme-standalone.c:633:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
str_len = strlen(entry->name);
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme-standalone.c:763:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
str_len = strlen(p->name);
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:898:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(p->name),
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2447:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(theme_filename, theme_name, 255);
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2466:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(theme_filename, DEFAULTTHEME, 255);
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2476:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
theme_path[strlen(theme_filename)-9] = '\0';
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2481:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
PropModeReplace, (unsigned char*)theme_path, strlen(theme_path));
data/matchbox-window-manager-1.2.2+git20200512/src/mbtheme.c:2484:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
PropModeReplace, (unsigned char*)theme_name, strlen(theme_name));
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:51:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop1val.length = strlen ("matchbox-window-manager");
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:59:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop2val.length = strlen (userId);
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:74:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop4val.length = strlen (prop4val.value);
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:82:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop5val.length = strlen (prop5val.value);
data/matchbox-window-manager-1.2.2+git20200512/src/session.c:112:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop1val.length = strlen ("matchbox-window-manager");
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:510:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(w->config->display_name, value.addr, (int) value.size);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:537:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(w->config->theme, value.addr, (int) value.size);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:550:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(w->config->force_dialogs, value.addr, (int) value.size);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:561:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(w->config->kbd_conf_file, value.addr, (int) value.size);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:656:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(geom, value.addr, (int) value.size);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:680:8: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(w->config->sm_client_id, value.addr, (int) value.size);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:3208:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop_str_len += (strlen(current_cycle->bin_name) + 1);
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:3224:8: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(prop_str, "|");
data/matchbox-window-manager-1.2.2+git20200512/src/wm.c:3235:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(unsigned char *)prop_str, strlen(prop_str)
data/matchbox-window-manager-1.2.2+git20200512/src/xml.c:165:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sizeof(char)*(strlen(parser->_current_node->cdata))
data/matchbox-window-manager-1.2.2+git20200512/src/xml.c:166:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
+ sizeof(char)*(strlen(cdata)+1));
data/matchbox-window-manager-1.2.2+git20200512/src/xml.c:490:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (! XML_Parse(p, data, strlen(data), 1)) {
ANALYSIS SUMMARY:
Hits = 92
Lines analyzed = 20393 in approximately 0.42 seconds (48672 lines/second)
Physical Source Lines of Code (SLOC) = 14759
Hits@level = [0] 155 [1] 40 [2] 21 [3] 20 [4] 11 [5] 0
Hits@level+ = [0+] 247 [1+] 92 [2+] 52 [3+] 31 [4+] 11 [5+] 0
Hits/KSLOC@level+ = [0+] 16.7356 [1+] 6.23348 [2+] 3.52327 [3+] 2.10041 [4+] 0.745308 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.