Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/mate-terminal-1.24.1/src/eggdesktopfile.c
Examining data/mate-terminal-1.24.1/src/eggdesktopfile.h
Examining data/mate-terminal-1.24.1/src/eggshell.c
Examining data/mate-terminal-1.24.1/src/eggshell.h
Examining data/mate-terminal-1.24.1/src/eggsmclient-private.h
Examining data/mate-terminal-1.24.1/src/eggsmclient-xsmp.c
Examining data/mate-terminal-1.24.1/src/eggsmclient.c
Examining data/mate-terminal-1.24.1/src/eggsmclient.h
Examining data/mate-terminal-1.24.1/src/extra-strings.c
Examining data/mate-terminal-1.24.1/src/profile-editor.c
Examining data/mate-terminal-1.24.1/src/profile-editor.h
Examining data/mate-terminal-1.24.1/src/skey-popup.c
Examining data/mate-terminal-1.24.1/src/skey-popup.h
Examining data/mate-terminal-1.24.1/src/skey/btoe.c
Examining data/mate-terminal-1.24.1/src/skey/btoe.h
Examining data/mate-terminal-1.24.1/src/skey/md4.c
Examining data/mate-terminal-1.24.1/src/skey/md4.h
Examining data/mate-terminal-1.24.1/src/skey/md5.c
Examining data/mate-terminal-1.24.1/src/skey/md5.h
Examining data/mate-terminal-1.24.1/src/skey/sha1.c
Examining data/mate-terminal-1.24.1/src/skey/sha1.h
Examining data/mate-terminal-1.24.1/src/skey/skey.c
Examining data/mate-terminal-1.24.1/src/skey/skey.h
Examining data/mate-terminal-1.24.1/src/skey/skeyutil.c
Examining data/mate-terminal-1.24.1/src/skey/skeyutil.h
Examining data/mate-terminal-1.24.1/src/skey/test.c
Examining data/mate-terminal-1.24.1/src/terminal-accels.c
Examining data/mate-terminal-1.24.1/src/terminal-accels.h
Examining data/mate-terminal-1.24.1/src/terminal-app.c
Examining data/mate-terminal-1.24.1/src/terminal-app.h
Examining data/mate-terminal-1.24.1/src/terminal-close-button.c
Examining data/mate-terminal-1.24.1/src/terminal-close-button.h
Examining data/mate-terminal-1.24.1/src/terminal-debug.c
Examining data/mate-terminal-1.24.1/src/terminal-debug.h
Examining data/mate-terminal-1.24.1/src/terminal-encoding.c
Examining data/mate-terminal-1.24.1/src/terminal-encoding.h
Examining data/mate-terminal-1.24.1/src/terminal-info-bar.c
Examining data/mate-terminal-1.24.1/src/terminal-info-bar.h
Examining data/mate-terminal-1.24.1/src/terminal-intl.h
Examining data/mate-terminal-1.24.1/src/terminal-options.c
Examining data/mate-terminal-1.24.1/src/terminal-options.h
Examining data/mate-terminal-1.24.1/src/terminal-profile.c
Examining data/mate-terminal-1.24.1/src/terminal-profile.h
Examining data/mate-terminal-1.24.1/src/terminal-screen-container.c
Examining data/mate-terminal-1.24.1/src/terminal-screen-container.h
Examining data/mate-terminal-1.24.1/src/terminal-screen.c
Examining data/mate-terminal-1.24.1/src/terminal-screen.h
Examining data/mate-terminal-1.24.1/src/terminal-search-dialog.c
Examining data/mate-terminal-1.24.1/src/terminal-search-dialog.h
Examining data/mate-terminal-1.24.1/src/terminal-tab-label.c
Examining data/mate-terminal-1.24.1/src/terminal-tab-label.h
Examining data/mate-terminal-1.24.1/src/terminal-tabs-menu.c
Examining data/mate-terminal-1.24.1/src/terminal-tabs-menu.h
Examining data/mate-terminal-1.24.1/src/terminal-util.c
Examining data/mate-terminal-1.24.1/src/terminal-util.h
Examining data/mate-terminal-1.24.1/src/terminal-window.c
Examining data/mate-terminal-1.24.1/src/terminal-window.h
Examining data/mate-terminal-1.24.1/src/terminal.c
FINAL RESULTS:
data/mate-terminal-1.24.1/src/terminal-screen.c:219:9: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
len = readlink (cwd_file, buf, sizeof (buf) - 1);
data/mate-terminal-1.24.1/src/eggshell.c:77:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access (shell, X_OK) == 0)
data/mate-terminal-1.24.1/src/eggshell.c:86:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access (pw->pw_shell, X_OK) == 0)
data/mate-terminal-1.24.1/src/eggshell.c:94:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access (shells [i], X_OK) == 0)
data/mate-terminal-1.24.1/src/skey/md4.c:277:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buf, seed);
data/mate-terminal-1.24.1/src/skey/md4.c:279:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, passphrase);
data/mate-terminal-1.24.1/src/skey/md5.c:25:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buf, seed);
data/mate-terminal-1.24.1/src/skey/md5.c:27:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, passhrase);
data/mate-terminal-1.24.1/src/skey/sha1.c:56:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buf, seed);
data/mate-terminal-1.24.1/src/skey/sha1.c:58:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, passphrase);
data/mate-terminal-1.24.1/src/profile-editor.c:601:13: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
home_dir = g_get_home_dir ();
data/mate-terminal-1.24.1/src/terminal-screen.c:1578:17: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
working_dir = g_get_home_dir ();
data/mate-terminal-1.24.1/src/terminal-util.c:51:60: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
role = g_strdup_printf ("%s-%d-%d-%d", prefix, getpid (), g_random_int (), (int) time (NULL));
data/mate-terminal-1.24.1/src/terminal.c:564:13: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
home_dir = g_get_home_dir ();
data/mate-terminal-1.24.1/src/eggsmclient-xsmp.c:215:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pid_str[64];
data/mate-terminal-1.24.1/src/eggsmclient-xsmp.c:326:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char error_string_ret[256];
data/mate-terminal-1.24.1/src/eggsmclient-xsmp.c:905:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open (state_file_path, O_WRONLY | O_CREAT | O_EXCL, 0644);
data/mate-terminal-1.24.1/src/profile-editor.c:468:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[32];
data/mate-terminal-1.24.1/src/profile-editor.c:724:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[32];
data/mate-terminal-1.24.1/src/skey-popup.c:137:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char newline[2] = "\n";
data/mate-terminal-1.24.1/src/skey/btoe.c:18:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char Wp[2048][4] = { "A", "ABE", "ACE", "ACT", "AD", "ADA", "ADD",
data/mate-terminal-1.24.1/src/skey/btoe.c:249:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cp[9]; /* 64 + 2 = 66 bits */
data/mate-terminal-1.24.1/src/skey/btoe.c:254:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(cp, md, SKEY_SIZE);
data/mate-terminal-1.24.1/src/skey/md4.c:100:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, buf, len);
data/mate-terminal-1.24.1/src/skey/md4.c:103:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, buf, t);
data/mate-terminal-1.24.1/src/skey/md4.c:113:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctx->in, buf, 64);
data/mate-terminal-1.24.1/src/skey/md4.c:122:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctx->in, buf, len);
data/mate-terminal-1.24.1/src/skey/md4.c:171:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(digest, ctx->buf, 16);
data/mate-terminal-1.24.1/src/skey/md4.c:289:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void *)result, (void *)results, SKEY_SIZE);
data/mate-terminal-1.24.1/src/skey/md4.c:307:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void *)x, (void *)results, SKEY_SIZE);
data/mate-terminal-1.24.1/src/skey/md4.c:319:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char digest[16];
data/mate-terminal-1.24.1/src/skey/md4.c:320:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char data[1024];
data/mate-terminal-1.24.1/src/skey/md4.h:10:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char in[64];
data/mate-terminal-1.24.1/src/skey/md5.c:41:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void *)result, (void *)results, SKEY_SIZE);
data/mate-terminal-1.24.1/src/skey/md5.c:64:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void *)x, (void *)results, SKEY_SIZE);
data/mate-terminal-1.24.1/src/skey/sha1.c:81:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void *)result, (void *)results, SKEY_SIZE);
data/mate-terminal-1.24.1/src/skey/sha1.c:111:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void *)x, (void *)results, SKEY_SIZE);
data/mate-terminal-1.24.1/src/skey/skey.c:29:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key[SKEY_SIZE];
data/mate-terminal-1.24.1/src/terminal-profile.c:770:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[16];
data/mate-terminal-1.24.1/src/terminal-profile.c:1375:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char profile_name[32];
data/mate-terminal-1.24.1/src/terminal-screen.c:214:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cwd_file[64];
data/mate-terminal-1.24.1/src/terminal-screen.c:215:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX + 1];
data/mate-terminal-1.24.1/src/terminal-screen.c:2111:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *uris[2];
data/mate-terminal-1.24.1/src/terminal-screen.c:2148:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *uris[2];
data/mate-terminal-1.24.1/src/terminal-screen.c:2446:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[64];
data/mate-terminal-1.24.1/src/terminal-tabs-menu.c:190:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char verb[ACTION_VERB_FORMAT_LENGTH];
data/mate-terminal-1.24.1/src/terminal-tabs-menu.c:439:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char accel_path[ACCEL_PATH_FORMAT_LENGTH];
data/mate-terminal-1.24.1/src/terminal-util.c:939:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char notify_signal_name[64];
data/mate-terminal-1.24.1/src/terminal-window.c:751:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[32];
data/mate-terminal-1.24.1/src/terminal-window.c:881:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[32];
data/mate-terminal-1.24.1/src/terminal-window.c:988:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[128];
data/mate-terminal-1.24.1/src/terminal-window.c:1036:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[128];
data/mate-terminal-1.24.1/src/terminal-window.c:1109:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[40];
data/mate-terminal-1.24.1/src/eggsmclient-xsmp.c:1183:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pv.length = strlen (value);
data/mate-terminal-1.24.1/src/eggsmclient-xsmp.c:1217:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pv.length = strlen (values->pdata[i]);
data/mate-terminal-1.24.1/src/eggsmclient-xsmp.c:1246:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop->vals[0].length = strlen (value);
data/mate-terminal-1.24.1/src/skey-popup.c:56:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*seq = strtol (skey_match + strlen (SKEY_PREFIX), &end_ptr, 0);
data/mate-terminal-1.24.1/src/skey-popup.c:73:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const gchar *p = otp_match + strlen (OTP_PREFIX);
data/mate-terminal-1.24.1/src/skey-popup.c:139:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vte_terminal_feed_child (vte_terminal, response, strlen (response));
data/mate-terminal-1.24.1/src/skey-popup.c:140:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vte_terminal_feed_child (vte_terminal, newline, strlen (newline));
data/mate-terminal-1.24.1/src/skey-popup.c:160:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (SKEY_PREFIX, skey_match, strlen (SKEY_PREFIX)) == 0)
data/mate-terminal-1.24.1/src/skey/btoe.c:262:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(engout, &Wp[extract(cp, 0, 11)][0], 4);
data/mate-terminal-1.24.1/src/skey/btoe.c:263:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (engout," ");
data/mate-terminal-1.24.1/src/skey/btoe.c:264:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(engout, &Wp[extract(cp, 11, 11)][0], 4);
data/mate-terminal-1.24.1/src/skey/btoe.c:265:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (engout," ");
data/mate-terminal-1.24.1/src/skey/btoe.c:266:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(engout, &Wp[extract(cp, 22, 11)][0], 4);
data/mate-terminal-1.24.1/src/skey/btoe.c:267:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (engout," ");
data/mate-terminal-1.24.1/src/skey/btoe.c:268:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(engout, &Wp[extract(cp, 33, 11)][0], 4);
data/mate-terminal-1.24.1/src/skey/btoe.c:269:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (engout," ");
data/mate-terminal-1.24.1/src/skey/btoe.c:270:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(engout, &Wp[extract(cp, 44, 11)][0], 4);
data/mate-terminal-1.24.1/src/skey/btoe.c:271:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (engout," ");
data/mate-terminal-1.24.1/src/skey/btoe.c:272:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(engout, &Wp[extract(cp, 55, 11)][0], 4);
data/mate-terminal-1.24.1/src/skey/md4.c:272:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(seed) + strlen(passphrase);
data/mate-terminal-1.24.1/src/skey/md4.c:272:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(seed) + strlen(passphrase);
data/mate-terminal-1.24.1/src/skey/md4.c:330:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
r = read(0, data, sizeof data);
data/mate-terminal-1.24.1/src/skey/md5.c:20:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(seed) + strlen(passhrase);
data/mate-terminal-1.24.1/src/skey/md5.c:20:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(seed) + strlen(passhrase);
data/mate-terminal-1.24.1/src/skey/sha1.c:52:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(seed) + strlen(passphrase);
data/mate-terminal-1.24.1/src/skey/sha1.c:52:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(seed) + strlen(passphrase);
data/mate-terminal-1.24.1/src/terminal-app.c:1049:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (font && (strlen (font) == 0)) /* empty string */
data/mate-terminal-1.24.1/src/terminal-profile.c:563:11: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
gboolean equal;
data/mate-terminal-1.24.1/src/terminal-profile.c:695:8: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (!equal)
data/mate-terminal-1.24.1/src/terminal-profile.c:706:7: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
if (!equal || force_set)
data/mate-terminal-1.24.1/src/terminal-screen.c:2077:58: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vte_terminal_feed_child (VTE_TERMINAL (screen), text, strlen (text));
data/mate-terminal-1.24.1/src/terminal-tabs-menu.c:37:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define ACTION_VERB_FORMAT_PREFIX_LEN strlen (ACTION_VERB_FORMAT_PREFIX)
data/mate-terminal-1.24.1/src/terminal-tabs-menu.c:39:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define ACTION_VERB_FORMAT_LENGTH strlen (ACTION_VERB_FORMAT) + 14 + 1
data/mate-terminal-1.24.1/src/terminal-tabs-menu.c:42:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define ACCEL_PATH_FORMAT_LENGTH strlen (ACCEL_PATH_FORMAT) + 14 + 1
data/mate-terminal-1.24.1/src/terminal-util.c:305:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen (uris[i]) + 1;
data/mate-terminal-1.24.1/src/terminal-window.c:506:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
escaped_name = g_string_sized_new (strlen (name) + 4 + 1);
data/mate-terminal-1.24.1/src/terminal-window.c:1071:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
name = gtk_action_get_name (action) + strlen (SIZE_TO_ACTION_NAME_PREFIX);
data/mate-terminal-1.24.1/src/terminal-window.c:1647:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
action_name = I_(accel_path + strlen ("<Actions>/Main/"));
data/mate-terminal-1.24.1/src/terminal.c:120:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen (string);
data/mate-terminal-1.24.1/src/terminal.c:469:63: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
8, PropModeReplace, (unsigned char *)name, strlen (name));
data/mate-terminal-1.24.1/src/terminal.c:488:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
name = g_string_sized_new (strlen (TERMINAL_FACTORY_SERVICE_NAME_PREFIX) + strlen (display_name) + 1 /* NUL */);
data/mate-terminal-1.24.1/src/terminal.c:488:77: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
name = g_string_sized_new (strlen (TERMINAL_FACTORY_SERVICE_NAME_PREFIX) + strlen (display_name) + 1 /* NUL */);
ANALYSIS SUMMARY:
Hits = 95
Lines analyzed = 25182 in approximately 0.57 seconds (44505 lines/second)
Physical Source Lines of Code (SLOC) = 18498
Hits@level = [0] 4 [1] 42 [2] 39 [3] 4 [4] 9 [5] 1
Hits@level+ = [0+] 99 [1+] 95 [2+] 53 [3+] 14 [4+] 10 [5+] 1
Hits/KSLOC@level+ = [0+] 5.35193 [1+] 5.13569 [2+] 2.86517 [3+] 0.756839 [4+] 0.540599 [5+] 0.0540599
Dot directories skipped = 3 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.