Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/minidlna-1.2.1+dfsg/albumart.c
Examining data/minidlna-1.2.1+dfsg/albumart.h
Examining data/minidlna-1.2.1+dfsg/avahi.c
Examining data/minidlna-1.2.1+dfsg/avahi.h
Examining data/minidlna-1.2.1+dfsg/clients.c
Examining data/minidlna-1.2.1+dfsg/clients.h
Examining data/minidlna-1.2.1+dfsg/codelength.h
Examining data/minidlna-1.2.1+dfsg/containers.c
Examining data/minidlna-1.2.1+dfsg/containers.h
Examining data/minidlna-1.2.1+dfsg/getifaddr.c
Examining data/minidlna-1.2.1+dfsg/getifaddr.h
Examining data/minidlna-1.2.1+dfsg/icons.c
Examining data/minidlna-1.2.1+dfsg/image_utils.c
Examining data/minidlna-1.2.1+dfsg/image_utils.h
Examining data/minidlna-1.2.1+dfsg/libav.h
Examining data/minidlna-1.2.1+dfsg/linux/inotify-syscalls.h
Examining data/minidlna-1.2.1+dfsg/linux/inotify.h
Examining data/minidlna-1.2.1+dfsg/metadata.h
Examining data/minidlna-1.2.1+dfsg/minidlnapath.h
Examining data/minidlna-1.2.1+dfsg/minidlnatypes.h
Examining data/minidlna-1.2.1+dfsg/minissdp.h
Examining data/minidlna-1.2.1+dfsg/minixml.c
Examining data/minidlna-1.2.1+dfsg/minixml.h
Examining data/minidlna-1.2.1+dfsg/monitor.c
Examining data/minidlna-1.2.1+dfsg/monitor.h
Examining data/minidlna-1.2.1+dfsg/options.c
Examining data/minidlna-1.2.1+dfsg/options.h
Examining data/minidlna-1.2.1+dfsg/playlist.c
Examining data/minidlna-1.2.1+dfsg/playlist.h
Examining data/minidlna-1.2.1+dfsg/process.c
Examining data/minidlna-1.2.1+dfsg/process.h
Examining data/minidlna-1.2.1+dfsg/scanner.h
Examining data/minidlna-1.2.1+dfsg/scanner_sqlite.h
Examining data/minidlna-1.2.1+dfsg/sendfile.h
Examining data/minidlna-1.2.1+dfsg/sql.c
Examining data/minidlna-1.2.1+dfsg/sql.h
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.h
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.h
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-flc.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-flc.h
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.h
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-ogg.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-ogg.h
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-pcm.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-pcm.h
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-plist.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.h
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils.c
Examining data/minidlna-1.2.1+dfsg/tagutils/tagutils.h
Examining data/minidlna-1.2.1+dfsg/testupnpdescgen.c
Examining data/minidlna-1.2.1+dfsg/tivo_beacon.c
Examining data/minidlna-1.2.1+dfsg/tivo_beacon.h
Examining data/minidlna-1.2.1+dfsg/tivo_commands.c
Examining data/minidlna-1.2.1+dfsg/tivo_commands.h
Examining data/minidlna-1.2.1+dfsg/tivo_utils.c
Examining data/minidlna-1.2.1+dfsg/tivo_utils.h
Examining data/minidlna-1.2.1+dfsg/upnpdescgen.c
Examining data/minidlna-1.2.1+dfsg/upnpdescgen.h
Examining data/minidlna-1.2.1+dfsg/upnpevents.c
Examining data/minidlna-1.2.1+dfsg/upnpevents.h
Examining data/minidlna-1.2.1+dfsg/upnpglobalvars.h
Examining data/minidlna-1.2.1+dfsg/upnphttp.c
Examining data/minidlna-1.2.1+dfsg/upnphttp.h
Examining data/minidlna-1.2.1+dfsg/upnpreplyparse.c
Examining data/minidlna-1.2.1+dfsg/upnpreplyparse.h
Examining data/minidlna-1.2.1+dfsg/upnpsoap.c
Examining data/minidlna-1.2.1+dfsg/upnpsoap.h
Examining data/minidlna-1.2.1+dfsg/utils.c
Examining data/minidlna-1.2.1+dfsg/utils.h
Examining data/minidlna-1.2.1+dfsg/uuid.c
Examining data/minidlna-1.2.1+dfsg/uuid.h
Examining data/minidlna-1.2.1+dfsg/upnpglobalvars.c
Examining data/minidlna-1.2.1+dfsg/log.c
Examining data/minidlna-1.2.1+dfsg/log.h
Examining data/minidlna-1.2.1+dfsg/scanner.c
Examining data/minidlna-1.2.1+dfsg/minidlna.c
Examining data/minidlna-1.2.1+dfsg/metadata.c
Examining data/minidlna-1.2.1+dfsg/minissdp.c
FINAL RESULTS:
data/minidlna-1.2.1+dfsg/minidlna.c:434:8: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
if (chown(dir, uid, -1) != 0)
data/minidlna-1.2.1+dfsg/minidlna.c:1007:54: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
if (stat(db_path, &st) == 0 && st.st_uid != uid && chown(db_path, uid, -1) != 0)
data/minidlna-1.2.1+dfsg/utils.c:494:15: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
if( (len = readlink(path, str_buf, PATH_MAX-1)) > 0 )
data/minidlna-1.2.1+dfsg/albumart.c:50:11: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
return (!access(*cache_file, F_OK));
data/minidlna-1.2.1+dfsg/albumart.c:260:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(last_path, art_path);
data/minidlna-1.2.1+dfsg/albumart.c:291:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
ret = access(file, R_OK);
data/minidlna-1.2.1+dfsg/albumart.c:299:10: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
ret = access(file, R_OK);
data/minidlna-1.2.1+dfsg/albumart.c:308:11: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
ret = access(file, R_OK);
data/minidlna-1.2.1+dfsg/albumart.c:326:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if( access(file, R_OK) == 0 )
data/minidlna-1.2.1+dfsg/image_utils.c:379:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(*date, exif);
data/minidlna-1.2.1+dfsg/log.c:182:6: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
if (vfprintf(log_fp, fmt, ap) == -1)
data/minidlna-1.2.1+dfsg/metadata.c:143:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
ret = access(file, R_OK);
data/minidlna-1.2.1+dfsg/metadata.c:147:9: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
ret = access(file, R_OK);
data/minidlna-1.2.1+dfsg/metadata.c:1497:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(nfo, path);
data/minidlna-1.2.1+dfsg/metadata.c:1502:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if( access(nfo, F_OK) == 0 )
data/minidlna-1.2.1+dfsg/minidlna.c:243:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(serialnumber, mac_str);
data/minidlna-1.2.1+dfsg/minidlna.c:286:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(path, F_OK) != 0)
data/minidlna-1.2.1+dfsg/minidlna.c:366:7: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (system(cmd) != 0)
data/minidlna-1.2.1+dfsg/minidlna.c:558:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access(optionsfile, F_OK) == 0 || options_flag)
data/minidlna-1.2.1+dfsg/minidlna.c:605:17: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (word && (access(path, F_OK) != 0))
data/minidlna-1.2.1+dfsg/minidlna.c:628:17: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!path || access(path, F_OK) != 0)
data/minidlna-1.2.1+dfsg/minidlna.c:674:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(path, F_OK) != 0)
data/minidlna-1.2.1+dfsg/minidlna.c:683:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(path, F_OK) != 0)
data/minidlna-1.2.1+dfsg/minidlna.c:734:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(uuidvalue+5, ary_options[i].value);
data/minidlna-1.2.1+dfsg/minidlna.c:867:8: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (system(buf) != 0)
data/minidlna-1.2.1+dfsg/minidlna.c:961:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(db_path, F_OK) != 0)
data/minidlna-1.2.1+dfsg/minissdp.c:864:7: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
l = snprintf(strbuf, sizeof(strbuf), "http://%s:%u" ROOTDESC_PATH,
data/minidlna-1.2.1+dfsg/monitor.c:199:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access("/proc/sys/fs/inotify/max_user_watches", W_OK) == 0)
data/minidlna-1.2.1+dfsg/monitor.c:421:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(path_buf, path);
data/minidlna-1.2.1+dfsg/monitor.c:435:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(base_name, last_dir);
data/minidlna-1.2.1+dfsg/monitor.c:442:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(last_dir, parent_buf);
data/minidlna-1.2.1+dfsg/monitor.c:453:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(path_buf, path);
data/minidlna-1.2.1+dfsg/monitor.c:484:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if( access(path, R_OK|X_OK) != 0 )
data/minidlna-1.2.1+dfsg/scanner.c:178:4: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(last_date.parentID, IMAGE_DATE_ID"$%llX", (unsigned long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:192:4: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(last_cam.parentID, IMAGE_CAMERA_ID"$%llX", (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:205:4: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(last_camdate.parentID, "%s$%llX", last_cam.parentID, (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:259:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(last_album.parentID, MUSIC_ALBUM_ID"$%llX", (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:274:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(last_artist.parentID, MUSIC_ARTIST_ID"$%llX", (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:279:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(last_artistAlbumAll.parentID, "%s$%llX", last_artist.parentID, (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:295:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(last_artistAlbum.parentID, "%s$%llX", last_artist.parentID, (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:316:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(last_genre.parentID, MUSIC_GENRE_ID"$%llX", (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:320:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(last_genreArtistAll.parentID, "%s$%llX", last_genre.parentID, (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:335:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(last_genreArtist.parentID, "%s$%llX", last_genre.parentID, (long long)parentID);
data/minidlna-1.2.1+dfsg/scanner.c:411:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(last_found, id_buf);
data/minidlna-1.2.1+dfsg/scanner.c:464:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(base, IMAGE_DIR_ID);
data/minidlna-1.2.1+dfsg/scanner.c:470:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(base, VIDEO_DIR_ID);
data/minidlna-1.2.1+dfsg/scanner.c:483:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(base, MUSIC_DIR_ID);
data/minidlna-1.2.1+dfsg/scanner.c:493:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(objectID, "%s%s$%X", BROWSEDIR_ID, parentID, object);
data/minidlna-1.2.1+dfsg/scanner.c:799:30: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if( (type == TYPE_DIR) && (access(full_path, R_OK|X_OK) == 0) )
data/minidlna-1.2.1+dfsg/scanner.c:807:34: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
else if( type == TYPE_FILE && (access(full_path, R_OK) == 0) )
data/minidlna-1.2.1+dfsg/scanner.c:831:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(path, R_OK) != 0)
data/minidlna-1.2.1+dfsg/tagutils/tagutils.c:225:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(psong->contributor[ROLE_ARTIST], psong->contributor[ROLE_BAND]);
data/minidlna-1.2.1+dfsg/tagutils/tagutils.c:231:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(psong->contributor[ROLE_ARTIST], psong->contributor[ROLE_CONDUCTOR]);
data/minidlna-1.2.1+dfsg/tivo_beacon.c:263:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(scp, b->machine);
data/minidlna-1.2.1+dfsg/tivo_beacon.c:265:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(scp, buf);
data/minidlna-1.2.1+dfsg/tivo_commands.c:637:8: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
ret = sprintf(str_buf, "<?xml version='1.0' encoding='UTF-8' ?>\n"
data/minidlna-1.2.1+dfsg/upnpdescgen.c:476:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(eltname, "%s", element);
data/minidlna-1.2.1+dfsg/upnphttp.c:1569:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if( access(path, F_OK) != 0 )
data/minidlna-1.2.1+dfsg/upnphttp.c:1645:36: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if( !file_path || !resolution || (access(file_path, F_OK) != 0) )
data/minidlna-1.2.1+dfsg/upnpsoap.c:124:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp, errCode, errDesc);
data/minidlna-1.2.1+dfsg/upnpsoap.c:178:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/minidlna-1.2.1+dfsg/upnpsoap.c:202:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/minidlna-1.2.1+dfsg/upnpsoap.c:225:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/minidlna-1.2.1+dfsg/upnpsoap.c:271:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/minidlna-1.2.1+dfsg/upnpsoap.c:300:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/minidlna-1.2.1+dfsg/upnpsoap.c:319:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/minidlna-1.2.1+dfsg/upnpsoap.c:363:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/minidlna-1.2.1+dfsg/upnpsoap.c:1041:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(dlna_buf, "DLNA.ORG_PN=%s;DLNA.ORG_OP=01;DLNA.ORG_CI=1", "MPEG_PS_NTSC");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1053:8: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(dlna_buf, "DLNA.ORG_PN=%s;DLNA.ORG_OP=01;DLNA.ORG_CI=1", "MPEG_TS_SD_NA");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1059:8: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(dlna_buf, "DLNA.ORG_PN=%s;DLNA.ORG_OP=01;DLNA.ORG_CI=1", "MPEG_TS_SD_EU");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1074:8: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(dlna_buf, "DLNA.ORG_PN=%s;DLNA.ORG_OP=01;DLNA.ORG_CI=1", "MPEG_PS_NTSC");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1080:8: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(dlna_buf, "DLNA.ORG_PN=%s;DLNA.ORG_OP=01;DLNA.ORG_CI=1", "MPEG_PS_PAL");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1094:14: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(dlna_buf, "DLNA.ORG_PN=AVC_TS_HD_50_AC3%s", dlna_pn + 16);
data/minidlna-1.2.1+dfsg/upnpsoap.c:1294:12: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
str.off = sprintf(str.data, "%s", resp0);
data/minidlna-1.2.1+dfsg/upnpsoap.c:1770:12: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
str.off = sprintf(str.data, "%s", resp0);
data/minidlna-1.2.1+dfsg/upnpsoap.c:1909:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
bodylen = snprintf(body, sizeof(body), resp,
data/minidlna-1.2.1+dfsg/upnpsoap.c:2091:8: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = snprintf(body, sizeof(body), resp, audio, video, image);
data/minidlna-1.2.1+dfsg/utils.h:48:8: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
ret = vsnprintf(str->data + str->off, size, fmt, ap);
data/minidlna-1.2.1+dfsg/metadata.c:356:8: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if( !getenv("LANG") )
data/minidlna-1.2.1+dfsg/metadata.c:359:19: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
strncpyt(lang, getenv("LANG"), sizeof(lang));
data/minidlna-1.2.1+dfsg/minidlna.c:253:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
logname = getenv("USER");
data/minidlna-1.2.1+dfsg/minidlna.c:489:42: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
locale_dir = bindtextdomain("minidlna", getenv("TEXTDOMAINDIR"));
data/minidlna-1.2.1+dfsg/minidlna.c:627:11: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
path = realpath(path, buf);
data/minidlna-1.2.1+dfsg/minidlna.c:670:11: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
path = realpath(ary_options[i].value, buf);
data/minidlna-1.2.1+dfsg/minidlna.c:679:11: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
path = realpath(ary_options[i].value, buf);
data/minidlna-1.2.1+dfsg/minissdp.c:734:13: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
_usleep(random()>>20);
data/minidlna-1.2.1+dfsg/upnpevents.c:141:38: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
snprintf(tmp->uuid+37, 5, "%04lx", random() & 0xffff);
data/minidlna-1.2.1+dfsg/upnphttp.c:1350:10: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
path = realpath(orig_path, buf);
data/minidlna-1.2.1+dfsg/uuid.c:112:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(monotonic_us());
data/minidlna-1.2.1+dfsg/uuid.c:120:3: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(pid);
data/minidlna-1.2.1+dfsg/albumart.c:48:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(strchr(*cache_file, '\0')-4, ".jpg");
data/minidlna-1.2.1+dfsg/albumart.c:59:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cache_dir[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/albumart.c:99:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char file[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/albumart.c:100:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fpath[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/albumart.c:101:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dpath[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/albumart.c:172:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char last_path[PATH_MAX];
data/minidlna-1.2.1+dfsg/albumart.c:231:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dstfile = fopen(art_path, "w");
data/minidlna-1.2.1+dfsg/albumart.c:268:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char file[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/albumart.c:269:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mypath[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/albumart.c:298:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(p, ".jpg");
data/minidlna-1.2.1+dfsg/avahi.c:85:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[128+1];
data/minidlna-1.2.1+dfsg/avahi.c:86:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[64];
data/minidlna-1.2.1+dfsg/clients.c:316:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mac[6];
data/minidlna-1.2.1+dfsg/clients.h:98:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mac[6];
data/minidlna-1.2.1+dfsg/getifaddr.c:117:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8192];
data/minidlna-1.2.1+dfsg/getifaddr.c:153:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&lan_addr[n_lan_addr].mask, &addr.sin_addr, sizeof(addr));
data/minidlna-1.2.1+dfsg/getifaddr.c:174:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mac[6];
data/minidlna-1.2.1+dfsg/getifaddr.c:205:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mac, ifr.ifr_hwaddr.sa_data, 6);
data/minidlna-1.2.1+dfsg/getifaddr.c:209:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mac, LLADDR(sdl), sdl->sdl_alen);
data/minidlna-1.2.1+dfsg/getifaddr.c:248:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mac, ifr.ifr_addr.sa_data, 6);
data/minidlna-1.2.1+dfsg/getifaddr.c:252:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mac, ifr.ifr_hwaddr.sa_data, 6);
data/minidlna-1.2.1+dfsg/getifaddr.c:263:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "%02x%02x%02x%02x%02x%02x",
data/minidlna-1.2.1+dfsg/getifaddr.c:277:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char remote_ip[16];
data/minidlna-1.2.1+dfsg/getifaddr.c:281:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
arp = fopen("/proc/net/arp", "r");
data/minidlna-1.2.1+dfsg/getifaddr.c:316:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&old_addr[i], &lan_addr[i].addr, sizeof(struct in_addr));
data/minidlna-1.2.1+dfsg/getifaddr.c:384:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/minidlna-1.2.1+dfsg/image_utils.c:237:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[8];
data/minidlna-1.2.1+dfsg/image_utils.c:244:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
img = fopen(path, "r");
data/minidlna-1.2.1+dfsg/image_utils.c:275:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&h, buf+3, 2);
data/minidlna-1.2.1+dfsg/image_utils.c:277:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&w, buf+5, 2);
data/minidlna-1.2.1+dfsg/image_utils.c:288:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&offset, buf, 2);
data/minidlna-1.2.1+dfsg/image_utils.c:302:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[8];
data/minidlna-1.2.1+dfsg/image_utils.c:310:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
img = fopen(path, "r");
data/minidlna-1.2.1+dfsg/image_utils.c:339:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&offset, buf, 2);
data/minidlna-1.2.1+dfsg/image_utils.c:391:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&offset, buf, 2);
data/minidlna-1.2.1+dfsg/image_utils.c:428:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char *line[16], *ptr;
data/minidlna-1.2.1+dfsg/image_utils.c:438:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (file = fopen(path, "r")) == NULL )
data/minidlna-1.2.1+dfsg/image_utils.c:860:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dst_file = fopen(path, "w");
data/minidlna-1.2.1+dfsg/linux/inotify.h:23:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[0]; /* stub for possible name */
data/minidlna-1.2.1+dfsg/log.c:132:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(log_fp = fopen(log_filename, "a")))
data/minidlna-1.2.1+dfsg/log.c:147:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(log_fp = fopen(log_filename, "a")))
data/minidlna-1.2.1+dfsg/metadata.c:81:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[3*MPEG_TS_PACKET_LENGTH_DLNA];
data/minidlna-1.2.1+dfsg/metadata.c:85:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(filename, O_RDONLY);
data/minidlna-1.2.1+dfsg/metadata.c:121:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char file[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/metadata.c:142:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(p, ".srt");
data/minidlna-1.2.1+dfsg/metadata.c:146:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(p, ".smi");
data/minidlna-1.2.1+dfsg/metadata.c:179:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
nfo = fopen(path, "r");
data/minidlna-1.2.1+dfsg/metadata.c:292:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char type[4];
data/minidlna-1.2.1+dfsg/metadata.c:293:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char lang[6] = { '\0' };
data/minidlna-1.2.1+dfsg/metadata.c:309:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "mp3");
data/minidlna-1.2.1+dfsg/metadata.c:315:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "aac");
data/minidlna-1.2.1+dfsg/metadata.c:320:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "aac");
data/minidlna-1.2.1+dfsg/metadata.c:325:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "asf");
data/minidlna-1.2.1+dfsg/metadata.c:330:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "flc");
data/minidlna-1.2.1+dfsg/metadata.c:335:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "wav");
data/minidlna-1.2.1+dfsg/metadata.c:340:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "ogg");
data/minidlna-1.2.1+dfsg/metadata.c:345:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "pcm");
data/minidlna-1.2.1+dfsg/metadata.c:357:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(lang, "en_US");
data/minidlna-1.2.1+dfsg/metadata.c:506:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char make[32], model[64] = {'\0'};
data/minidlna-1.2.1+dfsg/metadata.c:507:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[1024];
data/minidlna-1.2.1+dfsg/metadata.c:610:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
infile = fopen(path, "r");
data/minidlna-1.2.1+dfsg/metadata.c:676:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fourcc[4];
data/minidlna-1.2.1+dfsg/metadata.c:678:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char nfo[MAXPATHLEN], *ext;
data/minidlna-1.2.1+dfsg/metadata.c:695:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char err[128];
data/minidlna-1.2.1+dfsg/metadata.c:747:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&data, lav_codec_extradata(astream), 1);
data/minidlna-1.2.1+dfsg/metadata.c:865:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off = sprintf(m.dlna_pn, "MPEG_");
data/minidlna-1.2.1+dfsg/metadata.c:872:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "TS_");
data/minidlna-1.2.1+dfsg/metadata.c:876:14: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HD_NA");
data/minidlna-1.2.1+dfsg/metadata.c:880:14: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "SD_");
data/minidlna-1.2.1+dfsg/metadata.c:883:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "EU");
data/minidlna-1.2.1+dfsg/metadata.c:885:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "NA");
data/minidlna-1.2.1+dfsg/metadata.c:906:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "_ISO");
data/minidlna-1.2.1+dfsg/metadata.c:909:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "_T");
data/minidlna-1.2.1+dfsg/metadata.c:920:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "PS_");
data/minidlna-1.2.1+dfsg/metadata.c:923:14: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "PAL");
data/minidlna-1.2.1+dfsg/metadata.c:925:14: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "NTSC");
data/minidlna-1.2.1+dfsg/metadata.c:938:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off = sprintf(m.dlna_pn, "AVC_");
data/minidlna-1.2.1+dfsg/metadata.c:947:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "TS_");
data/minidlna-1.2.1+dfsg/metadata.c:963:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HD_60_");
data/minidlna-1.2.1+dfsg/metadata.c:976:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HD_50_");
data/minidlna-1.2.1+dfsg/metadata.c:984:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BL_");
data/minidlna-1.2.1+dfsg/metadata.c:989:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "CIF15_");
data/minidlna-1.2.1+dfsg/metadata.c:996:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "CIF30_");
data/minidlna-1.2.1+dfsg/metadata.c:1004:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MP_");
data/minidlna-1.2.1+dfsg/metadata.c:1016:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "SD_");
data/minidlna-1.2.1+dfsg/metadata.c:1022:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HD_");
data/minidlna-1.2.1+dfsg/metadata.c:1034:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HP_");
data/minidlna-1.2.1+dfsg/metadata.c:1040:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HD_");
data/minidlna-1.2.1+dfsg/metadata.c:1058:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MPEG1_L3");
data/minidlna-1.2.1+dfsg/metadata.c:1061:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "AC3");
data/minidlna-1.2.1+dfsg/metadata.c:1065:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "AAC_MULT5");
data/minidlna-1.2.1+dfsg/metadata.c:1095:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "_ISO");
data/minidlna-1.2.1+dfsg/metadata.c:1098:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "_T");
data/minidlna-1.2.1+dfsg/metadata.c:1107:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MP4_");
data/minidlna-1.2.1+dfsg/metadata.c:1116:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BL_CIF15_");
data/minidlna-1.2.1+dfsg/metadata.c:1118:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BL_CIF30_");
data/minidlna-1.2.1+dfsg/metadata.c:1124:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "AMR");
data/minidlna-1.2.1+dfsg/metadata.c:1128:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "AAC_");
data/minidlna-1.2.1+dfsg/metadata.c:1131:17: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "520");
data/minidlna-1.2.1+dfsg/metadata.c:1135:17: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "940");
data/minidlna-1.2.1+dfsg/metadata.c:1155:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BL_L3L_SD_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1159:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BL_L31_HD_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1169:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BL_L31_HD_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1173:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BL_L32_HD_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1182:14: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MP_");
data/minidlna-1.2.1+dfsg/metadata.c:1188:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(m.dlna_pn+off, "SD_");
data/minidlna-1.2.1+dfsg/metadata.c:1190:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "AC3");
data/minidlna-1.2.1+dfsg/metadata.c:1193:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "AAC_MULT5");
data/minidlna-1.2.1+dfsg/metadata.c:1195:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MPEG1_L3");
data/minidlna-1.2.1+dfsg/metadata.c:1204:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HD_720p_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1211:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HD_1080i_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1227:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HP_HD_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1261:12: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off = sprintf(m.dlna_pn, "MPEG4_P2_");
data/minidlna-1.2.1+dfsg/metadata.c:1269:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "3GPP_SP_L0B_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1272:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "3GPP_SP_L0B_AMR");
data/minidlna-1.2.1+dfsg/metadata.c:1287:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MP4_ASP_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1294:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MP4_SP_VGA_AAC");
data/minidlna-1.2.1+dfsg/metadata.c:1324:11: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off = sprintf(m.dlna_pn, "WMV");
data/minidlna-1.2.1+dfsg/metadata.c:1331:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "SPLL_");
data/minidlna-1.2.1+dfsg/metadata.c:1335:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MP3");
data/minidlna-1.2.1+dfsg/metadata.c:1338:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BASE");
data/minidlna-1.2.1+dfsg/metadata.c:1353:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "SPML_");
data/minidlna-1.2.1+dfsg/metadata.c:1357:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MP3");
data/minidlna-1.2.1+dfsg/metadata.c:1360:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BASE");
data/minidlna-1.2.1+dfsg/metadata.c:1374:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "MED_");
data/minidlna-1.2.1+dfsg/metadata.c:1378:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "PRO");
data/minidlna-1.2.1+dfsg/metadata.c:1381:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "FULL");
data/minidlna-1.2.1+dfsg/metadata.c:1384:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "BASE");
data/minidlna-1.2.1+dfsg/metadata.c:1398:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "HIGH_");
data/minidlna-1.2.1+dfsg/metadata.c:1402:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "PRO");
data/minidlna-1.2.1+dfsg/metadata.c:1405:15: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
off += sprintf(m.dlna_pn+off, "FULL");
data/minidlna-1.2.1+dfsg/metadata.c:1493:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(m.mime, "video/x-tivo-mpeg");
data/minidlna-1.2.1+dfsg/metadata.c:1501:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(ext+1, "nfo");
data/minidlna-1.2.1+dfsg/minidlna.c:198:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hn[256];
data/minidlna-1.2.1+dfsg/minidlna.c:209:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "Unknown");
data/minidlna-1.2.1+dfsg/minidlna.c:215:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ibuf[64], *key, *val;
data/minidlna-1.2.1+dfsg/minidlna.c:217:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
info = fopen("/proc/sys/dev/boot/info", "r");
data/minidlna-1.2.1+dfsg/minidlna.c:241:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mac_str[13];
data/minidlna-1.2.1+dfsg/minidlna.c:270:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[PATH_MAX];
data/minidlna-1.2.1+dfsg/minidlna.c:282:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[PATH_MAX];
data/minidlna-1.2.1+dfsg/minidlna.c:308:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmd[PATH_MAX*2];
data/minidlna-1.2.1+dfsg/minidlna.c:406:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[PATH_MAX], *dir;
data/minidlna-1.2.1+dfsg/minidlna.c:440:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
pidfile = fopen(fname, "w");
data/minidlna-1.2.1+dfsg/minidlna.c:470:4: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
(atoi(str) == 1));
data/minidlna-1.2.1+dfsg/minidlna.c:514:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mac_str[13];
data/minidlna-1.2.1+dfsg/minidlna.c:517:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/minidlna-1.2.1+dfsg/minidlna.c:518:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char log_str[75] = "general,artwork,database,inotify,scanner,metadata,http,ssdp,tivo=warn";
data/minidlna-1.2.1+dfsg/minidlna.c:540:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mac_str, "554e4b4e4f57");
data/minidlna-1.2.1+dfsg/minidlna.c:542:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(uuidvalue+5, "4d696e69-444c-164e-9d41-");
data/minidlna-1.2.1+dfsg/minidlna.c:581:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
runtime_vars.port = atoi(ary_options[i].value);
data/minidlna-1.2.1+dfsg/minidlna.c:587:35: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
runtime_vars.notify_interval = atoi(ary_options[i].value);
data/minidlna-1.2.1+dfsg/minidlna.c:752:35: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
runtime_vars.max_connections = atoi(ary_options[i].value);
data/minidlna-1.2.1+dfsg/minidlna.c:794:36: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
runtime_vars.notify_interval = atoi(argv[++i]);
data/minidlna-1.2.1+dfsg/minidlna.c:812:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
runtime_vars.port = atoi(argv[++i]);
data/minidlna-1.2.1+dfsg/minidlna.c:936:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(log_str+65, "debug");
data/minidlna-1.2.1+dfsg/minidlna.c:947:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(log_str+65, "maxdebug");
data/minidlna-1.2.1+dfsg/minidlna.c:1154:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&lastnotifytime, &timeofday, sizeof(struct timeval));
data/minidlna-1.2.1+dfsg/minidlna.c:1177:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&lastbeacontime, &timeofday, sizeof(struct timeval));
data/minidlna-1.2.1+dfsg/minidlnatypes.h:41:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[16]; /* example: 192.168.0.1 */
data/minidlna-1.2.1+dfsg/minidlnatypes.h:53:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *ifaces[MAX_LAN_ADDR]; /* list of configured network interfaces */
data/minidlna-1.2.1+dfsg/minissdp.c:232:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[512];
data/minidlna-1.2.1+dfsg/minissdp.c:233:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmstr[30];
data/minidlna-1.2.1+dfsg/minissdp.c:279:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bufr[512];
data/minidlna-1.2.1+dfsg/minissdp.c:331:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8192];
data/minidlna-1.2.1+dfsg/minissdp.c:451:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (atoi(serial) < 20081201)
data/minidlna-1.2.1+dfsg/minissdp.c:496:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bufr[1500];
data/minidlna-1.2.1+dfsg/minissdp.c:503:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmbuf[CMSG_SPACE(sizeof(struct in_pktinfo))];
data/minidlna-1.2.1+dfsg/minissdp.c:664:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char host[40] = "127.0.0.1";
data/minidlna-1.2.1+dfsg/minissdp.c:777:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bufr[512];
data/minidlna-1.2.1+dfsg/minissdp.c:823:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[2048];
data/minidlna-1.2.1+dfsg/minissdp.c:824:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strbuf[256];
data/minidlna-1.2.1+dfsg/minissdp.c:851:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, known_service_types[i], l);
data/minidlna-1.2.1+dfsg/minissdp.c:858:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, strbuf, l);
data/minidlna-1.2.1+dfsg/minissdp.c:862:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, MINIDLNA_SERVER_STRING, l);
data/minidlna-1.2.1+dfsg/minissdp.c:867:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, strbuf, l);
data/minidlna-1.2.1+dfsg/monitor.c:102:22: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *max_watches = fopen("/proc/sys/fs/inotify/max_user_watches", "r+");
data/minidlna-1.2.1+dfsg/monitor.c:191:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
max_watches = fopen("/proc/sys/fs/inotify/max_user_watches", "r");
data/minidlna-1.2.1+dfsg/monitor.c:255:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sql[128];
data/minidlna-1.2.1+dfsg/monitor.c:256:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char art_cache[PATH_MAX];
data/minidlna-1.2.1+dfsg/monitor.c:299:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(strrchr(result[i], '$') + 1));
data/minidlna-1.2.1+dfsg/monitor.c:333:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char file[PATH_MAX];
data/minidlna-1.2.1+dfsg/monitor.c:352:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char video[PATH_MAX];
data/minidlna-1.2.1+dfsg/monitor.c:479:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path_buf[PATH_MAX];
data/minidlna-1.2.1+dfsg/monitor.c:608:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[BUF_LEN];
data/minidlna-1.2.1+dfsg/monitor.c:609:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path_buf[PATH_MAX];
data/minidlna-1.2.1+dfsg/options.c:76:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/minidlna-1.2.1+dfsg/options.c:94:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(!(hfile = fopen(fname, "r")))
data/minidlna-1.2.1+dfsg/options.h:80:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char value[MAX_OPTION_VALUE_LEN];
data/minidlna-1.2.1+dfsg/playlist.c:46:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char type[4];
data/minidlna-1.2.1+dfsg/playlist.c:95:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dir[PATH_MAX], *base;
data/minidlna-1.2.1+dfsg/playlist.c:125:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char type[4];
data/minidlna-1.2.1+dfsg/process.c:153:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
i = open("/dev/null",O_RDWR); /* open stdin */
data/minidlna-1.2.1+dfsg/process.c:176:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[64];
data/minidlna-1.2.1+dfsg/process.c:183:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if( (pidfile = open(fname, O_RDONLY)) < 0)
data/minidlna-1.2.1+dfsg/process.c:190:14: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if( (pid = atol(buffer)) > 0)
data/minidlna-1.2.1+dfsg/scanner.c:65:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char parentID[64];
data/minidlna-1.2.1+dfsg/scanner.c:66:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[256];
data/minidlna-1.2.1+dfsg/scanner.c:142:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sql[128];
data/minidlna-1.2.1+dfsg/scanner.c:392:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char last_found[256] = "-1";
data/minidlna-1.2.1+dfsg/scanner.c:397:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char id_buf[64], parent_buf[64], refID[64];
data/minidlna-1.2.1+dfsg/scanner.c:452:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char objectID[64];
data/minidlna-1.2.1+dfsg/scanner.c:454:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char base[8];
data/minidlna-1.2.1+dfsg/scanner.c:876:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[MAXPATHLEN], buf[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/scanner.c:897:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[MAXPATHLEN];
data/minidlna-1.2.1+dfsg/scanner.c:913:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8];
data/minidlna-1.2.1+dfsg/scanner.c:921:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "$%X", startID);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:34:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char atom[4];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:72:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char current_atom[4];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:77:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(!(fin = fopen(file, "rb")))
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:132:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->year = atoi((char*)¤t_data[16]);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:160:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(psong->image, current_data+16, psong->image_size);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:186:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char atom_name[5];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:240:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[3];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:270:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[2];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:276:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
infile = fopen(file, "rb");
data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.c:375:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char data[2048];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.c:440:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.c:529:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2048];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.c:534:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(!(fp = fopen(file, "rb")))
data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.c:631:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->track = atoi(buf);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.c:643:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->year = atoi(buf);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-asf.c:665:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->track = atoi(buf);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-flc.c:87:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(psong->image, block->data.picture.data, psong->image_size);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:82:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *cpnames[N_LANG_ALT];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:187:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strbuf[1024];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:240:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->track = atoi(strbuf + 12);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:244:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->disc = atoi(strbuf + 11);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:260:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->year = atoi(strbuf + 5 + 6);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:266:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->year = atoi(strbuf + 5);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:88:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(psong->image, image, image_size);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:160:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
genre = atoi(psong->genre);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:165:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
genre = atoi((char*)&psong->genre[1]);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:189:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->total_discs = atoi(tmp);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:191:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->disc = atoi((char*)utf8_text);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:199:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->total_tracks = atoi(tmp);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:201:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->track = atoi((char*)utf8_text);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:205:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->year = atoi((char*)utf8_text);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:209:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->song_length = atoi((char*)utf8_text);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:213:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->bpm = atoi((char*)utf8_text);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:217:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->compilation = (char)atoi((char*)utf8_text);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:403:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char frame_buffer[2900];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:404:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char header[4];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:485:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char frame_buffer[4];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:552:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[1024];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:559:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char frame_buffer[4];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:561:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char id3v1taghdr[4];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:563:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(!(infile = fopen(file, "rb")))
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:596:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tagversion[16];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-ogg.c:423:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *file = fopen(filename, "rb");
data/minidlna-1.2.1+dfsg/tagutils/tagutils-plist.c:60:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(!(fp = fopen(path, "rb")))
data/minidlna-1.2.1+dfsg/tagutils/tagutils-plist.c:94:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAX_BUF], *p;
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:37:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char hdr[12];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:38:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char fmt[16];
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:54:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if(!(fd = open(filename, O_RDONLY)))
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:193:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->track = atoi(p + 8);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:196:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
psong->year = atoi(p + 8);
data/minidlna-1.2.1+dfsg/tagutils/tagutils.c:52:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char id[3];
data/minidlna-1.2.1+dfsg/tagutils/tagutils.c:53:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char version[2];
data/minidlna-1.2.1+dfsg/tagutils/tagutils.c:55:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char size[4];
data/minidlna-1.2.1+dfsg/tagutils/tagutils.c:228:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(psong->contributor[ROLE_ARTIST], " - ");
data/minidlna-1.2.1+dfsg/tagutils/tagutils.h:63:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *contributor[N_ROLE]; // TPE1 (artist)
data/minidlna-1.2.1+dfsg/tagutils/tagutils.h:67:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *contributor_sort[N_ROLE];
data/minidlna-1.2.1+dfsg/tivo_beacon.c:155:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[512];
data/minidlna-1.2.1+dfsg/tivo_beacon.c:220:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/minidlna-1.2.1+dfsg/tivo_beacon.c:260:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy( scp, "Known servers: " );
data/minidlna-1.2.1+dfsg/tivo_beacon.c:264:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "(%ld)", current - b->lastSeen);
data/minidlna-1.2.1+dfsg/tivo_beacon.c:297:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char bufr[1500];
data/minidlna-1.2.1+dfsg/tivo_commands.c:225:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(strrchr(duration, '.')+1) + (1000*atoi(strrchr(duration, ':')+1))
data/minidlna-1.2.1+dfsg/tivo_commands.c:225:49: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(strrchr(duration, '.')+1) + (1000*atoi(strrchr(duration, ':')+1))
data/minidlna-1.2.1+dfsg/tivo_commands.c:226:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
+ (60000*atoi(strrchr(duration, ':')-2)) + (3600000*atoi(duration)));
data/minidlna-1.2.1+dfsg/tivo_commands.c:226:62: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
+ (60000*atoi(strrchr(duration, ':')-2)) + (3600000*atoi(duration)));
data/minidlna-1.2.1+dfsg/tivo_commands.c:302:12: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
str.off = sprintf(str.data, "<?xml version='1.0' encoding='UTF-8' ?>\n<TiVoItem>");
data/minidlna-1.2.1+dfsg/tivo_commands.c:332:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char what[10], order[96]={0}, order2[96]={0}, myfilter[256]={0};
data/minidlna-1.2.1+dfsg/tivo_commands.c:333:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str_buf[1024];
data/minidlna-1.2.1+dfsg/tivo_commands.c:334:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char type[8];
data/minidlna-1.2.1+dfsg/tivo_commands.c:335:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char groupBy[19] = {0};
data/minidlna-1.2.1+dfsg/tivo_commands.c:360:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "music");
data/minidlna-1.2.1+dfsg/tivo_commands.c:363:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "videos");
data/minidlna-1.2.1+dfsg/tivo_commands.c:366:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "photos");
data/minidlna-1.2.1+dfsg/tivo_commands.c:369:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(type, "server");
data/minidlna-1.2.1+dfsg/tivo_commands.c:406:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(groupBy, "group by DETAIL_ID");
data/minidlna-1.2.1+dfsg/tivo_commands.c:417:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(order, "tivorandom(%lu)", randomSeed);
data/minidlna-1.2.1+dfsg/tivo_commands.c:419:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(order2, "tivorandom(%lu) DESC", randomSeed);
data/minidlna-1.2.1+dfsg/tivo_commands.c:421:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(order2, "tivorandom(%lu)", randomSeed);
data/minidlna-1.2.1+dfsg/tivo_commands.c:437:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, "CLASS");
data/minidlna-1.2.1+dfsg/tivo_commands.c:438:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "CLASS");
data/minidlna-1.2.1+dfsg/tivo_commands.c:447:8: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, "DISC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:448:8: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "DISC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:453:8: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, "TRACK");
data/minidlna-1.2.1+dfsg/tivo_commands.c:454:8: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "TRACK");
data/minidlna-1.2.1+dfsg/tivo_commands.c:460:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, "TITLE");
data/minidlna-1.2.1+dfsg/tivo_commands.c:461:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "TITLE");
data/minidlna-1.2.1+dfsg/tivo_commands.c:468:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, "DATE");
data/minidlna-1.2.1+dfsg/tivo_commands.c:469:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "DATE");
data/minidlna-1.2.1+dfsg/tivo_commands.c:479:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, " DESC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:481:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, " DESC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:483:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, " ASC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:487:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, " ASC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:489:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, " ASC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:491:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, " DESC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:493:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, ", ");
data/minidlna-1.2.1+dfsg/tivo_commands.c:494:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, ", ");
data/minidlna-1.2.1+dfsg/tivo_commands.c:501:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, "TITLE ASC, ");
data/minidlna-1.2.1+dfsg/tivo_commands.c:503:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "TITLE ASC, ");
data/minidlna-1.2.1+dfsg/tivo_commands.c:505:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "TITLE DESC, ");
data/minidlna-1.2.1+dfsg/tivo_commands.c:507:4: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order, "DETAIL_ID ASC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:509:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "DETAIL_ID ASC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:511:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(order2, "DETAIL_ID DESC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:516:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(order, "CLASS, NAME, DETAIL_ID");
data/minidlna-1.2.1+dfsg/tivo_commands.c:518:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(order2, "CLASS DESC, NAME DESC, DETAIL_ID DESC");
data/minidlna-1.2.1+dfsg/tivo_commands.c:520:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(order2, "CLASS, NAME, DETAIL_ID");
data/minidlna-1.2.1+dfsg/tivo_commands.c:530:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(myfilter, " or ");
data/minidlna-1.2.1+dfsg/tivo_commands.c:535:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(myfilter, "CLASS glob 'container*'");
data/minidlna-1.2.1+dfsg/tivo_commands.c:539:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(myfilter, "MIME = 'image/jpeg'");
data/minidlna-1.2.1+dfsg/tivo_commands.c:543:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(myfilter, "MIME = 'audio/mpeg'");
data/minidlna-1.2.1+dfsg/tivo_commands.c:547:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(myfilter, "MIME in ('video/mpeg', 'video/x-tivo-mpeg', 'video/x-tivo-mpeg-ts')");
data/minidlna-1.2.1+dfsg/tivo_commands.c:564:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(myfilter, "MIME in ('image/jpeg', 'audio/mpeg', 'video/mpeg', 'video/x-tivo-mpeg', 'video/x-tivo-mpeg-ts') or CLASS glob 'container*'");
data/minidlna-1.2.1+dfsg/tivo_commands.c:571:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(what, "OBJECT_ID");
data/minidlna-1.2.1+dfsg/tivo_commands.c:578:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(what, "DETAIL_ID");
data/minidlna-1.2.1+dfsg/tivo_commands.c:649:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str.data, &str_buf, ret);
data/minidlna-1.2.1+dfsg/tivo_commands.c:696:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
itemStart = atoi(val);
data/minidlna-1.2.1+dfsg/tivo_commands.c:700:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
itemCount = atoi(val);
data/minidlna-1.2.1+dfsg/tivo_commands.c:708:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
anchorOffset = atoi(val);
data/minidlna-1.2.1+dfsg/tivo_utils.c:54:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hexstr[3];
data/minidlna-1.2.1+dfsg/tivo_utils.c:99:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char k[256];
data/minidlna-1.2.1+dfsg/tivo_utils.c:103:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&k, &seed, 4);
data/minidlna-1.2.1+dfsg/tivo_utils.c:150:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[5];
data/minidlna-1.2.1+dfsg/tivo_utils.c:151:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char hdr[5] = { 'T','i','V','o','\0' };
data/minidlna-1.2.1+dfsg/tivo_utils.c:155:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(path, O_RDONLY);
data/minidlna-1.2.1+dfsg/tivo_utils.h:32:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char s[256]; /* State variables */
data/minidlna-1.2.1+dfsg/upnpdescgen.c:413:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str + *len, s2, s2len + 1);
data/minidlna-1.2.1+dfsg/upnpdescgen.c:452:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char element[64];
data/minidlna-1.2.1+dfsg/upnpdescgen.c:544:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, xmlver, *len + 1);
data/minidlna-1.2.1+dfsg/upnpdescgen.c:561:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, xmlver, *len + 1);
data/minidlna-1.2.1+dfsg/upnpdescgen.c:563:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&samsungRootDesc, &rootDesc, sizeof(rootDesc));
data/minidlna-1.2.1+dfsg/upnpdescgen.c:592:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(str, xmlver, *len + 1);
data/minidlna-1.2.1+dfsg/upnpdescgen.c:707:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[512];
data/minidlna-1.2.1+dfsg/upnpevents.c:80:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char uuid[42];
data/minidlna-1.2.1+dfsg/upnpevents.c:99:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addrstr[16];
data/minidlna-1.2.1+dfsg/upnpevents.c:100:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char portstr[8];
data/minidlna-1.2.1+dfsg/upnpevents.c:134:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmp->callback, callback, callbacklen);
data/minidlna-1.2.1+dfsg/upnpevents.c:289:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = (unsigned short)atoi(p);
data/minidlna-1.2.1+dfsg/upnpglobalvars.c:66:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char modelname[MODELNAME_MAX_LEN] = ROOTDEV_MODELNAME;
data/minidlna-1.2.1+dfsg/upnpglobalvars.c:67:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char modelnumber[MODELNUMBER_MAX_LEN] = MINIDLNA_VERSION;
data/minidlna-1.2.1+dfsg/upnpglobalvars.c:68:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char serialnumber[SERIALNUMBER_MAX_LEN] = "00000000";
data/minidlna-1.2.1+dfsg/upnpglobalvars.c:72:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char presentationurl[PRESENTATIONURL_MAX_LEN];
data/minidlna-1.2.1+dfsg/upnpglobalvars.c:83:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char friendly_name[FRIENDLYNAME_MAX_LEN];
data/minidlna-1.2.1+dfsg/upnpglobalvars.c:84:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char db_path[PATH_MAX] = {'\0'};
data/minidlna-1.2.1+dfsg/upnpglobalvars.c:85:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char log_path[PATH_MAX] = {'\0'};
data/minidlna-1.2.1+dfsg/upnphttp.c:164:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
h->req_contentlen = atoi(p);
data/minidlna-1.2.1+dfsg/upnphttp.c:246:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
h->req_Timeout = atoi(p+7);
data/minidlna-1.2.1+dfsg/upnphttp.c:593:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[128];
data/minidlna-1.2.1+dfsg/upnphttp.c:610:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[4096];
data/minidlna-1.2.1+dfsg/upnphttp.c:817:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char HttpCommand[16];
data/minidlna-1.2.1+dfsg/upnphttp.c:818:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char HttpUrl[512];
data/minidlna-1.2.1+dfsg/upnphttp.c:925:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char model_sav[2];
data/minidlna-1.2.1+dfsg/upnphttp.c:927:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(model_sav, modelnumber, 2);
data/minidlna-1.2.1+dfsg/upnphttp.c:937:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(modelnumber, model_sav, 2);
data/minidlna-1.2.1+dfsg/upnphttp.c:1046:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2048];
data/minidlna-1.2.1+dfsg/upnphttp.c:1084:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->req_buf + h->req_buflen, buf, n);
data/minidlna-1.2.1+dfsg/upnphttp.c:1121:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->req_buf + h->req_buflen, buf, n);
data/minidlna-1.2.1+dfsg/upnphttp.c:1158:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char date[30];
data/minidlna-1.2.1+dfsg/upnphttp.c:1210:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->res_buf + h->res_buflen, body, bodylen);
data/minidlna-1.2.1+dfsg/upnphttp.c:1324:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char date[30];
data/minidlna-1.2.1+dfsg/upnphttp.c:1344:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PATH_MAX];
data/minidlna-1.2.1+dfsg/upnphttp.c:1373:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(path, O_RDONLY);
data/minidlna-1.2.1+dfsg/upnphttp.c:1383:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[512];
data/minidlna-1.2.1+dfsg/upnphttp.c:1384:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mime[12] = "image/";
data/minidlna-1.2.1+dfsg/upnphttp.c:1394:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "png");
data/minidlna-1.2.1+dfsg/upnphttp.c:1401:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "png");
data/minidlna-1.2.1+dfsg/upnphttp.c:1408:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "jpeg");
data/minidlna-1.2.1+dfsg/upnphttp.c:1415:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "jpeg");
data/minidlna-1.2.1+dfsg/upnphttp.c:1440:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[512];
data/minidlna-1.2.1+dfsg/upnphttp.c:1497:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[512];
data/minidlna-1.2.1+dfsg/upnphttp.c:1545:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[512];
data/minidlna-1.2.1+dfsg/upnphttp.c:1610:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[512];
data/minidlna-1.2.1+dfsg/upnphttp.c:1611:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/minidlna-1.2.1+dfsg/upnphttp.c:1614:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dlna_pn[22];
data/minidlna-1.2.1+dfsg/upnphttp.c:1643:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rotate = result[5] ? atoi(result[5]) : 0;
data/minidlna-1.2.1+dfsg/upnphttp.c:1666:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
width = atoi(val);
data/minidlna-1.2.1+dfsg/upnphttp.c:1670:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
height = atoi(val);
data/minidlna-1.2.1+dfsg/upnphttp.c:1674:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rotate = (rotate + atoi(val)) % 360;
data/minidlna-1.2.1+dfsg/upnphttp.c:1746:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(dlna_pn, "DLNA.ORG_PN=JPEG_TN;");
data/minidlna-1.2.1+dfsg/upnphttp.c:1748:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(dlna_pn, "DLNA.ORG_PN=JPEG_SM;");
data/minidlna-1.2.1+dfsg/upnphttp.c:1750:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(dlna_pn, "DLNA.ORG_PN=JPEG_MED;");
data/minidlna-1.2.1+dfsg/upnphttp.c:1752:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(dlna_pn, "DLNA.ORG_PN=JPEG_LRG;");
data/minidlna-1.2.1+dfsg/upnphttp.c:1813:10: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
ret = sprintf(buf, "%x\r\n", size);
data/minidlna-1.2.1+dfsg/upnphttp.c:1840:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[1024];
data/minidlna-1.2.1+dfsg/upnphttp.c:1842:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/minidlna-1.2.1+dfsg/upnphttp.c:1854:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[PATH_MAX];
data/minidlna-1.2.1+dfsg/upnphttp.c:1855:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mime[32];
data/minidlna-1.2.1+dfsg/upnphttp.c:1856:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dlna[96];
data/minidlna-1.2.1+dfsg/upnphttp.c:1907:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(last_file.mime+8, "mkv");
data/minidlna-1.2.1+dfsg/upnphttp.c:1912:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(last_file.mime+6, "mpeg");
data/minidlna-1.2.1+dfsg/upnphttp.c:1919:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(last_file.mime+6, "divx");
data/minidlna-1.2.1+dfsg/upnphttp.h:82:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char HttpVer[16];
data/minidlna-1.2.1+dfsg/upnpreplyparse.c:42:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data->curelt, name, l);
data/minidlna-1.2.1+dfsg/upnpreplyparse.c:50:9: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(nv->name, "rootElement");
data/minidlna-1.2.1+dfsg/upnpreplyparse.c:51:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(nv->value, name, l);
data/minidlna-1.2.1+dfsg/upnpreplyparse.c:67:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(nv->value, datas, l);
data/minidlna-1.2.1+dfsg/upnpreplyparse.h:41:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[64];
data/minidlna-1.2.1+dfsg/upnpreplyparse.h:47:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char curelt[64];
data/minidlna-1.2.1+dfsg/upnpsoap.c:120:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[2048];
data/minidlna-1.2.1+dfsg/upnpsoap.c:153:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->res_buf + h->res_buflen, beforebody, sizeof(beforebody) - 1);
data/minidlna-1.2.1+dfsg/upnpsoap.c:156:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->res_buf + h->res_buflen, body, bodylen);
data/minidlna-1.2.1+dfsg/upnpsoap.c:159:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(h->res_buf + h->res_buflen, afterbody, sizeof(afterbody) - 1);
data/minidlna-1.2.1+dfsg/upnpsoap.c:175:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/minidlna-1.2.1+dfsg/upnpsoap.c:193:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/minidlna-1.2.1+dfsg/upnpsoap.c:222:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/minidlna-1.2.1+dfsg/upnpsoap.c:268:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/minidlna-1.2.1+dfsg/upnpsoap.c:297:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/minidlna-1.2.1+dfsg/upnpsoap.c:316:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/minidlna-1.2.1+dfsg/upnpsoap.c:341:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[sizeof(resp)+128];
data/minidlna-1.2.1+dfsg/upnpsoap.c:724:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int br = atoi(bitrate);
data/minidlna-1.2.1+dfsg/upnpsoap.c:786:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
#define NON_ZERO(x) (x && atoi(x))
data/minidlna-1.2.1+dfsg/upnpsoap.c:787:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
#define IS_ZERO(x) (!x || !atoi(x))
data/minidlna-1.2.1+dfsg/upnpsoap.c:797:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dlna_buf[128];
data/minidlna-1.2.1+dfsg/upnpsoap.c:846:7: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "divx");
data/minidlna-1.2.1+dfsg/upnpsoap.c:848:7: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "avi");
data/minidlna-1.2.1+dfsg/upnpsoap.c:855:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "avi");
data/minidlna-1.2.1+dfsg/upnpsoap.c:863:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "mp2t");
data/minidlna-1.2.1+dfsg/upnpsoap.c:870:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "mpeg");
data/minidlna-1.2.1+dfsg/upnpsoap.c:884:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+8, "mkv");
data/minidlna-1.2.1+dfsg/upnpsoap.c:920:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "flac");
data/minidlna-1.2.1+dfsg/upnpsoap.c:927:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "wav");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1071:7: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(mime+6, "avi");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1249:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char where[256] = "";
data/minidlna-1.2.1+dfsg/upnpsoap.c:1266:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
RequestedCount = atoi(ptr);
data/minidlna-1.2.1+dfsg/upnpsoap.c:1275:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
StartingIndex = atoi(ptr);
data/minidlna-1.2.1+dfsg/upnpsoap.c:1754:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
RequestedCount = atoi(ptr);
data/minidlna-1.2.1+dfsg/upnpsoap.c:1758:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
StartingIndex = atoi(ptr);
data/minidlna-1.2.1+dfsg/upnpsoap.c:1891:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[512];
data/minidlna-1.2.1+dfsg/upnpsoap.c:1933:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char x[3] = { str[1], str[2], '\0' };
data/minidlna-1.2.1+dfsg/upnpsoap.c:1956:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return atoi(str);
data/minidlna-1.2.1+dfsg/upnpsoap.c:1974:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tag[32], current[32], new[32];
data/minidlna-1.2.1+dfsg/upnpsoap.c:2014:8: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (atoi(new))
data/minidlna-1.2.1+dfsg/upnpsoap.c:2066:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[1024];
data/minidlna-1.2.1+dfsg/upnpsoap.c:2115:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int sec = atoi(PosSecond);
data/minidlna-1.2.1+dfsg/utils.c:185:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, after, newlen);
data/minidlna-1.2.1+dfsg/utils.c:487:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str_buf[PATH_MAX];
data/minidlna-1.2.1+dfsg/uuid.c:81:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
boot_id = fopen("/proc/sys/kernel/random/boot_id", "r");
data/minidlna-1.2.1+dfsg/uuid.c:102:6: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
i = open("/dev/urandom", O_RDONLY);
data/minidlna-1.2.1+dfsg/uuid.c:128:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[4];
data/minidlna-1.2.1+dfsg/uuid.c:137:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
generate_uuid(unsigned char uuid_out[16])
data/minidlna-1.2.1+dfsg/uuid.c:141:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char last_node[6] = { 0, 0, 0, 0, 0, 0 };
data/minidlna-1.2.1+dfsg/uuid.c:147:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char mac[6];
data/minidlna-1.2.1+dfsg/uuid.c:157:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&uuid_out[10], mac, ETH_ALEN);
data/minidlna-1.2.1+dfsg/uuid.c:173:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(last_node, uuid_out+10, 6);
data/minidlna-1.2.1+dfsg/uuid.c:244:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char uuid[16];
data/minidlna-1.2.1+dfsg/uuid.c:249:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x",
data/minidlna-1.2.1+dfsg/albumart.c:116:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ncmp = strlen(match)-10;
data/minidlna-1.2.1+dfsg/containers.c:140:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(magic_containers[i].objectid_match);
data/minidlna-1.2.1+dfsg/getifaddr.c:200:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(ifr.ifr_name, p->ifa_name, IFNAMSIZ);
data/minidlna-1.2.1+dfsg/getifaddr.c:286:13: [1] (buffer) fscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
matches = fscanf(arp, "%15s 0x%8X 0x%8X %2hhx:%2hhx:%2hhx:%2hhx:%2hhx:%2hhx",
data/minidlna-1.2.1+dfsg/image_utils.c:378:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*date = realloc(*date, strlen(exif)+1);
data/minidlna-1.2.1+dfsg/log.c:77:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int level, c = (start != NULL) ? start - str : strlen(str);
data/minidlna-1.2.1+dfsg/metadata.c:88:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
i = read(fd, buffer, MPEG_TS_PACKET_LENGTH_DLNA*3);
data/minidlna-1.2.1+dfsg/metadata.c:395:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(m.creator) > 48 )
data/minidlna-1.2.1+dfsg/metadata.c:421:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(m.artist) > 48 )
data/minidlna-1.2.1+dfsg/metadata.c:534:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(m.date) > 10 )
data/minidlna-1.2.1+dfsg/metadata.c:1213:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(m.dlna_pn) <= 11 )
data/minidlna-1.2.1+dfsg/minidlna.c:211:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
off = strlen(buf);
data/minidlna-1.2.1+dfsg/minidlna.c:245:6: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(serialnumber, "0");
data/minidlna-1.2.1+dfsg/minidlna.c:543:2: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(uuidvalue, mac_str, 12);
data/minidlna-1.2.1+dfsg/minidlna.c:651:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(word);
data/minidlna-1.2.1+dfsg/minidlna.c:981:3: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(presentationurl, "/");
data/minidlna-1.2.1+dfsg/minissdp.c:383:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((n = read(s, buf+nread, sizeof(buf)-nread-1)) > 0)
data/minidlna-1.2.1+dfsg/minissdp.c:709:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(known_service_types[i]);
data/minidlna-1.2.1+dfsg/minissdp.c:745:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(known_service_types[i]);
data/minidlna-1.2.1+dfsg/minissdp.c:847:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(known_service_types[i]);
data/minidlna-1.2.1+dfsg/minissdp.c:860:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
l = strlen(MINIDLNA_SERVER_STRING);
data/minidlna-1.2.1+dfsg/monitor.c:296:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strncmp(result[i], MUSIC_PLIST_ID, strlen(MUSIC_PLIST_ID)) == 0 )
data/minidlna-1.2.1+dfsg/monitor.c:412:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(path)+1;
data/minidlna-1.2.1+dfsg/monitor.c:667:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
length = read(pollfds[0].fd, buffer, BUF_LEN);
data/minidlna-1.2.1+dfsg/playlist.c:98:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dir, path, sizeof(dir));
data/minidlna-1.2.1+dfsg/playlist.c:203:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(fname) + strlen(plpath) + 2;
data/minidlna-1.2.1+dfsg/playlist.c:203:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(fname) + strlen(plpath) + 2;
data/minidlna-1.2.1+dfsg/process.c:157:4: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(027);
data/minidlna-1.2.1+dfsg/process.c:188:5: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(read(pidfile, buffer, 63) > 0)
data/minidlna-1.2.1+dfsg/sql.c:249:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(str, (char *)sqlite3_column_text(stmt, 0), len + 1);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-aac.c:206:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(atom_name, cur_p, 4);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:137:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
rc = do_iconv(iconv_map[i].cpnames[0], "UTF-8", in8, strlen(in8), iconv_buf, MAX_ICONV_BUF);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:146:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
rc = do_iconv("UTF-8", iconv_map[i].cpnames[0], in, strlen(in), iconv_buf, MAX_ICONV_BUF);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:156:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
rc = do_iconv("UTF-8", iconv_map[i].cpnames[n], in, strlen(in), iconv_buf, MAX_ICONV_BUF);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-misc.c:202:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(strbuf, comment, length);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-mp3.c:153:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!strlen(psong->genre))
data/minidlna-1.2.1+dfsg/tagutils/tagutils-plist.c:153:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(p);
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:61:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(!(len = read(fd, hdr, len)) || (len != 12))
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:85:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(!(len = read(fd, hdr, len)) || (len != 8))
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:114:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(read(fd, fmt, len) != len)
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:155:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(read(fd, tags, len) < len ||
data/minidlna-1.2.1+dfsg/tagutils/tagutils-wav.c:200:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(*m, p + 8, taglen);
data/minidlna-1.2.1+dfsg/tagutils/tagutils.c:215:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(psong->contributor[ROLE_BAND]);
data/minidlna-1.2.1+dfsg/tagutils/tagutils.c:217:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(psong->contributor[ROLE_CONDUCTOR]);
data/minidlna-1.2.1+dfsg/testupnpdescgen.c:46:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(buf, "1.2.3.4", len);
data/minidlna-1.2.1+dfsg/tivo_beacon.c:257:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(b->machine) + 32;
data/minidlna-1.2.1+dfsg/tivo_beacon.c:267:5: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(scp, ",");
data/minidlna-1.2.1+dfsg/tivo_beacon.c:269:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(scp, "\n");
data/minidlna-1.2.1+dfsg/tivo_commands.c:373:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(objectID) == 1 )
data/minidlna-1.2.1+dfsg/tivo_commands.c:554:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret = strlen(myfilter);
data/minidlna-1.2.1+dfsg/tivo_utils.c:36:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int alloc = (int)strlen(string)+1;
data/minidlna-1.2.1+dfsg/tivo_utils.c:158:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if( read(fd, buf, 5) < 5 )
data/minidlna-1.2.1+dfsg/upnpdescgen.c:393:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s2len = (int)strlen(s2);
data/minidlna-1.2.1+dfsg/upnpdescgen.c:543:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
* len = strlen(xmlver);
data/minidlna-1.2.1+dfsg/upnpdescgen.c:560:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
* len = strlen(xmlver);
data/minidlna-1.2.1+dfsg/upnpdescgen.c:591:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*len = strlen(xmlver);
data/minidlna-1.2.1+dfsg/upnphttp.c:765:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
h->req_SIDLen = strlen(sid);
data/minidlna-1.2.1+dfsg/upnphttp.c:928:5: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(modelnumber, "1");
data/minidlna-1.2.1+dfsg/upnphttp.c:931:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen(friendly_name);
data/minidlna-1.2.1+dfsg/upnphttp.c:1300:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ret = read(sendfd, buf, send_size);
data/minidlna-1.2.1+dfsg/upnphttp.c:1360:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(path, media_path->path, strlen(media_path->path)) == 0)
data/minidlna-1.2.1+dfsg/upnphttp.c:1363:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!media_path && strncmp(path, db_path, strlen(db_path)))
data/minidlna-1.2.1+dfsg/upnphttp.c:1899:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(last_file.path, result[3], sizeof(last_file.path)-1);
data/minidlna-1.2.1+dfsg/upnphttp.c:1902:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(last_file.mime, result[4], sizeof(last_file.mime)-1);
data/minidlna-1.2.1+dfsg/upnpreplyparse.c:65:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(nv->name, data->curelt, 64);
data/minidlna-1.2.1+dfsg/upnpsoap.c:418:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( !filter || (strlen(filter) <= 1) ) {
data/minidlna-1.2.1+dfsg/upnpsoap.c:652:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret = strlen(order);
data/minidlna-1.2.1+dfsg/upnpsoap.c:899:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(title) > 23 )
data/minidlna-1.2.1+dfsg/upnpsoap.c:949:4: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(dlna_buf, "*");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1001:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strncmp(id, MUSIC_PLIST_ID, strlen(MUSIC_PLIST_ID)) == 0 ) {
data/minidlna-1.2.1+dfsg/upnpsoap.c:1379:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strncmp(ObjectID, MUSIC_PLIST_ID, strlen(MUSIC_PLIST_ID)) == 0 )
data/minidlna-1.2.1+dfsg/upnpsoap.c:1471:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(str) + 32;
data/minidlna-1.2.1+dfsg/upnpsoap.c:1597:6: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(sep, "*");
data/minidlna-1.2.1+dfsg/upnpsoap.c:1935:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memmove(str, str+2, strlen(str+1));
data/minidlna-1.2.1+dfsg/upnpsoap.c:2184:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(soapMethods[i].methodName);
data/minidlna-1.2.1+dfsg/utils.c:59:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int nlen = strlen(needle);
data/minidlna-1.2.1+dfsg/utils.c:60:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int hlen = strlen(haystack);
data/minidlna-1.2.1+dfsg/utils.c:78:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(str);
data/minidlna-1.2.1+dfsg/utils.c:111:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
plen = strlen(p);
data/minidlna-1.2.1+dfsg/utils.c:134:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
plen = strlen(p);
data/minidlna-1.2.1+dfsg/utils.c:158:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
oldlen = strlen(before);
data/minidlna-1.2.1+dfsg/utils.c:159:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newlen = strlen(after);
data/minidlna-1.2.1+dfsg/utils.c:170:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s = realloc(string, strlen(string)+((newlen-oldlen)*chgcnt)+1);
data/minidlna-1.2.1+dfsg/utils.c:184:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memmove(p + newlen, p + oldlen, strlen(p + oldlen) + 1);
data/minidlna-1.2.1+dfsg/utils.c:469:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strncmp(album_art_name->name, name, strlen(album_art_name->name)) == 0 )
data/minidlna-1.2.1+dfsg/utils.c:498:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strncmp(path, str_buf, strlen(str_buf)) == 0 )
data/minidlna-1.2.1+dfsg/utils.c:528:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(path, media_dir->path, strlen(media_dir->path)) == 0)
data/minidlna-1.2.1+dfsg/utils.h:56:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dst, src, len);
data/minidlna-1.2.1+dfsg/uuid.c:105:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(i, buf, size) == -1)
ANALYSIS SUMMARY:
Hits = 629
Lines analyzed = 24806 in approximately 0.76 seconds (32853 lines/second)
Physical Source Lines of Code (SLOC) = 19910
Hits@level = [0] 154 [1] 89 [2] 450 [3] 12 [4] 75 [5] 3
Hits@level+ = [0+] 783 [1+] 629 [2+] 540 [3+] 90 [4+] 78 [5+] 3
Hits/KSLOC@level+ = [0+] 39.327 [1+] 31.5922 [2+] 27.122 [3+] 4.52034 [4+] 3.91763 [5+] 0.150678
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.