Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/monopd-0.10.2/src/gameconfig.h
Examining data/monopd-0.10.2/src/listener.h
Examining data/monopd-0.10.2/src/card.cpp
Examining data/monopd-0.10.2/src/listenport.cpp
Examining data/monopd-0.10.2/src/player.cpp
Examining data/monopd-0.10.2/src/debt.cpp
Examining data/monopd-0.10.2/src/game.h
Examining data/monopd-0.10.2/src/player.h
Examining data/monopd-0.10.2/src/gameconfig.cpp
Examining data/monopd-0.10.2/src/io.h
Examining data/monopd-0.10.2/src/auction.h
Examining data/monopd-0.10.2/src/estate.h
Examining data/monopd-0.10.2/src/estate.cpp
Examining data/monopd-0.10.2/src/auction.cpp
Examining data/monopd-0.10.2/src/socket.h
Examining data/monopd-0.10.2/src/display.cpp
Examining data/monopd-0.10.2/src/server.cpp
Examining data/monopd-0.10.2/src/gameproperty.h
Examining data/monopd-0.10.2/src/trade.h
Examining data/monopd-0.10.2/src/cardgroup.cpp
Examining data/monopd-0.10.2/src/tradecomponent.h
Examining data/monopd-0.10.2/src/estategroup.h
Examining data/monopd-0.10.2/src/gameproperty.cpp
Examining data/monopd-0.10.2/src/server.h
Examining data/monopd-0.10.2/src/estategroup.cpp
Examining data/monopd-0.10.2/src/trade.cpp
Examining data/monopd-0.10.2/src/debt.h
Examining data/monopd-0.10.2/src/listener.cpp
Examining data/monopd-0.10.2/src/game.cpp
Examining data/monopd-0.10.2/src/event.h
Examining data/monopd-0.10.2/src/io.cpp
Examining data/monopd-0.10.2/src/cardgroup.h
Examining data/monopd-0.10.2/src/card.h
Examining data/monopd-0.10.2/src/display.h
Examining data/monopd-0.10.2/src/gameobject.cpp
Examining data/monopd-0.10.2/src/tradecomponent.cpp
Examining data/monopd-0.10.2/src/gameobject.h
Examining data/monopd-0.10.2/src/event.cpp
Examining data/monopd-0.10.2/src/socket.cpp
Examining data/monopd-0.10.2/src/listenport.h
FINAL RESULTS:
data/monopd-0.10.2/src/display.cpp:102:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf, sizeof(buf), fmt, arg);
data/monopd-0.10.2/src/game.cpp:107:7: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
n = vsnprintf(buf, size, fmt, arg);
data/monopd-0.10.2/src/game.cpp:141:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf, sizeof(buf)-1, data, arg);
data/monopd-0.10.2/src/player.cpp:95:7: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
n = vsnprintf(buf, size, fmt, arg);
data/monopd-0.10.2/src/player.cpp:128:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf, sizeof(buf)-1, data, arg);
data/monopd-0.10.2/src/player.cpp:146:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf, sizeof(buf)-1, data, arg);
data/monopd-0.10.2/src/server.cpp:748:7: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
n = vsnprintf(buf, size, fmt, arg);
data/monopd-0.10.2/src/trade.cpp:240:7: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
n = vsnprintf(buf, size, fmt, arg);
data/monopd-0.10.2/src/server.cpp:74:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand((unsigned int)time(0));
data/monopd-0.10.2/src/display.cpp:99:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2048];
data/monopd-0.10.2/src/game.cpp:138:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2048];
data/monopd-0.10.2/src/game.cpp:240:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
goEstate = atoi( value.c_str() );
data/monopd-0.10.2/src/game.cpp:250:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
payTargets[eTmp] = atoi( value.c_str() );
data/monopd-0.10.2/src/game.cpp:272:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
setProperty( key, atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:275:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_houses = atoi( value.c_str() );
data/monopd-0.10.2/src/game.cpp:278:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_hotels = atoi( value.c_str() );
data/monopd-0.10.2/src/game.cpp:281:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_startMoney = atoi( value.c_str() );
data/monopd-0.10.2/src/game.cpp:331:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
es->setProperty( key, atoi( value.c_str() ), this );
data/monopd-0.10.2/src/game.cpp:333:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
es->setRent(0, atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:335:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
es->setRent(1, atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:337:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
es->setRent(2, atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:339:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
es->setRent(3, atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:341:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
es->setRent(4, atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:343:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
es->setRent(5, atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:345:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
es->setBoolProperty( key, atoi( value.c_str() ), this );
data/monopd-0.10.2/src/game.cpp:356:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setCanBeOwned( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:358:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setPay( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:360:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setPayHouse( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:362:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setPayHotel( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:364:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setPayEach( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:366:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setToJail( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:368:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setOutOfJail( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:370:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setAdvance( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:372:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
card->setAdvanceTo( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:385:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group->setPrice( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:387:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
group->setHousePrice( atoi( value.c_str() ) );
data/monopd-0.10.2/src/game.cpp:415:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int configId = atoi(strsep(&data, ":"));
data/monopd-0.10.2/src/game.cpp:429:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
configOption->setProperty( "value", atoi(newValue.c_str()) );
data/monopd-0.10.2/src/game.cpp:431:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
configOption->setBoolProperty( "value", atoi(newValue.c_str()) );
data/monopd-0.10.2/src/game.cpp:913:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int auctionId = atoi(strsep(&data, ":"));
data/monopd-0.10.2/src/game.cpp:914:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int bid = atoi(data);
data/monopd-0.10.2/src/game.cpp:1009:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tradeId = atoi(strsep(&data, ":"));
data/monopd-0.10.2/src/game.cpp:1010:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
revision = atoi(data);
data/monopd-0.10.2/src/io.cpp:48:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/monopd-0.10.2/src/listener.cpp:230:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip_str[INET6_ADDRSTRLEN];
data/monopd-0.10.2/src/listener.cpp:293:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip_str[INET6_ADDRSTRLEN];
data/monopd-0.10.2/src/listener.cpp:336:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip_str[INET6_ADDRSTRLEN];
data/monopd-0.10.2/src/player.cpp:125:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2048];
data/monopd-0.10.2/src/player.cpp:143:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2048];
data/monopd-0.10.2/src/player.cpp:807:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int tradeId = atoi(strsep(&data, ":"));
data/monopd-0.10.2/src/player.cpp:814:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int objectId = atoi(strsep(&data, ":"));
data/monopd-0.10.2/src/player.cpp:815:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int playerId = atoi(data);
data/monopd-0.10.2/src/player.cpp:886:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int tradeId = atoi(strsep(&data, ":"));
data/monopd-0.10.2/src/player.cpp:893:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int playerFromId = atoi(strsep(&data, ":"));
data/monopd-0.10.2/src/player.cpp:901:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int playerToId = atoi(strsep(&data, ":"));
data/monopd-0.10.2/src/player.cpp:902:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int money = atoi(data);
data/monopd-0.10.2/src/server.cpp:79:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_port = atoi(argv[1]);
data/monopd-0.10.2/src/server.cpp:587:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char port_str[6];
data/monopd-0.10.2/src/server.cpp:620:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *f = fopen(MONOPD_CONFIGDIR "/monopd.conf", "r");
data/monopd-0.10.2/src/server.cpp:627:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[1024], *buf, *ret;
data/monopd-0.10.2/src/server.cpp:637:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_port = atoi(strtok(NULL, "\n\0"));
data/monopd-0.10.2/src/server.cpp:641:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_metaserverPort = atoi(strtok(NULL, "\n\0"));
data/monopd-0.10.2/src/server.cpp:666:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[256], *buf, *ret;
data/monopd-0.10.2/src/server.cpp:674:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *f = fopen(filename.c_str(), "r");
data/monopd-0.10.2/src/server.cpp:884:22: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
joinGame(pInput, atol(data2.substr(3).c_str()));
data/monopd-0.10.2/src/server.cpp:887:23: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
joinGame( pInput, atol(data2.substr(3).c_str()), true );
data/monopd-0.10.2/src/server.cpp:919:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pKick = game->kickPlayer( pInput, atoi(data+3) );
data/monopd-0.10.2/src/server.cpp:925:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
game->upgradePlayer( pInput, atoi(data+3) );
data/monopd-0.10.2/src/server.cpp:943:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
game->setTokenLocation(pInput, atoi(data+2));
data/monopd-0.10.2/src/server.cpp:978:27: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
game->newTrade(pInput, atol(data2.substr(3).c_str()));
data/monopd-0.10.2/src/server.cpp:984:30: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
game->rejectTrade(pInput, atol(data2.substr(3).c_str()));
data/monopd-0.10.2/src/server.cpp:993:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pInput->buyHouse(atoi(data+3));
data/monopd-0.10.2/src/server.cpp:996:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pInput->sellHouse(atoi(data+3));
data/monopd-0.10.2/src/server.cpp:1008:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pInput->mortgageEstate(atoi(data+3));
data/monopd-0.10.2/src/server.cpp:1011:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pInput->sellEstate(atoi(data+3));
data/monopd-0.10.2/src/listener.cpp:68:3: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(100000);
data/monopd-0.10.2/src/listener.cpp:191:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int n = read((*it)->fd(), readBuf, MAXLINE);
data/monopd-0.10.2/src/server.cpp:661:3: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(100000);
data/monopd-0.10.2/src/server.cpp:685:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!utf8::is_valid(str, str+strlen(str))) {
data/monopd-0.10.2/src/socket.cpp:45:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssize_t len = strlen(data.c_str());
data/monopd-0.10.2/src/socket.cpp:78:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssize_t len = strlen(m_sendBuf.c_str());
ANALYSIS SUMMARY:
Hits = 81
Lines analyzed = 8409 in approximately 0.21 seconds (39282 lines/second)
Physical Source Lines of Code (SLOC) = 6263
Hits@level = [0] 34 [1] 6 [2] 66 [3] 1 [4] 8 [5] 0
Hits@level+ = [0+] 115 [1+] 81 [2+] 75 [3+] 9 [4+] 8 [5+] 0
Hits/KSLOC@level+ = [0+] 18.3618 [1+] 12.9331 [2+] 11.9751 [3+] 1.43701 [4+] 1.27734 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.