Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/munin-c-0.0.13/src/node/inetd.c
Examining data/munin-c-0.0.13/src/node/node.c
Examining data/munin-c-0.0.13/src/plugins/common.c
Examining data/munin-c-0.0.13/src/plugins/common.h
Examining data/munin-c-0.0.13/src/plugins/cpu.c
Examining data/munin-c-0.0.13/src/plugins/df.c
Examining data/munin-c-0.0.13/src/plugins/entropy.c
Examining data/munin-c-0.0.13/src/plugins/external_.c
Examining data/munin-c-0.0.13/src/plugins/forks.c
Examining data/munin-c-0.0.13/src/plugins/fw_packets.c
Examining data/munin-c-0.0.13/src/plugins/if_err_.c
Examining data/munin-c-0.0.13/src/plugins/interrupts.c
Examining data/munin-c-0.0.13/src/plugins/load.c
Examining data/munin-c-0.0.13/src/plugins/main.c
Examining data/munin-c-0.0.13/src/plugins/memory.c
Examining data/munin-c-0.0.13/src/plugins/open_files.c
Examining data/munin-c-0.0.13/src/plugins/open_inodes.c
Examining data/munin-c-0.0.13/src/plugins/plugins.h
Examining data/munin-c-0.0.13/src/plugins/processes.c
Examining data/munin-c-0.0.13/src/plugins/swap.c
Examining data/munin-c-0.0.13/src/plugins/threads.c
Examining data/munin-c-0.0.13/src/plugins/uptime.c
Examining data/munin-c-0.0.13/t/common.c
Examining data/munin-c-0.0.13/t/common.h
Examining data/munin-c-0.0.13/t/nb_env.c
Examining data/munin-c-0.0.13/t/ok_plugin.c
FINAL RESULTS:
data/munin-c-0.0.13/src/node/node.c:148:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(cmdline, X_OK) == 0) {
data/munin-c-0.0.13/src/node/node.c:606:10: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(cmdline, X_OK) == 0) {
data/munin-c-0.0.13/src/node/node.c:647:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(cmdline, X_OK) == -1) {
data/munin-c-0.0.13/src/node/node.c:662:5: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(cmdline, arg, cmd, NULL);
data/munin-c-0.0.13/src/node/node.c:708:8: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(cmdline, X_OK) == 0) {
data/munin-c-0.0.13/src/node/node.c:753:2: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(plugin_filename, plugin_name, "acquire", NULL);
data/munin-c-0.0.13/src/plugins/common.c:25:11: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (0 == access(path, R_OK))
data/munin-c-0.0.13/src/plugins/memory.c:127:8: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
if (!sscanf(buff, "%s %" SCNdFAST64, key, &value)) {
data/munin-c-0.0.13/src/node/node.c:176:18: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((optch = getopt(argc, argv, format)) != -1)
data/munin-c-0.0.13/src/plugins/common.c:36:10: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
value = getenv(name);
data/munin-c-0.0.13/src/plugins/common.c:63:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
p = getenv("warning");
data/munin-c-0.0.13/src/plugins/common.c:75:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
p = getenv("critical");
data/munin-c-0.0.13/src/plugins/cpu.c:79:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *s = getenv("scaleto100");
data/munin-c-0.0.13/src/plugins/external_.c:45:6: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv(action) == NULL) {
data/munin-c-0.0.13/src/plugins/external_.c:48:5: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
getenv("MUNIN_PLUGSTATE"), plugin_basename,
data/munin-c-0.0.13/src/plugins/external_.c:52:44: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
return snprintf(filename, LINE_MAX, "%s", getenv(action));
data/munin-c-0.0.13/src/node/inetd.c:24:9: [2] (race) vfork:
On some old systems, vfork() permits race conditions, and it's very
difficult to use correctly (CWE-362). Use fork() instead.
#define vfork fork
data/munin-c-0.0.13/src/node/node.c:325:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAX_ENV_BUF_SZ];
data/munin-c-0.0.13/src/node/node.c:389:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_MAX];
data/munin-c-0.0.13/src/node/node.c:498:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmdline[LINE_MAX];
data/munin-c-0.0.13/src/node/node.c:509:16: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *f = fopen(cmdline, "r");
data/munin-c-0.0.13/src/node/node.c:560:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_MAX];
data/munin-c-0.0.13/src/node/node.c:594:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmdline[LINE_MAX];
data/munin-c-0.0.13/src/node/node.c:629:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmdline[LINE_MAX];
data/munin-c-0.0.13/src/node/node.c:698:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmdline[LINE_MAX];
data/munin-c-0.0.13/src/plugins/common.c:39:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return atoi(value);
data/munin-c-0.0.13/src/plugins/cpu.c:74:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[256];
data/munin-c-0.0.13/src/plugins/cpu.c:83:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_STAT, "r")))
data/munin-c-0.0.13/src/plugins/cpu.c:191:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_STAT, "r")))
data/munin-c-0.0.13/src/plugins/entropy.c:36:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(ENTROPY_AVAIL, "r")))
data/munin-c-0.0.13/src/plugins/external_.c:27:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(filename, "r"))) {
data/munin-c-0.0.13/src/plugins/external_.c:57:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[LINE_MAX];
data/munin-c-0.0.13/src/plugins/forks.c:20:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[256];
data/munin-c-0.0.13/src/plugins/forks.c:39:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_STAT, "r")))
data/munin-c-0.0.13/src/plugins/fw_packets.c:20:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[1024], *s;
data/munin-c-0.0.13/src/plugins/fw_packets.c:40:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_NET_SNMP, "r")))
data/munin-c-0.0.13/src/plugins/if_err_.c:23:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[256], *s;
data/munin-c-0.0.13/src/plugins/if_err_.c:36:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (NULL == (f = fopen(PROC_NET_DEV, "r")))
data/munin-c-0.0.13/src/plugins/if_err_.c:79:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (NULL == (f = fopen(PROC_NET_DEV, "r")))
data/munin-c-0.0.13/src/plugins/interrupts.c:20:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[256];
data/munin-c-0.0.13/src/plugins/interrupts.c:32:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_STAT, "r")))
data/munin-c-0.0.13/src/plugins/load.c:37:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_LOADAVG, "r")))
data/munin-c-0.0.13/src/plugins/memory.c:86:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[256];
data/munin-c-0.0.13/src/plugins/memory.c:121:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_MEMINFO, "r")))
data/munin-c-0.0.13/src/plugins/memory.c:125:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key[256];
data/munin-c-0.0.13/src/plugins/open_files.c:24:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(FS_FILE_NR, "r")))
data/munin-c-0.0.13/src/plugins/open_files.c:49:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(FS_FILE_NR, "r")))
data/munin-c-0.0.13/src/plugins/open_inodes.c:41:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(FS_INODE_NR, "r")))
data/munin-c-0.0.13/src/plugins/swap.c:23:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[256];
data/munin-c-0.0.13/src/plugins/swap.c:49:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen(PROC_VMSTAT, "r"))) {
data/munin-c-0.0.13/src/plugins/swap.c:65:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_STAT, "r")))
data/munin-c-0.0.13/src/plugins/threads.c:23:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buff[270];
data/munin-c-0.0.13/src/plugins/threads.c:33:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (NULL == (f = fopen(buff, "r")))
data/munin-c-0.0.13/src/plugins/threads.c:65:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(buff, "r")))
data/munin-c-0.0.13/src/plugins/uptime.c:35:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(PROC_UPTIME, "r")))
data/munin-c-0.0.13/src/node/node.c:93:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
assert(strlen(s) < MAX_ALLOC_SIZE);
data/munin-c-0.0.13/src/node/node.c:115:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t plugin_basename_len = strlen(plugin_basename);
data/munin-c-0.0.13/src/node/node.c:297:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = s + strlen(s) - 1;
data/munin-c-0.0.13/src/node/node.c:340:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t key_len = strlen(key);
data/munin-c-0.0.13/src/node/node.c:434:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
value = trim(key + strlen(key) + 1);
data/munin-c-0.0.13/src/node/node.c:452:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncmp(key, "env.", strlen("env."))) {
data/munin-c-0.0.13/src/node/node.c:453:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *env_key = key + strlen("env.");
data/munin-c-0.0.13/src/node/node.c:576:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!cmd || strlen(cmd) == 0) {
data/munin-c-0.0.13/src/plugins/common.c:48:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len1 = strlen(name1), len2 = strlen(name2);
data/munin-c-0.0.13/src/plugins/common.c:48:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len1 = strlen(name1), len2 = strlen(name2);
data/munin-c-0.0.13/src/plugins/external_.c:32:14: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = fgetc(f)) != EOF) {
data/munin-c-0.0.13/src/plugins/if_err_.c:30:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
interface_len = strlen(interface);
data/munin-c-0.0.13/src/plugins/main.c:69:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(progname, "external_", strlen("external_")))
data/munin-c-0.0.13/src/plugins/main.c:81:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(progname, "if_err_", strlen("if_err_")))
ANALYSIS SUMMARY:
Hits = 69
Lines analyzed = 2562 in approximately 0.09 seconds (27668 lines/second)
Physical Source Lines of Code (SLOC) = 1944
Hits@level = [0] 114 [1] 14 [2] 39 [3] 8 [4] 8 [5] 0
Hits@level+ = [0+] 183 [1+] 69 [2+] 55 [3+] 16 [4+] 8 [5+] 0
Hits/KSLOC@level+ = [0+] 94.1358 [1+] 35.4938 [2+] 28.2922 [3+] 8.23045 [4+] 4.11523 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.