Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/amqp.h
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/amqp_framing.h
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/amqp_ssl_socket.h
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/amqp_tcp_socket.h
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.h
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/murano-agent.c
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/producer.c
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/utils.c
Examining data/murano-agent-6.0.0/contrib/c-demo-agent/utils.h
FINAL RESULTS:
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1327:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(c->error, sizeof(c->error), fmt, ap);
data/murano-agent-6.0.0/contrib/c-demo-agent/murano-agent.c:38:13: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf ( stdout, title, received );
data/murano-agent-6.0.0/contrib/c-demo-agent/utils.c:37:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf ( stderr, fmt, ap );
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:363:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(s_new->str, s->str, s_new->size);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:440:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(s->str + s->size, cstr, len);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:550:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[BUFFER_SIZE];
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:635:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hex[3];
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:869:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(t, &s->prepared_token, sizeof(struct lcfg_token));
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:939:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sdup, s, len);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1180:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open(p->filename, 0);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1281:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char error[0xff];
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1431:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(n->value.string.data, data, len);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1474:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[strlen(key) + 1];
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1483:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *pathv[path_components];
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1590:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[strlen(key) + 1];
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1599:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *pathv[path_components];
data/murano-agent-6.0.0/contrib/c-demo-agent/murano-agent.c:174:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int log_fd = open ( log_filename, flags, mode );
data/murano-agent-6.0.0/contrib/c-demo-agent/murano-agent.c:197:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int port = atoi ( get_config_value ( cfg, "RABBITMQ_PORT" , 1 ) );
data/murano-agent-6.0.0/contrib/c-demo-agent/producer.c:98:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi ( argv[2] );
data/murano-agent-6.0.0/contrib/c-demo-agent/producer.c:99:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rate_limit = atoi ( argv[3] );
data/murano-agent-6.0.0/contrib/c-demo-agent/producer.c:100:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
message_count = atoi ( argv[4] );
data/murano-agent-6.0.0/contrib/c-demo-agent/amqp_framing.h:226:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
amqp_boolean_t read;
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:436:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(cstr);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:565:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if( (s->size = read(s->fd, s->buffer, BUFFER_SIZE)) < 0 )
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:934:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(s) + 1;
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1474:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char path[strlen(key) + 1];
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1477:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(path, key, strlen(key) + 1);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1477:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(path, key, strlen(key) + 1);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1590:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char path[strlen(key) + 1];
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1593:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(path, key, strlen(key) + 1);
data/murano-agent-6.0.0/contrib/c-demo-agent/lcfg_static.c:1593:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(path, key, strlen(key) + 1);
data/murano-agent-6.0.0/contrib/c-demo-agent/murano-agent.c:45:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write ( log_fd, ( void * ) title, strlen ( title ) );
data/murano-agent-6.0.0/contrib/c-demo-agent/producer.c:30:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
message_bytes.len = strlen ( message );
data/murano-agent-6.0.0/contrib/c-demo-agent/utils.c:30:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep ( usec );
ANALYSIS SUMMARY:
Hits = 34
Lines analyzed = 5530 in approximately 0.16 seconds (33917 lines/second)
Physical Source Lines of Code (SLOC) = 2651
Hits@level = [0] 37 [1] 13 [2] 18 [3] 0 [4] 3 [5] 0
Hits@level+ = [0+] 71 [1+] 34 [2+] 21 [3+] 3 [4+] 3 [5+] 0
Hits/KSLOC@level+ = [0+] 26.7823 [1+] 12.8253 [2+] 7.92154 [3+] 1.13165 [4+] 1.13165 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.