Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/mustang-plug-1.2/plug/amp_advanced.cpp
Examining data/mustang-plug-1.2/plug/amp_advanced.h
Examining data/mustang-plug-1.2/plug/amplifier.cpp
Examining data/mustang-plug-1.2/plug/amplifier.h
Examining data/mustang-plug-1.2/plug/data_structs.h
Examining data/mustang-plug-1.2/plug/defaulteffects.cpp
Examining data/mustang-plug-1.2/plug/defaulteffects.h
Examining data/mustang-plug-1.2/plug/effect.cpp
Examining data/mustang-plug-1.2/plug/effect.h
Examining data/mustang-plug-1.2/plug/effects_enum.h
Examining data/mustang-plug-1.2/plug/library.cpp
Examining data/mustang-plug-1.2/plug/library.h
Examining data/mustang-plug-1.2/plug/loadfromamp.cpp
Examining data/mustang-plug-1.2/plug/loadfromamp.h
Examining data/mustang-plug-1.2/plug/loadfromfile.cpp
Examining data/mustang-plug-1.2/plug/loadfromfile.h
Examining data/mustang-plug-1.2/plug/mainwindow.h
Examining data/mustang-plug-1.2/plug/mustang.cpp
Examining data/mustang-plug-1.2/plug/mustang.h
Examining data/mustang-plug-1.2/plug/quickpresets.cpp
Examining data/mustang-plug-1.2/plug/quickpresets.h
Examining data/mustang-plug-1.2/plug/save_effects.h
Examining data/mustang-plug-1.2/plug/saveonamp.h
Examining data/mustang-plug-1.2/plug/savetofile.cpp
Examining data/mustang-plug-1.2/plug/savetofile.h
Examining data/mustang-plug-1.2/plug/settings.cpp
Examining data/mustang-plug-1.2/plug/settings.h
Examining data/mustang-plug-1.2/plug/main.cpp
Examining data/mustang-plug-1.2/plug/mainwindow.cpp
Examining data/mustang-plug-1.2/plug/save_effects.cpp
Examining data/mustang-plug-1.2/plug/saveonamp.cpp
FINAL RESULTS:
data/mustang-plug-1.2/plug/amplifier.cpp:38:67: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
connect(ui->advancedButton, SIGNAL(clicked()), advanced, SLOT(open()));
data/mustang-plug-1.2/plug/effect.h:27:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char title[10];
data/mustang-plug-1.2/plug/library.cpp:6:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
Library::Library(char names[100][32], QWidget *parent) :
data/mustang-plug-1.2/plug/library.h:18:22: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
explicit Library(char names[100][32], QWidget *parent = 0);
data/mustang-plug-1.2/plug/mainwindow.cpp:60:73: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
connect(ui->actionSave_effects, SIGNAL(triggered()), seffects, SLOT(open()));
data/mustang-plug-1.2/plug/mainwindow.cpp:141:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[32];
data/mustang-plug-1.2/plug/mainwindow.cpp:335:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(names[slot], name, 32);
data/mustang-plug-1.2/plug/mainwindow.cpp:345:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[32];
data/mustang-plug-1.2/plug/mainwindow.cpp:508:20: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file->open(QFile::ReadOnly | QFile::Text))
data/mustang-plug-1.2/plug/mainwindow.h:62:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char names[100][32];
data/mustang-plug-1.2/plug/mustang.cpp:31:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char array[LENGTH];
data/mustang-plug-1.2/plug/mustang.cpp:32:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char recieved_data[296][LENGTH];
data/mustang-plug-1.2/plug/mustang.cpp:98:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(recieved_data[i], array, LENGTH);
data/mustang-plug-1.2/plug/mustang.cpp:105:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(list[j], recieved_data[i]+16, 32);
data/mustang-plug-1.2/plug/mustang.cpp:109:22: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char data[7][LENGTH];
data/mustang-plug-1.2/plug/mustang.cpp:112:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data[j], recieved_data[i], LENGTH);
data/mustang-plug-1.2/plug/mustang.cpp:152:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char temp[LENGTH], array[LENGTH] = {
data/mustang-plug-1.2/plug/mustang.cpp:169:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(array, prev_array[i], LENGTH);
data/mustang-plug-1.2/plug/mustang.cpp:470:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(prev_array[array[DSP]-6], array, LENGTH);
data/mustang-plug-1.2/plug/mustang.cpp:491:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char array[LENGTH] = {
data/mustang-plug-1.2/plug/mustang.cpp:653:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char array[LENGTH];
data/mustang-plug-1.2/plug/mustang.cpp:679:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char array[LENGTH], data[7][LENGTH];
data/mustang-plug-1.2/plug/mustang.cpp:693:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(data[i], array, LENGTH);
data/mustang-plug-1.2/plug/mustang.cpp:702:35: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
int Mustang::decode_data(unsigned char data[7][LENGTH], char *name, struct amp_settings *amp_set, struct fx_pedal_settings *effects_set)
data/mustang-plug-1.2/plug/mustang.cpp:995:37: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
int Mustang::save_effects(int slot, char name[24], int number_of_effects, struct fx_pedal_settings effects[2])
data/mustang-plug-1.2/plug/mustang.cpp:999:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char temp[LENGTH], array[LENGTH] = {
data/mustang-plug-1.2/plug/mustang.cpp:1277:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char array[LENGTH], number = 0;
data/mustang-plug-1.2/plug/mustang.cpp:1337:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
file = fopen(filename, "rb");
data/mustang-plug-1.2/plug/mustang.h:83:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char execute[LENGTH]; // "apply" command sent after each instruction
data/mustang-plug-1.2/plug/mustang.h:84:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char prev_array[4][LENGTH]; // array used to clear the effect
data/mustang-plug-1.2/plug/savetofile.cpp:43:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file->open(QFile::WriteOnly))
data/mustang-plug-1.2/plug/mustang.cpp:663:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(name) > 31)
data/mustang-plug-1.2/plug/mustang.cpp:1349:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(10000);
data/mustang-plug-1.2/plug/mustang.cpp:1363:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(10000);
ANALYSIS SUMMARY:
Hits = 34
Lines analyzed = 8252 in approximately 0.26 seconds (31249 lines/second)
Physical Source Lines of Code (SLOC) = 6853
Hits@level = [0] 2 [1] 3 [2] 31 [3] 0 [4] 0 [5] 0
Hits@level+ = [0+] 36 [1+] 34 [2+] 31 [3+] 0 [4+] 0 [5+] 0
Hits/KSLOC@level+ = [0+] 5.25317 [1+] 4.96133 [2+] 4.52357 [3+] 0 [4+] 0 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.