Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/ncmpc-0.42/src/AsyncUserInput.cxx
Examining data/ncmpc-0.42/src/BasicColors.cxx
Examining data/ncmpc-0.42/src/BasicMarquee.cxx
Examining data/ncmpc-0.42/src/Bindings.cxx
Examining data/ncmpc-0.42/src/ChatPage.cxx
Examining data/ncmpc-0.42/src/Command.cxx
Examining data/ncmpc-0.42/src/Completion.cxx
Examining data/ncmpc-0.42/src/ConfigFile.cxx
Examining data/ncmpc-0.42/src/ConfigParser.cxx
Examining data/ncmpc-0.42/src/CustomColors.cxx
Examining data/ncmpc-0.42/src/DelayedSeek.cxx
Examining data/ncmpc-0.42/src/FileBrowserPage.cxx
Examining data/ncmpc-0.42/src/FileListPage.cxx
Examining data/ncmpc-0.42/src/GlobalBindings.cxx
Examining data/ncmpc-0.42/src/HelpPage.cxx
Examining data/ncmpc-0.42/src/Instance.cxx
Examining data/ncmpc-0.42/src/KeyDefPage.cxx
Examining data/ncmpc-0.42/src/KeyName.cxx
Examining data/ncmpc-0.42/src/LibraryPage.cxx
Examining data/ncmpc-0.42/src/ListCursor.cxx
Examining data/ncmpc-0.42/src/ListWindow.cxx
Examining data/ncmpc-0.42/src/LyricsPage.cxx
Examining data/ncmpc-0.42/src/Main.cxx
Examining data/ncmpc-0.42/src/Match.cxx
Examining data/ncmpc-0.42/src/Options.cxx
Examining data/ncmpc-0.42/src/OutputsPage.cxx
Examining data/ncmpc-0.42/src/ProgressBar.cxx
Examining data/ncmpc-0.42/src/ProxyPage.cxx
Examining data/ncmpc-0.42/src/Queue.cxx
Examining data/ncmpc-0.42/src/QueuePage.cxx
Examining data/ncmpc-0.42/src/SearchPage.cxx
Examining data/ncmpc-0.42/src/SongPage.cxx
Examining data/ncmpc-0.42/src/SongRowPaint.cxx
Examining data/ncmpc-0.42/src/StatusBar.cxx
Examining data/ncmpc-0.42/src/Styles.cxx
Examining data/ncmpc-0.42/src/TabBar.cxx
Examining data/ncmpc-0.42/src/TagFilter.cxx
Examining data/ncmpc-0.42/src/TagListPage.cxx
Examining data/ncmpc-0.42/src/TextListRenderer.cxx
Examining data/ncmpc-0.42/src/TextPage.cxx
Examining data/ncmpc-0.42/src/TitleBar.cxx
Examining data/ncmpc-0.42/src/XdgBaseDirectory.cxx
Examining data/ncmpc-0.42/src/aconnect.cxx
Examining data/ncmpc-0.42/src/callbacks.cxx
Examining data/ncmpc-0.42/src/charset.cxx
Examining data/ncmpc-0.42/src/db_completion.cxx
Examining data/ncmpc-0.42/src/event/IdleEvent.cxx
Examining data/ncmpc-0.42/src/event/Loop.cxx
Examining data/ncmpc-0.42/src/event/PollBackend.cxx
Examining data/ncmpc-0.42/src/event/SignalMonitor.cxx
Examining data/ncmpc-0.42/src/event/SocketEvent.cxx
Examining data/ncmpc-0.42/src/event/TimerEvent.cxx
Examining data/ncmpc-0.42/src/filelist.cxx
Examining data/ncmpc-0.42/src/gidle.cxx
Examining data/ncmpc-0.42/src/hscroll.cxx
Examining data/ncmpc-0.42/src/i18n.h
Examining data/ncmpc-0.42/src/io/FileDescriptor.cxx
Examining data/ncmpc-0.42/src/io/uring/Features.h
Examining data/ncmpc-0.42/src/lirc.cxx
Examining data/ncmpc-0.42/src/lyrics.cxx
Examining data/ncmpc-0.42/src/mpdclient.cxx
Examining data/ncmpc-0.42/src/ncu.cxx
Examining data/ncmpc-0.42/src/net/AddressInfo.cxx
Examining data/ncmpc-0.42/src/net/AllocatedSocketAddress.cxx
Examining data/ncmpc-0.42/src/net/AsyncConnect.cxx
Examining data/ncmpc-0.42/src/net/AsyncResolveConnect.cxx
Examining data/ncmpc-0.42/src/net/HostParser.cxx
Examining data/ncmpc-0.42/src/net/IPv4Address.cxx
Examining data/ncmpc-0.42/src/net/IPv6Address.cxx
Examining data/ncmpc-0.42/src/net/Resolver.cxx
Examining data/ncmpc-0.42/src/net/SocketAddress.cxx
Examining data/ncmpc-0.42/src/net/SocketDescriptor.cxx
Examining data/ncmpc-0.42/src/net/StaticSocketAddress.cxx
Examining data/ncmpc-0.42/src/player_command.cxx
Examining data/ncmpc-0.42/src/plugin.cxx
Examining data/ncmpc-0.42/src/save_playlist.cxx
Examining data/ncmpc-0.42/src/screen.cxx
Examining data/ncmpc-0.42/src/screen_client.cxx
Examining data/ncmpc-0.42/src/screen_find.cxx
Examining data/ncmpc-0.42/src/screen_init.cxx
Examining data/ncmpc-0.42/src/screen_list.cxx
Examining data/ncmpc-0.42/src/screen_paint.cxx
Examining data/ncmpc-0.42/src/screen_status.cxx
Examining data/ncmpc-0.42/src/screen_utils.cxx
Examining data/ncmpc-0.42/src/signals.cxx
Examining data/ncmpc-0.42/src/strfsong.cxx
Examining data/ncmpc-0.42/src/system/EpollFD.cxx
Examining data/ncmpc-0.42/src/system/EventFD.cxx
Examining data/ncmpc-0.42/src/system/EventPipe.cxx
Examining data/ncmpc-0.42/src/system/SignalFD.cxx
Examining data/ncmpc-0.42/src/time_format.cxx
Examining data/ncmpc-0.42/src/util/Compiler.h
Examining data/ncmpc-0.42/src/util/Exception.cxx
Examining data/ncmpc-0.42/src/util/LocaleString.cxx
Examining data/ncmpc-0.42/src/util/PrintException.cxx
Examining data/ncmpc-0.42/src/util/StringCompare.cxx
Examining data/ncmpc-0.42/src/util/StringStrip.cxx
Examining data/ncmpc-0.42/src/util/StringUTF8.cxx
Examining data/ncmpc-0.42/src/util/StringView.cxx
Examining data/ncmpc-0.42/src/util/UriUtil.cxx
Examining data/ncmpc-0.42/src/wreadln.cxx
Examining data/ncmpc-0.42/src/xterm_title.cxx
Examining data/ncmpc-0.42/test/run_hscroll.cxx
FINAL RESULTS:
data/ncmpc-0.42/src/LyricsPage.cxx:400:3: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp(editor, editor, path, nullptr);
data/ncmpc-0.42/src/Main.cxx:88:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(title, new_title);
data/ncmpc-0.42/src/Options.cxx:93:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, PACKAGE ": invalid option %s\n", option);
data/ncmpc-0.42/src/Options.cxx:96:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, PACKAGE ": bad argument: %s\n", option);
data/ncmpc-0.42/src/Options.cxx:99:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, PACKAGE ": invalid option %s=%s\n", option, arg);
data/ncmpc-0.42/src/Options.cxx:102:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, PACKAGE ": missing value for %s option\n", option);
data/ncmpc-0.42/src/Options.cxx:105:3: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, PACKAGE ": internal error %d\n", error);
data/ncmpc-0.42/src/ncu.cxx:75:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buffer + 1, name + 2);
data/ncmpc-0.42/src/plugin.cxx:283:3: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(plugin_path, argv.get());
data/ncmpc-0.42/src/screen_status.cxx:39:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(msg, sizeof(msg), format, ap);
data/ncmpc-0.42/src/util/Compiler.h:70:47: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define gcc_printf(a,b) __attribute__((format(printf, a, b)))
data/ncmpc-0.42/src/ChatPage.cxx:140:21: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *user = getenv("USER");
data/ncmpc-0.42/src/LyricsPage.cxx:154:4: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
getenv("HOME"), artist, title);
data/ncmpc-0.42/src/LyricsPage.cxx:172:4: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
getenv("HOME"));
data/ncmpc-0.42/src/Options.cxx:347:30: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (options.host.empty() && getenv("MPD_HOST"))
data/ncmpc-0.42/src/Options.cxx:348:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
options.host = getenv("MPD_HOST");
data/ncmpc-0.42/src/XdgBaseDirectory.cxx:38:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
return getenv("HOME");
data/ncmpc-0.42/src/XdgBaseDirectory.cxx:44:28: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *config_home = getenv("XDG_CONFIG_HOME");
data/ncmpc-0.42/src/xterm_title.cxx:35:6: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv("WINDOWID") == nullptr) {
data/ncmpc-0.42/src/ConfigParser.cxx:473:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.scroll_offset = atoi(value);
data/ncmpc-0.42/src/ConfigParser.cxx:530:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.status_message_time = std::chrono::seconds(atoi(value));
data/ncmpc-0.42/src/ConfigParser.cxx:540:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.crossfade_time = atoi(value);
data/ncmpc-0.42/src/ConfigParser.cxx:544:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.hide_cursor = std::chrono::seconds(atoi(value));
data/ncmpc-0.42/src/ConfigParser.cxx:546:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.seek_time = atoi(value);
data/ncmpc-0.42/src/ConfigParser.cxx:556:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.port = atoi(GetStringValue(value).c_str());
data/ncmpc-0.42/src/ConfigParser.cxx:560:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.timeout_ms = atoi(GetStringValue(value).c_str())
data/ncmpc-0.42/src/ConfigParser.cxx:564:49: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.lyrics_timeout = std::chrono::seconds(atoi(GetStringValue(value).c_str()));
data/ncmpc-0.42/src/ConfigParser.cxx:630:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *file = fopen(filename, "r");
data/ncmpc-0.42/src/ConfigParser.cxx:639:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[MAX_LINE_LENGTH];
data/ncmpc-0.42/src/FileBrowserPage.cxx:255:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char prompt[256];
data/ncmpc-0.42/src/FileListPage.cxx:153:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZE];
data/ncmpc-0.42/src/FileListPage.cxx:272:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFSIZE];
data/ncmpc-0.42/src/FileListPage.cxx:569:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char duration_string[32];
data/ncmpc-0.42/src/KeyDefPage.cxx:175:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char prompt[256];
data/ncmpc-0.42/src/KeyDefPage.cxx:414:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *f = fopen(filename.c_str(), "w");
data/ncmpc-0.42/src/KeyName.cxx:78:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[32];
data/ncmpc-0.42/src/KeyName.cxx:150:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[32];
data/ncmpc-0.42/src/LibraryPage.cxx:199:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[64];
data/ncmpc-0.42/src/ListWindow.cxx:83:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/ncmpc-0.42/src/ListWindow.cxx:129:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/ncmpc-0.42/src/ListWindow.cxx:164:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/ncmpc-0.42/src/LyricsPage.cxx:160:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[1024];
data/ncmpc-0.42/src/LyricsPage.cxx:170:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[1024];
data/ncmpc-0.42/src/LyricsPage.cxx:177:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
return fopen(path, "w");
data/ncmpc-0.42/src/LyricsPage.cxx:200:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[1024];
data/ncmpc-0.42/src/LyricsPage.cxx:398:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[1024];
data/ncmpc-0.42/src/Main.cxx:75:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[BUFSIZE];
data/ncmpc-0.42/src/Main.cxx:86:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char title[BUFSIZE];
data/ncmpc-0.42/src/Main.cxx:266:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256];
data/ncmpc-0.42/src/Options.cxx:118:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tmp[32];
data/ncmpc-0.42/src/Options.cxx:246:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.port = atoi(arg);
data/ncmpc-0.42/src/QueuePage.cxx:429:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char duration_string[32];
data/ncmpc-0.42/src/SearchPage.cxx:312:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *tabv[N];
data/ncmpc-0.42/src/SearchPage.cxx:313:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *matchv[N];
data/ncmpc-0.42/src/SongPage.cxx:236:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[BUFFER_SIZE];
data/ncmpc-0.42/src/SongPage.cxx:303:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char songpos[16];
data/ncmpc-0.42/src/SongPage.cxx:314:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char length[16];
data/ncmpc-0.42/src/SongPage.cxx:320:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[64];
data/ncmpc-0.42/src/SongPage.cxx:323:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char start[16], end[16];
data/ncmpc-0.42/src/SongPage.cxx:333:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char start[16];
data/ncmpc-0.42/src/SongPage.cxx:373:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64];
data/ncmpc-0.42/src/SongPage.cxx:471:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[16];
data/ncmpc-0.42/src/SongPage.cxx:481:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/ncmpc-0.42/src/SongRowPaint.cxx:37:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/ncmpc-0.42/src/SongRowPaint.cxx:45:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char duration[32];
data/ncmpc-0.42/src/StatusBar.cxx:105:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char elapsed_string[32], duration_string[32];
data/ncmpc-0.42/src/StatusBar.cxx:192:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/ncmpc-0.42/src/TextListRenderer.cxx:38:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/ncmpc-0.42/src/TitleBar.cxx:98:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/ncmpc-0.42/src/aconnect.cxx:70:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/ncmpc-0.42/src/charset.cxx:130:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024], *outbuf = buffer;
data/ncmpc-0.42/src/io/FileDescriptor.cxx:103:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = ::open(pathname, flags | O_NOCTTY | O_CLOEXEC, mode);
data/ncmpc-0.42/src/lyrics.cxx:41:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *args[3] = { artist, title, nullptr };
data/ncmpc-0.42/src/mpdclient.cxx:194:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/ncmpc-0.42/src/ncu.cxx:67:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[8];
data/ncmpc-0.42/src/net/AllocatedSocketAddress.cxx:48:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(address, src.GetAddress(), size);
data/ncmpc-0.42/src/net/AllocatedSocketAddress.cxx:86:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sun->sun_path, path, path_length);
data/ncmpc-0.42/src/net/Resolver.cxx:80:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(interface, "%u", i);
data/ncmpc-0.42/src/net/Resolver.cxx:91:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256], port_string[16];
data/ncmpc-0.42/src/net/Resolver.cxx:107:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, eh.host.data, eh.host.size);
data/ncmpc-0.42/src/net/StaticSocketAddress.cxx:43:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&address, other.GetAddress(), size);
data/ncmpc-0.42/src/plugin.cxx:218:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/ncmpc-0.42/src/plugin.cxx:327:39: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
std::unique_ptr<char *[]> result(new char *[num]);
data/ncmpc-0.42/src/save_playlist.cxx:106:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char prompt[256];
data/ncmpc-0.42/src/screen_find.cxx:102:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[WRLN_MAX_LINE_SIZE];
data/ncmpc-0.42/src/screen_status.cxx:38:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[256];
data/ncmpc-0.42/src/screen_utils.cxx:99:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char prompt[256];
data/ncmpc-0.42/src/strfsong.cxx:184:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[32];
data/ncmpc-0.42/src/system/EventPipe.cxx:71:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[256];
data/ncmpc-0.42/src/wreadln.cxx:231:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[32] = { (char)key };
data/ncmpc-0.42/test/run_hscroll.cxx:25:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
width = atoi(argv[3]);
data/ncmpc-0.42/test/run_hscroll.cxx:26:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
count = atoi(argv[4]);
data/ncmpc-0.42/src/BasicMarquee.cxx:32:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const char *end = AtWidthMB(p, strlen(p), width);
data/ncmpc-0.42/src/Command.cxx:241:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(i.name);
data/ncmpc-0.42/src/Completion.cxx:28:8: [1] (buffer) equal:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
std::equal(needle.begin(), needle.end(), haystack.begin());
data/ncmpc-0.42/src/Completion.cxx:44:16: [1] (buffer) mismatch:
Function does not check the second iterator for over-read conditions
(CWE-126). This function is often discouraged by most C++ coding standards
in favor of its safer alternatives provided since C++14. Consider using a
form of this function that checks the second iterator before potentially
overflowing it.
auto m = std::mismatch(lower->begin(), lower->end(),
data/ncmpc-0.42/src/ConfigParser.cxx:255:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
comma = p + strlen(p);
data/ncmpc-0.42/src/ConfigParser.cxx:304:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t length = strlen(s);
data/ncmpc-0.42/src/ConfigParser.cxx:349:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
std::transform(name, name + strlen(name), name, tolower);
data/ncmpc-0.42/src/FileListPage.cxx:572:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const unsigned duration_width = strlen(duration_string);
data/ncmpc-0.42/src/KeyDefPage.cxx:450:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(name);
data/ncmpc-0.42/src/KeyDefPage.cxx:451:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(buffer, name, size);
data/ncmpc-0.42/src/Match.cxx:37:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(expression);
data/ncmpc-0.42/src/Match.cxx:67:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return pcre_exec(re, nullptr, line, strlen(line),
data/ncmpc-0.42/src/Options.cxx:281:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(arg);
data/ncmpc-0.42/src/QueuePage.cxx:273:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (line && line[0] && line[strlen(line) - 1] == '/') {
data/ncmpc-0.42/src/QueuePage.cxx:288:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (line && line[0] && line[strlen(line) - 1] == '/') {
data/ncmpc-0.42/src/QueuePage.cxx:432:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const unsigned duration_width = strlen(duration_string);
data/ncmpc-0.42/src/SongPage.cxx:232:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const char *const value_end = value + strlen(value);
data/ncmpc-0.42/src/SongPage.cxx:242:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t label_length = std::min(strlen(label),
data/ncmpc-0.42/src/SongRowPaint.cxx:48:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
width -= strlen(duration) + 1;
data/ncmpc-0.42/src/StatusBar.cxx:78:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return strlen(p);
data/ncmpc-0.42/src/TitleBar.cxx:114:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
wmove(w, 1, window.size.width - strlen(flags) - 3);
data/ncmpc-0.42/src/charset.cxx:199:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return CopyUtf8ToLocale(dest, dest_size, src, strlen(src));
data/ncmpc-0.42/src/charset.cxx:243:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
src, strlen(src));
data/ncmpc-0.42/src/charset.cxx:247:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
:Utf8ToLocale(src, strlen(src)) {}
data/ncmpc-0.42/src/net/AllocatedSocketAddress.cxx:80:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t path_length = strlen(path) + !is_abstract;
data/ncmpc-0.42/src/net/SocketDescriptor.cxx:335:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return SetOption(SOL_SOCKET, SO_BINDTODEVICE, name, strlen(name));
data/ncmpc-0.42/src/plugin.cxx:219:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t nbytes = read(socket_event.GetSocket().Get(),
data/ncmpc-0.42/src/strfsong.cxx:263:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
value_length = strlen(value);
data/ncmpc-0.42/src/system/EventPipe.cxx:75:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return read(fds[0], buffer, sizeof(buffer)) > 0;
data/ncmpc-0.42/src/util/LocaleString.cxx:111:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/ncmpc-0.42/src/util/LocaleString.cxx:155:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return StringWidthMB(s, strlen(s));
data/ncmpc-0.42/src/util/StringStrip.cxx:74:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
std::size_t old_length = std::strlen(p);
data/ncmpc-0.42/src/wreadln.cxx:112:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
assert(x <= strlen(data));
data/ncmpc-0.42/src/wreadln.cxx:128:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t length = strlen(data);
data/ncmpc-0.42/src/wreadln.cxx:159:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
assert(right <= strlen(data));
ANALYSIS SUMMARY:
Hits = 127
Lines analyzed = 19490 in approximately 0.44 seconds (44322 lines/second)
Physical Source Lines of Code (SLOC) = 13417
Hits@level = [0] 92 [1] 35 [2] 73 [3] 8 [4] 11 [5] 0
Hits@level+ = [0+] 219 [1+] 127 [2+] 92 [3+] 19 [4+] 11 [5+] 0
Hits/KSLOC@level+ = [0+] 16.3226 [1+] 9.4656 [2+] 6.85697 [3+] 1.41611 [4+] 0.819855 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.