Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/netperfmeter-1.8.6~rc2/src/storage/ldcalc.cc
Examining data/netperfmeter-1.8.6~rc2/src/combinesummaries.cc
Examining data/netperfmeter-1.8.6~rc2/src/control.cc
Examining data/netperfmeter-1.8.6~rc2/src/control.h
Examining data/netperfmeter-1.8.6~rc2/src/cpustatus.cc
Examining data/netperfmeter-1.8.6~rc2/src/cpustatus.h
Examining data/netperfmeter-1.8.6~rc2/src/createsummary.cc
Examining data/netperfmeter-1.8.6~rc2/src/debug.h
Examining data/netperfmeter-1.8.6~rc2/src/defragmenter.cc
Examining data/netperfmeter-1.8.6~rc2/src/defragmenter.h
Examining data/netperfmeter-1.8.6~rc2/src/ext_socket.h
Examining data/netperfmeter-1.8.6~rc2/src/extractvectors.cc
Examining data/netperfmeter-1.8.6~rc2/src/flow.cc
Examining data/netperfmeter-1.8.6~rc2/src/flow.h
Examining data/netperfmeter-1.8.6~rc2/src/flowbandwidthstats.cc
Examining data/netperfmeter-1.8.6~rc2/src/flowbandwidthstats.h
Examining data/netperfmeter-1.8.6~rc2/src/flowtrafficspec.cc
Examining data/netperfmeter-1.8.6~rc2/src/flowtrafficspec.h
Examining data/netperfmeter-1.8.6~rc2/src/getabstime.cc
Examining data/netperfmeter-1.8.6~rc2/src/inputfile.cc
Examining data/netperfmeter-1.8.6~rc2/src/inputfile.h
Examining data/netperfmeter-1.8.6~rc2/src/measurement.cc
Examining data/netperfmeter-1.8.6~rc2/src/measurement.h
Examining data/netperfmeter-1.8.6~rc2/src/messagereader.cc
Examining data/netperfmeter-1.8.6~rc2/src/messagereader.h
Examining data/netperfmeter-1.8.6~rc2/src/mutex.cc
Examining data/netperfmeter-1.8.6~rc2/src/mutex.h
Examining data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc
Examining data/netperfmeter-1.8.6~rc2/src/netperfmeterpackets.h
Examining data/netperfmeter-1.8.6~rc2/src/outputfile.cc
Examining data/netperfmeter-1.8.6~rc2/src/outputfile.h
Examining data/netperfmeter-1.8.6~rc2/src/redblacktree.h
Examining data/netperfmeter-1.8.6~rc2/src/redblacktree_impl.h
Examining data/netperfmeter-1.8.6~rc2/src/rootshell.c
Examining data/netperfmeter-1.8.6~rc2/src/runtimeestimator.cc
Examining data/netperfmeter-1.8.6~rc2/src/simpleredblacktree.c
Examining data/netperfmeter-1.8.6~rc2/src/simpleredblacktree.h
Examining data/netperfmeter-1.8.6~rc2/src/thread.cc
Examining data/netperfmeter-1.8.6~rc2/src/thread.h
Examining data/netperfmeter-1.8.6~rc2/src/tools.cc
Examining data/netperfmeter-1.8.6~rc2/src/tools.h
Examining data/netperfmeter-1.8.6~rc2/src/transfer.cc
Examining data/netperfmeter-1.8.6~rc2/src/transfer.h
FINAL RESULTS:
data/netperfmeter-1.8.6~rc2/src/outputfile.cc:155:18: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
bool OutputFile::printf(const char* str, ...)
data/netperfmeter-1.8.6~rc2/src/outputfile.cc:162:26: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int bufferLength = vsnprintf(buffer, sizeof(buffer), str, va);
data/netperfmeter-1.8.6~rc2/src/outputfile.h:55:9: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
bool printf(const char* str, ...);
data/netperfmeter-1.8.6~rc2/src/tools.cc:59:4: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buffer, sizeof(buffer), fmt, va);
data/netperfmeter-1.8.6~rc2/src/tools.cc:376:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((char*)&host,string);
data/netperfmeter-1.8.6~rc2/src/tools.cc:384:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((char*)&port, &p1[2]);
data/netperfmeter-1.8.6~rc2/src/tools.cc:407:16: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((char*)&port, &p1[1]);
data/netperfmeter-1.8.6~rc2/src/tools.cc:1132:24: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
#warning Using OMNeT++ random generator instead of time-seeded one!
data/netperfmeter-1.8.6~rc2/src/tools.cc:1148:16: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom(number);
data/netperfmeter-1.8.6~rc2/src/tools.cc:1155:10: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom((unsigned int)(getMicroTime() & (uint64_t)0xffffffff));
data/netperfmeter-1.8.6~rc2/src/tools.cc:1158:23: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
const uint16_t a = random() & 0xffff;
data/netperfmeter-1.8.6~rc2/src/tools.cc:1159:23: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
const uint16_t b = random() & 0xffff;
data/netperfmeter-1.8.6~rc2/src/combinesummaries.cc:56:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[4097];
data/netperfmeter-1.8.6~rc2/src/combinesummaries.cc:103:29: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
compressionLevel = atol((char*)&argv[i][10]);
data/netperfmeter-1.8.6~rc2/src/combinesummaries.cc:137:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char commandBuffer[4097];
data/netperfmeter-1.8.6~rc2/src/control.cc:53:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char messageBuffer[sizeof(NetPerfMeterResults) +
data/netperfmeter-1.8.6~rc2/src/control.cc:57:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* fh = fopen(fileName, "w");
data/netperfmeter-1.8.6~rc2/src/control.cc:155:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char addFlowMsgBuffer[addFlowMsgSize];
data/netperfmeter-1.8.6~rc2/src/control.cc:327:20: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
configFile = fopen(configName, "w");
data/netperfmeter-1.8.6~rc2/src/control.cc:352:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char extension[32];
data/netperfmeter-1.8.6~rc2/src/control.cc:653:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char messageBuffer[sizeof(NetPerfMeterResults) +
data/netperfmeter-1.8.6~rc2/src/control.cc:754:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char description[sizeof(addFlowMsg->Description) + 1];
data/netperfmeter-1.8.6~rc2/src/control.cc:755:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char*)&description, (const char*)&addFlowMsg->Description, sizeof(addFlowMsg->Description));
data/netperfmeter-1.8.6~rc2/src/control.cc:803:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char congestionControl[sizeof(addFlowMsg->CongestionControl) + 1];
data/netperfmeter-1.8.6~rc2/src/control.cc:804:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char*)&congestionControl, (const char*)&addFlowMsg->CongestionControl, sizeof(addFlowMsg->CongestionControl));
data/netperfmeter-1.8.6~rc2/src/control.cc:808:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pathMgr[sizeof(addFlowMsg->PathMgr) + 1];
data/netperfmeter-1.8.6~rc2/src/control.cc:809:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char*)&pathMgr, (const char*)&addFlowMsg->PathMgr, sizeof(addFlowMsg->PathMgr));
data/netperfmeter-1.8.6~rc2/src/control.cc:813:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char scheduler[sizeof(addFlowMsg->Scheduler) + 1];
data/netperfmeter-1.8.6~rc2/src/control.cc:814:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char*)&scheduler, (const char*)&addFlowMsg->Scheduler, sizeof(addFlowMsg->Scheduler));
data/netperfmeter-1.8.6~rc2/src/control.cc:1008:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char inputBuffer[65536];
data/netperfmeter-1.8.6~rc2/src/cpustatus.cc:92:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ProcStatFD = fopen("/proc/stat", "r");
data/netperfmeter-1.8.6~rc2/src/cpustatus.cc:134:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(OldCpuTimes, CpuTimes, cpuTimesSize);
data/netperfmeter-1.8.6~rc2/src/cpustatus.cc:176:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(OldCpuTimes, CpuTimes, cpuTimesSize);
data/netperfmeter-1.8.6~rc2/src/cpustatus.cc:196:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:45:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Prefix[128];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:293:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char aggregate[i + 2];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:308:28: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
unsigned long value = atol((const char*)&segment[i + 1]);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:309:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char valueString[16];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:488:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char scalarName[4096];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:489:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char aggNames[MAX_NAME_SIZE];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:490:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char aggValues[MAX_VALUES_SIZE];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:540:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[4097];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:541:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char objectName[4096];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:542:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char statName[4096];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:543:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fieldName[4096];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:544:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char statisticObjectName[4096];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:545:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char statisticBlockName[4096];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:827:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[4096];
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:840:32: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
compressionLevel = atol((char*)&argv[i][10]);
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:58:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char inBuffer[4096];
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:59:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char outBuffer[sizeof(inBuffer) + 4096];
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:116:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char objectName[1024];
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:117:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char vectorName[1024];
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:216:32: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
compressionLevel = atol((char*)&argv[i][10]);
data/netperfmeter-1.8.6~rc2/src/flow.cc:290:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[64];
data/netperfmeter-1.8.6~rc2/src/flow.cc:437:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cpuUtilization[160];
data/netperfmeter-1.8.6~rc2/src/flow.cc:443:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[48];
data/netperfmeter-1.8.6~rc2/src/flow.cc:453:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[48];
data/netperfmeter-1.8.6~rc2/src/flowtrafficspec.cc:45:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[256];
data/netperfmeter-1.8.6~rc2/src/flowtrafficspec.cc:97:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ordered[32];
data/netperfmeter-1.8.6~rc2/src/flowtrafficspec.cc:98:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char reliable[32];
data/netperfmeter-1.8.6~rc2/src/inputfile.cc:65:28: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
File = (name != NULL) ? fopen(name, "r") : tmpfile();
data/netperfmeter-1.8.6~rc2/src/inputfile.cc:65:47: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
File = (name != NULL) ? fopen(name, "r") : tmpfile();
data/netperfmeter-1.8.6~rc2/src/inputfile.cc:134:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, (const char*)&Storage, StoragePos);
data/netperfmeter-1.8.6~rc2/src/inputfile.cc:163:16: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char*)&Storage, &buffer[i + 1], StoragePos);
data/netperfmeter-1.8.6~rc2/src/inputfile.h:78:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Storage[16384];
data/netperfmeter-1.8.6~rc2/src/messagereader.cc:287:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, socket->MessageBuffer, socket->MessageSize);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:92:21: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gSndBufSize = atol((const char*)¶meter[8]);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:95:21: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gRcvBufSize = atol((const char*)¶meter[8]);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:243:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char description[256];
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:483:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pathMgr[NETPERFMETER_PATHMGR_LENGTH + 1];
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:503:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char scheduler[NETPERFMETER_SCHEDULER_LENGTH + 1];
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:523:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char congestionControl[NETPERFMETER_CC_LENGTH + 1];
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:1316:29: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gOutputVerbosity = atol((const char*)&argv[i][11]);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:1324:31: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
const uint16_t localPort = atol(argv[1]);
data/netperfmeter-1.8.6~rc2/src/netperfmeterpackets.h:97:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Description[NETPERFMETER_DESCRIPTION_SIZE];
data/netperfmeter-1.8.6~rc2/src/netperfmeterpackets.h:116:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char PathMgr[NETPERFMETER_PATHMGR_LENGTH];
data/netperfmeter-1.8.6~rc2/src/netperfmeterpackets.h:117:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char CongestionControl[NETPERFMETER_CC_LENGTH];
data/netperfmeter-1.8.6~rc2/src/netperfmeterpackets.h:118:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Scheduler[NETPERFMETER_SCHEDULER_LENGTH];
data/netperfmeter-1.8.6~rc2/src/outputfile.cc:68:31: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
File = (name != NULL) ? fopen(name, "w+") : tmpfile();
data/netperfmeter-1.8.6~rc2/src/outputfile.cc:68:51: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
File = (name != NULL) ? fopen(name, "w+") : tmpfile();
data/netperfmeter-1.8.6~rc2/src/outputfile.cc:158:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[16384];
data/netperfmeter-1.8.6~rc2/src/runtimeestimator.cc:48:30: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
unsigned int totalRuns = atol(argv[2]);
data/netperfmeter-1.8.6~rc2/src/runtimeestimator.cc:49:30: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
unsigned int currentRun = atol(argv[3]);
data/netperfmeter-1.8.6~rc2/src/runtimeestimator.cc:61:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* fh = fopen(argv[1], "w");
data/netperfmeter-1.8.6~rc2/src/runtimeestimator.cc:76:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* fh = fopen(argv[1], "r");
data/netperfmeter-1.8.6~rc2/src/runtimeestimator.cc:95:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[64];
data/netperfmeter-1.8.6~rc2/src/storage/ldcalc.cc:59:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[128];
data/netperfmeter-1.8.6~rc2/src/tools.cc:56:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[16384];
data/netperfmeter-1.8.6~rc2/src/tools.cc:78:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[128];
data/netperfmeter-1.8.6~rc2/src/tools.cc:252:10: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void*)&x1, (void*)&((struct sockaddr_in6*)a1)->sin6_addr, 16);
data/netperfmeter-1.8.6~rc2/src/tools.cc:262:10: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((void*)&x2, (void*)&((struct sockaddr_in6*)a2)->sin6_addr, 16);
data/netperfmeter-1.8.6~rc2/src/tools.cc:301:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[128];
data/netperfmeter-1.8.6~rc2/src/tools.cc:302:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char scope[IFNAMSIZ + 16];
data/netperfmeter-1.8.6~rc2/src/tools.cc:303:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ifnamebuffer[IFNAMSIZ];
data/netperfmeter-1.8.6~rc2/src/tools.cc:359:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char host[128];
data/netperfmeter-1.8.6~rc2/src/tools.cc:360:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char port[128];
data/netperfmeter-1.8.6~rc2/src/tools.cc:457:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char*)address,res->ai_addr,res->ai_addrlen);
data/netperfmeter-1.8.6~rc2/src/tools.cc:488:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char str[128];
data/netperfmeter-1.8.6~rc2/src/tools.cc:683:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[localAddressCount * sizeof(sockaddr_union)];
data/netperfmeter-1.8.6~rc2/src/tools.cc:687:16: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, (void*)&localAddressArray[i].in, sizeof(sockaddr_in));
data/netperfmeter-1.8.6~rc2/src/tools.cc:692:16: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, (void*)&localAddressArray[i].in6, sizeof(sockaddr_in6));
data/netperfmeter-1.8.6~rc2/src/tools.cc:709:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&localAddress, (void*)&localAddressArray[0].in, sizeof(sockaddr_in));
data/netperfmeter-1.8.6~rc2/src/tools.cc:713:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&localAddress, (void*)&localAddressArray[0].in6, sizeof(sockaddr_in6));
data/netperfmeter-1.8.6~rc2/src/tools.cc:1145:25: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
RandomDevice = fopen("/dev/urandom", "r");
data/netperfmeter-1.8.6~rc2/src/tools.cc:1293:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cbuf[CMSG_SPACE(sizeof(struct sctp_sndrcvinfo))];
data/netperfmeter-1.8.6~rc2/src/tools.cc:1307:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sri, sinfo, sizeof(struct sctp_sndrcvinfo));
data/netperfmeter-1.8.6~rc2/src/transfer.cc:67:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char outputBuffer[MAXIMUM_MESSAGE_SIZE];
data/netperfmeter-1.8.6~rc2/src/transfer.cc:215:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char inputBuffer[65536];
data/netperfmeter-1.8.6~rc2/src/combinesummaries.cc:145:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
command[strlen(command) - 1] = 0x00;
data/netperfmeter-1.8.6~rc2/src/control.cc:207:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char*)&addFlowMsg->Description, flow->getTrafficSpec().Description.c_str(),
data/netperfmeter-1.8.6~rc2/src/control.cc:211:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char*)&addFlowMsg->CongestionControl, flow->getTrafficSpec().CongestionControl.c_str(),
data/netperfmeter-1.8.6~rc2/src/control.cc:215:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char*)&addFlowMsg->PathMgr, flow->getTrafficSpec().PathMgr.c_str(),
data/netperfmeter-1.8.6~rc2/src/control.cc:219:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char*)&addFlowMsg->Scheduler, flow->getTrafficSpec().Scheduler.c_str(),
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:174:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t length = strlen(str);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:186:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t length = strlen(str);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:200:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t length = strlen(str);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:228:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t l1 = strlen(dest);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:229:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t l2 = strlen(src);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:231:4: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(dest, src, size - l1 - 1);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:284:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t length = strlen(segment);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:294:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char*)&aggregate, segment, i + 1);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:327:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t identifierLength = strlen(identifier);
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:472:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(int i = strlen(statName) - 1; i >= 0; i--) {
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:500:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(skipListNode->Prefix)) == 0) {
data/netperfmeter-1.8.6~rc2/src/createsummary.cc:889:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
command[strlen(command) - 1] = 0x00;
data/netperfmeter-1.8.6~rc2/src/ext_socket.h:533:27: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#define ext_read(a,b,c) ::read(a,b,c)
data/netperfmeter-1.8.6~rc2/src/ext_socket.h:560:25: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#define ext_read(a,b,c) read(a,b,c)
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:118:18: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
if( (sscanf(inBuffer, "vector %u %1022s \"%1022[^\\\"]s\" ETV",
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:120:18: [1] (buffer) sscanf:
It's unclear if the %s limit in the format string is small enough
(CWE-120). Check that the limit is sufficiently small, or use a different
input function.
(sscanf(inBuffer, "vector %u %1022s %1022[^\\\"]s ETV",
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:139:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(int i = strlen(vectorName); i >= 0; i--) {
data/netperfmeter-1.8.6~rc2/src/extractvectors.cc:173:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!outputFile.write(outBuffer, strlen(outBuffer))) {
data/netperfmeter-1.8.6~rc2/src/flow.cc:1267:96: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(socketDescriptor, IPPROTO_TCP, MPTCP_PATH_MANAGER_LEGACY, pathMgr, strlen(pathMgr)) < 0) {
data/netperfmeter-1.8.6~rc2/src/flow.cc:1268:92: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(socketDescriptor, IPPROTO_TCP, MPTCP_PATH_MANAGER, pathMgr, strlen(pathMgr)) < 0) {
data/netperfmeter-1.8.6~rc2/src/flow.cc:1275:95: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(socketDescriptor, IPPROTO_TCP, MPTCP_SCHEDULER_LEGACY, scheduler, strlen(scheduler)) < 0) {
data/netperfmeter-1.8.6~rc2/src/flow.cc:1276:91: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(socketDescriptor, IPPROTO_TCP, MPTCP_SCHEDULER, scheduler, strlen(scheduler)) < 0) {
data/netperfmeter-1.8.6~rc2/src/flow.cc:1288:95: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(socketDescriptor, IPPROTO_TCP, TCP_CONGESTION, congestionControl, strlen(congestionControl)) < 0) {
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:398:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = 12 + strlen(description);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:426:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m += strlen((const char*)¶meters[m]);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:500:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = 8 + strlen((const char*)&pathMgr);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:520:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = 10 + strlen((const char*)&scheduler);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:540:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n = 3 + strlen((const char*)&congestionControl);
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:963:90: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(gMPTCPSocket, IPPROTO_TCP, MPTCP_PATH_MANAGER_LEGACY, gPathMgr, strlen(gPathMgr)) < 0) {
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:964:86: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(gMPTCPSocket, IPPROTO_TCP, MPTCP_PATH_MANAGER, gPathMgr, strlen(gPathMgr)) < 0) {
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:971:89: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(gMPTCPSocket, IPPROTO_TCP, MPTCP_SCHEDULER_LEGACY, gScheduler, strlen(gScheduler)) < 0) {
data/netperfmeter-1.8.6~rc2/src/netperfmeter.cc:972:85: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ext_setsockopt(gMPTCPSocket, IPPROTO_TCP, MPTCP_SCHEDULER, gScheduler, strlen(gScheduler)) < 0) {
data/netperfmeter-1.8.6~rc2/src/thread.cc:102:4: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(us);
data/netperfmeter-1.8.6~rc2/src/tools.cc:119:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dest, src, size);
data/netperfmeter-1.8.6~rc2/src/tools.cc:121:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return(strlen(dest) < size);
data/netperfmeter-1.8.6~rc2/src/tools.cc:128:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t l1 = strlen(dest);
data/netperfmeter-1.8.6~rc2/src/tools.cc:129:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t l2 = strlen(src);
data/netperfmeter-1.8.6~rc2/src/tools.cc:132:4: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(dest, src, size - l1 - 1);
data/netperfmeter-1.8.6~rc2/src/tools.cc:161:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
string = (char*)&string[strlen(string)];
data/netperfmeter-1.8.6~rc2/src/tools.cc:373:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(string) > sizeof(host)) {
data/netperfmeter-1.8.6~rc2/src/tools.cc:377:4: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy((char*)&port, "0");
data/netperfmeter-1.8.6~rc2/src/tools.cc:395:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(size_t i = 0;i < strlen(host);i++) {
data/netperfmeter-1.8.6~rc2/src/tools.cc:428:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
hostLength = strlen(host);
ANALYSIS SUMMARY:
Hits = 157
Lines analyzed = 12830 in approximately 0.40 seconds (32098 lines/second)
Physical Source Lines of Code (SLOC) = 9622
Hits@level = [0] 155 [1] 48 [2] 97 [3] 5 [4] 7 [5] 0
Hits@level+ = [0+] 312 [1+] 157 [2+] 109 [3+] 12 [4+] 7 [5+] 0
Hits/KSLOC@level+ = [0+] 32.4257 [1+] 16.3168 [2+] 11.3282 [3+] 1.24714 [4+] 0.727499 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.