Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/nvidia-persistenced-450.57/nvidia-cfg.h
Examining data/nvidia-persistenced-450.57/command_server.c
Examining data/nvidia-persistenced-450.57/nvidia-persistenced.c
Examining data/nvidia-persistenced-450.57/options.c
Examining data/nvidia-persistenced-450.57/nvidia-syslog-utils.c
Examining data/nvidia-persistenced-450.57/nvpd_rpc_server.c
Examining data/nvidia-persistenced-450.57/nvpd_rpc_xdr.c
Examining data/nvidia-persistenced-450.57/nvidia-numa.c
Examining data/nvidia-persistenced-450.57/nvpd_defs.h
Examining data/nvidia-persistenced-450.57/nvidia-persistenced.h
Examining data/nvidia-persistenced-450.57/nvidia-syslog-utils.h
Examining data/nvidia-persistenced-450.57/option-table.h
Examining data/nvidia-persistenced-450.57/gen-manpage-opts.c
Examining data/nvidia-persistenced-450.57/nvpd_rpc.h
Examining data/nvidia-persistenced-450.57/nvidia-numa.h
Examining data/nvidia-persistenced-450.57/common-utils/nvgetopt.c
Examining data/nvidia-persistenced-450.57/common-utils/common-utils.c
Examining data/nvidia-persistenced-450.57/common-utils/msg.c
Examining data/nvidia-persistenced-450.57/common-utils/nvgetopt.h
Examining data/nvidia-persistenced-450.57/common-utils/common-utils.h
Examining data/nvidia-persistenced-450.57/common-utils/msg.h
Examining data/nvidia-persistenced-450.57/common-utils/gen-manpage-opts-helper.c
Examining data/nvidia-persistenced-450.57/common-utils/gen-manpage-opts-helper.h
FINAL RESULTS:
data/nvidia-persistenced-450.57/nvidia-persistenced.c:815:13: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
if (chown(NVPD_VAR_RUNTIME_DATA_PATH, uid, gid) < 0) {
data/nvidia-persistenced-450.57/common-utils/common-utils.c:102:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(result, s);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:345:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ret, prefix);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:346:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(ret, replace);
data/nvidia-persistenced-450.57/common-utils/gen-manpage-opts-helper.c:42:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(scratch, o->arg_name);
data/nvidia-persistenced-450.57/common-utils/msg.c:231:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int vsnprintf(char *str, size_t size, const char *format,
data/nvidia-persistenced-450.57/common-utils/msg.h:72:19: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = vsnprintf((buf), current_len, (fmt), ap); \
data/nvidia-persistenced-450.57/nvidia-numa.c:101:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(info_path, NV_DEVICE_INFO_PATH_FMT, domain, bus, slot, function);
data/nvidia-persistenced-450.57/nvidia-numa.c:143:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(dev_file, NV_DEVICE_FILE_NAME, minor_num);
data/nvidia-persistenced-450.57/nvidia-numa.c:285:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(numa_file_path, MEMBLK_STATE_PATH_FMT, mem_block_id);
data/nvidia-persistenced-450.57/nvidia-numa.c:330:13: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
return (sscanf(dirname, "memory%" PRIu32, block_id) == 1) ? 0 : -EINVAL;
data/nvidia-persistenced-450.57/nvidia-numa.c:349:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(numa_file_path, NID_PATH_FMT, node_id);
data/nvidia-persistenced-450.57/nvidia-numa.c:499:9: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(blacklisted_addr_str, "0x%"PRIx64,
data/nvidia-persistenced-450.57/nvidia-numa.c:542:9: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(start_addr_str, "0x%"PRIx64, start_addr);
data/nvidia-persistenced-450.57/nvidia-numa.c:551:9: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(memory_file_str, MEMBLK_DIR_PATH_FMT, memory_num);
data/nvidia-persistenced-450.57/nvidia-numa.c:554:13: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(memory_file_str, F_OK) != 0) {
data/nvidia-persistenced-450.57/nvidia-numa.c:676:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(numa_file_path, NID_PATH_FMT, node_id);
data/nvidia-persistenced-450.57/nvidia-numa.c:696:9: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(memory_file_path, MEMBLK_STATE_PATH_FMT, block_id);
data/nvidia-persistenced-450.57/nvidia-numa.c:712:13: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(memory_file_path, MEMBLK_VALID_ZONES_PATH_FMT, block_id);
data/nvidia-persistenced-450.57/nvidia-numa.c:725:17: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
syslog(LOG_NOTICE, MEMORY_AUTO_ONLINE_WARNING_FMT,
data/nvidia-persistenced-450.57/nvidia-persistenced.c:838:9: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(NVPD_VAR_RUNTIME_DATA_PATH, R_OK | W_OK) < 0) {
data/nvidia-persistenced-450.57/nvidia-syslog-utils.h:49:9: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
syslog(priority, format, ##__VA_ARGS__); \
data/nvidia-persistenced-450.57/common-utils/common-utils.c:315:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
prefix = getenv("HOME");
data/nvidia-persistenced-450.57/common-utils/common-utils.c:397:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tmpbuf, buf, len);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:446:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(pathname, flags, mode);
data/nvidia-persistenced-450.57/common-utils/gen-manpage-opts-helper.c:34:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char scratch[64], *s;
data/nvidia-persistenced-450.57/common-utils/nvgetopt.c:459:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char scratch[16];
data/nvidia-persistenced-450.57/nvidia-cfg.h:96:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char monitor_name[64];
data/nvidia-persistenced-450.57/nvidia-numa.c:99:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char info_path[BUF_SIZE], read_buf[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:103:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(info_path, "r");
data/nvidia-persistenced-450.57/nvidia-numa.c:119:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*minor_num = atoi(last_str + 1);
data/nvidia-persistenced-450.57/nvidia-numa.c:152:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dev_file[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:160:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
*fd = open(dev_file, O_RDWR);
data/nvidia-persistenced-450.57/nvidia-numa.c:219:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(path_to_file, O_RDONLY, S_IRUSR);
data/nvidia-persistenced-450.57/nvidia-numa.c:254:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(path_to_file, O_WRONLY | O_TRUNC, S_IWUSR);
data/nvidia-persistenced-450.57/nvidia-numa.c:282:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:283:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char numa_file_path[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:345:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char numa_file_path[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:495:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char blacklisted_addr_str[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:526:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char start_addr_str[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:527:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char memory_file_str[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:668:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char read_buf[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:669:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char numa_file_path[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-numa.c:670:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char memory_file_path[BUF_SIZE];
data/nvidia-persistenced-450.57/nvidia-persistenced.c:692:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pid_str[13];
data/nvidia-persistenced-450.57/nvidia-persistenced.c:848:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(NVPD_PID_FILE, O_RDWR | O_CREAT, 0644);
data/nvidia-persistenced-450.57/nvidia-persistenced.c:867:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(pid_str, "%d\n", pid);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:84:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(s);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:181:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (m, s, n);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:331:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!replace) replace = str + strlen(str);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:335:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(user, str+1, len-1);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:344:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret = malloc(strlen(prefix) + strlen(replace) + 1);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:344:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret = malloc(strlen(prefix) + strlen(replace) + 1);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:404:15: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ret = fgetc(fp);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:429:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return (s + strlen(s));
data/nvidia-persistenced-450.57/common-utils/common-utils.c:615:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (end = ret + strlen(ret) - 1; end >= ret && isspace(*end); end--) {
data/nvidia-persistenced-450.57/common-utils/common-utils.c:644:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(string);
data/nvidia-persistenced-450.57/common-utils/common-utils.c:715:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(string);
data/nvidia-persistenced-450.57/common-utils/gen-manpage-opts-helper.c:44:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(o->name);
data/nvidia-persistenced-450.57/common-utils/msg.c:275:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
z = strlen(buf); /* length of entire string */
data/nvidia-persistenced-450.57/common-utils/msg.c:281:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prefix_len = strlen(prefix);
data/nvidia-persistenced-450.57/common-utils/msg.c:328:27: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
if (local_prefix) strncpy(line, local_prefix, prefix_len);
data/nvidia-persistenced-450.57/common-utils/msg.c:329:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(line + prefix_len, a, len - prefix_len);
data/nvidia-persistenced-450.57/common-utils/msg.c:381:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(msg);
data/nvidia-persistenced-450.57/nvidia-numa.c:227:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read_count = read(fd, read_buffer, read_buffer_size - 1);
data/nvidia-persistenced-450.57/nvidia-numa.c:309:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
status = write_string_to_file(numa_file_path, cmd, strlen(cmd));
data/nvidia-persistenced-450.57/nvidia-numa.c:508:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(blacklisted_addr_str));
data/nvidia-persistenced-450.57/nvidia-numa.c:548:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(start_addr_str));
data/nvidia-persistenced-450.57/nvidia-persistenced.c:249:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
bytes = read(pipe_read_fd, &success, sizeof(success));
data/nvidia-persistenced-450.57/nvidia-persistenced.c:752:5: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(0);
data/nvidia-persistenced-450.57/nvidia-persistenced.c:868:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (write(pid_fd, pid_str, strlen(pid_str)) != strlen(pid_str)) {
data/nvidia-persistenced-450.57/nvidia-persistenced.c:868:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (write(pid_fd, pid_str, strlen(pid_str)) != strlen(pid_str)) {
ANALYSIS SUMMARY:
Hits = 72
Lines analyzed = 5793 in approximately 0.17 seconds (33494 lines/second)
Physical Source Lines of Code (SLOC) = 3217
Hits@level = [0] 113 [1] 25 [2] 24 [3] 1 [4] 21 [5] 1
Hits@level+ = [0+] 185 [1+] 72 [2+] 47 [3+] 23 [4+] 22 [5+] 1
Hits/KSLOC@level+ = [0+] 57.507 [1+] 22.3811 [2+] 14.6099 [3+] 7.14952 [4+] 6.83867 [5+] 0.310849
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.