Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/pdl-2.025/Basic/Core/pdlhash.c
Examining data/pdl-2.025/Basic/Core/pdlapi.c
Examining data/pdl-2.025/Basic/Core/pdlmagic.c
Examining data/pdl-2.025/Basic/Core/pdltest.c
Examining data/pdl-2.025/Basic/Core/pdlthread.h
Examining data/pdl-2.025/Basic/Core/pdlmagic.h
Examining data/pdl-2.025/Basic/Core/ppport.h
Examining data/pdl-2.025/Basic/Core/pdlthread.c
Examining data/pdl-2.025/Basic/Math/const.c
Examining data/pdl-2.025/Basic/Math/asinh.c
Examining data/pdl-2.025/Basic/Math/quiet_nan.c
Examining data/pdl-2.025/Basic/Math/cpoly.c
Examining data/pdl-2.025/Basic/Math/protos.h
Examining data/pdl-2.025/Basic/Math/polevl.c
Examining data/pdl-2.025/Basic/Math/mconf.h
Examining data/pdl-2.025/Basic/Math/ndtri.c
Examining data/pdl-2.025/Basic/Math/mtherr.c
Examining data/pdl-2.025/Basic/Math/jn.c
Examining data/pdl-2.025/Basic/Math/j0.c
Examining data/pdl-2.025/Basic/Math/atanh.c
Examining data/pdl-2.025/Basic/Math/j1.c
Examining data/pdl-2.025/Basic/Math/ndtr.c
Examining data/pdl-2.025/Basic/Math/cpoly.h
Examining data/pdl-2.025/Basic/Math/infinity.c
Examining data/pdl-2.025/Basic/Math/yn.c
Examining data/pdl-2.025/Basic/Math/acosh.c
Examining data/pdl-2.025/Basic/Math/rint.c
Examining data/pdl-2.025/Basic/MatrixOps/sslib.h
Examining data/pdl-2.025/Basic/MatrixOps/protos.h
Examining data/pdl-2.025/Basic/MatrixOps/matrix.c
Examining data/pdl-2.025/Basic/MatrixOps/simq.c
Examining data/pdl-2.025/Basic/MatrixOps/sslib.c
Examining data/pdl-2.025/Basic/MatrixOps/complex.c
Examining data/pdl-2.025/Basic/MatrixOps/eigen.c
Examining data/pdl-2.025/Basic/MatrixOps/complex.h
Examining data/pdl-2.025/Basic/MatrixOps/eigens.c
Examining data/pdl-2.025/Basic/MatrixOps/eigen.h
Examining data/pdl-2.025/Basic/MatrixOps/blas.c
Examining data/pdl-2.025/Basic/MatrixOps/svd.c
Examining data/pdl-2.025/Basic/MatrixOps/matrix.h
Examining data/pdl-2.025/pdl.c
Examining data/pdl-2.025/t/callext.c
Examining data/pdl-2.025/IO/Browser/browse.c
Examining data/pdl-2.025/Lib/Fit/Gaussian/gauss.c
Examining data/pdl-2.025/Lib/Minuit/FCN.c
Examining data/pdl-2.025/Lib/Compression/ricecomp.c
Examining data/pdl-2.025/Lib/GIS/Proj/include/projects.h
Examining data/pdl-2.025/Lib/FFT/fftn.c
Examining data/pdl-2.025/Lib/FFT/fftn.h
Examining data/pdl-2.025/Lib/Image2D/resample.c
Examining data/pdl-2.025/Lib/Image2D/rotate.c
Examining data/pdl-2.025/Lib/Image2D/resample.h
Examining data/pdl-2.025/Lib/GSL/SF/gslerr.h
Examining data/pdl-2.025/Lib/GSL/INTEG/FUNC.c
Examining data/pdl-2.025/Lib/GSL/INTERP/gslerr.h
Examining data/pdl-2.025/Lib/GSL/MROOT/FUNC.c
Examining data/pdl-2.025/Lib/GSL/DIFF/FUNC.c
Examining data/pdl-2.025/Lib/ImageRGB/pdlppm.h
Examining data/pdl-2.025/Lib/ImageRGB/ppm_quant.c
Examining data/pdl-2.025/Graphics/IIS/libiis.h
Examining data/pdl-2.025/Graphics/IIS/pdliisdisp.c
FINAL RESULTS:
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:239:36: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncpy(iname,home,STRSIZE); strncat(iname,"/iraf/dev/imt1i",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:242:36: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncpy(iname,home,STRSIZE); strncat(iname,"/dev/imt1i",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:269:36: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncpy(oname,home,STRSIZE); strncat(oname,"/iraf/dev/imt1o",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:272:36: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncpy(oname,home,STRSIZE); strncat(oname,"/dev/imt1o",STRSIZE);
data/pdl-2.025/Basic/Core/pdlapi.c:444:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf("%s%"IND_FLAG,(i?" ":""),foo->incs[i]);
data/pdl-2.025/Basic/Core/pdlapi.c:448:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf("%s%"IND_FLAG,(i?" ":""),foo->pdls[1]->dims[i]);
data/pdl-2.025/Basic/Core/pdlapi.c:485:3: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf("%s%"IND_FLAG,(i?" ":""),it->dims[i]);
data/pdl-2.025/Basic/Core/pdlapi.c:495:4: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf("%s%"IND_FLAG,(i?" ":""),it->vafftrans->incs[i]);
data/pdl-2.025/Basic/Core/pdlmagic.c:456:19: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int extralen = vsnprintf(NULL, 0, pat, *args) + 1;
data/pdl-2.025/Basic/Core/pdlmagic.c:467:4: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf( *msgs + *len, extralen + 1, pat, *args);
data/pdl-2.025/Basic/Core/pdlthread.c:37:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf("%s%"IND_FLAG,(i?" ":""),iarr[i]); // IND_FLAG in pdl.h, at build time from Types.pm.PL
data/pdl-2.025/Basic/Core/pdlthread.c:489:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(s," Mismatched implicit thread dimension %d: size %"IND_FLAG" vs. %"IND_FLAG"\nThere are %d PDLs in the expression; %d thread dim%s.\n",i,thread->dims[nth],pdls[j]->dims[i+realdims[j]],thread->npdls,nimpl,(nimpl==1)?"":"s");
data/pdl-2.025/Basic/Core/pdlthread.c:500:7: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(s,format,"ACTIVE DIMS | ");
data/pdl-2.025/Basic/Core/pdlthread.c:507:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(s," #%3d (%s",ii,creating[ii]?"null)\n":"normal): ");
data/pdl-2.025/Basic/Core/pdlthread.c:516:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(s,"%8s"," ");
data/pdl-2.025/Basic/Core/pdlthread.c:760:3: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(msgptr, remaining, pat, args);
data/pdl-2.025/Basic/Core/ppport.h:6346:14: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
retval = vsnprintf(buffer, len, format, ap);
data/pdl-2.025/Basic/Core/ppport.h:6348:14: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
retval = vsprintf(buffer, format, ap);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:240:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(iname,F_OK))
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:243:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(iname,F_OK))
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:246:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(iname,F_OK))
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:270:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(oname,F_OK))
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:273:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(oname,F_OK))
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:276:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!access(oname,F_OK))
data/pdl-2.025/IO/Browser/browse.c:42:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(str,format[type],*(((char *)data)+y*nx+x));
data/pdl-2.025/IO/Browser/browse.c:45:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(str,format[type],*(((short *)data)+y*nx+x));
data/pdl-2.025/IO/Browser/browse.c:48:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(str,format[type],*(((unsigned short *)data)+y*nx+x));
data/pdl-2.025/IO/Browser/browse.c:51:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(str,format[type],*(((int *)data)+y*nx+x));
data/pdl-2.025/IO/Browser/browse.c:54:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(str,format[type],*(((long long *)data)+y*nx+x));
data/pdl-2.025/IO/Browser/browse.c:57:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(str,format[type],*(((float *)data)+y*nx+x));
data/pdl-2.025/IO/Browser/browse.c:60:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(str,format[type],*(((double *)data)+y*nx+x));
data/pdl-2.025/Lib/GSL/INTERP/gslerr.h:6:72: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
#define GSLERR(x,y) gsl_set_error_handler_off (); if ((status = x y)) {sprintf(buf,"Error in %s: %s",# x ,gsl_strerror(status));barf(buf);}
data/pdl-2.025/Lib/ImageRGB/ppm_quant.c:13:25: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#define FatalError(x) { fprintf(stderr,x); return(NULL); }
data/pdl-2.025/pdl.c:34:5: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system("which perldl");
data/pdl-2.025/pdl.c:64:7: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(perldl,argv2);
data/pdl-2.025/pdl.c:71:3: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(perldl,argv);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:217:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
home = getenv("HOME");
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:219:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
imtdev = getenv("IMTDEV");
data/pdl-2.025/Lib/GIS/Proj/include/projects.h:92:11: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
# define getenv wceex_getenv
data/pdl-2.025/Basic/Core/pdlapi.c:344:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(it->data,src->data, pdl_howbig(it->datatype) * it->nvals);
data/pdl-2.025/Basic/Core/pdlapi.c:394:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char spaces[PDL_MAXSPACE];
data/pdl-2.025/Basic/Core/pdlapi.c:427:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char spaces[PDL_MAXSPACE];
data/pdl-2.025/Basic/Core/pdlapi.c:467:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char spaces[PDL_MAXSPACE];
data/pdl-2.025/Basic/Core/pdlthread.c:484:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf0[BUFSIZ];
data/pdl-2.025/Basic/Core/pdlthread.c:496:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s, " PDL IN EXPR. "); s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:498:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char format[80];
data/pdl-2.025/Basic/Core/pdlthread.c:499:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(format,"%%%ds",8 * maxrealdims + 3);
data/pdl-2.025/Basic/Core/pdlthread.c:503:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s,"THREAD DIMS\n");
data/pdl-2.025/Basic/Core/pdlthread.c:512:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s," ");
data/pdl-2.025/Basic/Core/pdlthread.c:520:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s,"%8ld",(long)(pdls[ii]->dims[jj]));
data/pdl-2.025/Basic/Core/pdlthread.c:524:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s," | ");
data/pdl-2.025/Basic/Core/pdlthread.c:528:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s,"%8ld",(long)(pdls[ii]->dims[jj+thread->realdims[ii]]));
data/pdl-2.025/Basic/Core/pdlthread.c:713:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char message [4096] = {'\0'};
data/pdl-2.025/Basic/Core/pdlthread.c:732:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(msgptr, "ERROR: UNKNOWN PARAMETER");
data/pdl-2.025/Basic/Core/ppport.h:3549:42: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
# define CopyD(s,d,n,t) memcpy((char*)(d),(char*)(s), (n) * sizeof(t))
data/pdl-2.025/Basic/Core/ppport.h:6201:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
&& (xdigit = strchr((char *) PL_hexdigit, s[1])))
data/pdl-2.025/Basic/Core/ppport.h:6397:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst + used, src, copy);
data/pdl-2.025/Basic/Core/ppport.h:6426:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst, src, copy);
data/pdl-2.025/Basic/Math/mtherr.c:66:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char *ermsg[7] = {
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:64:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char wcsbuf[SZ_WCSTEXT];
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:67:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char label[1024]; /* wcs file title */
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:214:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char iname[STRSIZE],oname[STRSIZE];
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:295:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((iispipe_i = open (oname, O_RDONLY | O_NONBLOCK)) != -1) {
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:296:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((iispipe_o = open (oname, O_WRONLY | O_NONBLOCK)) != -1) {
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:306:21: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((iispipe_i = open (iname, O_RDONLY | O_NONBLOCK)) != -1) {
data/pdl-2.025/IO/Browser/browse.c:74:36: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*(((PDL_Byte *)data)+y*nx+x) = atol(str);
data/pdl-2.025/IO/Browser/browse.c:77:37: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*(((PDL_Short *)data)+y*nx+x) = atol(str);
data/pdl-2.025/IO/Browser/browse.c:80:38: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*(((PDL_Ushort *)data)+y*nx+x) = atol(str);
data/pdl-2.025/IO/Browser/browse.c:83:36: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*(((PDL_Long *)data)+y*nx+x) = atol(str);
data/pdl-2.025/IO/Browser/browse.c:86:40: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*(((PDL_LongLong *)data)+y*nx+x) = atol(str);
data/pdl-2.025/IO/Browser/browse.c:103:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/pdl-2.025/IO/Browser/browse.c:111:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(line,"%d",ioff+x);
data/pdl-2.025/IO/Browser/browse.c:123:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/pdl-2.025/IO/Browser/browse.c:130:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(line,"%-4d",joff+y);
data/pdl-2.025/IO/Browser/browse.c:141:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/pdl-2.025/IO/Browser/browse.c:155:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/pdl-2.025/IO/Browser/browse.c:175:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/pdl-2.025/IO/Browser/browse.c:196:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[BUFSIZ];
data/pdl-2.025/IO/Browser/browse.c:220:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[CHBUF],echobuf[CHBUF],line[CHBUF];
data/pdl-2.025/IO/Browser/browse.c:255:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s,"Perldl data browser: type %d, (%d,%d), type q to quit\n",
data/pdl-2.025/IO/Browser/browse.c:280:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(echobuf,"%8o",ch);
data/pdl-2.025/Lib/Compression/ricecomp.c:231:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
case 1: nextpix = ((char *)a)[i+j]; break;
data/pdl-2.025/Lib/Compression/ricecomp.c:591:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
case 1: ((char *)array)[i] = lastpix; break;
data/pdl-2.025/Lib/Compression/ricecomp.c:627:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
((char *)array)[i] = diff + lastpix;
data/pdl-2.025/Lib/Compression/ricecomp.c:628:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
lastpix = ((char *)array)[i];
data/pdl-2.025/Lib/Compression/ricecomp.c:672:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
((char *)array)[i] = diff + lastpix;
data/pdl-2.025/Lib/Compression/ricecomp.c:673:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
lastpix = ((char *)array)[i];
data/pdl-2.025/Lib/GIS/Proj/include/projects.h:215:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char param[1]; } paralist;
data/pdl-2.025/Lib/GIS/Proj/include/projects.h:258:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char axis[4];
data/pdl-2.025/Lib/GIS/Proj/include/projects.h:334:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char id[MAX_TAB_ID]; /* ascii info */
data/pdl-2.025/Lib/GSL/INTERP/gslerr.h:3:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[200];
data/pdl-2.025/Lib/GSL/SF/gslerr.h:3:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[200];
data/pdl-2.025/pdl.c:24:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char perldl[BUFSIZ];
data/pdl-2.025/Basic/Core/pdlapi.c:418:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sz += strlen(flagchar[i]);
data/pdl-2.025/Basic/Core/pdlhash.c:79:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(void)hv_store(hash, key, strlen(key), newRV( (SV*) array), 0 );
data/pdl-2.025/Basic/Core/pdlthread.c:488:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s = buf0+strlen(buf0);
data/pdl-2.025/Basic/Core/pdlthread.c:490:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:496:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(s, " PDL IN EXPR. "); s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:501:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:504:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:508:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:513:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:517:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:521:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:525:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:529:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:531:7: [1] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source is a constant character.
sprintf(s,"\n");
data/pdl-2.025/Basic/Core/pdlthread.c:532:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s += strlen(s);
data/pdl-2.025/Basic/Core/pdlthread.c:719:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int N = strlen(msgptr); \
data/pdl-2.025/Basic/Core/ppport.h:4835:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sv_vsetpvfn(sv, pat, strlen(pat), args, Null(SV**), 0, Null(bool*));
data/pdl-2.025/Basic/Core/ppport.h:4843:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
# define sv_vcatpvf(sv, pat, args) sv_vcatpvfn(sv, pat, strlen(pat), args, Null(SV**), 0, Null(bool*))
data/pdl-2.025/Basic/Core/ppport.h:4847:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
# define sv_vsetpvf(sv, pat, args) sv_vsetpvfn(sv, pat, strlen(pat), args, Null(SV**), 0, Null(bool*))
data/pdl-2.025/Basic/Core/ppport.h:4867:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sv_vcatpvfn(sv, pat, strlen(pat), &args, Null(SV**), 0, Null(bool*));
data/pdl-2.025/Basic/Core/ppport.h:4895:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sv_vcatpvfn(sv, pat, strlen(pat), &args, Null(SV**), 0, Null(bool*));
data/pdl-2.025/Basic/Core/ppport.h:4916:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sv_vcatpvfn(sv, pat, strlen(pat), args, Null(SV**), 0, Null(bool*)); \
data/pdl-2.025/Basic/Core/ppport.h:4938:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sv_vsetpvfn(sv, pat, strlen(pat), &args, Null(SV**), 0, Null(bool*));
data/pdl-2.025/Basic/Core/ppport.h:4966:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sv_vsetpvfn(sv, pat, strlen(pat), &args, Null(SV**), 0, Null(bool*));
data/pdl-2.025/Basic/Core/ppport.h:4987:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sv_vsetpvfn(sv, pat, strlen(pat), args, Null(SV**), 0, Null(bool*)); \
data/pdl-2.025/Basic/Core/ppport.h:5795:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
STRLEN len = strlen(radix);
data/pdl-2.025/Basic/Core/ppport.h:6393:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
used = strlen(dst);
data/pdl-2.025/Basic/Core/ppport.h:6394:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(src);
data/pdl-2.025/Basic/Core/ppport.h:6423:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(src);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:45:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((nbytes = read (iispipe_i, buf, SZ_WCSTEXT)) <= 0)
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:232:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(iname,tok,STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:239:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(iname,home,STRSIZE); strncat(iname,"/iraf/dev/imt1i",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:242:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(iname,home,STRSIZE); strncat(iname,"/dev/imt1i",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:245:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(iname,"/dev/imt1i",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:250:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(iname,inpipe,STRSIZE); /* Use supplied arg */
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:263:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(oname,tok,STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:269:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(oname,home,STRSIZE); strncat(oname,"/iraf/dev/imt1o",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:272:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(oname,home,STRSIZE); strncat(oname,"/dev/imt1o",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:275:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(oname,"/dev/imt1o",STRSIZE);
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:280:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(oname,outpipe,STRSIZE); /* Use supplied arg */
data/pdl-2.025/Graphics/IIS/pdliisdisp.c:348:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
n = read (iispipe_i, buf, size - total);
data/pdl-2.025/IO/Browser/browse.c:112:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(line);
data/pdl-2.025/IO/Browser/browse.c:131:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(line);
data/pdl-2.025/IO/Browser/browse.c:163:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(line);
data/pdl-2.025/IO/Browser/browse.c:184:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(line);
data/pdl-2.025/IO/Browser/browse.c:205:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(line);
data/pdl-2.025/pdl.c:37:3: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read(pipes[0],perldl,BUFSIZ);
ANALYSIS SUMMARY:
Hits = 140
Lines analyzed = 20983 in approximately 0.62 seconds (34077 lines/second)
Physical Source Lines of Code (SLOC) = 12078
Hits@level = [0] 187 [1] 47 [2] 54 [3] 3 [4] 32 [5] 4
Hits@level+ = [0+] 327 [1+] 140 [2+] 93 [3+] 39 [4+] 36 [5+] 4
Hits/KSLOC@level+ = [0+] 27.074 [1+] 11.5913 [2+] 7.69995 [3+] 3.22901 [4+] 2.98063 [5+] 0.331181
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.