Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/psocksxx-1.1.1/lib/psocksxx/iosocks.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/iosocks.h
Examining data/psocksxx-1.1.1/lib/psocksxx/iosockstream.h
Examining data/psocksxx-1.1.1/lib/psocksxx/isockstream.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/isockstream.h
Examining data/psocksxx-1.1.1/lib/psocksxx/lsockaddr.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/lsockaddr.h
Examining data/psocksxx-1.1.1/lib/psocksxx/lsockstream.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/lsockstream.h
Examining data/psocksxx-1.1.1/lib/psocksxx/nsockaddr.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/nsockaddr.h
Examining data/psocksxx-1.1.1/lib/psocksxx/nsockstream.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/nsockstream.h
Examining data/psocksxx-1.1.1/lib/psocksxx/osockstream.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/osockstream.h
Examining data/psocksxx-1.1.1/lib/psocksxx/sockaddr.h
Examining data/psocksxx-1.1.1/lib/psocksxx/sockexception.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/sockexception.h
Examining data/psocksxx-1.1.1/lib/psocksxx/sockstreambuf.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/socktimeoutexception.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/socktimeoutexception.h
Examining data/psocksxx-1.1.1/lib/psocksxx/tcpnsockstream.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/tcpnsockstream.h
Examining data/psocksxx-1.1.1/lib/psocksxx/udpnsockstream.cpp
Examining data/psocksxx-1.1.1/lib/psocksxx/udpnsockstream.h
Examining data/psocksxx-1.1.1/lib/psocksxx/sockstreambuf.h
Examining data/psocksxx-1.1.1/src/examples/echo/client.cpp
Examining data/psocksxx-1.1.1/src/examples/echo/server.cpp
Examining data/psocksxx-1.1.1/test/lecho.cpp
Examining data/psocksxx-1.1.1/test/lecho.h
Examining data/psocksxx-1.1.1/test/lsockstream_test.cpp
Examining data/psocksxx-1.1.1/test/necho.cpp
Examining data/psocksxx-1.1.1/test/necho.h
Examining data/psocksxx-1.1.1/test/nsockaddr_test.cpp
Examining data/psocksxx-1.1.1/test/nsockstream_test.cpp
Examining data/psocksxx-1.1.1/test/nsockstream_test.h
Examining data/psocksxx-1.1.1/test/sockstreambuf_test.cpp
Examining data/psocksxx-1.1.1/test/sockstreambuf_test.h
Examining data/psocksxx-1.1.1/test/socktimeoutexception_test.cpp
Examining data/psocksxx-1.1.1/test/socktimeoutexception_test.h
Examining data/psocksxx-1.1.1/test/tap-runner.cpp
Examining data/psocksxx-1.1.1/test/tap/tap_listener.cpp
Examining data/psocksxx-1.1.1/test/tap/tap_listener.h
Examining data/psocksxx-1.1.1/test/tcpnsockstream_test.cpp
Examining data/psocksxx-1.1.1/test/tcpnsockstream_test.h
Examining data/psocksxx-1.1.1/test/udpnsockstream_test.cpp
Examining data/psocksxx-1.1.1/test/udpnsockstream_test.h
Examining data/psocksxx-1.1.1/test/nsockaddr_test.h
Examining data/psocksxx-1.1.1/test/lsockstream_test.h
FINAL RESULTS:
data/psocksxx-1.1.1/lib/psocksxx/lsockaddr.cpp:33:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy( sun_path, path );
data/psocksxx-1.1.1/test/lecho.cpp:78:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy( saddr.sun_path, _lsock_path );
data/psocksxx-1.1.1/test/lecho.cpp:174:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy( saddr.sun_path, _lsock_path );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:49:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy( saddr.sun_path, path );
data/psocksxx-1.1.1/lib/psocksxx/lsockstream.cpp:31:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb->open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/lib/psocksxx/nsockstream.cpp:32:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb->open( sockstreambuf::pf_inet, type, proto );
data/psocksxx-1.1.1/lib/psocksxx/sockstreambuf.cpp:89:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void sockstreambuf::open( socket_domain_t domain, socket_type_t type, socket_protocol_t proto ) throw( sockexception ) {
data/psocksxx-1.1.1/lib/psocksxx/sockstreambuf.h:128:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open( socket_domain_t domain, socket_type_t type, socket_protocol_t proto = proto_unspec ) throw( sockexception );
data/psocksxx-1.1.1/test/lecho.cpp:105:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cbuffer[64];
data/psocksxx-1.1.1/test/necho.cpp:155:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cbuffer[64];
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:87:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::ipproto_ip ) );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:173:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:206:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:248:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:277:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:308:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:380:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:420:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:472:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:517:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/sockstreambuf_test.cpp:610:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ssb.open( sockstreambuf::pf_local, sockstreambuf::sock_stream, sockstreambuf::proto_unspec );
data/psocksxx-1.1.1/test/tcpnsockstream_test.cpp:80:51: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
CPPUNIT_ASSERT_NO_THROW( ss.connect( NSOCK_NODE, atoi( NSOCK_SERVICE_2 ) ) );
data/psocksxx-1.1.1/lib/psocksxx/sockstreambuf.cpp:427:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read_size = ::read( _socket, read_buffer, readable_size );
data/psocksxx-1.1.1/test/lecho.cpp:184:4: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep( 500 );
data/psocksxx-1.1.1/test/necho.cpp:217:4: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep( 500 );
ANALYSIS SUMMARY:
Hits = 25
Lines analyzed = 5148 in approximately 0.14 seconds (36967 lines/second)
Physical Source Lines of Code (SLOC) = 1856
Hits@level = [0] 2 [1] 3 [2] 18 [3] 0 [4] 4 [5] 0
Hits@level+ = [0+] 27 [1+] 25 [2+] 22 [3+] 4 [4+] 4 [5+] 0
Hits/KSLOC@level+ = [0+] 14.5474 [1+] 13.4698 [2+] 11.8534 [3+] 2.15517 [4+] 2.15517 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.