Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/pumpa-0.9.3/src/fullobjectwidget.cpp
Examining data/pumpa-0.9.3/src/oauthwizard.cpp
Examining data/pumpa-0.9.3/src/shortobjectwidget.h
Examining data/pumpa-0.9.3/src/imagelabel.h
Examining data/pumpa-0.9.3/src/activitywidget.h
Examining data/pumpa-0.9.3/src/sundown/houdini_html_e.c
Examining data/pumpa-0.9.3/src/sundown/stack.h
Examining data/pumpa-0.9.3/src/sundown/stack.c
Examining data/pumpa-0.9.3/src/sundown/html_smartypants.c
Examining data/pumpa-0.9.3/src/sundown/autolink.c
Examining data/pumpa-0.9.3/src/sundown/html.h
Examining data/pumpa-0.9.3/src/sundown/houdini_href_e.c
Examining data/pumpa-0.9.3/src/sundown/html_blocks.h
Examining data/pumpa-0.9.3/src/sundown/markdown.c
Examining data/pumpa-0.9.3/src/sundown/autolink.h
Examining data/pumpa-0.9.3/src/sundown/buffer.c
Examining data/pumpa-0.9.3/src/sundown/html.c
Examining data/pumpa-0.9.3/src/sundown/markdown.h
Examining data/pumpa-0.9.3/src/sundown/houdini.h
Examining data/pumpa-0.9.3/src/sundown/buffer.h
Examining data/pumpa-0.9.3/src/contextwidget.cpp
Examining data/pumpa-0.9.3/src/recipientedit.h
Examining data/pumpa-0.9.3/src/fancyhighlighter.cpp
Examining data/pumpa-0.9.3/src/pumpasettingsdialog.cpp
Examining data/pumpa-0.9.3/src/collectionwidget.h
Examining data/pumpa-0.9.3/src/qactivitystreams.cpp
Examining data/pumpa-0.9.3/src/editprofiledialog.h
Examining data/pumpa-0.9.3/src/actorwidget.cpp
Examining data/pumpa-0.9.3/src/shortobjectwidget.cpp
Examining data/pumpa-0.9.3/src/qasactivity.h
Examining data/pumpa-0.9.3/src/objectwidgetwithsignals.cpp
Examining data/pumpa-0.9.3/src/filedownloader.h
Examining data/pumpa-0.9.3/src/qaspell.cpp
Examining data/pumpa-0.9.3/src/fullobjectwidget.h
Examining data/pumpa-0.9.3/src/objectwidgetwithsignals.h
Examining data/pumpa-0.9.3/src/messagerecipients.cpp
Examining data/pumpa-0.9.3/src/messagewindow.cpp
Examining data/pumpa-0.9.3/src/qasobjectlist.cpp
Examining data/pumpa-0.9.3/src/pumpasettings.cpp
Examining data/pumpa-0.9.3/src/qaspell.h
Examining data/pumpa-0.9.3/src/fancyhighlighter.h
Examining data/pumpa-0.9.3/src/activitywidget.cpp
Examining data/pumpa-0.9.3/src/texttoolbutton.cpp
Examining data/pumpa-0.9.3/src/messagerecipients.h
Examining data/pumpa-0.9.3/src/qasactor.h
Examining data/pumpa-0.9.3/src/qasactivity.cpp
Examining data/pumpa-0.9.3/src/qasobject.h
Examining data/pumpa-0.9.3/src/oauthwizard.h
Examining data/pumpa-0.9.3/src/pumpasettingsdialog.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthauthreplyserver_p.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthrequest_xauth_p.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthutils.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthrequest.cpp
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthrequest_xauth.cpp
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthglobals.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthrequest.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthutils.cpp
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthmanager.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthauthreplyserver.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthrequest_1.cpp
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthrequest_xauth.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthrequest_p.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthmanager.cpp
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthauthreplyserver.cpp
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthmanager_p.h
Examining data/pumpa-0.9.3/src/kQOAuth/kqoauthrequest_1.h
Examining data/pumpa-0.9.3/src/objectlistwidget.cpp
Examining data/pumpa-0.9.3/src/pumpa_defines.h
Examining data/pumpa-0.9.3/src/richtextlabel.h
Examining data/pumpa-0.9.3/src/tabwidget.cpp
Examining data/pumpa-0.9.3/src/qasabstractobject.h
Examining data/pumpa-0.9.3/src/pumpapp.h
Examining data/pumpa-0.9.3/src/messageedit.cpp
Examining data/pumpa-0.9.3/src/contextwidget.h
Examining data/pumpa-0.9.3/src/messageedit.h
Examining data/pumpa-0.9.3/src/messagewindow.h
Examining data/pumpa-0.9.3/src/objectwidget.h
Examining data/pumpa-0.9.3/src/qasabstractobjectlist.h
Examining data/pumpa-0.9.3/src/texttoolbutton.h
Examining data/pumpa-0.9.3/src/imagelabel.cpp
Examining data/pumpa-0.9.3/src/qascollection.cpp
Examining data/pumpa-0.9.3/src/util.cpp
Examining data/pumpa-0.9.3/src/qasabstractobjectlist.cpp
Examining data/pumpa-0.9.3/src/recipientedit.cpp
Examining data/pumpa-0.9.3/src/qasactorlist.h
Examining data/pumpa-0.9.3/src/qasactor.cpp
Examining data/pumpa-0.9.3/src/json.h
Examining data/pumpa-0.9.3/src/objectlistwidget.h
Examining data/pumpa-0.9.3/src/qasabstractobject.cpp
Examining data/pumpa-0.9.3/src/collectionwidget.cpp
Examining data/pumpa-0.9.3/src/aswidget.cpp
Examining data/pumpa-0.9.3/src/json.cpp
Examining data/pumpa-0.9.3/src/filedownloader.cpp
Examining data/pumpa-0.9.3/src/aswidget.h
Examining data/pumpa-0.9.3/src/util.h
Examining data/pumpa-0.9.3/src/actorwidget.h
Examining data/pumpa-0.9.3/src/qasactorlist.cpp
Examining data/pumpa-0.9.3/src/main.cpp
Examining data/pumpa-0.9.3/src/pumpasettings.h
Examining data/pumpa-0.9.3/src/richtextlabel.cpp
Examining data/pumpa-0.9.3/src/tabwidget.h
Examining data/pumpa-0.9.3/src/pumpapp.cpp
Examining data/pumpa-0.9.3/src/editprofiledialog.cpp
Examining data/pumpa-0.9.3/src/objectwidget.cpp
Examining data/pumpa-0.9.3/src/qasobject.cpp
Examining data/pumpa-0.9.3/src/qascollection.h
Examining data/pumpa-0.9.3/src/qasobjectlist.h
Examining data/pumpa-0.9.3/src/qactivitystreams.h
FINAL RESULTS:
data/pumpa-0.9.3/src/main.cpp:58:29: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
QString locale = QLocale::system().name();
data/pumpa-0.9.3/src/sundown/buffer.c:31:25: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
# define _buf_vsnprintf vsnprintf
data/pumpa-0.9.3/src/sundown/buffer.h:90:73: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
void bufprintf(struct buf *, const char *, ...) __attribute__ ((format (printf, 2, 3)));
data/pumpa-0.9.3/src/sundown/html_smartypants.c:26:9: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/pumpa-0.9.3/src/sundown/html_smartypants.c:26:18: [4] (format) _snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
#define snprintf _snprintf
data/pumpa-0.9.3/src/filedownloader.cpp:329:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!fp->open(QIODevice::WriteOnly)) {
data/pumpa-0.9.3/src/pumpapp.cpp:1275:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!fp.open(QIODevice::ReadOnly)) {
data/pumpa-0.9.3/src/sundown/autolink.c:45:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
strncasecmp((char *)link, valid_uris[i], len) == 0 &&
data/pumpa-0.9.3/src/sundown/buffer.c:162:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf->data + buf->size, data, len);
data/pumpa-0.9.3/src/sundown/houdini_href_e.c:58:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hex_str[3];
data/pumpa-0.9.3/src/sundown/html.c:582:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(callbacks, &cb_default, sizeof(struct sd_callbacks));
data/pumpa-0.9.3/src/sundown/html.c:625:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(callbacks, &cb_default, sizeof(struct sd_callbacks));
data/pumpa-0.9.3/src/sundown/html_blocks.h:36:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char gperf_downcase[256] =
data/pumpa-0.9.3/src/sundown/html_smartypants.c:89:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ent[8];
data/pumpa-0.9.3/src/sundown/markdown.c:2413:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&md->cb, callbacks, sizeof(struct sd_callbacks));
data/pumpa-0.9.3/src/util.cpp:220:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!fp.open(QIODevice::ReadOnly))
data/pumpa-0.9.3/src/sundown/autolink.c:42:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(valid_uris[i]);
data/pumpa-0.9.3/src/sundown/autolink.c:177:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (size < 4 || memcmp(data, "www.", strlen("www.")) != 0)
data/pumpa-0.9.3/src/sundown/autolink.c:275:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
link_end = strlen("://");
data/pumpa-0.9.3/src/sundown/buffer.c:170:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bufput(buf, str, strlen(str));
data/pumpa-0.9.3/src/sundown/buffer.h:53:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
{ (uint8_t *)strname, strlen(strname), 0, 0, 0 }
data/pumpa-0.9.3/src/sundown/markdown.c:1864:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t tag_size = strlen(curtag);
ANALYSIS SUMMARY:
Hits = 22
Lines analyzed = 19270 in approximately 0.46 seconds (41747 lines/second)
Physical Source Lines of Code (SLOC) = 12184
Hits@level = [0] 1 [1] 6 [2] 11 [3] 0 [4] 5 [5] 0
Hits@level+ = [0+] 23 [1+] 22 [2+] 16 [3+] 5 [4+] 5 [5+] 0
Hits/KSLOC@level+ = [0+] 1.88772 [1+] 1.80565 [2+] 1.3132 [3+] 0.410374 [4+] 0.410374 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.