Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/remote-logon-service-1.0.2.90/src/citrix-server.c Examining data/remote-logon-service-1.0.2.90/src/citrix-server.h Examining data/remote-logon-service-1.0.2.90/src/crypt.c Examining data/remote-logon-service-1.0.2.90/src/crypt.h Examining data/remote-logon-service-1.0.2.90/src/defines.h Examining data/remote-logon-service-1.0.2.90/src/main.c Examining data/remote-logon-service-1.0.2.90/src/rdp-server.c Examining data/remote-logon-service-1.0.2.90/src/rdp-server.h Examining data/remote-logon-service-1.0.2.90/src/server.c Examining data/remote-logon-service-1.0.2.90/src/server.h Examining data/remote-logon-service-1.0.2.90/src/uccs-server.h Examining data/remote-logon-service-1.0.2.90/src/x2go-server.c Examining data/remote-logon-service-1.0.2.90/src/x2go-server.h Examining data/remote-logon-service-1.0.2.90/src/uccs-server.c Examining data/remote-logon-service-1.0.2.90/tests/dbus-interface.c Examining data/remote-logon-service-1.0.2.90/tests/server-test.c FINAL RESULTS: data/remote-logon-service-1.0.2.90/src/crypt.c:93:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, origBuffer, origBufferLength); data/remote-logon-service-1.0.2.90/src/citrix-server.c:81:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). munlock(pass, strlen(pass)); data/remote-logon-service-1.0.2.90/src/citrix-server.c:207:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). mlock(server->password, strlen(server->password)); data/remote-logon-service-1.0.2.90/src/crypt.c:40:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). const size_t passwordLength = strlen(password); data/remote-logon-service-1.0.2.90/src/crypt.c:41:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(aesSymKey, password, blkLength); data/remote-logon-service-1.0.2.90/src/crypt.c:90:34: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). const size_t origBufferLength = strlen(origBuffer); data/remote-logon-service-1.0.2.90/src/rdp-server.c:81:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). munlock(pass, strlen(pass)); data/remote-logon-service-1.0.2.90/src/rdp-server.c:207:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). mlock(server->password, strlen(server->password)); data/remote-logon-service-1.0.2.90/src/uccs-server.c:561:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (lserver == NULL && strlen(default_server_name) > 0) { data/remote-logon-service-1.0.2.90/src/uccs-server.c:769:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(pass), /* number of bytes */ data/remote-logon-service-1.0.2.90/src/uccs-server.c:820:61: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (g_key_file_load_from_data (key_file, file_contents, strlen (file_contents), G_KEY_FILE_NONE, NULL)) { data/remote-logon-service-1.0.2.90/src/x2go-server.c:82:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). munlock(pass, strlen(pass)); data/remote-logon-service-1.0.2.90/src/x2go-server.c:208:48: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). mlock(server->password, strlen(server->password)); ANALYSIS SUMMARY: Hits = 13 Lines analyzed = 3853 in approximately 0.12 seconds (32085 lines/second) Physical Source Lines of Code (SLOC) = 2631 Hits@level = [0] 0 [1] 12 [2] 1 [3] 0 [4] 0 [5] 0 Hits@level+ = [0+] 13 [1+] 13 [2+] 1 [3+] 0 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 4.94109 [1+] 4.94109 [2+] 0.380084 [3+] 0 [4+] 0 [5+] 0 Dot directories skipped = 2 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.