Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.cpp
Examining data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.h
Examining data/shairport-sync-3.3.5/FFTConvolver/FFTConvolver.cpp
Examining data/shairport-sync-3.3.5/FFTConvolver/FFTConvolver.h
Examining data/shairport-sync-3.3.5/FFTConvolver/Utilities.cpp
Examining data/shairport-sync-3.3.5/FFTConvolver/Utilities.h
Examining data/shairport-sync-3.3.5/FFTConvolver/convolver.cpp
Examining data/shairport-sync-3.3.5/FFTConvolver/convolver.h
Examining data/shairport-sync-3.3.5/activity_monitor.c
Examining data/shairport-sync-3.3.5/activity_monitor.h
Examining data/shairport-sync-3.3.5/alac.c
Examining data/shairport-sync-3.3.5/alac.h
Examining data/shairport-sync-3.3.5/apple_alac.cpp
Examining data/shairport-sync-3.3.5/apple_alac.h
Examining data/shairport-sync-3.3.5/audio.c
Examining data/shairport-sync-3.3.5/audio.h
Examining data/shairport-sync-3.3.5/audio_alsa.c
Examining data/shairport-sync-3.3.5/audio_ao.c
Examining data/shairport-sync-3.3.5/audio_dummy.c
Examining data/shairport-sync-3.3.5/audio_jack.c
Examining data/shairport-sync-3.3.5/audio_pa.c
Examining data/shairport-sync-3.3.5/audio_pipe.c
Examining data/shairport-sync-3.3.5/audio_sndio.c
Examining data/shairport-sync-3.3.5/audio_soundio.c
Examining data/shairport-sync-3.3.5/audio_stdout.c
Examining data/shairport-sync-3.3.5/common.c
Examining data/shairport-sync-3.3.5/common.h
Examining data/shairport-sync-3.3.5/dacp.c
Examining data/shairport-sync-3.3.5/dacp.h
Examining data/shairport-sync-3.3.5/dbus-service.c
Examining data/shairport-sync-3.3.5/dbus-service.h
Examining data/shairport-sync-3.3.5/definitions.h
Examining data/shairport-sync-3.3.5/loudness.c
Examining data/shairport-sync-3.3.5/loudness.h
Examining data/shairport-sync-3.3.5/mdns.c
Examining data/shairport-sync-3.3.5/mdns.h
Examining data/shairport-sync-3.3.5/mdns_avahi.c
Examining data/shairport-sync-3.3.5/mdns_dns_sd.c
Examining data/shairport-sync-3.3.5/mdns_external.c
Examining data/shairport-sync-3.3.5/mdns_tinysvcmdns.c
Examining data/shairport-sync-3.3.5/metadata_hub.c
Examining data/shairport-sync-3.3.5/metadata_hub.h
Examining data/shairport-sync-3.3.5/mpris-service.c
Examining data/shairport-sync-3.3.5/mpris-service.h
Examining data/shairport-sync-3.3.5/mqtt.c
Examining data/shairport-sync-3.3.5/mqtt.h
Examining data/shairport-sync-3.3.5/player.c
Examining data/shairport-sync-3.3.5/player.h
Examining data/shairport-sync-3.3.5/rtp.c
Examining data/shairport-sync-3.3.5/rtp.h
Examining data/shairport-sync-3.3.5/rtsp.c
Examining data/shairport-sync-3.3.5/rtsp.h
Examining data/shairport-sync-3.3.5/shairport-sync-dbus-test-client.c
Examining data/shairport-sync-3.3.5/shairport-sync-mpris-test-client.c
Examining data/shairport-sync-3.3.5/shairport.c
Examining data/shairport-sync-3.3.5/tinyhttp/chunk.c
Examining data/shairport-sync-3.3.5/tinyhttp/chunk.h
Examining data/shairport-sync-3.3.5/tinyhttp/example.cpp
Examining data/shairport-sync-3.3.5/tinyhttp/header.c
Examining data/shairport-sync-3.3.5/tinyhttp/header.h
Examining data/shairport-sync-3.3.5/tinyhttp/http.c
Examining data/shairport-sync-3.3.5/tinyhttp/http.h
Examining data/shairport-sync-3.3.5/tinysvcmdns.c
Examining data/shairport-sync-3.3.5/tinysvcmdns.h
FINAL RESULTS:
data/shairport-sync-3.3.5/audio_alsa.c:269:11: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int r = system("if [ -d /proc/asound ] ; then echo \" hardware output devices:\" ; ls -al "
data/shairport-sync-3.3.5/audio_alsa.c:421:20: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
snd_pcm_access_t access;
data/shairport-sync-3.3.5/audio_alsa.c:477:64: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
ret = snd_pcm_hw_params_set_access(alsa_handle, alsa_params, access);
data/shairport-sync-3.3.5/audio_jack.c:246:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(full_port_name[i], "%s:%s", config.jack_client_name, port_name[i]);
data/shairport-sync-3.3.5/common.c:116:56: [4] (format) syslog:
If syslog's format strings can be influenced by an attacker, they can be
exploited (CWE-134). Use a constant format string for syslog.
static void (*sps_log)(int prio, const char *t, ...) = syslog;
data/shairport-sync-3.3.5/common.c:123:3: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(s, sizeof(s), t, args);
data/shairport-sync-3.3.5/common.c:231:3: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(s, sizeof(b) - (s - b), format, args);
data/shairport-sync-3.3.5/common.c:260:3: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(s, sizeof(b) - (s - b), format, args);
data/shairport-sync-3.3.5/common.c:285:3: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(s, sizeof(b) - (s - b), format, args);
data/shairport-sync-3.3.5/common.c:313:3: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(s, sizeof(b) - (s - b), format, args);
data/shairport-sync-3.3.5/common.c:395:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(inbuf, input);
data/shairport-sync-3.3.5/common.c:448:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(inbuf, input);
data/shairport-sync-3.3.5/common.c:741:11: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(argV[0], argV);
data/shairport-sync-3.3.5/common.c:796:9: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(argV[0], argV);
data/shairport-sync-3.3.5/common.c:852:9: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(argV[0], argV);
data/shairport-sync-3.3.5/common.c:1310:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(version_string, PACKAGE_VERSION);
data/shairport-sync-3.3.5/common.c:1379:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(version_string, SYSCONFDIR);
data/shairport-sync-3.3.5/dacp.c:186:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(server, dacp_server.ip_string);
data/shairport-sync-3.3.5/mdns.c:75:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(p, config.service_name);
data/shairport-sync-3.3.5/mdns_external.c:59:9: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(file, argv);
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:144:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(extendedregtype, config.regtype);
data/shairport-sync-3.3.5/shairport.c:1430:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(configuration_file_path, SYSCONFDIR);
data/shairport-sync-3.3.5/shairport.c:1434:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(configuration_file_path, config.appName);
data/shairport-sync-3.3.5/audio_alsa.c:1315:17: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt(argc, argv, "d:t:m:c:i:")) > 0) {
data/shairport-sync-3.3.5/audio_ao.c:69:17: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt(argc, argv, "d:i:n:o:")) > 0) {
data/shairport-sync-3.3.5/audio_sndio.c:159:17: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt(argc, argv, "d:")) > 0) {
data/shairport-sync-3.3.5/rtp.c:205:16: [3] (random) drand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
(drand48() > config.diagnostic_drop_packet_fraction))
data/shairport-sync-3.3.5/rtp.c:258:12: [3] (random) drand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
(drand48() > config.diagnostic_drop_packet_fraction)) {
data/shairport-sync-3.3.5/rtp.c:532:10: [3] (random) drand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
(drand48() > config.diagnostic_drop_packet_fraction)) {
data/shairport-sync-3.3.5/rtp.c:598:12: [3] (random) drand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
(drand48() > config.diagnostic_drop_packet_fraction)) {
data/shairport-sync-3.3.5/rtp.c:1227:12: [3] (random) drand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
(drand48() > config.diagnostic_drop_packet_fraction)) {
data/shairport-sync-3.3.5/rtsp.c:2044:11: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
uint8_t random[8];
data/shairport-sync-3.3.5/rtsp.c:2049:16: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
if (read(fd, random, sizeof(random)) != sizeof(random))
data/shairport-sync-3.3.5/rtsp.c:2049:31: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
if (read(fd, random, sizeof(random)) != sizeof(random))
data/shairport-sync-3.3.5/rtsp.c:2049:50: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
if (read(fd, random, sizeof(random)) != sizeof(random))
data/shairport-sync-3.3.5/rtsp.c:2052:21: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
return base64_enc(random, 8); // returns a pointer to malloc'ed memory
data/shairport-sync-3.3.5/shairport.c:431:33: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
char *config_file_real_path = realpath(config.configfile, NULL);
data/shairport-sync-3.3.5/shairport.c:1762:26: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
char *realConfigPath = realpath(config.configfile, NULL);
data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.cpp:829:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(_re.data(), re, size2 * sizeof(float));
data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.cpp:830:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(_im.data(), im, size2 * sizeof(float));
data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.cpp:946:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(_data, data, _size * sizeof(float));
data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.cpp:948:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(re, _re, _complexSize * sizeof(float));
data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.cpp:949:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(im, _im, _complexSize * sizeof(float));
data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.cpp:954:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(_re, re, _complexSize * sizeof(float));
data/shairport-sync-3.3.5/FFTConvolver/AudioFFT.cpp:955:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(_im, im, _complexSize * sizeof(float));
data/shairport-sync-3.3.5/FFTConvolver/FFTConvolver.cpp:157:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(_inputBuffer.data()+inputBufferPos, input+processed, processing * sizeof(Sample));
data/shairport-sync-3.3.5/FFTConvolver/FFTConvolver.cpp:192:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(_overlap.data(), _fftBuffer.data()+_blockSize, _blockSize * sizeof(Sample));
data/shairport-sync-3.3.5/FFTConvolver/Utilities.h:116:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(_data, other._data, _size * sizeof(T));
data/shairport-sync-3.3.5/FFTConvolver/Utilities.h:319:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
::memcpy(dest.data(), src, srcSize * sizeof(T));
data/shairport-sync-3.3.5/alac.c:416:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer_out + 1, error_buffer + 1, (output_size - 1) * 4);
data/shairport-sync-3.3.5/audio_alsa.c:440:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/audio_alsa.c:1692:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/audio_alsa.c:1982:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/audio_alsa.c:2017:15: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/audio_jack.c:67:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char *port_name[NPORTS] = {"out_L", "out_R"};
data/shairport-sync-3.3.5/audio_jack.c:244:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *full_port_name[NPORTS];
data/shairport-sync-3.3.5/audio_pa.c:226:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(audio_eoq, buf, bytes_to_transfer);
data/shairport-sync-3.3.5/audio_pa.c:232:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(audio_eoq, buf, space_to_end_of_buffer);
data/shairport-sync-3.3.5/audio_pa.c:234:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(audio_lmb, buf, bytes_to_transfer - space_to_end_of_buffer);
data/shairport-sync-3.3.5/audio_pa.c:376:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, audio_toq, bytes_we_can_transfer);
data/shairport-sync-3.3.5/audio_pa.c:389:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, audio_toq, first_portion_to_write);
data/shairport-sync-3.3.5/audio_pa.c:391:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_buffer, audio_lmb, bytes_we_can_transfer - first_portion_to_write);
data/shairport-sync-3.3.5/audio_pipe.c:54:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(pipename, O_WRONLY | O_NONBLOCK);
data/shairport-sync-3.3.5/audio_pipe.c:56:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/audio_pipe.c:67:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/audio_pipe.c:69:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(pipename, O_WRONLY | O_NONBLOCK);
data/shairport-sync-3.3.5/audio_soundio.c:64:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(areas[ch].ptr, read_ptr, outstream->bytes_per_sample);
data/shairport-sync-3.3.5/audio_soundio.c:184:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(write_ptr, buf, write_bytes);
data/shairport-sync-3.3.5/audio_stdout.c:47:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/common.c:120:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[1024];
data/shairport-sync-3.3.5/common.c:212:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[1024];
data/shairport-sync-3.3.5/common.c:241:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[1024];
data/shairport-sync-3.3.5/common.c:271:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[1024];
data/shairport-sync-3.3.5/common.c:294:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[1024];
data/shairport-sync-3.3.5/common.c:396:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(inbuf, "===");
data/shairport-sync-3.3.5/common.c:449:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(inbuf, "===");
data/shairport-sync-3.3.5/common.c:491:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, bptr->data, bptr->length - 1);
data/shairport-sync-3.3.5/common.c:812:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buffer[256];
data/shairport-sync-3.3.5/common.c:833:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char new_command_buffer[1024];
data/shairport-sync-3.3.5/common.c:1075:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newstr, oldstr, tok - oldstr);
data/shairport-sync-3.3.5/common.c:1076:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newstr + (tok - oldstr), replacement, strlen(replacement));
data/shairport-sync-3.3.5/common.c:1077:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newstr + (tok - oldstr) + strlen(replacement), tok + strlen(substr),
data/shairport-sync-3.3.5/common.c:1206:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errstr[1000];
data/shairport-sync-3.3.5/common.c:1238:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errstr[1000];
data/shairport-sync-3.3.5/common.c:1261:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dstring[1000];
data/shairport-sync-3.3.5/common.c:1286:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dstring[1000];
data/shairport-sync-3.3.5/common.c:1287:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errstr[512];
data/shairport-sync-3.3.5/common.c:1313:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-libdaemon");
data/shairport-sync-3.3.5/common.c:1316:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-mbedTLS");
data/shairport-sync-3.3.5/common.c:1319:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-PolarSSL");
data/shairport-sync-3.3.5/common.c:1322:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-OpenSSL");
data/shairport-sync-3.3.5/common.c:1325:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-tinysvcmdns");
data/shairport-sync-3.3.5/common.c:1328:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-Avahi");
data/shairport-sync-3.3.5/common.c:1331:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-dns_sd");
data/shairport-sync-3.3.5/common.c:1334:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-external_mdns");
data/shairport-sync-3.3.5/common.c:1337:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-ALSA");
data/shairport-sync-3.3.5/common.c:1340:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-sndio");
data/shairport-sync-3.3.5/common.c:1343:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-ao");
data/shairport-sync-3.3.5/common.c:1346:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-pa");
data/shairport-sync-3.3.5/common.c:1349:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-soundio");
data/shairport-sync-3.3.5/common.c:1352:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-dummy");
data/shairport-sync-3.3.5/common.c:1355:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-stdout");
data/shairport-sync-3.3.5/common.c:1358:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-pipe");
data/shairport-sync-3.3.5/common.c:1361:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-soxr");
data/shairport-sync-3.3.5/common.c:1364:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-convolution");
data/shairport-sync-3.3.5/common.c:1367:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-metadata");
data/shairport-sync-3.3.5/common.c:1370:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-mqtt");
data/shairport-sync-3.3.5/common.c:1373:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-dbus");
data/shairport-sync-3.3.5/common.c:1376:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-mpris");
data/shairport-sync-3.3.5/common.c:1378:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(version_string, "-sysconfdir:");
data/shairport-sync-3.3.5/dacp.c:53:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dacp_id[256]; // the DACP ID string
data/shairport-sync-3.3.5/dacp.c:57:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip_string[INET6_ADDRSTRLEN]; // the ip string pointing to the client
data/shairport-sync-3.3.5/dacp.c:99:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(response->body + response->size, data, size);
data/shairport-sync-3.3.5/dacp.c:181:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char portstring[10], server[1024], message[1024];
data/shairport-sync-3.3.5/dacp.c:249:15: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/dacp.c:275:15: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[8192];
data/shairport-sync-3.3.5/dacp.c:285:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/dacp.c:589:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char command[1024] = "";
data/shairport-sync-3.3.5/dacp.c:738:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char st[33];
data/shairport-sync-3.3.5/dacp.c:921:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char typecode[5];
data/shairport-sync-3.3.5/dacp.c:922:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(typecode, *p, 4);
data/shairport-sync-3.3.5/dacp.c:979:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char message[1000];
data/shairport-sync-3.3.5/dacp.c:990:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char message[1000];
data/shairport-sync-3.3.5/dacp.h:13:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[128]; // this is really just for debugging
data/shairport-sync-3.3.5/dbus-service.c:31:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char response[100];
data/shairport-sync-3.3.5/dbus-service.c:87:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Not Available");
data/shairport-sync-3.3.5/dbus-service.c:90:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Stopped");
data/shairport-sync-3.3.5/dbus-service.c:93:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Paused");
data/shairport-sync-3.3.5/dbus-service.c:96:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Playing");
data/shairport-sync-3.3.5/dbus-service.c:114:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Not Available");
data/shairport-sync-3.3.5/dbus-service.c:117:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Off");
data/shairport-sync-3.3.5/dbus-service.c:120:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "One");
data/shairport-sync-3.3.5/dbus-service.c:123:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "All");
data/shairport-sync-3.3.5/dbus-service.c:176:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char trackidstring[128];
data/shairport-sync-3.3.5/dbus-service.c:997:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char interface_name[256] = "";
data/shairport-sync-3.3.5/mdns_avahi.c:105:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char portstring[20];
data/shairport-sync-3.3.5/mdns_external.c:84:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mdns_port[6];
data/shairport-sync-3.3.5/mdns_external.c:123:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mdns_port[6];
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:53:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[100 + 6];
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:61:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(hostname, ".local");
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:145:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(extendedregtype, ".local");
data/shairport-sync-3.3.5/metadata_hub.c:207:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char img_md5_str[33];
data/shairport-sync-3.3.5/metadata_hub.c:237:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int cover_fd = open(path, O_WRONLY | O_CREAT | O_EXCL, S_IRWXU | S_IRGRP | S_IROTH);
data/shairport-sync-3.3.5/metadata_hub.c:260:26: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int dir_fd = open(config.cover_art_cache_dir, O_DIRECTORY);
data/shairport-sync-3.3.5/metadata_hub.c:461:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char uri[2048];
data/shairport-sync-3.3.5/metadata_hub.c:564:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char typestring[5];
data/shairport-sync-3.3.5/metadata_hub.c:566:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(typestring, &tm, sizeof(uint32_t));
data/shairport-sync-3.3.5/metadata_hub.c:568:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char codestring[5];
data/shairport-sync-3.3.5/metadata_hub.c:570:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(codestring, &cm, sizeof(uint32_t));
data/shairport-sync-3.3.5/metadata_hub.h:75:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char
data/shairport-sync-3.3.5/mpris-service.c:19:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char response[100];
data/shairport-sync-3.3.5/mpris-service.c:23:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Not Available");
data/shairport-sync-3.3.5/mpris-service.c:26:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "None");
data/shairport-sync-3.3.5/mpris-service.c:29:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Track");
data/shairport-sync-3.3.5/mpris-service.c:32:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Playlist");
data/shairport-sync-3.3.5/mpris-service.c:40:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Not Available");
data/shairport-sync-3.3.5/mpris-service.c:43:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Stopped");
data/shairport-sync-3.3.5/mpris-service.c:46:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Paused");
data/shairport-sync-3.3.5/mpris-service.c:49:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(response, "Playing");
data/shairport-sync-3.3.5/mpris-service.c:130:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char trackidstring[128];
data/shairport-sync-3.3.5/mpris-service.c:299:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char interface_name[256] = "";
data/shairport-sync-3.3.5/mqtt.c:49:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char payload[msg->payloadlen + 1];
data/shairport-sync-3.3.5/mqtt.c:50:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(payload, msg->payload, msg->payloadlen);
data/shairport-sync-3.3.5/mqtt.c:87:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char remotetopic[strlen(config.mqtt_topic) + 8];
data/shairport-sync-3.3.5/mqtt.c:95:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fulltopic[strlen(config.mqtt_topic) + strlen(topic) + 3];
data/shairport-sync-3.3.5/mqtt.c:125:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(topic, &val, 4);
data/shairport-sync-3.3.5/mqtt.c:127:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(topic + 5, &val, 4);
data/shairport-sync-3.3.5/player.c:298:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char packet[MAX_PACKET];
data/shairport-sync-3.3.5/player.c:306:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char iv[16];
data/shairport-sync-3.3.5/player.c:318:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(packet + aeslen, buf + aeslen, len - aeslen);
data/shairport-sync-3.3.5/player.c:1785:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char rnstate[256];
data/shairport-sync-3.3.5/player.c:3058:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/player.h:181:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char client_ip_string[INET6_ADDRSTRLEN]; // the ip string pointing to the client
data/shairport-sync-3.3.5/player.h:182:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char self_ip_string[INET6_ADDRSTRLEN]; // the ip string being used by this program -- it
data/shairport-sync-3.3.5/rtp.c:535:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char em[1024];
data/shairport-sync-3.3.5/rtp.c:904:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/rtp.c:991:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char portstr[20];
data/shairport-sync-3.3.5/rtp.c:998:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->rtp_client_control_socket, servinfo->ai_addr, sizeof(struct sockaddr_in6));
data/shairport-sync-3.3.5/rtp.c:1004:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->rtp_client_control_socket, servinfo->ai_addr, sizeof(struct sockaddr_in));
data/shairport-sync-3.3.5/rtp.c:1017:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->rtp_client_timing_socket, servinfo->ai_addr, sizeof(struct sockaddr_in6));
data/shairport-sync-3.3.5/rtp.c:1023:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&conn->rtp_client_timing_socket, servinfo->ai_addr, sizeof(struct sockaddr_in));
data/shairport-sync-3.3.5/rtp.c:1208:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char req[8]; // *not* a standard RTCP NACK
data/shairport-sync-3.3.5/rtp.c:1240:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char em[1024];
data/shairport-sync-3.3.5/rtsp.c:131:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *name[16];
data/shairport-sync-3.3.5/rtsp.c:132:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *value[16];
data/shairport-sync-3.3.5/rtsp.c:138:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char method[16];
data/shairport-sync-3.3.5/rtsp.c:206:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, the_stuff, the_queue->item_size);
data/shairport-sync-3.3.5/rtsp.c:242:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(the_stuff, p, the_queue->item_size);
data/shairport-sync-3.3.5/rtsp.c:567:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return atoi(cl);
data/shairport-sync-3.3.5/rtsp.c:620:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/rtsp.c:714:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/rtsp.c:741:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pkt[2048];
data/shairport-sync-3.3.5/rtsp.c:776:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, resp->content, resp->contentlength);
data/shairport-sync-3.3.5/rtsp.c:791:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/rtsp.c:956:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
cport = atoi(p);
data/shairport-sync-3.3.5/rtsp.c:961:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tport = atoi(p);
data/shairport-sync-3.3.5/rtsp.c:983:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char resphdr[256] = "";
data/shairport-sync-3.3.5/rtsp.c:1287:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(path, O_WRONLY | O_NONBLOCK);
data/shairport-sync-3.3.5/rtsp.c:1310:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, &v, 4);
data/shairport-sync-3.3.5/rtsp.c:1313:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, &v, 4);
data/shairport-sync-3.3.5/rtsp.c:1315:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, data, length);
data/shairport-sync-3.3.5/rtsp.c:1332:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, "ssncchnk", 8);
data/shairport-sync-3.3.5/rtsp.c:1335:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, &v, 4);
data/shairport-sync-3.3.5/rtsp.c:1338:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, &v, 4);
data/shairport-sync-3.3.5/rtsp.c:1341:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, &v, 4);
data/shairport-sync-3.3.5/rtsp.c:1344:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, &v, 4);
data/shairport-sync-3.3.5/rtsp.c:1350:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ptr, data_crsr, datalen);
data/shairport-sync-3.3.5/rtsp.c:1366:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char thestring[1024];
data/shairport-sync-3.3.5/rtsp.c:1388:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char outbuf[76];
data/shairport-sync-3.3.5/rtsp.c:1540:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&itag, (uint32_t *)(cp + off), sizeof(uint32_t)); /* can be misaligned, thus memcpy */
data/shairport-sync-3.3.5/rtsp.c:1545:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&vl, (uint32_t *)(cp + off), sizeof(uint32_t)); /* can be misaligned, thus memcpy */
data/shairport-sync-3.3.5/rtsp.c:1830:31: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn->minimum_latency = atoi(pminlatency);
data/shairport-sync-3.3.5/rtsp.c:1835:31: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn->maximum_latency = atoi(pmaxlatency);
data/shairport-sync-3.3.5/rtsp.c:1855:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(conn->stream.aesiv, aesiv, 16);
data/shairport-sync-3.3.5/rtsp.c:1866:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(conn->stream.aeskey, aeskey, 16);
data/shairport-sync-3.3.5/rtsp.c:1892:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn->stream.fmtp[i++] = atoi(found);
data/shairport-sync-3.3.5/rtsp.c:1942:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn->AirPlayVersion = atoi(p + 1);
data/shairport-sync-3.3.5/rtsp.c:2004:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(bp, chall, chall_len);
data/shairport-sync-3.3.5/rtsp.c:2011:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(bp, sa6->sin6_addr.s6_addr, 16);
data/shairport-sync-3.3.5/rtsp.c:2017:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(bp, &sa->sin_addr.s_addr, 4);
data/shairport-sync-3.3.5/rtsp.c:2045:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int fd = open("/dev/urandom", O_RDONLY);
data/shairport-sync-3.3.5/rtsp.c:2165:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[33];
data/shairport-sync-3.3.5/rtsp.c:2393:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char obf[4096];
data/shairport-sync-3.3.5/rtsp.c:2467:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/rtsp.c:2523:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char portstr[6];
data/shairport-sync-3.3.5/rtsp.c:2674:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip4[INET_ADDRSTRLEN]; // space to hold the IPv4 string
data/shairport-sync-3.3.5/rtsp.c:2675:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char remote_ip4[INET_ADDRSTRLEN]; // space to hold the IPv4 string
data/shairport-sync-3.3.5/rtsp.c:2689:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ip6[INET6_ADDRSTRLEN]; // space to hold the IPv6 string
data/shairport-sync-3.3.5/rtsp.c:2690:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char remote_ip6[INET6_ADDRSTRLEN]; // space to hold the IPv6 string
data/shairport-sync-3.3.5/rtsp.c:2717:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errorstring[1024];
data/shairport-sync-3.3.5/shairport.c:117:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char configuration_file_path[4096 + 1];
data/shairport-sync-3.3.5/shairport.c:118:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char actual_configuration_file_path[4096 + 1];
data/shairport-sync-3.3.5/shairport.c:1197:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[100];
data/shairport-sync-3.3.5/shairport.c:1262:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pid_file_path_string[4096] = "\0";
data/shairport-sync-3.3.5/shairport.c:1435:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(configuration_file_path, ".conf");
data/shairport-sync-3.3.5/tinyhttp/example.cpp:155:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/shairport-sync-3.3.5/tinysvcmdns.c:1472:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char notify_buf[2]; // buffer for reading of notify_pipe
data/shairport-sync-3.3.5/audio_alsa.c:2035:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(sleep_time_ms * 1000); // has a cancellation point in it
data/shairport-sync-3.3.5/common.c:155:14: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
response = usleep(usec);
data/shairport-sync-3.3.5/common.c:188:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
insertion_point = insertion_point + strlen(insertion_point);
data/shairport-sync-3.3.5/common.c:189:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
space_remaining = space_remaining - strlen(insertion_point);
data/shairport-sync-3.3.5/common.c:193:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
insertion_point = insertion_point + strlen(insertion_point);
data/shairport-sync-3.3.5/common.c:194:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
space_remaining = space_remaining - strlen(insertion_point);
data/shairport-sync-3.3.5/common.c:198:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
insertion_point = insertion_point + strlen(insertion_point);
data/shairport-sync-3.3.5/common.c:199:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
space_remaining = space_remaining - strlen(insertion_point);
data/shairport-sync-3.3.5/common.c:204:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
insertion_point = insertion_point + strlen(insertion_point);
data/shairport-sync-3.3.5/common.c:388:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int inbufsize = ((strlen(input) + 3) / 4) * 4; // this is the size of the input buffer we will
data/shairport-sync-3.3.5/common.c:441:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int inbufsize = ((strlen(input) + 3) / 4) * 4; // this is the size of the input buffer we will
data/shairport-sync-3.3.5/common.c:505:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int inlen = strlen(input);
data/shairport-sync-3.3.5/common.c:518:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int bufsize = strlen(input) * 3 / 4 + 1;
data/shairport-sync-3.3.5/common.c:600:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(pers));
data/shairport-sync-3.3.5/common.c:652:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(pers))) != 0)
data/shairport-sync-3.3.5/common.c:657:64: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
rc = x509parse_key(&trsa, (unsigned char *)super_secret_key, strlen(super_secret_key), NULL, 0);
data/shairport-sync-3.3.5/common.c:721:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t command_buffer_size = strlen(config.cmd_set_volume) + 32;
data/shairport-sync-3.3.5/common.c:815:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
len = read(pipes[0], buffer, 255);
data/shairport-sync-3.3.5/common.c:1069:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newstr = malloc(strlen(oldstr) - strlen(substr) + strlen(replacement) + 1);
data/shairport-sync-3.3.5/common.c:1069:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newstr = malloc(strlen(oldstr) - strlen(substr) + strlen(replacement) + 1);
data/shairport-sync-3.3.5/common.c:1069:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newstr = malloc(strlen(oldstr) - strlen(substr) + strlen(replacement) + 1);
data/shairport-sync-3.3.5/common.c:1076:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy(newstr + (tok - oldstr), replacement, strlen(replacement));
data/shairport-sync-3.3.5/common.c:1077:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy(newstr + (tok - oldstr) + strlen(replacement), tok + strlen(substr),
data/shairport-sync-3.3.5/common.c:1077:67: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memcpy(newstr + (tok - oldstr) + strlen(replacement), tok + strlen(substr),
data/shairport-sync-3.3.5/common.c:1078:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(oldstr) - strlen(substr) - (tok - oldstr));
data/shairport-sync-3.3.5/common.c:1078:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(oldstr) - strlen(substr) - (tok - oldstr));
data/shairport-sync-3.3.5/common.c:1079:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(newstr + strlen(oldstr) - strlen(substr) + strlen(replacement), 0, 1);
data/shairport-sync-3.3.5/common.c:1079:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(newstr + strlen(oldstr) - strlen(substr) + strlen(replacement), 0, 1);
data/shairport-sync-3.3.5/common.c:1079:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(newstr + strlen(oldstr) - strlen(substr) + strlen(replacement), 0, 1);
data/shairport-sync-3.3.5/common.c:1081:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
head = newstr + (tok - oldstr) + strlen(replacement);
data/shairport-sync-3.3.5/dacp.c:247:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssize_t wresp = send(sockfd, message, strlen(message), 0);
data/shairport-sync-3.3.5/dacp.c:259:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (wresp != (ssize_t)strlen(message)) {
data/shairport-sync-3.3.5/dacp.c:307:23: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int read;
data/shairport-sync-3.3.5/dacp.c:308:59: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
needmore = http_data(&rt, data, ndata, &read);
data/shairport-sync-3.3.5/dacp.c:309:28: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ndata -= read;
data/shairport-sync-3.3.5/dacp.c:310:27: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
data += read;
data/shairport-sync-3.3.5/dacp.c:394:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dacp_server.dacp_id, conn->dacp_id, sizeof(dacp_server.dacp_id) - 1);
data/shairport-sync-3.3.5/dacp.c:401:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(dacp_server.ip_string, conn->client_ip_string, INET6_ADDRSTRLEN);
data/shairport-sync-3.3.5/dacp.c:1040:15: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)&speaker_info[speaker_index].name, t,
data/shairport-sync-3.3.5/mdns.c:67:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *mdns_service_name = alloca(strlen(config.service_name) + 14);
data/shairport-sync-3.3.5/mdns_avahi.c:98:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dacpid += strlen("iTunes_Ctrl_");
data/shairport-sync-3.3.5/mdns_avahi.c:108:58: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_ssnc_metadata('dapo', strdup(portstring), strlen(portstring), 0);
data/shairport-sync-3.3.5/mdns_avahi.c:152:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dacpid += strlen("iTunes_Ctrl_");
data/shairport-sync-3.3.5/mdns_dns_sd.c:55:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length += strlen(*field) + 1; // One byte for length each time
data/shairport-sync-3.3.5/mdns_external.c:71:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(execpipe[0], &childErrno, sizeof(childErrno)) ==
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:59:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *hostend = hostname + strlen(hostname);
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:60:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((strlen(hostname) < strlen(".local")) || (strcmp(hostend - 6, ".local") != 0)) {
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:60:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((strlen(hostname) < strlen(".local")) || (strcmp(hostend - 6, ".local") != 0)) {
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:139:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *extendedregtype = malloc(strlen(config.regtype) + strlen(".local") + 1);
data/shairport-sync-3.3.5/mdns_tinysvcmdns.c:139:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *extendedregtype = malloc(strlen(config.regtype) + strlen(".local") + 1);
data/shairport-sync-3.3.5/metadata_hub.c:67:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return string_update_with_size(str, flag, s, strlen(s));
data/shairport-sync-3.3.5/metadata_hub.c:224:23: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
mode_t oldumask = umask(000);
data/shairport-sync-3.3.5/metadata_hub.c:226:5: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(oldumask);
data/shairport-sync-3.3.5/metadata_hub.c:232:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t pl = strlen(config.cover_art_cache_dir) + 1 + strlen(prefix) + strlen(img_md5_str) + 1 +
data/shairport-sync-3.3.5/metadata_hub.c:232:60: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t pl = strlen(config.cover_art_cache_dir) + 1 + strlen(prefix) + strlen(img_md5_str) + 1 +
data/shairport-sync-3.3.5/metadata_hub.c:232:77: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t pl = strlen(config.cover_art_cache_dir) + 1 + strlen(prefix) + strlen(img_md5_str) + 1 +
data/shairport-sync-3.3.5/metadata_hub.c:233:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(ext);
data/shairport-sync-3.3.5/metadata_hub.c:253:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int fnl = strlen(prefix) + strlen(img_md5_str) + 1 + strlen(ext) + 1;
data/shairport-sync-3.3.5/metadata_hub.c:253:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int fnl = strlen(prefix) + strlen(img_md5_str) + 1 + strlen(ext) + 1;
data/shairport-sync-3.3.5/metadata_hub.c:253:66: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int fnl = strlen(prefix) + strlen(img_md5_str) + 1 + strlen(ext) + 1;
data/shairport-sync-3.3.5/mqtt.c:64:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((size_t)msg->payloadlen >= strlen(commands[it]) &&
data/shairport-sync-3.3.5/mqtt.c:65:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncmp(msg->payload, commands[it], strlen(commands[it])) == 0) {
data/shairport-sync-3.3.5/mqtt.c:87:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char remotetopic[strlen(config.mqtt_topic) + 8];
data/shairport-sync-3.3.5/mqtt.c:88:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
snprintf(remotetopic, strlen(config.mqtt_topic) + 8, "%s/remote", config.mqtt_topic);
data/shairport-sync-3.3.5/mqtt.c:95:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char fulltopic[strlen(config.mqtt_topic) + strlen(topic) + 3];
data/shairport-sync-3.3.5/mqtt.c:95:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char fulltopic[strlen(config.mqtt_topic) + strlen(topic) + 3];
data/shairport-sync-3.3.5/mqtt.c:96:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
snprintf(fulltopic, strlen(config.mqtt_topic) + strlen(topic) + 2, "%s/%s", config.mqtt_topic,
data/shairport-sync-3.3.5/mqtt.c:96:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
snprintf(fulltopic, strlen(config.mqtt_topic) + strlen(topic) + 2, "%s/%s", config.mqtt_topic,
data/shairport-sync-3.3.5/player.c:2946:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_ssnc_metadata('pvol', dv, strlen(dv), 1);
data/shairport-sync-3.3.5/player.c:2970:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_ssnc_metadata('pvol', dv, strlen(dv), 1);
data/shairport-sync-3.3.5/rtp.c:546:7: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(500000); // these are thread cancellation points
data/shairport-sync-3.3.5/rtp.c:548:7: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(3000000);
data/shairport-sync-3.3.5/rtp.c:1050:64: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_ssnc_metadata('clip', strdup(conn->client_ip_string), strlen(conn->client_ip_string), 1);
data/shairport-sync-3.3.5/rtp.c:1051:62: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_ssnc_metadata('svip', strdup(conn->self_ip_string), strlen(conn->self_ip_string), 1);
data/shairport-sync-3.3.5/rtsp.c:281:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(2000000); // check every two seconds
data/shairport-sync-3.3.5/rtsp.c:537:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(msg->method, p, sizeof(msg->method) - 1);
data/shairport-sync-3.3.5/rtsp.c:552:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(line)) {
data/shairport-sync-3.3.5/rtsp.c:603:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
nread = read(conn->fd, buf + inbuf, buflen - inbuf);
data/shairport-sync-3.3.5/rtsp.c:700:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(80000); // wait about 80 milliseconds between reads of up to about 64 kB
data/shairport-sync-3.3.5/rtsp.c:701:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
nread = read(conn->fd, buf + inbuf, read_chunk);
data/shairport-sync-3.3.5/rtsp.c:898:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'flsr', p + 1, strlen(p + 1), req, 1);
data/shairport-sync-3.3.5/rtsp.c:925:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'acre', ar, strlen(ar), req, 1);
data/shairport-sync-3.3.5/rtsp.c:940:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'daid', ar, strlen(ar), req, 1);
data/shairport-sync-3.3.5/rtsp.c:1062:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "volume: ", strlen("volume: "))) {
data/shairport-sync-3.3.5/rtsp.c:1063:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
float volume = atof(cp + strlen("volume: "));
data/shairport-sync-3.3.5/rtsp.c:1068:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "progress: ", strlen("progress: "))) {
data/shairport-sync-3.3.5/rtsp.c:1069:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *progress = cp + strlen("progress: ");
data/shairport-sync-3.3.5/rtsp.c:1072:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_ssnc_metadata('prgr', strdup(progress), strlen(progress), 1);
data/shairport-sync-3.3.5/rtsp.c:1077:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
debug(1, "unrecognised parameter: \"%s\" (%d)\n", cp, strlen(cp));
data/shairport-sync-3.3.5/rtsp.c:1255:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t pl = strlen(config.metadata_pipename) + 1;
data/shairport-sync-3.3.5/rtsp.c:1260:21: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
mode_t oldumask = umask(000);
data/shairport-sync-3.3.5/rtsp.c:1266:3: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(oldumask);
data/shairport-sync-3.3.5/rtsp.c:1282:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t pl = strlen(config.metadata_pipename) + 1;
data/shairport-sync-3.3.5/rtsp.c:1369:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret = non_blocking_write(fd, thestring, strlen(thestring));
data/shairport-sync-3.3.5/rtsp.c:1376:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret = non_blocking_write(fd, thestring, strlen(thestring));
data/shairport-sync-3.3.5/rtsp.c:1408:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret = non_blocking_write(fd, thestring, strlen(thestring));
data/shairport-sync-3.3.5/rtsp.c:1415:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret = non_blocking_write(fd, thestring, strlen(thestring));
data/shairport-sync-3.3.5/rtsp.c:1568:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((req->content) && (req->contentlength == strlen("volume\r\n")) &&
data/shairport-sync-3.3.5/rtsp.c:1620:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'mdst', p + 1, strlen(p + 1), req, 1); // metadata starting
data/shairport-sync-3.3.5/rtsp.c:1628:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'mden', p + 1, strlen(p + 1), req, 1); // metadata ending
data/shairport-sync-3.3.5/rtsp.c:1644:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'pcst', p + 1, strlen(p + 1), req, 1); // picture starting
data/shairport-sync-3.3.5/rtsp.c:1652:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'pcen', p + 1, strlen(p + 1), req, 1); // picture ending
data/shairport-sync-3.3.5/rtsp.c:1716:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(100000);
data/shairport-sync-3.3.5/rtsp.c:1768:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "a=rtpmap:96 L16/44100/2", strlen("a=rtpmap:96 L16/44100/2")))
data/shairport-sync-3.3.5/rtsp.c:1769:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pUncompressedCDAudio = cp + strlen("a=rtpmap:96 L16/44100/2");
data/shairport-sync-3.3.5/rtsp.c:1774:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "o=iTunes", strlen("o=iTunes")))
data/shairport-sync-3.3.5/rtsp.c:1775:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pssid = cp + strlen("o=iTunes");
data/shairport-sync-3.3.5/rtsp.c:1777:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "a=fmtp:", strlen("a=fmtp:")))
data/shairport-sync-3.3.5/rtsp.c:1778:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pfmtp = cp + strlen("a=fmtp:");
data/shairport-sync-3.3.5/rtsp.c:1780:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "a=aesiv:", strlen("a=aesiv:")))
data/shairport-sync-3.3.5/rtsp.c:1781:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
paesiv = cp + strlen("a=aesiv:");
data/shairport-sync-3.3.5/rtsp.c:1783:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "a=rsaaeskey:", strlen("a=rsaaeskey:")))
data/shairport-sync-3.3.5/rtsp.c:1784:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prsaaeskey = cp + strlen("a=rsaaeskey:");
data/shairport-sync-3.3.5/rtsp.c:1786:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "a=min-latency:", strlen("a=min-latency:")))
data/shairport-sync-3.3.5/rtsp.c:1787:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pminlatency = cp + strlen("a=min-latency:");
data/shairport-sync-3.3.5/rtsp.c:1789:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(cp, "a=max-latency:", strlen("a=max-latency:")))
data/shairport-sync-3.3.5/rtsp.c:1790:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pmaxlatency = cp + strlen("a=max-latency:");
data/shairport-sync-3.3.5/rtsp.c:1915:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(cp) != 0)
data/shairport-sync-3.3.5/rtsp.c:1917:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cp += strlen(cp) + 1;
data/shairport-sync-3.3.5/rtsp.c:1918:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cp_left -= strlen(cp) + 1;
data/shairport-sync-3.3.5/rtsp.c:1928:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'snam', hdr, strlen(hdr), req, 1);
data/shairport-sync-3.3.5/rtsp.c:1948:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send_metadata('ssnc', 'snua', hdr, strlen(hdr), req, 1);
data/shairport-sync-3.3.5/rtsp.c:2049:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(fd, random, sizeof(random)) != sizeof(random))
data/shairport-sync-3.3.5/rtsp.c:2102:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5_Update(&ctx, username, strlen(username));
data/shairport-sync-3.3.5/rtsp.c:2104:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5_Update(&ctx, realm, strlen(realm));
data/shairport-sync-3.3.5/rtsp.c:2106:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5_Update(&ctx, config.password, strlen(config.password));
data/shairport-sync-3.3.5/rtsp.c:2109:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5_Update(&ctx, req->method, strlen(req->method));
data/shairport-sync-3.3.5/rtsp.c:2111:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5_Update(&ctx, uri, strlen(uri));
data/shairport-sync-3.3.5/rtsp.c:2120:66: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update_ret(&tctx, (const unsigned char *)username, strlen(username));
data/shairport-sync-3.3.5/rtsp.c:2122:63: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update_ret(&tctx, (const unsigned char *)realm, strlen(realm));
data/shairport-sync-3.3.5/rtsp.c:2124:73: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update_ret(&tctx, (const unsigned char *)config.password, strlen(config.password));
data/shairport-sync-3.3.5/rtsp.c:2127:69: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update_ret(&tctx, (const unsigned char *)req->method, strlen(req->method));
data/shairport-sync-3.3.5/rtsp.c:2129:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update_ret(&tctx, (const unsigned char *)uri, strlen(uri));
data/shairport-sync-3.3.5/rtsp.c:2134:62: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update(&tctx, (const unsigned char *)username, strlen(username));
data/shairport-sync-3.3.5/rtsp.c:2136:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update(&tctx, (const unsigned char *)realm, strlen(realm));
data/shairport-sync-3.3.5/rtsp.c:2138:69: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update(&tctx, (const unsigned char *)config.password, strlen(config.password));
data/shairport-sync-3.3.5/rtsp.c:2141:65: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update(&tctx, (const unsigned char *)req->method, strlen(req->method));
data/shairport-sync-3.3.5/rtsp.c:2143:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update(&tctx, (const unsigned char *)uri, strlen(uri));
data/shairport-sync-3.3.5/rtsp.c:2151:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
md5_update(&tctx, (const unsigned char *)username, strlen(username));
data/shairport-sync-3.3.5/rtsp.c:2153:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
md5_update(&tctx, (const unsigned char *)realm, strlen(realm));
data/shairport-sync-3.3.5/rtsp.c:2155:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
md5_update(&tctx, (const unsigned char *)config.password, strlen(config.password));
data/shairport-sync-3.3.5/rtsp.c:2158:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
md5_update(&tctx, (const unsigned char *)req->method, strlen(req->method));
data/shairport-sync-3.3.5/rtsp.c:2160:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
md5_update(&tctx, (const unsigned char *)uri, strlen(uri));
data/shairport-sync-3.3.5/rtsp.c:2174:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5_Update(&ctx, *nonce, strlen(*nonce));
data/shairport-sync-3.3.5/rtsp.c:2188:64: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update_ret(&tctx, (const unsigned char *)*nonce, strlen(*nonce));
data/shairport-sync-3.3.5/rtsp.c:2198:60: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update(&tctx, (const unsigned char *)*nonce, strlen(*nonce));
data/shairport-sync-3.3.5/rtsp.c:2211:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
md5_update(&tctx, (const unsigned char *)*nonce, strlen(*nonce));
data/shairport-sync-3.3.5/rtsp.c:2228:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int hdrlen = strlen(*nonce) + 40;
data/shairport-sync-3.3.5/rtsp.c:2458:13: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(20000);
data/shairport-sync-3.3.5/rtsp.c:2465:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssize_t reply = write(conn->fd, response_text, strlen(response_text));
data/shairport-sync-3.3.5/rtsp.c:2470:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (reply != (ssize_t)strlen(response_text)) {
data/shairport-sync-3.3.5/rtsp.c:2471:102: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
debug(1, "rtsp_read_request_response_bad_packet write %d bytes requested but %d written.", strlen(response_text),
data/shairport-sync-3.3.5/shairport.c:1225:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int topic_length = 1 + strlen(config.service_name) + 1;
data/shairport-sync-3.3.5/shairport.c:1433:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(configuration_file_path, "/");
data/shairport-sync-3.3.5/shairport.c:1508:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(config.service_name) > 50) {
data/shairport-sync-3.3.5/shairport.c:1632:3: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(S_IWGRP | S_IWOTH);
data/shairport-sync-3.3.5/shairport.c:1806:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5_Update(&ctx, config.service_name, strlen(config.service_name));
data/shairport-sync-3.3.5/shairport.c:1814:71: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update_ret(&tctx, (unsigned char *)config.service_name, strlen(config.service_name));
data/shairport-sync-3.3.5/shairport.c:1819:67: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mbedtls_md5_update(&tctx, (unsigned char *)config.service_name, strlen(config.service_name));
data/shairport-sync-3.3.5/shairport.c:1827:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
md5_update(&tctx, (unsigned char *)config.service_name, strlen(config.service_name));
data/shairport-sync-3.3.5/tinyhttp/example.cpp:167:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int read;
data/shairport-sync-3.3.5/tinyhttp/example.cpp:168:53: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
needmore = http_data(&rt, data, ndata, &read);
data/shairport-sync-3.3.5/tinyhttp/example.cpp:169:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ndata -= read;
data/shairport-sync-3.3.5/tinyhttp/example.cpp:170:21: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
data += read;
data/shairport-sync-3.3.5/tinyhttp/http.c:93:78: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int http_data(struct http_roundtripper* rt, const char* data, int size, int* read)
data/shairport-sync-3.3.5/tinyhttp/http.h:81:78: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int http_data(struct http_roundtripper* rt, const char* data, int size, int* read);
data/shairport-sync-3.3.5/tinysvcmdns.c:99:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)newlabel, (char *)label, len);
data/shairport-sync-3.3.5/tinysvcmdns.c:112:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len1 = strlen((char *)n1);
data/shairport-sync-3.3.5/tinysvcmdns.c:113:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len2 = strlen((char *)n2);
data/shairport-sync-3.3.5/tinysvcmdns.c:117:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)s, (char *)n1, len1);
data/shairport-sync-3.3.5/tinysvcmdns.c:118:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)s + len1, (char *)n2, len2);
data/shairport-sync-3.3.5/tinysvcmdns.c:142:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(labelp, (char *)p + 1, label_len);
data/shairport-sync-3.3.5/tinysvcmdns.c:196:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(txt);
data/shairport-sync-3.3.5/tinysvcmdns.c:203:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)s + 1, txt, len);
data/shairport-sync-3.3.5/tinysvcmdns.c:220:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(name);
data/shairport-sync-3.3.5/tinysvcmdns.c:225:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)label + 1, name, len);
data/shairport-sync-3.3.5/tinysvcmdns.c:297:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(sp, (char *)p2, llen);
data/shairport-sync-3.3.5/tinysvcmdns.c:301:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(sp, (char *)p, llen);
data/shairport-sync-3.3.5/tinysvcmdns.c:930:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)p, (char *)name, segment_len);
data/shairport-sync-3.3.5/tinysvcmdns.c:1004:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy((char *)p, (char *)txt_rec->txt, len);
data/shairport-sync-3.3.5/tinysvcmdns.c:1447:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return read(s, buf, len);
ANALYSIS SUMMARY:
Hits = 418
Lines analyzed = 26760 in approximately 0.72 seconds (36997 lines/second)
Physical Source Lines of Code (SLOC) = 19112
Hits@level = [0] 151 [1] 181 [2] 199 [3] 15 [4] 23 [5] 0
Hits@level+ = [0+] 569 [1+] 418 [2+] 237 [3+] 38 [4+] 23 [5+] 0
Hits/KSLOC@level+ = [0+] 29.7719 [1+] 21.8711 [2+] 12.4006 [3+] 1.98828 [4+] 1.20343 [5+] 0
Dot directories skipped = 2 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.