Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/Fits_IO.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/HMS.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/HMS.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/ImageCoords.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/ImageCoords.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/ImageIO.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/ImageIO.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/SAOWCS.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/SAOWCS.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/TclWorldCoords.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/TclWorldCoords.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WCSRep.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WCSRep.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldOrImageCoords.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/compiler.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/cotr.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/jprec.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/ok.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/osdefos.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/slasubs.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/slasubs.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/trigo.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/trigod.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/world_coords.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/world_coords.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/Astrotcl.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/digitize.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gen_msg.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gen_str.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gen_types.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip_inflate.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip_util.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_comp.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_press.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/hcomp.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/hinv.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/hsmooth.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/htrans.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/local_press.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/local_press.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/none.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/pr_msg.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/press.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/press.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/undigitize.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ux_press.c Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ux_press.h Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tCompress.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tHMS.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tImageCoords.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tWorldCoords.C Examining data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tWorldOrImageCoords.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroQuery.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroQuery.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/LocalCatalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/LocalCatalog.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/QueryResult.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/QueryResult.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroImage.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroImage.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclQueryUtil.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclQueryUtil.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclTcsCat.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclTcsCat.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalog.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsLocalCatalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsLocalCatalog.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsQueryResult.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsQueryResult.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/astro_catalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/astro_catalog.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/astro_image.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/astro_image.h Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/cat_bitmaps.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/main.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tAstroCatalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tAstroImage.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tLocalCatalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tQueryResult.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tTabTable.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tTcsCatalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tTcsLocalCatalog.C Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tastro_catalog.c Examining data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tastro_image.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/BiasData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ByteImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ByteImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ColorMapInfo.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ColorMapInfo.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/CompoundImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/CompoundImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/DoubleImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/DoubleImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/FloatImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/FloatImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ITTInfo.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ITTInfo.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageColor.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageColor.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageDisplay.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageDisplay.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageTemplates.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageZoom.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageZoom.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/LongImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/LongImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/LongLongImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/LongLongImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/LookupTable.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/LookupTable.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/NativeImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/NativeImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCoords.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdHDU.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdUtils.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdUtils.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ShortImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ShortImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/UShortImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/UShortImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/XImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/XImageData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/colormaps.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/histdist.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/histeq.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/histeql.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/histlist.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/histmap.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/histscan.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/histzero.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_bitmaps.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/saoutil.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/tkCanvasPsImage.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/mpfit.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/mpfit.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/iqefunc.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/BiasData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCLNT.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdLOG.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdLOG.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSem.c Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSem.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtd_server.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCLNT.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tImageEvent.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtdEvt.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtdEvt.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtdEvtData.C Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtdEvtData.h Examining data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/trtdRemote.c Examining data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C Examining data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.h Examining data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.h Examining data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/TcsSkySearch.C Examining data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/TcsSkySearch.h Examining data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Blt_GraphElement.c Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/ErrorHandler.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/ErrorHandler.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem_Map.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/ShellCommand.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/ShellCommand.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TkImage.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TkImage.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TkWidget.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TkWidget.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/base64.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/base64.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/define.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/tcl_findLibrary.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/tclutil_bitmaps.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem_Map.h Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Tclutil.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tHTTP.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tMem.C Examining data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tShellCommand.C FINAL RESULTS: data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:537:5: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. chmod(auth_file_, 0600); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:135:13: [5] (race) readlink: This accepts filename arguments; if an attacker can move those files or change the link content, a race condition results. Also, it does not terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach. int n = readlink(filename, buf, buflen); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:164:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmpfile, "%s.comp", file); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:280:6: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmpfile, "/tmp/fio-%s-%d.%d.fits", getenv("USER"), getpid(), count++); // unique filename data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:285:6: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmpfile, "%s.tmp", filename); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:342:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmpfile, "/tmp/cfio-%s-%d.%d.fits", getenv("USER"), getpid(), count++); // unique filename data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:389:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(cfile, (char *)filename); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:391:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(cfile, tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:403:29: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (mem_options == 0 && access(filename, W_OK) == 0) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:817:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-80s", "END"); // mark the end of the header data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:834:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf1, "%-8s= '%s'", keyword, value); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:835:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf2, "%-80s", buf1); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:848:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf1, "%-8s= %20c", keyword, value); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:849:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf2, "%-80s", buf1); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:862:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf1, "%-8s= %20d", keyword, value); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:863:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf2, "%-80s", buf1); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:875:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf1, "%-8s= %20f", keyword, value); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:876:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf2, "%-80s", buf1); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:889:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %20d", keyword, value); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:901:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %20f", keyword, value); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:913:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= '%s'", keyword, value); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:926:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %20c", keyword, value); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:965:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(filename, F_OK) == 0) { data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:967:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(backup, "%s.BAK", filename); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1993:6: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(header_.filename(), W_OK) != 0) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/SAOWCS.C:82:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(equinoxStr_, wcs_->radecout); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/SAOWCS.C:87:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(equinoxStr_, wcs_->radecout); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/SAOWCS.C:119:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf (buf, "%s %s %s", rastr, decstr, equinoxStr_); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.c:136:9: [4] (shell) execlp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. (void) execlp( "gzip", "gzip", "-c", NULL ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.h:149:38: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define Tracevv(x) {if (verbose>1) fprintf x ;} data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.h:150:47: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define Tracecv(c,x) {if (verbose>1 && (c)) fprintf x ;} data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip_util.c:481:11: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). env = strcpy(p, env); /* keep env variable intact */ data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:879:12: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf( line, "%10.10s'%*.*s'%*s%48s", "DATATYPE=", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:126:13: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). (void) strcpy( msg1, msg2 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:259:13: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf( temp_buffer2, "(%s+%d) %s: %s", prefix, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:264:13: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf( temp_buffer2, "(%s+%d) %s: %s", prefix, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:275:13: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf( temp_buffer2, "(%s+%d) %s: %s", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:294:9: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. (void) vsprintf( temp_buffer1, format, args ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:298:13: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf( temp_buffer2, "(%s%d) %s", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:303:13: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. (void) sprintf( temp_buffer2, "(%s%d) ", prefix, status ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:122:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt1, "SIMPLE", "T", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:127:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "BITPIX", 8, "8 bits per pixel." ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:131:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "NAXIS", 0, "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:135:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt1, "EXTEND", "T", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:140:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "RA", header.uh_ra, "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:144:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "DEC", header.uh_dec, "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:148:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "CAMERA", header.uh_cam, "Camera idenifier" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:152:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt1, "IMAGE", header.uh_imno, "Image number" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:156:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt5, "APERTURE", header.uh_ap, "Aperture id" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:160:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "DISPERSN", "LOW", "Camera idenifier" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:164:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "DATE", header.uh_obs_date, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:169:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt3, "EXPOSURE", header.uh_exp_time, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:174:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "EXPCODE", header.uh_exp_code, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:179:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "OBJECT", header.uh_id, "Object id" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:183:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt5, "CLASS", header.uh_obj_class, "Aperture id" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:214:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt1, "XTENSION", "'BINTABLE'", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:219:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "BITPIX", 8, "8 bits per pixel" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:223:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "NAXIS", 2, "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:227:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "NAXIS1", 5, "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:231:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "NAXIS2", header.uh_numlam, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:236:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "PCOUNT", 0, "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:240:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "GCOUNT", 1, "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:244:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt2, "TFIELDS", 3, "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:248:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt1, "TFORM1", "'I '", "Wavelength" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:252:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "TTYPE1", "Wavelength", "Wavelength" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:256:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "TUNIT1", "Angstroms", "Wavelength" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:260:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt3, "TZERO1", header.uh_lamzer, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:265:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt3, "TSCAL1", header.uh_lamstp, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:270:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt1, "TFORM2", "'I '", "Flux" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:274:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "TTYPE2", "Flux", "Flux" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:278:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt3, "TZERO2", header.uh_bzero, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:283:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt3, "TSCAL2", header.uh_bscale, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:288:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt1, "TFORM3", "'B '", "Epsilon" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:292:12: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. (void) sprintf( (char *) line, fmt4, "TTYPE3", "Epsilon", "Epsilon" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tCompress.C:56:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "cmp %s %s", "test.fits", "test.fits.gzip_decompress"); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tCompress.C:57:10: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. TEST(system(buf) == 0); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tCompress.C:67:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "cmp %s %s", "test.fits", "test.fits.unix_decompress"); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tCompress.C:68:10: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. TEST(system(buf) == 0); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:32:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(cmd, "cp %s tmp.fits", filename); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:33:9: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (system(cmd) != 0) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:36:9: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (system("chmod 777 tmp.fits") != 0) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:139:9: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (system("gzip < test.fits > tmp.fits.gz") != 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.h:136:17: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. const char* system() {return entry_->system();} data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.h:136:42: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. const char* system() {return entry_->system();} data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:439:9: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. entry->system(value); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:762:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(name, R_OK) == 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:1216:11: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (e.system()) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:1217:31: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. os << "system: " << e.system() << endl; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.h:205:10: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. void system(const char* s) {setVal_(SYSTEM_, s);} data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.h:242:17: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. const char* system() const {return val_[SYSTEM_] ? val_[SYSTEM_] : "";} data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/LocalCatalog.C:166:13: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy( p, c ); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:547:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmpfile, "%s.TMP", filename); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:586:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(bakfile, "%s.BAK", filename); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:632:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmpfile, "%s.TMP", filename); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:650:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(bakfile, "%s.BAK", filename); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:1003:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(buf2, buf); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1198:35: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. appendKeyVal("system", (char*)e->system()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1346:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(url, "file:%s", argv[0]); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1451:26: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. return set_result(cat_->system()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclQueryUtil.C:186:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(equinoxStr, value); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:112:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(id_, t.id_); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:113:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(cooSystem_, t.cooSystem_); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:114:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(cooType_, t.cooType_); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:115:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(band_, t.band_); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:138:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(id_, t.id_); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:141:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(cooSystem_, t.cooSystem_); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:147:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(cooType_, t.cooType_); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:148:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(band_, t.band_); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tAstroImage.C:57:9: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (system(os.str().c_str()) != 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tQueryResult.C:45:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "col1\tcol2\tcol3\n---\t---\t---\n%s\n%s\n%s\n%s\n", data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tQueryResult.C:107:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "col1\tcol2\tcol3\n---\t---\t---\n%s\n%s\n%s\n%s\n%s\n%s\n%s\n%s\n%s\n", data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tTabTable.C:28:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "col1\tcol2\tcol3\n---\t---\t---\n%s\n%s\n%s\n%s\n", data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tastro_image.c:63:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "mv %s ./dss.fits", filename); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tastro_image.c:64:9: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (system(buf) != 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/BiasData.C:176:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(&files_[nr][0], file); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/BiasData.C:210:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(&files_[nr][0], filename); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.C:205:6: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer_, data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.C:216:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer_, "detach image event: check if %s is running!\n", RTD_SERVICE); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.C:305:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer_, "%d %s", attached(), camera()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.h:96:39: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). void camera(const char *camera) {strcpy(camBuf_, camera);} data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:171:7: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(buf, argv[i]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:399:13: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (buf, biasimage_->file(nr)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1739:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_line %g %g %g %g\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1744:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_diag_text %g %g\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1748:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s itemconfig mband_diag_text -text %s -anchor %s\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1752:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s bbox mband_diag_text\n", canvas); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1759:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_diag_rect %g %g %g %g\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1765:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_angle %g %g %g %g %g %g\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1769:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_width_text %g %g\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1773:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s itemconfig mband_width_text -text %s -anchor %s\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1777:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s bbox mband_width_text\n", canvas); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1782:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_width_rect %g %g %g %g\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1786:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_height_text %g %g\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1790:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s itemconfig mband_height_text -text %s -anchor %s\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1794:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s bbox mband_height_text\n", canvas); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1799:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_height_rect %g %g %g %g\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1807:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_angle %g %g %g %g\n", canvas, x0, y0, x1, y1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1810:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s itemconfig mband_width_text -text {}\n", canvas); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1813:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_width_rect %g %g %g %g\n", canvas, x0, y0, x1, y1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1816:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s itemconfig mband_height_text -text {}\n", canvas); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1819:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s coords mband_height_rect %g %g %g %g", canvas, x0, y0, x1, y1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:3472:6: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s %s %g %g %g %d %d %g %g %g %s", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:216:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s %d", rtdimage_->cameraPreCmd(), info.frameId); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:226:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s %d", rtdimage_->cameraPostCmd(), info.frameId); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:2106:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s %d %d %d %d %d", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.h:413:34: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). void filename(char *file) {strcpy(filename_, file);} data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.h:55:29: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). void name(char *nam) {strcpy(name_, nam);} data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.C:68:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(evDescs[timeIndex++], "%s", evDesc); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.C:132:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(timeLines[j].descr, "%s", evDescs[j]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.C:247:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(summaryData[i].procDesc, rtdEventDesc[i]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:277:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(err, "Unable to open file %s", fileName); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:358:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %s", "SIMPLE", "T"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:363:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %d", "BITPIX", bitpix); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:365:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %d", "NAXIS", 3); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:367:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %d", "NAXIS1", (subImage ? width : imageInfo->xPixels)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:369:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %d", "NAXIS2", (subImage ? height: imageInfo->yPixels)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:372:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %f", "BZERO", (double)32768.0); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:374:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= %f", "BSCALE", (double)1.0); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:381:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%-8s= \'%s\'", "DATE", buf2); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:454:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf2, "%-8s= %d", "NAXIS3", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:456:6: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer, "%-80s", buf2); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:481:2: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(TSBuf, buf3); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:484:6: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer, "%-8s= \"TS: %s/\"", "COMMENT", TSBuf); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:491:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer, "%-8s= \"TS: %s/\"", "COMMENT", TSBuf); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:486:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(msg, "Unable to open file %s", fileName); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:264:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(filename, "%s/.rtd-remote", (home ? home : "/tmp")); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdUtils.C:91:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(name_, nam); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdUtils.C:101:5: [4] (format) vprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vprintf(format, ap); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/mpfit.c:925:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(result->version, MPFIT_VERSION); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:75:5: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buf, fmt, args); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:78:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(info.errmsg, buf); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:98:5: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buf, fmt, args); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:102:5: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(buf, strerror(errno)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:104:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(info.errmsg, buf); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:217:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(filename, "%s/.rtd-remote", (home ? home : "/tmp")); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:222:9: [4] (buffer) fscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. if (fscanf(f, "%u %s %u", &info.pid, info.host, &info.port) != 3) data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c:103:22: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). case 'a': attach++; strcpy(camera,optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:316:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(error, msg); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdLOG.C:64:5: [4] (format) vprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vprintf(format, ap); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:123:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(startTime_, ctime(&timeVal)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:316:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "rtdServer info:\n" data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:326:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf2, "Entry: %d \tName: %s\tCamera: %s\t Type: %s\t\n", data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:329:6: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(buf, buf2); data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:309:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "subst %s", label); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:292:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(cmd, "%s > %s", command, tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:293:9: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if (system(cmd) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:461:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(auth_info, "%s:%s", username, passwd); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:486:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(filename, home); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:487:2: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(filename, s+1); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:524:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(newentry, "%s:%s:%s", server, realm, auth_info_); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:558:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(entry, "%s:%s:", server, realm); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:718:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "could not contact http server on %s:%d\n", hostname_, port_); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:920:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(req, "POST %s HTTP/1.0\nContent-type: text/plain\nContent-length: %d\n\n%s", data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:926:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "could not contact http server on %s:%d\n", hostname_, port_); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem.C:264:6: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(filename, F_OK) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem.C:270:6: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(filename, R_OK) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem.C:277:26: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if ((flags & O_RDWR) && access(filename, W_OK) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/ShellCommand.C:88:9: [4] (shell) execl: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execl ("/bin/sh", "sh", "-c", cmd, NULL); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:51:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(instname_, "%s%d", cmdname_, seq_++); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:54:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(instname_, instname); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/base64.C:97:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(out, in); /* I hate abort */ data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:111:5: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buf, fmt, ap); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:127:5: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buf, fmt, ap); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:202:5: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buf, fmt, ap); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:60:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(p, ar[i]); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:158:2: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(path, filename); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tHTTP.C:71:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(url, "http://%s:%d/skycat/servers/gsc-server?3:19:48+41:30:39&r10&n10", host, port); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tHTTP.C:100:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf2, "file:%s", TEST_FILE); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tHTTP.C:111:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf2, "/bin/ls %s", TEST_FILE); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tMem.C:37:2: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. system("ipcs"); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tShellCommand.C:50:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(cmd, "cat %s", TEST_FILE); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:280:49: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. sprintf(tmpfile, "/tmp/fio-%s-%d.%d.fits", getenv("USER"), getpid(), count++); // unique filename data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:342:49: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. sprintf(tmpfile, "/tmp/cfio-%s-%d.%d.fits", getenv("USER"), getpid(), count++); // unique filename data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip_util.c:477:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. env = (char*)getenv(env); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:651:17: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char* url = getenv("CATLIB_CONFIG"); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:659:11: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. url = getenv("SKYCAT_CONFIG"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:263:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char* home = getenv("HOME"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:213:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char* home = getenv("HOME"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c:94:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(argc,argv,":cvsia:r:")) != -1) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:182:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(argc,argv,":vlf:c:t:")) != -1) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:256:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv(RTD_SERVER_PORT)) data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:257:38: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rtdServerAddr.sin_port = htons(atoi(getenv(RTD_SERVER_PORT))); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtd_server.C:153:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(argc, argv, "v:p:t:")) != -1) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtd_server.C:182:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv(RTD_SERVER_PORT) != NULL) data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtd_server.C:183:16: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. portNo = atoi(getenv(RTD_SERVER_PORT)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tImageEvent.C:135:24: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char* rtd_camera = getenv("RTD_CAMERA"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:222:23: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. opt->rtd_camera = getenv("RTD_CAMERA"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:231:17: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(argc, argv, "x:y:w:h:W:H:f:v:c:t:b:l:I:E:D:0:1:2:3:")) != -1) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:484:15: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char* home = getenv("HOME"); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:1109:19: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char *proxy = getenv( "http_proxy" ); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:1125:25: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char *ptr = getenv( "http_noproxy" ); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tHTTP.C:62:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char* host = getenv("GSC_HOST"); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/Astrotcl.C:61:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:61:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[8*1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:100:20: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int write_fd = open(outfile, O_WRONLY|O_CREAT|O_TRUNC, 0777); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:136:16: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int read_fd = open(infile, O_RDONLY); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:163:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfile[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:163:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). char tmpfile[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:164:13: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). sprintf(tmpfile, "%s.comp", file); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:165:33: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). int status = compress(file, tmpfile, ctype, compress_flag, mmap_flag); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:168:9: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:172:16: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if (rename(tmpfile, file) != 0) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:107:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buf_[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:202:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(filename, "/tmp/fits%d", getpid()); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:203:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE* f = fopen(filename, "w"); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:208:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:274:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfile[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:274:7: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). char tmpfile[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:280:14: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). sprintf(tmpfile, "/tmp/fio-%s-%d.%d.fits", getenv("USER"), getpid(), count++); // unique filename data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:281:38: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). status = c.decompress(filename, tmpfile, ctype); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:285:14: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). sprintf(tmpfile, "%s.tmp", filename); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:286:36: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). status = c.compress(filename, tmpfile, ctype); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:296:15: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). strncpy(buf, tmpfile, bufsz); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:339:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfile[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:339:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). char tmpfile[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:342:13: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). sprintf(tmpfile, "/tmp/cfio-%s-%d.%d.fits", getenv("USER"), getpid(), count++); // unique filename data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:344:12: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:345:34: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if (imcopy((char *)filename, tmpfile) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:346:16: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:351:18: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). strncpy(buf, tmpfile, bufsz); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:367:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfile[1024], tmpfile2[1024], cfile[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:367:11: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). char tmpfile[1024], tmpfile2[1024], cfile[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:370:5: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). tmpfile[0] = '\0'; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:373:34: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). filename = getFromStdin(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:380:41: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). filename = check_compress(filename, tmpfile, (int)sizeof(tmpfile), istemp, 1, 0); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:380:62: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). filename = check_compress(filename, tmpfile, (int)sizeof(tmpfile), istemp, 1, 0); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:383:20: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:391:23: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). strcpy(cfile, tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:396:20: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:429:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:525:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char card[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:816:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:833:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf1[81], buf2[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:847:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf1[81], buf2[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:861:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf1[81], buf2[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:874:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf1[81], buf2[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:888:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:900:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:912:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:925:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:953:6: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfilename[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:966:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char backup[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:973:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(filename,"w"); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1013:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf2[50]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1019:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[10]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1022:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "BLANK%02d", ++i); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1090:16: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if (strcmp(tmpfile, filename) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1091:13: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if (rename(tmpfile, filename) != 0) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1158:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1412:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char value[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1688:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char keyword[16]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1689:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(keyword, "TTYPE%d", col); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1762:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf_, "%ld", l); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1778:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf_, "%I64d", ll); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1780:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf_, "%lld", ll); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1782:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf_, "%ld", ll); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1795:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf_, "%lu", ul); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1807:9: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf_, "%.*g", DBL_DIG, (double)f * scale); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1817:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf_, "%.*g", DBL_DIG, d*scale); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/HMS.C:144:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char lbuf[32]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/HMS.C:158:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char lbuf[32]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/HMS.C:176:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/ImageCoords.C:41:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(x_buf, "%g", x_); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/ImageCoords.C:42:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(y_buf, "%g", y_); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/SAOWCS.C:85:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(equinoxStr_, "%g", equinox_); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/SAOWCS.C:113:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char rastr[32], decstr[32]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/SAOWCS.h:47:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char equinoxStr_[32]; // equinox string: "J2000", "B1950", ... data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C:89:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[126]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C:90:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "could not convert equinox from %g to %g\n", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C:277:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(ra_buf, "%.17g", ra_deg()); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C:278:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(dec_buf, "%.17g", dec_deg()); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C:290:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(ra_buf, "%.17g", tmp.ra_deg()); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C:291:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(dec_buf, "%.17g", tmp.dec_deg()); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C:319:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(ra_buf, "%.17g", tmp.ra_deg()); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/WorldCoords.C:320:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(dec_buf, "%.17g", tmp.dec_deg()); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.c:132:21: [2] (race) vfork: On some old systems, vfork() permits race conditions, and it's very difficult to use correctly (CWE-362). Use fork() instead. if ( ( status = vfork() ) == 0 ) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.c:226:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip_inflate.c:780:7: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(swindow + w, swindow + d, e); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_comp.h:26:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char code_magic[2] = { 0xDD, 0x99 }; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:145:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmagic[2]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:146:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:460:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:856:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[81]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:859:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( line, "%-80.80s", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:863:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( line, "%10.10s%10d%-60.60s", "BITPIX =", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:867:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( line, "%-80.80s", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:871:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( line, "%10.10s%10d%-60.60s", "NAXIS1 =", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:875:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( line, "%10.10s%10d%-60.60s", "NAXIS2 =", data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:884:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( line, "%-80.80s", "END" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_press.c:583:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[82]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/hcomp.c:360:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char c[2]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/local_press.c:125:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. (void) memcpy( buffer, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/local_press.c:162:12: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. (void) memcpy( local_press.lp_out_buf + local_press.lp_out_buf_pos, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:239:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char temp_buffer1[MSG_MAX_LEN]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:240:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char temp_buffer2[MSG_MAX_LEN]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/pr_msg.c:39:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pr_msg[MSG_MAX_LEN]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/press.c:430:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[4]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:50:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char uh_dubious[81]; /* Dubious comments. */ data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:51:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char uh_id[17]; /* Homogeneous object id. */ data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:52:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char uh_obs_date[10];/* Observation date. */ data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:53:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char uh_imno[6]; /* Image number. */ data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:54:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char uh_cam[4]; /* Camera id. */ data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:55:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char uh_exp_code[4]; /* Exposure code. */ data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:61:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. typedef char ULDA_DATA[5]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:188:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( (char *) line, "COMMENT %-72.72s", header.uh_dubious ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:192:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( (char *) line, "%-80.80s", "END" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:296:12: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. (void) sprintf( (char *) line, "%-80.80s", "END" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/ulda.c:321:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy( data[tmp], &tmp, 2 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tCompress.C:33:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[3*1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:31:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cmd[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:72:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char keyword[80], comment[80]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:74:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(keyword, "TEST_%d", i); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:75:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(comment, "test insert of keyword %d", i); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:147:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(keyword, "TEST_%d", i); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:148:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(value, "%d", i); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:149:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(comment, "test insert of keyword %d", i); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tWorldCoords.C:31:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tWorldCoords.C:32:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%f", 49.95096/15); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tWorldCoords.C:90:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ra_buf[80], dec_buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tWorldOrImageCoords.C:53:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tWorldOrImageCoords.C:54:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%f", 49.95096/15); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:208:29: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). AstroCatalog* AstroCatalog::open(const char* name) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:251:39: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). AstroCatalog* cat = AstroCatalog::open(nameServer); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:301:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char url[10000]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:380:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char url[10000]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:884:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:885:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "/tmp/cat%d%d.fits", (int)getpid(), count++); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:886:2: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). tmpfile(buf); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:895:20: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). void AstroCatalog::tmpfile(const char* name) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.h:78:26: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). static AstroCatalog* open(const char* name); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.h:194:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). void tmpfile(const char* name); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.h:195:17: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). const char* tmpfile() {return tmpfile_;} data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.C:43:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[32]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.C:44:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "/tmp/img%d.fits", (int)getpid()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.C:70:18: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). void AstroImage::tmpfile(const char* name) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.C:82:25: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). AstroImage* AstroImage::open(const char* name) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.C:215:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.h:58:24: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). static AstroImage* open(const char* name); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.h:85:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). void tmpfile(const char* name); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroImage.h:86:17: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). const char* tmpfile() {return tmpfile_;} data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:267:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[10*2048]; // contents of a line data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:898:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[2048]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:323:6: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msg[255]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:324:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(msg, "expected %d rows, but found %d", numRows_, i); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:546:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfile[2048]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:546:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). char tmpfile[2048]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:547:13: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). sprintf(tmpfile, "%s.TMP", filename); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:548:17: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). ofstream os(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:550:40: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). return sys_error("can't open file: ", tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:553:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_ROW_SIZE]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:585:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char bakfile[2048]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:589:16: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if (rename(tmpfile, filename) != 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:631:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfile[2048]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:631:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). char tmpfile[2048]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:632:13: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). sprintf(tmpfile, "%s.TMP", filename); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:633:17: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). ofstream os(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:635:40: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). return sys_error("can't open file: ", tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:637:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_ROW_SIZE]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:649:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char bakfile[2048]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:653:16: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if (rename(tmpfile, filename) != 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:670:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_ROW_SIZE]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:852:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_ROW_SIZE]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:1002:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf2[MAX_ROW_SIZE]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:1160:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_HEADER_SIZE]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:1193:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msg[80]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:1194:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(msg, "row index %d out of range (max %d)", row, numRows_-1); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:1199:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msg[80]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:1200:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(msg, "column index %d out of range (max %d)", col, numCols_-1); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:208:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[2048]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:281:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(equinoxStr_, "2000"); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:369:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). cat_ = AstroCatalog::open(argv[0]); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:750:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ra_buf[32], dec_buf[32]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:813:29: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). return set_result(cat_->tmpfile()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1156:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1203:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%lg", e->equinox()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1208:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", e->id_col()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1213:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", e->ra_col()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1218:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", e->dec_col()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1223:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", e->x_col()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1228:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", e->y_col()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1233:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", e->is_tcs()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1238:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", e->stc_col()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1345:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char url[2048+5]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1868:16: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(cat_->tmpfile()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1869:9: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). cat_->tmpfile(value); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:1881:45: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). Tcl_AppendElement(interp_, (char*)cat_->tmpfile()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:2096:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char raStr[32], decStr[32]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.h:35:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char equinoxStr_[32]; // saved equinox option from last query data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroImage.C:143:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). im_ = AstroImage::open(argv[0]); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroImage.C:248:15: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(im_->tmpfile()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroImage.C:249:8: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). im_->tmpfile(value); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroImage.C:261:28: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). return set_result(im_->tmpfile()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclQueryUtil.C:132:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(equinoxStr, "2000"); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclTcsCat.C:137:24: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). cat_ = TcsCatalog::open(argv[0]); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclTcsCat.C:226:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalog.C:29:25: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). TcsCatalog* TcsCatalog::open(const char* name) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalog.h:75:24: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). static TcsCatalog* open(const char* name); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:89:7: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(cooSystem_, "J2000"); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.h:32:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char id_[64]; // object catalog id data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.h:35:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cooSystem_[8]; // Equinox system and equinox ("B1950" or "J2000") data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.h:41:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cooType_[4]; // Coordinate type as "M" for mean or "A" for apparent character data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.h:42:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char band_[4]; // Magnitude wavelength band ("V") data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/astro_catalog.C:59:36: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). return (AcHandle)AstroCatalog::open(name); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/astro_catalog.C:236:45: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). return (char*)(((AstroCatalog*)handle)->tmpfile()); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/astro_image.C:47:34: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). return (AiHandle)AstroImage::open(name); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/astro_image.C:85:43: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). return (char*)(((AstroImage*)handle)->tmpfile()); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tAstroCatalog.C:28:39: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). AstroCatalog* cat = AstroCatalog::open("gsc@eso"); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tAstroImage.C:29:39: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). AstroCatalog* cat = AstroCatalog::open("dss@eso"); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tAstroImage.C:51:33: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). const char* filename = cat->tmpfile(); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tLocalCatalog.C:28:39: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). AstroCatalog* cat = AstroCatalog::open("test.table"); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tQueryResult.C:29:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tQueryResult.C:44:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tTabTable.C:27:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tTcsCatalog.C:28:35: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). TcsCatalog* cat = TcsCatalog::open("gsc@eso"); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tTcsLocalCatalog.C:28:35: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). TcsCatalog* cat = TcsCatalog::open("test.table"); data/skycat-3.1.2+starlink1~b+dfsg/cat/tests/tastro_image.c:33:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/BiasData.C:137:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((char *)data.ptr(), (char *)fits->data().ptr(), length); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/BiasData.C:207:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((char *)data.ptr(), (char *)image->data().ptr(), length); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/BiasData.h:32:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char files_[MAXBIAS][1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/CompoundImageData.C:589:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%.1f %.1f -", x, y); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/CompoundImageData.C:650:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(xStr, "%.1f", cx); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/CompoundImageData.C:651:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(yStr, "%.1f", cy); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.C:361:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(head, origHeaderPtr, origHeaderSize); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.C:481:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.C:482:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", imio.bitpix()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.h:107:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name_[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.h:124:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char object_[81]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.h:171:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char blankValue_[32]; // character string with BLANK value data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.h:132:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char camBuf_[RTD_NAMELEN]; // .. and the buffer data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.h:133:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer_[1024]; // general purpose character buffer data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:165:6: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[4096]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:220:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:221:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d %d", colors_->colorCount(), colors_->freeCount()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:298:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char sts[100]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:299:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(sts, "%g %g", image_->lowCut(), image_->highCut()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:331:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:339:9: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", biasimage_->status()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:345:9: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", MAXBIAS); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:362:13: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", biasimage_->select()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:368:13: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "biasimage select: number must be in range 0-%d", MAXBIAS-1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:412:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char sts[10]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:413:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(sts, "%d", biasimage_->status()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:453:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[128]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:463:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", camera_->attached()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:855:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char outx_buf[32], outy_buf[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:926:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:927:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%g %g", image_->lowCut(), image_->highCut()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:933:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char sts[100]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:934:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(sts, "%g %g", image_->lowCut(), image_->highCut()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:958:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:960:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%.1f %.1f %.1f %.1f", x0, y0, x1, y1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:980:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:981:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%g %g", minv, maxv); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1107:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1108:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d %d", image_->flipX(), image_->flipY()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1178:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char sts[10]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1179:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(sts, "%d %d", image_->flipX(), image_->flipY()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1219:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1278:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1295:17: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(buf, "- "); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1298:17: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%g ", val); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1643:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:1676:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char widthStr[32], heightStr[32], distStr[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2410:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char sts[10]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2411:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(sts, "%d", image_->rotate()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2468:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char sts[100]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2469:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(sts, "%d %d", image_->xScale(), image_->yScale()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2592:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2597:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d %d %d %d", m.shmId(), m.offset(), m.length(), m.size()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2604:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d %d %d %d", m.shmId(), m.offset(), m.length(), m.size()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2840:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cx[TCL_DOUBLE_SPACE], cy[TCL_DOUBLE_SPACE]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2841:17: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf( cx, "%.9g", dx ); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2842:17: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf( cy, "%.9g", dy ); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2879:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:2883:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf (buf, "%g %g %g %g %d %d %d %d %d", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:3267:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:3374:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:3375:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%.2f", equinox); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:3460:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:3464:6: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char raStr[32], decStr[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:3483:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "{} {} {} {} {} %d %d 0 2000 2000 {}", data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCoords.C:152:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(outx_buf, "%.17g", x); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCoords.C:154:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(outy_buf, "%.17g", y); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCoords.C:180:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char in[2], out[2]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdHDU.C:307:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[20]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdHDU.C:330:17: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf( buf, "TUNIT%d", racol + 1 ); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdHDU.C:341:17: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf( buf, "TUNIT%d", deccol + 1 ); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdHDU.C:579:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char extName[80], naxis[32], naxis1[32], naxis2[32], naxis3[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdHDU.C:580:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char crpix1[32], crpix2[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:208:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[2048]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:350:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:531:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char hostname[64]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:906:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&infoRapid, &info, sizeof(rtdIMAGE_INFO)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1017:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1909:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char xStr[32], yStr[32], valueStr[32], raStr[32], decStr[32], equinoxStr[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1925:6: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char indexStr[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1934:7: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(indexStr, "%d,%d", j, i); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1938:8: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%g", d); // pix value data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1961:8: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%.1f", d); // x,y index data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1971:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%g", ave); // average data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1973:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%g", minv); // min data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1975:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%g", maxv); // max data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1977:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%d", npix); // npix data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1980:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%d", maxx); // maxx data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1982:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%d", maxy); // maxy data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1985:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%d", minx); // minx data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1987:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%d", miny); // miny data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:2002:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(valueStr, "%g", rms); // rms data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:2105:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.h:250:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename_[1024]; // filename or object of master image data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:164:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%.3f", 1.0 / FREQtime_); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:166:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%.3f", (imageCount_ - 1.0) / accFREQtime_); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:193:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%.0f", imageCount_); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:196:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%6.3f", GENtime_); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:198:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%6.3f", Xtime_); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:200:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%6.3f", TCLtime_); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:202:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%8.3f", TOTtime * 1.0e+3); // in msec data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:206:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%6.3f", aveGENtime); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:208:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%6.3f", aveXtime); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:210:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%6.3f", aveTCLtime); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.C:212:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer_, "%6.3f", aveTOTtime * 1.0e+3); // in msec data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.h:82:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name_[100]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerf.h:83:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer_[2048]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.C:93:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(evDescs[timeIndex], "SEND"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.C:94:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&timeStamps[timeIndex++], (void *)&imageInfo->timeStamp, data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.C:135:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(timeLines[timeIndex - 1].descr, "END"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.C:146:17: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fStr = fopen(RTD_PTEST_FNAME, "w")) == NULL) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.h:25:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char descr[32]; // Line description. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.h:31:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char procDesc[32]; /* Process description line. */ data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdPerformanceTool.h:50:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char evDescs[RTD_NUMSHM * RTD_NUMTMSTMPS][32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:57:14: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fPtr = fopen(fileName, accFlag)) == NULL) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:214:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[64]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:222:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer, "%d %d %d %d", imageCounter_, numFileImages_, bof, eof); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:270:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[16]; // Temporary buffer. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:276:17: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((file = fopen(fileName, "r")) == NULL) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:297:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (newInstance->open(err) == TCL_ERROR) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:345:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81], // Temporary buffers data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:390:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "BLANK%02d", i++); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:423:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[81]; // Buffer for reading data from file. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:424:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf2[64]; // General purpose buffer. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:475:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char TSBuf[64]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:477:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf3[32]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:479:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf3, "%.3lf ", timeStamps_[i]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:509:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int RtdFITSCube::open(char *errMsg) data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:511:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[81]; // Temporary buffer. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:541:17: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). xPixels_ = atoi(vptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:546:17: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). yPixels_ = atoi(vptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:551:18: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). dataType_ = atoi(vptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:559:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). numFileImages_ = atoi(ptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:563:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). bscale = atoi(ptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:567:14: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). bzero = atoi(ptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:577:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(errMsg, "Not a FITS file"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:615:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(errMsg, "Inconsistency between timestamp and image number"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:705:14: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fPtr = fopen(fileName_, "w+")) == NULL) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.h:67:17: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). virtual int open(char *errMsg) {return 0;} // Initialise props of existing file. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.h:138:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int open(char *); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.h:166:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int open(char*) {return 0;} data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:225:18: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). cycleMode_ = atoi(argv[0]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:360:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(camera_, "RTDSIMULATOR"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:464:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msg[64]; // User error message data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:574:33: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). fileFormat_ = (enum fileFormat)atoi(argv[1]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:636:11: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). x0_ = atoi(argv[1]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:637:11: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). y0_ = atoi(argv[2]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:638:14: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). width_ = atoi(argv[3]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:639:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). height_ = atoi(argv[4]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:729:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(err, "Unable to read file for playback"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:734:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(err, "Unable to allocate shared memory"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:909:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char errMsg[64]; // Return error message. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:962:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char errMsg[64]; // Error message buffer data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:1027:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char errMsg[2*1024]; // Error message buffer data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:1040:31: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). playSpeed_ = (enum playSpeed)atoi(argv[1]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:1043:14: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). direction = atoi(argv[1]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:1080:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char errMsg[64]; // Error message buffer data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:1196:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[2]; // Return buffer data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:1204:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", fileHandler->hasTimeInfo()); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:1232:13: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). index = atoi(argv[0]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.h:48:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char fileName[MAXFILENAMELEN]; // Filename to load images into. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.h:87:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char camera_[32]; // Camera to attach to. data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:262:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:265:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE* f = fopen(filename, "w+"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:268:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char hostname[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:270:2: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(hostname, "localhost"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:325:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&readFds, &readMask, sizeof(fd_set)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:371:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:372:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d %d\n", status, length); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:451:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[2*1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdUtils.C:77:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%02d:%02.2f", min*sign, sec); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdUtils.C:80:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%02.2f", sec*sign); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdUtils.h:38:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name_[100]; // name of application data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/iqefunc.c:487:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(b, arrin, n * sizeof(float)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/mpfit.h:116:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char version[20]; /* MPFIT version string */ data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:50:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char host[64]; /* hostname where dsplay is running */ data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:52:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char errmsg[10240]; /* copy of last error message */ data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:72:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[sizeof(info.errmsg)]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:92:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[sizeof(info.errmsg)]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:101:5: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat(buf, ": "); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:212:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[1024]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:215:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char hostname[64]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:218:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(filename, "r"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:354:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buf[1024]; /* use to hold results up to 1024 bytes */ data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/tkCanvasPsImage.c:153:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[256]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/tkCanvasPsImage.c:223:9: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buffer, "%.15g %.15g", x, y); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCLNT.h:96:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char reqNameBuf_[RTD_NAMELEN]; // name of requestor data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCLNT.h:97:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char camNameBuf_[RTD_NAMELEN]; // name of camera data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c:82:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char c,*buf, camera[RTD_NAMELEN],reqName[RTD_NAMELEN]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c:92:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(reqName,"rtdClient"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:102:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[81],*ptr,*vptr; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:114:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). *width = atoi(vptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:119:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). *height = atoi(vptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:124:19: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). cnt = atoi(vptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:129:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). *type = atoi(vptr); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:166:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char c,camera[RTD_NAMELEN],reqName[RTD_NAMELEN],fileName[256]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:191:27: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). case 't': timer = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:226:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fptr = fopen(fileName,"r"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:225:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:257:33: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). rtdServerAddr.sin_port = htons(atoi(getenv(RTD_SERVER_PORT))); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:303:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&eventHndl->clientAddr,&rtdClientAddr,sizeof(rtdClientAddr)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:425:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&rtdPacket->body.data.rtdImageInfo, imageInfo, sizeof(rtdIMAGE_INFO)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:506:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(imageInfo, &rtdPacket.body.data.rtdImageInfo, sizeof(rtdIMAGE_INFO)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.h:133:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char proj[8]; /* Projection: one of: "-SIN", "-TAN", "-ARC", "-NCP", "-GLS", data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.h:157:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char reqName[RTD_NAMELEN]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.h:181:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char reqName[RTD_NAMELEN]; /* requestor type */ data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.h:182:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char camName[RTD_NAMELEN]; /* requestor name */ data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.h:192:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char text[sizeof(rtdFORMAT_DATA)]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:314:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[4096], buf2[256]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:322:5: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat(buf, "Current rtdServer clients:\n"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.h:62:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char startTime_[256]; // start time data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSem.c:451:6: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. if (memcpy(ptr, data, shmSize) == NULL) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtd_server.C:162:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). portNo = atoi(optarg); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtd_server.C:165:14: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). delay = atoi(optarg); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtd_server.C:183:11: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). portNo = atoi(getenv(RTD_SERVER_PORT)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tImageEvent.C:85:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(s2, s1, WINSIZE * NUMBYTE); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tImageEvent.C:96:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(s1, s2, WINSIZE * NUMBYTE); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tImageEvent.C:168:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int fd = open(DFILE, O_RDONLY); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:90:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char data[MAX_NX * MAX_NY * 4]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:234:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->rapid_x = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:236:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->rapid_y = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:238:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->main_width = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:240:26: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->main_height = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:242:26: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->rapid_width = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:244:26: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->rapid_height = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:246:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->rapid_id = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:248:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->verbose = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:252:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->delay = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:254:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->numShm = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:256:19: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->lock = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:260:24: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->shmEndian = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:262:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->dataType = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:264:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->starx = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:266:20: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->stary = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:268:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->starbbox = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtd.C:270:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). opt->starjitter = atoi(optarg); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtdEvt.C:65:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data_, (char *)fits_->data().ptr(), nbytes); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtdEvt.C:159:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(imageInfo_.proj, "-TAN"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/trtdRemote.c:71:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[81]; data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/trtdRemote.c:92:6: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). w = atoi(send_rtd("width")); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/trtdRemote.c:93:6: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). h = atoi(send_rtd("height")); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/trtdRemote.c:94:11: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). bitpix = atoi(send_rtd("bitpix")); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/trtdRemote.c:133:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). data_id = atoi(send_rtd("shm get data")); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/trtdRemote.c:134:17: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). header_id = atoi(send_rtd("shm get header")); data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:305:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char labelVal[256]; data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:308:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:418:6: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char xy_units[32]; data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:422:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(xy_units, "image"); data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:427:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(xy_units, "deg"); data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:685:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[eval_buf_size_]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/ErrorHandler.C:71:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msg[80]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:103:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(hostname_, "localhost"); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:129:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024*2]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:183:11: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int HTTP::open(const char* hostname, int port) data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:223:6: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&servAddr_.sin_addr, host->h_addr_list[0], host->h_length); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:252:6: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(new_url, "%20"); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:270:13: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd_ = ::open(filename, O_RDONLY); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:288:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cmd[2048]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:289:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfile[80]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:289:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). char tmpfile[80]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:290:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(tmpfile, "/tmp/httpXXXXXX"); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:290:12: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). strcpy(tmpfile, "/tmp/httpXXXXXX"); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:291:5: [2] (tmpfile) mkstemp: Potential for temporary file vulnerability in some circumstances. Some older Unix-like systems create temp files with permission to write by all by default, so be sure to set the umask to override this. Also, some older Unix systems might fail to use O_EXCL when opening the file, so make sure that O_EXCL is used by the library (CWE-377). mkstemp(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:291:13: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). mkstemp(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:292:38: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). sprintf(cmd, "%s > %s", command, tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:295:9: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:304:43: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). int nHeaderLines = checkCommandOutput(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:307:27: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). int status = openFile(tmpfile); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:308:12: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). unlink(tmpfile); // remove on close data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:311:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:335:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[80]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:460:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char auth_info[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:482:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:523:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char newentry[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:525:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:557:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char entry[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:560:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:625:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:643:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char host[64]; // http host name data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:645:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char args[1024]; // part of URL after host:port data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:646:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char req[2048]; // request sent to http data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:649:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char new_url[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:668:13: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (open(host, port) != 0) data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:672:13: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (open(proxyname_, proxyport_) != 0) data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:717:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[255]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:734:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:780:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[8*1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:881:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char host[64]; // http host name data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:883:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char args[1024]; // part of URL after host:port data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:884:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char req[1024]; // request sent to http data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:898:13: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (open(host, port) != 0) data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:902:13: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (open(proxyname_, proxyport_) != 0) data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:925:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[255]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:942:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:984:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[8*1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:1131:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.h:40:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char hostname_[64]; // http server hostname data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.h:41:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char proxyname_[64]; // http proxy server hostname data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.h:75:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int open(const char* hostname, int port = 80); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem.C:700:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m.ptr(), ptr(), length()); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem_Map.C:160:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). Mem_Map::open(const char file_name[], data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem_Map.C:166:21: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). this->handle_ = ::open(file_name, flags, mode); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem_Map.C:189:13: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (this->open(file_name, flags, mode) == -1) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem_Map.h:130:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int open (const char file_name[], data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem_Map.h:193:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename_[MAXPATHLEN + 1]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:159:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[32]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:160:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", i); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:171:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[64]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:172:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d %d", i, j); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:184:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[TCL_DOUBLE_SPACE + 1]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:202:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[TCL_DOUBLE_SPACE]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:244:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[32]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:245:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d", i); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:256:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[64]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:257:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf, "%d %d", i, j); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:269:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[TCL_DOUBLE_SPACE + 1]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:285:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[TCL_DOUBLE_SPACE + 1]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Tclutil.C:70:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/base64.C:66:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char in[3]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:38:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char errmsg_[5*1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:108:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:124:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:199:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tHTTP.C:70:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char url[255]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tHTTP.C:89:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf2[1024]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tMem.C:92:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy((char*)m1.ptr(), "test 1"); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tMem.C:136:18: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). Mem m7(1024, tmpfile, 1); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tShellCommand.C:49:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char cmd[1024]; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/DCompress.C:62:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while((n = read(read_fd, buf, sizeof(buf))) > 0) { data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:177:6: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy((char*)mergedHeader_.ptr(), data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:181:6: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(((char*)mergedHeader_.ptr())+header_.length(), data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:296:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, tmpfile, bufsz); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:351:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, tmpfile, bufsz); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:365:17: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). FitsIO* FitsIO::read(const char* filename, int mem_options) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:820:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy((char*)header.ptr(), os.str().c_str(), header.length()); // write to shared memory data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1159:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while(is.read(buf, 80)) { data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/FitsIO.C:1429:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, s, bufsz); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/Fits_IO.h:137:20: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). static FitsIO* read(const char* filename, int memOptions = 0); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/HMS.C:152:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy( buf, lbuf, 32 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/HMS.C:166:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy( buf, lbuf, 32 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/generic/slasubs.c:277:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). l = strlen ( order ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.c:165:16: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). bytes_read = read( in_pipe[0], in_buffer, 4096 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip.c:184:22: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). bytes_read = read( in_pipe[0], in_buffer, 4096 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip_util.c:153:11: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). insize = read(in, (char*)inbuf, INBUFSIZ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/gzip_util.c:480:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p = (char*)xmalloc(strlen(env)+1); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:167:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. (void) strncpy( line, "SI", 2 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:880:26: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). (int)strlen( datatype), (int)strlen( datatype ), datatype, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:880:50: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). (int)strlen( datatype), (int)strlen( datatype ), datatype, data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_decomp.c:881:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). 22-(int)strlen( datatype), "/", "" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_press.c:618:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(line) != 80) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/h_press.c:620:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (j = strlen(line); j < 80; j++) data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/local_press.c:193:11: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). len = read( local_press.lp_infile, buffer, length ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:118:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len1 = strlen( msg1 ) + 1; data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:119:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len2 = strlen( msg2 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:130:13: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. (void) strcat( msg1, "\n" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:131:13: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. (void) strncat( msg1, msg2, len2 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/msg.c:304:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). indent_size = strlen( temp_buffer2 ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/press/press.c:436:15: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). PR_CHECK_IO( read( fd_in, (char *) buf, sizeof(buf) ), "read" ); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:39:28: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). FitsIO* fits = FitsIO::read("tmp.fits", Mem::FILE_RDWR); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:81:20: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). fits = FitsIO::read("tmp.fits", Mem::FILE_RDWR); data/skycat-3.1.2+starlink1~b+dfsg/astrotcl/tests/tFitsIO.C:142:20: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). fits = FitsIO::read("tmp.fits.gz", Mem::FILE_RDWR); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:592:43: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strcmp(armin[i], armax[i]) == 0 || strlen(armax[i]) == 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:614:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, os.str().c_str(), bufsz); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/AstroCatalog.C:617:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(q.id()) && ! url_has_id) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:204:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += (strlen(p) - 1); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:236:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int i = strlen(p); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:243:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). i = strlen(p); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:277:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (buf[0] == '#' || strlen(buf) == 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:906:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (buf[0] == '#' || strlen(buf) == 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/CatalogInfo.C:1107:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (s && strlen(s)) { data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/LocalCatalog.C:140:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(data, (char*)m.ptr(), size-1); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/LocalCatalog.C:160:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). l = strlen( c ); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/QueryResult.C:295:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(q.id()) != 0) { // search for id only data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:216:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(s)) { data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:219:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). char* p = s + strlen(s) - 1; data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:460:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int l = strlen(colName(col)); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TabTable.C:671:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, tableRow, sizeof(buf)-1); // make a copy, since nulls are inserted by splitList data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:307:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (dirList == NULL || strlen(dirList) == 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:367:36: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (argc == 1 || (argc == 2 && strlen(argv[1]) == 0)) { data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:685:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(argv[0]) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:884:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(argv[0]); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroCat.C:983:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (! value || ! strlen(value)) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroImage.C:315:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(argv[0]) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclAstroImage.C:346:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strncmp(argv[0], e->servType(), strlen(e->servType())) == 0) { data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclQueryUtil.C:174:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(value) == 0) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TclQueryUtil.C:310:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(id) && q.id(id)) data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:90:7: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(cooType_, "M"); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:91:7: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(band_, "V"); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:271:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, os.str().c_str(), bufsize); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:297:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, os.str().c_str(), bufsize); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:311:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(id_, v, sizeof(id_)-1); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:329:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(cooSystem_, (v ? v : ""), sizeof(cooSystem_)-1); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:365:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(cooType_, (v ? v : ""), sizeof(cooType_)-1); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsCatalogObject.C:371:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(band_, (v ? v : ""), sizeof(band_)-1); data/skycat-3.1.2+starlink1~b+dfsg/cat/generic/TcsQueryResult.C:108:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(p) == 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/BiasData.C:103:20: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). fits = FitsIO::read(file, O_RDONLY | S_IRUSR); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.h:531:42: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). virtual void name(const char* name) {strncpy(name_, name, sizeof(name_)-1);} data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.h:534:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(object_, object, sizeof(object_)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/ImageData.h:557:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(blankValue_, value, sizeof(blankValue_)-1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCamera.C:190:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(cameraName) == 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:169:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). l += strlen(argv[i]); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:172:7: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. strcat(buf, " "); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:470:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). cameraPreCmd_ = (strlen(argv[2]) ? strdup(argv[2]) : (char*)NULL); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:475:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). cameraPostCmd_ = (strlen(argv[3]) ? strdup(argv[3]) : (char*)NULL); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:558:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (reuse && image_ && strlen(file()) == 0 && strlen(image_->object()) == 0 && data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:558:48: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (reuse && image_ && strlen(file()) == 0 && strlen(image_->object()) == 0 && data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:860:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(outx_name) == 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCmds.C:862:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(outy_name) == 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCoords.C:51:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). && strlen(coordType) > 4 data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdCoords.C:74:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(s); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdHDU.C:590:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(crpix1) != 0 && strlen(crpix2) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdHDU.C:590:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(crpix1) != 0 && strlen(crpix2) != 0) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:533:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(hostname); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1406:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(file()) == 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1441:17: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). fits = FitsIO::read(file(), O_RDONLY | S_IRUSR); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdImage.C:1501:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(newImageCmd())) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:476:5: [1] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source is a constant character. sprintf(TSBuf, "\0"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPFile.C:486:6: [1] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source is a constant character. sprintf(TSBuf, "\0"); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:205:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return TclCommand::call(name, strlen(name), argc, argv); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:266:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(fileName, argv[0], MAXFILENAMELEN); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:447:34: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return RtdRPTool::call(name, strlen(name), argc, argv); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:599:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(camera_, argv[0], 32); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRPTool.C:889:34: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return RtdRPTool::call(name, strlen(name), argc, argv); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:104:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). nread = read(fd, ptr, nleft); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:131:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if ( (rc = read(fd, &c, 1)) == 1) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:177:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return writen(fd, ptr, strlen(ptr)) + writen(fd, "\n", 1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:373:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (writen(socket, buf, strlen(buf)) <= 0 data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:401:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen(name); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/RtdRemote.C:462:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(Tcl_GetStringResult(interp_)), data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/mpfit.c:31:32: [1] (obsolete) ulimit: This C routine is considered obsolete (as opposed to the shell command by the same name, which is NOT obsolete) (CWE-676). Use getrlimit(2), setrlimit(2), and sysconf(3) instead. int *qulimited, double *ulimit, data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/mpfit.c:982:32: [1] (obsolete) ulimit: This C routine is considered obsolete (as opposed to the shell command by the same name, which is NOT obsolete) (CWE-676). Use getrlimit(2), setrlimit(2), and sysconf(3) instead. int *qulimited, double *ulimit, data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/mpfit.c:1137:16: [1] (obsolete) ulimit: This C routine is considered obsolete (as opposed to the shell command by the same name, which is NOT obsolete) (CWE-676). Use getrlimit(2), setrlimit(2), and sysconf(3) instead. qulimited && ulimit && qulimited[j] && data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/mpfit.c:1138:12: [1] (obsolete) ulimit: This C routine is considered obsolete (as opposed to the shell command by the same name, which is NOT obsolete) (CWE-676). Use getrlimit(2), setrlimit(2), and sysconf(3) instead. (temp > (ulimit[j]-h)))) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:127:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). nread = read(fd, ptr, nleft); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:175:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if ( (rc = read(fd, &c, 1)) == 1) { data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:199:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return writen(fd, ptr, strlen(ptr)) + writen(fd, "\n", 1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/generic/rtd_remote.c:266:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(info.host, host, sizeof(info.host)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCLNT.C:135:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((ReqName() == 0) || (strlen(ReqName()) == 0)) data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCLNT.h:47:33: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). void ReqName(char *name) { strncpy (reqNameBuf_, name, RTD_NAMELEN); } data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCLNT.h:51:33: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). void CamName(char *name) { strncpy (camNameBuf_, name, RTD_NAMELEN); } data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c:104:12: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). case 'r': strncpy(reqName,optarg,RTD_NAMELEN); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c:130:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(rtdPacket.body.data.hdr.reqName,reqName,RTD_NAMELEN); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c:168:7: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). read(eventHndl.socket,&rtdPacket, data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdClient.c:179:7: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). read(eventHndl.socket,buf,readable); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:192:19: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). case 'r': strncpy(reqName,optarg,RTD_NAMELEN); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:193:19: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). case 'f': strncpy(fileName,optarg,256); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:194:19: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). case 'c': strncpy(camera,optarg,RTD_NAMELEN); break; data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:207:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(camera) == 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdCubeDisplay.c:219:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(fileName) == 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:304:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(eventHndl->reqName,requestor,RTD_NAMELEN); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:424:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(rtdPacket->body.data.hdr.reqName,eventHndl->reqName, RTD_NAMELEN); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:478:6: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). n = read(eventHndl->socket, &rtdPacket, sizeof(rtdPACKET)); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:537:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(rtdPacket.body.data.hdr.reqName,eventHndl->reqName, data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:539:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(rtdPacket.body.data.hdr.camName,camera, data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:574:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(rtdPacket.body.data.hdr.reqName,eventHndl->reqName, RTD_NAMELEN); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:576:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(rtdPacket.body.data.hdr.camName,camera, RTD_NAMELEN); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdImageEvent.c:609:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(rtdPacket.body.data.hdr.reqName,eventHndl->reqName, RTD_NAMELEN); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:168:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). n = read(socket, &rtdPacket, packetSize); data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:328:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(buf) + sizeof(buf2) + 1 < sizeof(buf)) data/skycat-3.1.2+starlink1~b+dfsg/rtd/rtdevt/rtdSERVER.C:333:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). write(socket, buf, strlen(buf)+1); data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tImageEvent.C:172:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if ((read(fd, ptrInfo, OFFSET)) < 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tImageEvent.C:175:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if ((read(fd, ptrInfo, XSIZE * YSIZE * NUMBYTE)) < 0) data/skycat-3.1.2+starlink1~b+dfsg/rtd/tests/tRtdEvt.C:48:18: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). fits_ = FitsIO::read(opt->fitsFile); data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:114:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(argv[1])) { data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:121:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(argv[2])) { data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:128:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(argv[3])) { data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:135:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(argv[4])) { data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:142:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(argv[5])) { data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:204:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) { data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:307:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) { data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:313:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(Tcl_GetStringResult(interp_))) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:314:6: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(labelVal, Tcl_GetStringResult(interp_), data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:398:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (nexpr == 0 || strlen(exprList[0]) == 0) { data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:404:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (nexpr > 1 && strlen(exprList[1])) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/SkySearch.C:462:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!r.symbol() || strlen(r.symbol()) == 0) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:364:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:409:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:462:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:507:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:552:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:710:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:759:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:808:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:851:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/skycat/generic/Skycat.C:890:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (label && strlen(label)) data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:130:8: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). is.read(buf, sizeof(buf)); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:191:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(hostname_, hostname, sizeof(hostname_)-1); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:339:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(buf) <= 2) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:404:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(www_auth_realm_)-1; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:526:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(server) + strlen(realm) + 1; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:526:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(server) + strlen(realm) + 1; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:559:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(entry); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:626:6: [1] (buffer) sscanf: It's unclear if the %s limit in the format string is small enough (CWE-120). Check that the limit is sufficiently small, or use a different input function. if (sscanf(url, "file:%1023s", filename) == 1) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:656:9: [1] (buffer) sscanf: It's unclear if the %s limit in the format string is small enough (CWE-120). Check that the limit is sufficiently small, or use a different input function. if (sscanf(new_url, "http://%63[^:/]:%d%1000s", host, &port, args) != 3 && data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:657:2: [1] (buffer) sscanf: It's unclear if the %s limit in the format string is small enough (CWE-120). Check that the limit is sufficiently small, or use a different input function. sscanf(new_url, "http://%63[^/]%1000s", host, args) != 2) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:676:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy( args, new_url, 1024 ); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:680:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy( hostname_, host, 64 ); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:712:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(req, os.str().c_str(), sizeof(req)); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:715:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(req); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:785:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while ((n = read(fd_, buf, sizeof(buf))) > 0) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:792:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while ((n = read(fd_, buf, sizeof(buf))) > 0) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:886:9: [1] (buffer) sscanf: It's unclear if the %s limit in the format string is small enough (CWE-120). Check that the limit is sufficiently small, or use a different input function. if (sscanf(url, "http://%63[^:/]:%d%1000s", host, &port, args) != 3 && data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:887:2: [1] (buffer) sscanf: It's unclear if the %s limit in the format string is small enough (CWE-120). Check that the limit is sufficiently small, or use a different input function. sscanf(url, "http://%63[^/]%1000s", host, args) != 2) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:906:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(args, url, 1024); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:910:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(hostname_, host, 64); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:921:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). args, (int) strlen(data), data); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:923:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int n = strlen(req); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:988:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while((n = read(fd_, buf, sizeof(buf))) > 0) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:995:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while((n = read(fd_, buf, sizeof(buf))) > 0) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:1041:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if ( (rc = read(fd_, &c, 1)) == 1) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/HTTP.C:1132:7: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, ptr, sizeof(buf)-1); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/Mem_Map.C:164:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). ::strncpy (this->filename_, file_name, MAXPATHLEN); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/ShellCommand.C:52:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (read(fd, buf, stat_buf.st_size) != stat_buf.st_size) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:50:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). instname_ = new char[strlen(cmdname_)+16]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:53:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). instname_ = new char[strlen(instname)+1]; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/TclCommand.C:120:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen(argv[1]); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/base64.C:46:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t size = strlen(input); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/base64.C:115:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = strlen(input); i > 3; i -= 4) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:68:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(errmsg_, os.str().c_str(), sizeof(errmsg_)-1); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/error.C:97:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(errmsg_, os.str().c_str(), sizeof(errmsg_)-1); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:53:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). n += strlen(ar[i])+1; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:61:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(ar[i])+1; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:76:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). char* q = p + strlen(p) - 1; data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:157:2: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. strcat(path, "/"); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:176:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). nread = read(fd, ptr, nleft); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:206:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if ( (rc = read(fd, &c, 1)) == 1) { data/skycat-3.1.2+starlink1~b+dfsg/tclutil/generic/util.C:259:42: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return writeUnbufferedBytes(fd, ptr, strlen(ptr)) data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tHTTP.C:42:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ofile.write(TEST_STRING, strlen(TEST_STRING)); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tMem.C:58:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ofile.write(TEST_STRING, strlen(TEST_STRING)); data/skycat-3.1.2+starlink1~b+dfsg/tclutil/tests/tShellCommand.C:36:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ofile.write(TEST_STRING, strlen(TEST_STRING)); ANALYSIS SUMMARY: Hits = 986 Lines analyzed = 84249 in approximately 2.36 seconds (35717 lines/second) Physical Source Lines of Code (SLOC) = 52228 Hits@level = [0] 361 [1] 202 [2] 552 [3] 21 [4] 209 [5] 2 Hits@level+ = [0+] 1347 [1+] 986 [2+] 784 [3+] 232 [4+] 211 [5+] 2 Hits/KSLOC@level+ = [0+] 25.7908 [1+] 18.8788 [2+] 15.0111 [3+] 4.44206 [4+] 4.03998 [5+] 0.0382936 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.