Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/smpeg-0.4.5+cvs20030824/MPEG.cpp
Examining data/smpeg-0.4.5+cvs20030824/MPEGring.cpp
Examining data/smpeg-0.4.5+cvs20030824/MPEGlist.cpp
Examining data/smpeg-0.4.5+cvs20030824/MPEGstream.cpp
Examining data/smpeg-0.4.5+cvs20030824/MPEGsystem.cpp
Examining data/smpeg-0.4.5+cvs20030824/MPEGfilter.c
Examining data/smpeg-0.4.5+cvs20030824/smpeg.cpp
Examining data/smpeg-0.4.5+cvs20030824/gtv.c
Examining data/smpeg-0.4.5+cvs20030824/gtv.h
Examining data/smpeg-0.4.5+cvs20030824/glmovie-tile.c
Examining data/smpeg-0.4.5+cvs20030824/glmovie.c
Examining data/smpeg-0.4.5+cvs20030824/glmovie.h
Examining data/smpeg-0.4.5+cvs20030824/MPEG.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGaction.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGerror.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGfilter.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGring.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGlist.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGstream.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGsystem.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGvideo.h
Examining data/smpeg-0.4.5+cvs20030824/smpeg.h
Examining data/smpeg-0.4.5+cvs20030824/audio/MPEGaudio.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/bitwindow.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/filter.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/filter_2.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/mpeglayer1.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/mpeglayer2.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/mpeglayer3.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/mpegtable.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/mpegtoraw.cpp
Examining data/smpeg-0.4.5+cvs20030824/audio/huffmantable.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/MPEGvideo.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/decoders.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/decoders.h
Examining data/smpeg-0.4.5+cvs20030824/video/dither.h
Examining data/smpeg-0.4.5+cvs20030824/video/floatdct.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/gdith.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/jrevdct.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/motionvector.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/parseblock.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/proto.h
Examining data/smpeg-0.4.5+cvs20030824/video/readfile.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/util.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/util.h
Examining data/smpeg-0.4.5+cvs20030824/video/video.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/video.h
Examining data/smpeg-0.4.5+cvs20030824/video/vhar128.cpp
Examining data/smpeg-0.4.5+cvs20030824/video/vhar128.h
Examining data/smpeg-0.4.5+cvs20030824/MPEGaudio.h
Examining data/smpeg-0.4.5+cvs20030824/plaympeg.c
FINAL RESULTS:
data/smpeg-0.4.5+cvs20030824/MPEG.cpp:115:10: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if ( system && system->WasError() ) {
data/smpeg-0.4.5+cvs20030824/MPEG.cpp:154:6: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if(system) delete system;
data/smpeg-0.4.5+cvs20030824/MPEG.cpp:154:21: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if(system) delete system;
data/smpeg-0.4.5+cvs20030824/MPEG.h:112:18: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
MPEGsystem * system;
data/smpeg-0.4.5+cvs20030824/MPEGerror.h:39:9: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
vsprintf(errbuf, fmt, ap);
data/smpeg-0.4.5+cvs20030824/MPEGstream.h:98:24: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
class MPEGsystem * system;
data/smpeg-0.4.5+cvs20030824/MPEGsystem.cpp:1295:41: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
bool MPEGsystem::SystemLoop(MPEGsystem *system)
data/smpeg-0.4.5+cvs20030824/MPEGsystem.cpp:1348:23: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if ( ! SystemLoop(system) ) {
data/smpeg-0.4.5+cvs20030824/MPEGsystem.h:75:40: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
static bool SystemLoop(MPEGsystem *system);
data/smpeg-0.4.5+cvs20030824/gtv.c:155:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy( gtv_default_directory, filename);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:221:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(http_request,
data/smpeg-0.4.5+cvs20030824/plaympeg.c:327:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(ftp_request, "CWD %s\r\n", dir);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:359:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(ftp_request, "RETR %s\r\n", file);
data/smpeg-0.4.5+cvs20030824/smpeg.cpp:124:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(info->audio_string,
data/smpeg-0.4.5+cvs20030824/smpeg.cpp:140:20: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if(mpeg->obj->system != NULL)
data/smpeg-0.4.5+cvs20030824/video/parseblock.cpp:115:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
use_mmx = getenv("SMPEG_USE_MMX");
data/smpeg-0.4.5+cvs20030824/MPEG.cpp:67:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mpeg_mem, data, size);
data/smpeg-0.4.5+cvs20030824/MPEGaudio.h:148:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[2*WINDOWSIZE];
data/smpeg-0.4.5+cvs20030824/MPEGerror.h:58:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errbuf[512];
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:54:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:65:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w >> 1);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:76:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w >> 1);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:117:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:147:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:157:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w >> 1);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:168:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w >> 1);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:215:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:266:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:276:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w >> 1);
data/smpeg-0.4.5+cvs20030824/MPEGfilter.c:287:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(d, s, region->w >> 1);
data/smpeg-0.4.5+cvs20030824/MPEGstream.cpp:254:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(area, data, len);
data/smpeg-0.4.5+cvs20030824/MPEGstream.cpp:308:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newbr->Buffer(), Data, Size);
data/smpeg-0.4.5+cvs20030824/audio/bitwindow.cpp:24:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char store[4];
data/smpeg-0.4.5+cvs20030824/audio/mpegtoraw.cpp:35:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char store[4];
data/smpeg-0.4.5+cvs20030824/gtv.c:1025:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
GtkWidget *open;
data/smpeg-0.4.5+cvs20030824/gtv.c:1089:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gtk_widget_ref (open);
data/smpeg-0.4.5+cvs20030824/gtv.c:1090:62: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gtk_object_set_data_full (GTK_OBJECT (gtv_window), "open", open,
data/smpeg-0.4.5+cvs20030824/gtv.c:1092:20: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gtk_widget_show (open);
data/smpeg-0.4.5+cvs20030824/gtv.c:1093:49: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gtk_container_add (GTK_CONTAINER (file_menu), open);
data/smpeg-0.4.5+cvs20030824/gtv.c:1094:31: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gtk_widget_add_accelerator (open, "activate", accel_group,
data/smpeg-0.4.5+cvs20030824/plaympeg.c:177:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(strchr(host, ':') + 1);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:196:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char http_request[1024];
data/smpeg-0.4.5+cvs20030824/plaympeg.c:209:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(strchr(host, ':') + 1);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:255:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char answer[1024];
data/smpeg-0.4.5+cvs20030824/plaympeg.c:271:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
return(atoi(answer));
data/smpeg-0.4.5+cvs20030824/plaympeg.c:282:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ftp_request[1024];
data/smpeg-0.4.5+cvs20030824/plaympeg.c:303:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi(strchr(host, ':') + 1);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:316:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ftp_request, "USER anonymous\r\n");
data/smpeg-0.4.5+cvs20030824/plaympeg.c:319:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ftp_request, "PASS smpeguser@\r\n");
data/smpeg-0.4.5+cvs20030824/plaympeg.c:322:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ftp_request, "TYPE I\r\n");
data/smpeg-0.4.5+cvs20030824/plaympeg.c:352:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ftp_request, "PORT %d,%d,%d,%d,%d,%d\r\n",
data/smpeg-0.4.5+cvs20030824/plaympeg.c:396:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
track = atoi(pip+1) + 1;
data/smpeg-0.4.5+cvs20030824/plaympeg.c:407:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(arg, O_RDONLY, 0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:493:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/smpeg-0.4.5+cvs20030824/plaympeg.c:532:24: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
seek = atol(argv[i]);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:549:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
volume = atoi(argv[i]);
data/smpeg-0.4.5+cvs20030824/smpeg.h:66:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char audio_string[80];
data/smpeg-0.4.5+cvs20030824/video/dither.h:31:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern unsigned char pixel[256];
data/smpeg-0.4.5+cvs20030824/video/jrevdct.cpp:183:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
memset((char *) PreIDCT[i], 0, 64*sizeof(DCTELEM));
data/smpeg-0.4.5+cvs20030824/video/jrevdct.cpp:269:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *) tmpdata, data, 64*sizeof(DCTELEM));
data/smpeg-0.4.5+cvs20030824/video/jrevdct.cpp:274:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *) tmp2data, data, 64*sizeof(DCTELEM));
data/smpeg-0.4.5+cvs20030824/video/parseblock.cpp:117:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
mmx_available = atoi(use_mmx);
data/smpeg-0.4.5+cvs20030824/video/readfile.cpp:113:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((unsigned char *) buf_start, buffer, (unsigned int) (length*4));
data/smpeg-0.4.5+cvs20030824/video/vhar128.cpp:223:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(vhaMB.RunLevel, runlevel, 6*130*sizeof(long));
data/smpeg-0.4.5+cvs20030824/video/video.cpp:168:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char cropTbl[NUM_CROP_ENTRIES];
data/smpeg-0.4.5+cvs20030824/video/video.cpp:677:27: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const unsigned char default_intra_matrix[64] =
data/smpeg-0.4.5+cvs20030824/video/video.cpp:3970:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char forw_lum[256];
data/smpeg-0.4.5+cvs20030824/video/video.cpp:3971:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char forw_cr[64], forw_cb[64];
data/smpeg-0.4.5+cvs20030824/video/video.cpp:3972:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char back_lum[256], back_cr[64], back_cb[64];
data/smpeg-0.4.5+cvs20030824/video/video.h:258:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char intra_quant_matrix[8][8]; /* Quantization matrix for
data/smpeg-0.4.5+cvs20030824/video/video.h:260:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char non_intra_quant_matrix[8][8]; /* Quanitization matrix for
data/smpeg-0.4.5+cvs20030824/MPEGring.cpp:197:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
size = *((Uint32*) ring->read);
data/smpeg-0.4.5+cvs20030824/MPEGring.cpp:227:36: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
oldlen = *((Uint32*) ring->read);
data/smpeg-0.4.5+cvs20030824/MPEGring.cpp:230:27: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
*((Uint32*) ring->read) = newlen;
data/smpeg-0.4.5+cvs20030824/MPEGring.cpp:248:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if( ring->read >= ring->end )
data/smpeg-0.4.5+cvs20030824/MPEGring.h:85:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
Uint8 *read;
data/smpeg-0.4.5+cvs20030824/gtv.c:154:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gtv_default_directory = (gchar *) malloc( (strlen(filename) + 1) * sizeof(gchar) );
data/smpeg-0.4.5+cvs20030824/gtv.c:242:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy( (char*) gtk_object_get_data( GTK_OBJECT( raw ), "filename_buffer" ),
data/smpeg-0.4.5+cvs20030824/gtv.c:420:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gtk_editable_insert_text( GTK_EDITABLE( text ), buffer, strlen( buffer ), &ignored );
data/smpeg-0.4.5+cvs20030824/gtv.c:506:58: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gtk_editable_insert_text( GTK_EDITABLE( text ), msg, strlen( msg ), &ignored );
data/smpeg-0.4.5+cvs20030824/plaympeg.c:170:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strncmp(arg, "raw://", strlen("raw://"))) return(0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:174:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
host = arg + strlen("raw://");
data/smpeg-0.4.5+cvs20030824/plaympeg.c:200:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strncmp(arg, "http://", strlen("http://"))) return(0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:204:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
host = arg + strlen("http://");
data/smpeg-0.4.5+cvs20030824/plaympeg.c:229:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(tcp_sock, http_request, strlen(http_request), 0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:232:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
do read(tcp_sock, &c, sizeof(char)); while(c != ' ');
data/smpeg-0.4.5+cvs20030824/plaympeg.c:233:3: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read(tcp_sock, http_request, 4*sizeof(char));
data/smpeg-0.4.5+cvs20030824/plaympeg.c:239:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read(tcp_sock, &c, sizeof(char));
data/smpeg-0.4.5+cvs20030824/plaympeg.c:261:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read(tcp_sock, &c, sizeof(char));
data/smpeg-0.4.5+cvs20030824/plaympeg.c:288:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strncmp(arg, "ftp://", strlen("ftp://"))) return(0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:292:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
host = arg + strlen("ftp://");
data/smpeg-0.4.5+cvs20030824/plaympeg.c:317:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(tcp_sock, ftp_request, strlen(ftp_request), 0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:320:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(tcp_sock, ftp_request, strlen(ftp_request), 0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:323:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(tcp_sock, ftp_request, strlen(ftp_request), 0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:328:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(tcp_sock, ftp_request, strlen(ftp_request), 0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:356:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(tcp_sock, ftp_request, strlen(ftp_request), 0);
data/smpeg-0.4.5+cvs20030824/plaympeg.c:360:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(tcp_sock, ftp_request, strlen(ftp_request), 0);
ANALYSIS SUMMARY:
Hits = 97
Lines analyzed = 24740 in approximately 0.75 seconds (32809 lines/second)
Physical Source Lines of Code (SLOC) = 17294
Hits@level = [0] 192 [1] 26 [2] 55 [3] 1 [4] 15 [5] 0
Hits@level+ = [0+] 289 [1+] 97 [2+] 71 [3+] 16 [4+] 15 [5+] 0
Hits/KSLOC@level+ = [0+] 16.711 [1+] 5.60888 [2+] 4.10547 [3+] 0.925176 [4+] 0.867353 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.