Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/sniffit-0.5/src/sn_analyse.c
Examining data/sniffit-0.5/src/sn_cfgfile.c
Examining data/sniffit-0.5/src/sn_cfgfile.h
Examining data/sniffit-0.5/src/sn_config.h
Examining data/sniffit-0.5/src/sn_conn_desc.c
Examining data/sniffit-0.5/src/sn_curses.h
Examining data/sniffit-0.5/src/sn_data.h
Examining data/sniffit-0.5/src/sn_defines.h
Examining data/sniffit-0.5/src/sn_generation.c
Examining data/sniffit-0.5/src/sn_generation.h
Examining data/sniffit-0.5/src/sn_global.h
Examining data/sniffit-0.5/src/sn_interface.c
Examining data/sniffit-0.5/src/sn_interface.h
Examining data/sniffit-0.5/src/sn_logfile.c
Examining data/sniffit-0.5/src/sn_logfile.h
Examining data/sniffit-0.5/src/sn_packets.c
Examining data/sniffit-0.5/src/sn_packets.h
Examining data/sniffit-0.5/src/sn_packetstructs.h
Examining data/sniffit-0.5/src/sn_plugins.h
Examining data/sniffit-0.5/src/sn_resolv.c
Examining data/sniffit-0.5/src/sn_resolv.h
Examining data/sniffit-0.5/src/sn_structs.h
Examining data/sniffit-0.5/src/sniffit.c
Examining data/sniffit-0.5/src/sniffit.h
FINAL RESULTS:
data/sniffit-0.5/src/sn_analyse.c:165:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(workbuf2, p);
data/sniffit-0.5/src/sn_analyse.c:177:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(workbuf2, p);
data/sniffit-0.5/src/sn_cfgfile.c:138:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(string, help);
data/sniffit-0.5/src/sn_cfgfile.c:162:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(string, help);
data/sniffit-0.5/src/sn_cfgfile.c:172:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help, host);
data/sniffit-0.5/src/sn_cfgfile.c:227:27: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
if(field != NULL) strcpy(Logfile,field);
data/sniffit-0.5/src/sn_cfgfile.c:239:15: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host,dot_notation);
data/sniffit-0.5/src/sn_cfgfile.c:255:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host, clean_string(strtok(NULL," ")));
data/sniffit-0.5/src/sn_cfgfile.c:270:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host,dot_notation);
data/sniffit-0.5/src/sn_cfgfile.c:286:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host, clean_string(strtok(NULL," ")));
data/sniffit-0.5/src/sn_cfgfile.c:302:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host,dot_notation);
data/sniffit-0.5/src/sn_cfgfile.c:303:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(helpp->host,dot_notation);
data/sniffit-0.5/src/sn_cfgfile.c:326:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host, field);
data/sniffit-0.5/src/sn_cfgfile.c:327:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(helpp->host, field);
data/sniffit-0.5/src/sn_cfgfile.c:348:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host,dot_notation);
data/sniffit-0.5/src/sn_cfgfile.c:364:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host, clean_string(strtok(NULL," ")));
data/sniffit-0.5/src/sn_cfgfile.c:379:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host,dot_notation);
data/sniffit-0.5/src/sn_cfgfile.c:395:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host, clean_string(strtok(NULL," ")));
data/sniffit-0.5/src/sn_cfgfile.c:411:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host,dot_notation);
data/sniffit-0.5/src/sn_cfgfile.c:412:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(helpp->host,dot_notation);
data/sniffit-0.5/src/sn_cfgfile.c:434:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(help->host, field);
data/sniffit-0.5/src/sn_cfgfile.c:435:8: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(helpp->host, field);
data/sniffit-0.5/src/sn_interface.c:160:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(log_conn->log_enter,conn[i].connection);
data/sniffit-0.5/src/sn_interface.c:181:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(log_conn->log_enter, conn[i].connection);
data/sniffit-0.5/src/sn_interface.c:404:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
{strcpy(input,dummy);}
data/sniffit-0.5/src/sn_interface.c:562:17: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(conn[i].desc, desc); /* For description of connect */
data/sniffit-0.5/src/sn_interface.c:569:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(conn[i].connection, string);
data/sniffit-0.5/src/sn_interface.c:570:17: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(conn[i].desc, desc); /* For description of connect */
data/sniffit-0.5/src/sn_interface.c:585:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(conn[to_item].connection, string);
data/sniffit-0.5/src/sn_interface.c:586:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(conn[to_item].desc, desc); /* For description of connect */
data/sniffit-0.5/src/sn_interface.c:662:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(e_dummy,conn[i].connection);
data/sniffit-0.5/src/sn_interface.c:673:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(esource,strtok(e_dummy," "));
data/sniffit-0.5/src/sn_interface.c:674:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(es_port,strtok(NULL," "));
data/sniffit-0.5/src/sn_interface.c:676:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(edest,strtok(NULL," "));
data/sniffit-0.5/src/sn_interface.c:677:1: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ed_port,strtok(NULL," "));
data/sniffit-0.5/src/sn_interface.c:850:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access("./sniffit_key5", X_OK)<0) break;
data/sniffit-0.5/src/sn_interface.c:860:6: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl("./sniffit_key5","sniffit_key5",exec_s,exec_sp,exec_d,exec_dp,NULL);
data/sniffit-0.5/src/sn_interface.c:867:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access("./sniffit_key6", X_OK)<0) break;
data/sniffit-0.5/src/sn_interface.c:877:7: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl("./sniffit_key6","sniffit_key6",exec_s,exec_sp,exec_d,exec_dp,NULL);
data/sniffit-0.5/src/sn_interface.c:884:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access("./sniffit_key7", X_OK)<0) break;
data/sniffit-0.5/src/sn_interface.c:894:7: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl("./sniffit_key7","sniffit_key7",exec_s,exec_sp,exec_d,exec_dp,NULL);
data/sniffit-0.5/src/sn_interface.c:901:7: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(access("./sniffit_key8", X_OK)<0) break;
data/sniffit-0.5/src/sn_interface.c:911:7: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl("./sniffit_key8","sniffit_key8",exec_s,exec_sp,exec_d,exec_dp,NULL);
data/sniffit-0.5/src/sniffit.c:250:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (dummy_pointer->filename, file);
data/sniffit-0.5/src/sniffit.c:1445:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (conn_name, "%16s %5u -> %16s %5u",
data/sniffit-0.5/src/sniffit.c:1450:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (conn_name2, "%16s %5u -> %16s %5u",
data/sniffit-0.5/src/sniffit.c:1690:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (forced_dev, optarg);
data/sniffit-0.5/src/sniffit.c:1766:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (dev, forced_dev);
data/sniffit-0.5/src/sniffit.c:1551:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((c = getopt (argc, argv, "D:A:P:iIdp:l:xabt:s:F:c:nvL:M:Nr:R:")) != -1)
data/sniffit-0.5/src/sniffit.c:1554:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((c = getopt (argc, argv, "A:P:dp:l:xabt:s:F:c:nvL:M:Nr:R:")) != -1)
data/sniffit-0.5/src/sn_analyse.c:5:1: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&tcphead,header,sizeof(struct TCP_header));
data/sniffit-0.5/src/sn_analyse.c:152:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char workbuf1[MTU];
data/sniffit-0.5/src/sn_analyse.c:163:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char workbuf2[MTU];
data/sniffit-0.5/src/sn_analyse.c:175:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char workbuf2[MTU];
data/sniffit-0.5/src/sn_cfgfile.c:29:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char dot_notation[20]; /* for easy working, Q&D */
data/sniffit-0.5/src/sn_cfgfile.c:30:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char Logfile[250];
data/sniffit-0.5/src/sn_cfgfile.c:120:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char help[20];
data/sniffit-0.5/src/sn_cfgfile.c:144:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char help[20];
data/sniffit-0.5/src/sn_cfgfile.c:170:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char help[255];
data/sniffit-0.5/src/sn_cfgfile.c:176:1: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(dot_notation,"%u.%u.%u.%u",digit[0],digit[1],digit[2],digit[3]);
data/sniffit-0.5/src/sn_cfgfile.c:197:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
{ret = atoi(buf);}
data/sniffit-0.5/src/sn_cfgfile.c:453:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lineptr[260];
data/sniffit-0.5/src/sn_cfgfile.c:459:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((cfgfile = fopen(file,"r"))==NULL)
data/sniffit-0.5/src/sn_conn_desc.c:10:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
{strcpy(desc_string, "FTP DATA");}
data/sniffit-0.5/src/sn_conn_desc.c:15:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(desc_string, "FTP");
data/sniffit-0.5/src/sn_conn_desc.c:20:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(desc_string,"FTP: ");
data/sniffit-0.5/src/sn_conn_desc.c:36:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
{strcpy(desc_string, "TELNET");}
data/sniffit-0.5/src/sn_conn_desc.c:40:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
{strcpy(desc_string, "Secure Shell");}
data/sniffit-0.5/src/sn_conn_desc.c:44:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
{strcpy(desc_string, "MAIL");}
data/sniffit-0.5/src/sn_conn_desc.c:48:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
{strcpy(desc_string, "IDENT");}
data/sniffit-0.5/src/sn_conn_desc.c:52:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
{strcpy(desc_string, "IRC");}
data/sniffit-0.5/src/sn_conn_desc.c:56:4: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
{strcpy(desc_string, "X-Windows");}
data/sniffit-0.5/src/sn_conn_desc.c:63:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(desc_string, "HTTP");
data/sniffit-0.5/src/sn_conn_desc.c:71:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(desc_string, "HTTP");
data/sniffit-0.5/src/sn_conn_desc.c:76:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(desc_string,"HTTP: ");
data/sniffit-0.5/src/sn_data.h:98:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Logfile[250]; /* name of logfile */
data/sniffit-0.5/src/sn_data.h:101:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char IP[256];
data/sniffit-0.5/src/sn_data.h:109:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *IP_TYPE_precedence[8]=
data/sniffit-0.5/src/sn_data.h:113:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *IP_PROTOCOL_number[34]=
data/sniffit-0.5/src/sn_data.h:121:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *ICMP_type_3_code[6]=
data/sniffit-0.5/src/sn_data.h:125:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *ICMP_type_5_code[4]=
data/sniffit-0.5/src/sn_data.h:130:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *ICMP_type_11_code[2]=
data/sniffit-0.5/src/sn_data.h:145:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dot_notation[20]; /* for easy working, Q&D */
data/sniffit-0.5/src/sn_data.h:148:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char Plugin_Active[10];
data/sniffit-0.5/src/sn_generation.c:24:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[80];
data/sniffit-0.5/src/sn_generation.c:53:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(msg,"DISPATCH COMPLETE - Press ENTER");
data/sniffit-0.5/src/sn_generation.c:56:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(msg,"Packet No: %d dispatched.",count+1);
data/sniffit-0.5/src/sn_generation.c:214:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sp_pseudo_ip_construct[MTU];
data/sniffit-0.5/src/sn_generation.c:238:1: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sp_pseudo_ip_construct+12, sp_help_tcp, sp->TCP_optlen+sp->datalen+SP_TCP_HEAD_BASE);
data/sniffit-0.5/src/sn_generation.c:253:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sp_buffer[1500];
data/sniffit-0.5/src/sn_generation.c:258:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sp_buffer+SP_IP_HEAD_BASE,sp_data,sp_ipoptlen);
data/sniffit-0.5/src/sn_generation.c:261:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sp_buffer+SP_IP_HEAD_BASE+SP_TCP_HEAD_BASE+sp_ipoptlen,
data/sniffit-0.5/src/sn_generation.c:264:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sp_buffer+SP_IP_HEAD_BASE+SP_TCP_HEAD_BASE+sp_ipoptlen+sp_tcpoptlen,
data/sniffit-0.5/src/sn_generation.c:288:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sp_pseudo_ip_construct[MTU];
data/sniffit-0.5/src/sn_generation.c:309:1: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sp_pseudo_ip_construct+12, sp_help_udp, sp->datalen+SP_UDP_HEAD_BASE);
data/sniffit-0.5/src/sn_generation.c:322:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sp_buffer[1500];
data/sniffit-0.5/src/sn_generation.c:328:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sp_buffer+SP_IP_HEAD_BASE,sp_data,sp_ipoptlen);
data/sniffit-0.5/src/sn_generation.c:330:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(sp_buffer+SP_IP_HEAD_BASE+SP_UDP_HEAD_BASE+sp_ipoptlen,
data/sniffit-0.5/src/sn_interface.c:332:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char debug_line[200];
data/sniffit-0.5/src/sn_interface.c:341:1: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(debug_line,"FIX: POINTpos: %d LISTlength: %d LISTpos: %d\n",POINTpos,*LISTlength,LISTpos);
data/sniffit-0.5/src/sn_interface.c:382:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dummy[500];
data/sniffit-0.5/src/sn_interface.c:645:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char e_dummy[CONN_NAMELEN];
data/sniffit-0.5/src/sn_interface.c:691:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dummy[100];
data/sniffit-0.5/src/sn_interface.c:692:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char exec_s[20],exec_sp[20],exec_d[20],exec_dp[20];
data/sniffit-0.5/src/sn_interface.c:802:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
generate.source_port=atoi(dummy);
data/sniffit-0.5/src/sn_interface.c:807:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
generate.dest_port=atoi(dummy);
data/sniffit-0.5/src/sn_interface.c:810:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
generate.pkt_no=atoi(dummy);
data/sniffit-0.5/src/sn_interface.c:837:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
mask->source_port=atoi(dummy);
data/sniffit-0.5/src/sn_interface.c:843:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
mask->destination_port=atoi(dummy);
data/sniffit-0.5/src/sn_logfile.c:16:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char Logfile[250]; /* name of logfile */
data/sniffit-0.5/src/sn_logfile.c:49:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[250];
data/sniffit-0.5/src/sn_logfile.c:56:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[250];
data/sniffit-0.5/src/sn_logfile.c:63:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[250];
data/sniffit-0.5/src/sn_logfile.c:70:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[250];
data/sniffit-0.5/src/sn_logfile.c:77:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[250];
data/sniffit-0.5/src/sn_logfile.c:84:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[250];
data/sniffit-0.5/src/sn_logfile.c:91:25: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
if(Logfile[0]==0) strcpy(Logfile,"sniffit.log");
data/sniffit-0.5/src/sn_logfile.c:92:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
LogFILE=fopen(Logfile,"a");
data/sniffit-0.5/src/sn_packets.c:54:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&IPhead,(sp+PROTO_HEAD),sizeof(struct IP_header));
data/sniffit-0.5/src/sn_packets.c:83:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((sp+PROTO_HEAD),&IPhead,sizeof(struct IP_header));
data/sniffit-0.5/src/sn_packets.c:121:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&TCPhead,(sp+PROTO_HEAD+(unwrapped->IP_len)),
data/sniffit-0.5/src/sn_packets.c:158:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&ICMPhead,(sp+PROTO_HEAD+(unwrapped->IP_len)),
data/sniffit-0.5/src/sn_packets.c:191:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&UDPhead,(sp+PROTO_HEAD+(unwrapped->IP_len)),
data/sniffit-0.5/src/sn_structs.h:12:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char proto, filename[50];
data/sniffit-0.5/src/sn_structs.h:23:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char scroll_buf[SCBUF+1]; /* scroll buffer */
data/sniffit-0.5/src/sn_structs.h:31:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char host[16];
data/sniffit-0.5/src/sn_structs.h:43:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char PL_data[MTU];
data/sniffit-0.5/src/sn_structs.h:44:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char PL_packet[MTU];
data/sniffit-0.5/src/sn_structs.h:59:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char connection [CONN_NAMELEN]; /* full ID string of conn */
data/sniffit-0.5/src/sn_structs.h:60:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc [DESC_BYTES]; /* connection description */
data/sniffit-0.5/src/sn_structs.h:65:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char log_enter [CONN_NAMELEN]; /* normal logging */
data/sniffit-0.5/src/sniffit.c:253:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen (file, "a");
data/sniffit-0.5/src/sniffit.c:489:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char wc_so[20], wc_dest[20];
data/sniffit-0.5/src/sniffit.c:528:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&iphead, (sp + PROTO_HEAD), sizeof (struct IP_header));
data/sniffit-0.5/src/sniffit.c:539:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&tcphead, (sp + PROTO_HEAD + info->IP_len),
data/sniffit-0.5/src/sniffit.c:541:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (detail, &tcphead, sizeof (struct TCP_header));
data/sniffit-0.5/src/sniffit.c:562:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (wc_so, "%u.%u.%u.%u", so[0], so[1], so[2], so[3]);
data/sniffit-0.5/src/sniffit.c:563:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (wc_dest, "%u.%u.%u.%u", dest[0], dest[1], dest[2], dest[3]);
data/sniffit-0.5/src/sniffit.c:579:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (wc_so, "%u.%u.%u.%u", so[0], so[1], so[2], so[3]);
data/sniffit-0.5/src/sniffit.c:580:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (wc_dest, "%u.%u.%u.%u", dest[0], dest[1], dest[2], dest[3]);
data/sniffit-0.5/src/sniffit.c:773:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (file, "%u.%u.%u.%u.%u-%u.%u.%u.%u.%u",
data/sniffit-0.5/src/sniffit.c:778:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (file2, "%u.%u.%u.%u.%u-%u.%u.%u.%u.%u",
data/sniffit-0.5/src/sniffit.c:787:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (file, "%u.%u.%u.%u-%u.%u.%u.%u",
data/sniffit-0.5/src/sniffit.c:790:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (file2, "%u.%u.%u.%u-%u.%u.%u.%u",
data/sniffit-0.5/src/sniffit.c:823:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&icmphead, (sp + PROTO_HEAD + info->IP_len),
data/sniffit-0.5/src/sniffit.c:825:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (detail, &icmphead, sizeof (struct ICMP_header));
data/sniffit-0.5/src/sniffit.c:826:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (file, "%u.%u.%u.%u > %u.%u.%u.%u",
data/sniffit-0.5/src/sniffit.c:836:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&udphead, (sp + PROTO_HEAD + info->IP_len),
data/sniffit-0.5/src/sniffit.c:838:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (detail, &udphead, sizeof (struct UDP_header));
data/sniffit-0.5/src/sniffit.c:855:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (wc_so, "%u.%u.%u.%u", so[0], so[1], so[2], so[3]);
data/sniffit-0.5/src/sniffit.c:856:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (wc_dest, "%u.%u.%u.%u", dest[0], dest[1], dest[2], dest[3]);
data/sniffit-0.5/src/sniffit.c:872:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (wc_so, "%u.%u.%u.%u", so[0], so[1], so[2], so[3]);
data/sniffit-0.5/src/sniffit.c:873:8: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (wc_dest, "%u.%u.%u.%u", dest[0], dest[1], dest[2], dest[3]);
data/sniffit-0.5/src/sniffit.c:1054:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (file, "%u.%u.%u.%u.%u-%u.%u.%u.%u.%u",
data/sniffit-0.5/src/sniffit.c:1059:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (file2, "%u.%u.%u.%u.%u-%u.%u.%u.%u.%u",
data/sniffit-0.5/src/sniffit.c:1075:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[50], filename2[50], header[SNAPLEN];
data/sniffit-0.5/src/sniffit.c:1091:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&ipaddr, ipaddrpoint, sizeof (_32_bit));
data/sniffit-0.5/src/sniffit.c:1099:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&iphead, (sp + PROTO_HEAD), sizeof (struct IP_header)),
data/sniffit-0.5/src/sniffit.c:1112:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&iphead, (sp + PROTO_HEAD), sizeof (struct IP_header)),
data/sniffit-0.5/src/sniffit.c:1125:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&(PL_d.PL_info), &info, sizeof (struct unwrap));
data/sniffit-0.5/src/sniffit.c:1126:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&(PL_d.PL_iphead), (sp + PROTO_HEAD), sizeof (struct IP_header));
data/sniffit-0.5/src/sniffit.c:1127:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&(PL_d.PL_tcphead), (sp + PROTO_HEAD + info.IP_len), sizeof (struct TCP_header));
data/sniffit-0.5/src/sniffit.c:1128:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&(PL_d.PL_udphead), (sp + PROTO_HEAD + info.IP_len), sizeof (struct UDP_header));
data/sniffit-0.5/src/sniffit.c:1130:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (PL_d.PL_data, (sp + PROTO_HEAD + info.IP_len + info.TCP_len), info.DATA_len);
data/sniffit-0.5/src/sniffit.c:1132:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (PL_d.PL_data, (sp + PROTO_HEAD + info.IP_len + info.UDP_len), info.DATA_len);
data/sniffit-0.5/src/sniffit.c:1133:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (PL_d.PL_packet, (sp + PROTO_HEAD),
data/sniffit-0.5/src/sniffit.c:1140:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&PL_dex, &PL_d, sizeof (struct Plugin_data));
data/sniffit-0.5/src/sniffit.c:1150:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&tcphead, header, sizeof (struct TCP_header));
data/sniffit-0.5/src/sniffit.c:1174:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&tcphead, header, sizeof (struct TCP_header));
data/sniffit-0.5/src/sniffit.c:1224:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&iphead, (sp + PROTO_HEAD), sizeof (struct IP_header));
data/sniffit-0.5/src/sniffit.c:1276:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&icmphead, header, sizeof (struct ICMP_header));
data/sniffit-0.5/src/sniffit.c:1277:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&iphead_icmp,
data/sniffit-0.5/src/sniffit.c:1343:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&udphead, header, sizeof (struct UDP_header));
data/sniffit-0.5/src/sniffit.c:1386:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char helpstr1[20], helpstr2[20];
data/sniffit-0.5/src/sniffit.c:1426:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&iphead, (sp + PROTO_HEAD), sizeof (struct IP_header));
data/sniffit-0.5/src/sniffit.c:1427:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&tcphead, (sp + PROTO_HEAD + info->IP_len), sizeof (struct TCP_header));
data/sniffit-0.5/src/sniffit.c:1442:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (helpstr1, "%u.%u.%u.%u", so[0], so[1], so[2], so[3]);
data/sniffit-0.5/src/sniffit.c:1443:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (helpstr2, "%u.%u.%u.%u", dest[0], dest[1], dest[2], dest[3]);
data/sniffit-0.5/src/sniffit.c:1475:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char conn_name[CONN_NAMELEN], conn_name2[CONN_NAMELEN];
data/sniffit-0.5/src/sniffit.c:1476:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char desc_string[DESC_BYTES];
data/sniffit-0.5/src/sniffit.c:1481:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (desc_string, "Unknown");
data/sniffit-0.5/src/sniffit.c:1496:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy ((connection_data + *DATAlength), data, info.DATA_len);
data/sniffit-0.5/src/sniffit.c:1513:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *dev, forced_dev[20], buffer[SNAPLEN];
data/sniffit-0.5/src/sniffit.c:1514:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ebuf[PCAP_ERRBUF_SIZE];
data/sniffit-0.5/src/sniffit.c:1538:20: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((debug_dev = fopen (DEBUG_DEVICE, "a")) < 0)
data/sniffit-0.5/src/sniffit.c:1596:64: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(optarg));
data/sniffit-0.5/src/sniffit.c:1597:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
DEST_PORT = atoi(optarg);
data/sniffit-0.5/src/sniffit.c:1600:14: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
SNIFLEN = atol (optarg);
data/sniffit-0.5/src/sniffit.c:1639:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hlp[300], *hlp2;
data/sniffit-0.5/src/sniffit.c:1649:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
SRC_PORT = atoi(hlp2);
data/sniffit-0.5/src/sniffit.c:1654:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hlp[300], *hlp2;
data/sniffit-0.5/src/sniffit.c:1667:64: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi(hlp2));
data/sniffit-0.5/src/sniffit.c:1668:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
DEST_PORT = atoi(hlp2);
data/sniffit-0.5/src/sniffit.c:1686:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((atoi (optarg) >= 0) && (atoi (optarg) <= 9))
data/sniffit-0.5/src/sniffit.c:1686:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((atoi (optarg) >= 0) && (atoi (optarg) <= 9))
data/sniffit-0.5/src/sniffit.c:1687:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
Plugin_Active[atoi (optarg)] = 1;
data/sniffit-0.5/src/sniffit.c:1905:30: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((log_dev_stream = fopen (logging_device, "a"))
data/sniffit-0.5/src/sn_analyse.c:121:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
help+=strlen("USER ");
data/sniffit-0.5/src/sn_analyse.c:131:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
help+=strlen("PASS ");
data/sniffit-0.5/src/sn_analyse.c:157:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(workbuf1,data,len);
data/sniffit-0.5/src/sn_cfgfile.c:123:4: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(string) >= 20){
data/sniffit-0.5/src/sn_cfgfile.c:129:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(i=0;i<strlen(string);i++)
data/sniffit-0.5/src/sn_cfgfile.c:147:4: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strlen(string) >= 20){
data/sniffit-0.5/src/sn_cfgfile.c:153:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(i=0;i<strlen(string);i++)
data/sniffit-0.5/src/sn_cfgfile.c:187:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
namelen = strlen(buf) - 1;
data/sniffit-0.5/src/sn_generation.c:44:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
transmit_UDP(fd, dummy_data,0 ,strlen(dummy_data),
data/sniffit-0.5/src/sn_interface.c:389:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Work_inp=newwin(1,50,LINES-1,strlen(string));
data/sniffit-0.5/src/sniffit.c:126:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = 0; i < strlen (string); i++)
data/sniffit-0.5/src/sniffit.c:564:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n_s = strlen (IP);
data/sniffit-0.5/src/sniffit.c:611:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (wc_so, str_IP, strlen (str_IP)) == 0)
data/sniffit-0.5/src/sniffit.c:650:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (wc_dest, str_IP, strlen (str_IP)) == 0)
data/sniffit-0.5/src/sniffit.c:720:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (wc_dest, str_IP, strlen (str_IP)) == 0)
data/sniffit-0.5/src/sniffit.c:729:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (wc_dest, str_IP, strlen (str_IP)) == 0)
data/sniffit-0.5/src/sniffit.c:857:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
n_s = strlen (IP);
data/sniffit-0.5/src/sniffit.c:904:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (wc_so, str_IP, strlen (str_IP)) == 0)
data/sniffit-0.5/src/sniffit.c:945:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (wc_dest, str_IP, strlen (str_IP)) == 0)
data/sniffit-0.5/src/sniffit.c:1010:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (wc_dest, str_IP, strlen (str_IP)) == 0)
data/sniffit-0.5/src/sniffit.c:1019:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp (wc_dest, str_IP, strlen (str_IP)) == 0)
data/sniffit-0.5/src/sniffit.c:1644:11: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(hlp,optarg,299);
data/sniffit-0.5/src/sniffit.c:1647:11: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(IP,hlp2,255);
data/sniffit-0.5/src/sniffit.c:1659:11: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(hlp,optarg,299);
data/sniffit-0.5/src/sniffit.c:1662:11: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(IP,hlp2,255);
data/sniffit-0.5/src/sniffit.c:1744:4: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy (strchr (IP, '@'), "\0");
data/sniffit-0.5/src/sniffit.c:1764:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if((dev=malloc(strlen(forced_dev)+1))==NULL)
ANALYSIS SUMMARY:
Hits = 224
Lines analyzed = 5085 in approximately 0.18 seconds (27526 lines/second)
Physical Source Lines of Code (SLOC) = 4248
Hits@level = [0] 154 [1] 27 [2] 147 [3] 2 [4] 48 [5] 0
Hits@level+ = [0+] 378 [1+] 224 [2+] 197 [3+] 50 [4+] 48 [5+] 0
Hits/KSLOC@level+ = [0+] 88.9831 [1+] 52.7307 [2+] 46.3748 [3+] 11.7702 [4+] 11.2994 [5+] 0
Dot directories skipped = 2 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.