Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/subtle-0.11.3224-xi/src/subtlext/client.c
Examining data/subtle-0.11.3224-xi/src/subtlext/color.c
Examining data/subtle-0.11.3224-xi/src/subtlext/geometry.c
Examining data/subtle-0.11.3224-xi/src/subtlext/view.c
Examining data/subtle-0.11.3224-xi/src/subtlext/tray.c
Examining data/subtle-0.11.3224-xi/src/subtlext/tag.c
Examining data/subtle-0.11.3224-xi/src/subtlext/icon.c
Examining data/subtle-0.11.3224-xi/src/subtlext/subtlext.h
Examining data/subtle-0.11.3224-xi/src/subtlext/subtle.c
Examining data/subtle-0.11.3224-xi/src/subtlext/window.c
Examining data/subtle-0.11.3224-xi/src/subtlext/sublet.c
Examining data/subtle-0.11.3224-xi/src/subtlext/subtlext.c
Examining data/subtle-0.11.3224-xi/src/subtlext/gravity.c
Examining data/subtle-0.11.3224-xi/src/subtlext/screen.c
Examining data/subtle-0.11.3224-xi/src/subtle/client.c
Examining data/subtle-0.11.3224-xi/src/subtle/ewmh.c
Examining data/subtle-0.11.3224-xi/src/subtle/event.c
Examining data/subtle-0.11.3224-xi/src/subtle/hook.c
Examining data/subtle-0.11.3224-xi/src/subtle/panel.c
Examining data/subtle-0.11.3224-xi/src/subtle/style.c
Examining data/subtle-0.11.3224-xi/src/subtle/text.c
Examining data/subtle-0.11.3224-xi/src/subtle/view.c
Examining data/subtle-0.11.3224-xi/src/subtle/tray.c
Examining data/subtle-0.11.3224-xi/src/subtle/ruby.c
Examining data/subtle-0.11.3224-xi/src/subtle/subtle.h
Examining data/subtle-0.11.3224-xi/src/subtle/tag.c
Examining data/subtle-0.11.3224-xi/src/subtle/subtle.c
Examining data/subtle-0.11.3224-xi/src/subtle/grab.c
Examining data/subtle-0.11.3224-xi/src/subtle/display.c
Examining data/subtle-0.11.3224-xi/src/subtle/array.c
Examining data/subtle-0.11.3224-xi/src/subtle/gravity.c
Examining data/subtle-0.11.3224-xi/src/subtle/screen.c
Examining data/subtle-0.11.3224-xi/src/shared/shared.c
Examining data/subtle-0.11.3224-xi/src/shared/shared.h
FINAL RESULTS:
data/subtle-0.11.3224-xi/src/shared/shared.c:683:9: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp("/bin/sh", "sh", "-c", cmd, NULL);
data/subtle-0.11.3224-xi/src/subtle/event.c:1075:17: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(ev->data.b, "%hdx%hd+%hd+%hd#%s", &geom.x, &geom.y,
data/subtle-0.11.3224-xi/src/subtle/event.c:1158:17: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(ev->data.b, "%d#%s", &subletid, name);
data/subtle-0.11.3224-xi/src/subtle/event.c:1288:17: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(ev->data.b, "%d#%s", &view_id, name);
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2601:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(-1 == access(RSTRING_PTR(file), R_OK))
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2632:20: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(-1 != access(buf, R_OK)) break;
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2638:24: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(-1 != access(buf, R_OK)) break;
data/subtle-0.11.3224-xi/src/subtle/subtle.c:191:3: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf, sizeof(buf), format, ap);
data/subtle-0.11.3224-xi/src/subtle/subtle.c:390:7: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(argv[0], argv);
data/subtle-0.11.3224-xi/src/subtlext/gravity.c:46:11: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(gravities[i], "%hdx%hd+%hd+%hd#%s", &geom.x, &geom.y,
data/subtle-0.11.3224-xi/src/subtlext/icon.c:158:20: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(-1 == access(buf, R_OK))
data/subtle-0.11.3224-xi/src/subtlext/icon.c:175:24: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if(-1 == access(buf, R_OK))
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1750:11: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(strings[i], "%hdx%hd+%hd+%hd#%s", &geometry.x, &geometry.y,
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2608:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if((home = getenv("XDG_CONFIG_HOME")))
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2611:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
getenv("HOME"));
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2613:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if((dirs = getenv("XDG_CONFIG_DIRS")))
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2618:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if((home = getenv("XDG_DATA_HOME")))
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2624:17: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
tokens, getenv("HOME"), PKG_NAME);
data/subtle-0.11.3224-xi/src/subtle/ruby.c:3919:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if((home = getenv("XDG_DATA_HOME")))
data/subtle-0.11.3224-xi/src/subtle/ruby.c:3925:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
getenv("HOME"), PKG_NAME);
data/subtle-0.11.3224-xi/src/subtle/subtle.c:297:20: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while(-1 != (c = getopt_long(argc, argv, "c:d:hknrs:vl:D",
data/subtle-0.11.3224-xi/src/subtlext/icon.c:163:26: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if((home = getenv("XDG_DATA_HOME")))
data/subtle-0.11.3224-xi/src/subtlext/icon.c:171:20: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
getenv("HOME"), RSTRING_PTR(data[0]));
data/subtle-0.11.3224-xi/src/shared/shared.h:105:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[20]; ///< MessageData char
data/subtle-0.11.3224-xi/src/subtle/display.c:23:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[10] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/display.c:105:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char error[255] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/event.c:1073:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[30] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/event.c:1156:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[30] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/event.c:1286:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[30] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/event.c:1717:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUFLEN];
data/subtle-0.11.3224-xi/src/subtle/panel.c:240:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[5] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/panel.c:379:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[5] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/ruby.c:531:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[15] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/ruby.c:745:53: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
data = DATA((unsigned long)(atol(name) - 1));
data/subtle-0.11.3224-xi/src/subtle/ruby.c:753:53: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
data = DATA((unsigned long)(atol(name) - 1));
data/subtle-0.11.3224-xi/src/subtle/ruby.c:761:53: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
data = DATA((unsigned long)(atol(name) - 1));
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2597:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[100] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2683:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[20] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2828:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2910:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/ruby.c:3325:15: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[100] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/ruby.c:3894:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[100] = { 0 };
data/subtle-0.11.3224-xi/src/subtle/subtle.c:183:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[255];
data/subtle-0.11.3224-xi/src/subtlext/client.c:171:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[50] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/client.c:1090:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[5] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/color.c:250:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/color.c:342:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[20] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/geometry.c:268:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/gravity.c:42:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[30] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/gravity.c:50:36: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if((isdigit(match[0]) && atoi(match) == i) ||
data/subtle-0.11.3224-xi/src/subtlext/gravity.c:79:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[50] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/icon.c:141:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[100] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/icon.c:634:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[20] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/sublet.c:21:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[50] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:201:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char error[255] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:824:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char propname[255] = { 0 }, *name = NULL, *result = NULL;
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1232:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pidbuf[10] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1521:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(isdigit(source[0])) selid = atoi(source);
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1578:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(isdigit(source[0])) selid = atoi(source);
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1658:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(isdigit(source[0])) selid = atoi(source);
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1730:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[30] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1743:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if(isdigit(source[0])) selid = atoi(source);
data/subtle-0.11.3224-xi/src/subtlext/tag.c:21:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[50] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/tray.c:21:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[50] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/view.c:62:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[50] = { 0 };
data/subtle-0.11.3224-xi/src/subtlext/window.c:105:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32] = { 0 };
data/subtle-0.11.3224-xi/src/shared/shared.c:82:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(UChar *)(pattern + strlen(pattern)),
data/subtle-0.11.3224-xi/src/shared/shared.c:119:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(UChar *)(string + strlen(string)), (UChar *)string, NULL,
data/subtle-0.11.3224-xi/src/shared/shared.c:286:15: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(*name, *list, text.nitems);
data/subtle-0.11.3224-xi/src/subtle/event.c:542:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(buf) + strlen(key);
data/subtle-0.11.3224-xi/src/subtle/event.c:542:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len += strlen(buf) + strlen(key);
data/subtle-0.11.3224-xi/src/subtle/event.c:682:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
GRAVITYSTRLIMIT, size = strlen(g->data.string);
data/subtle-0.11.3224-xi/src/subtle/event.c:1804:30: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(0 < read(subtle->notify, buf, BUFLEN)) ///< Inotify events
data/subtle-0.11.3224-xi/src/subtle/ewmh.c:91:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(names[SUB_EWMH_NET_SYSTEM_TRAY_SELECTION]) + 5; ///< For high screen counts
data/subtle-0.11.3224-xi/src/subtle/ewmh.c:264:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
PropModeReplace, (unsigned char *)value, strlen(value));
data/subtle-0.11.3224-xi/src/subtle/gravity.c:154:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gravities[i] = (char *)subSharedMemoryAlloc(strlen(buf) + 1,
data/subtle-0.11.3224-xi/src/subtle/gravity.c:156:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(gravities[i], buf, strlen(buf));
data/subtle-0.11.3224-xi/src/subtle/gravity.c:156:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(gravities[i], buf, strlen(buf));
data/subtle-0.11.3224-xi/src/subtle/panel.c:62:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s->separator->string, strlen(s->separator->string));
data/subtle-0.11.3224-xi/src/subtle/panel.c:88:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf, strlen(buf), NULL, NULL, True);
data/subtle-0.11.3224-xi/src/subtle/panel.c:241:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int width = 0, len = strlen(c->name);
data/subtle-0.11.3224-xi/src/subtle/panel.c:286:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
v->name, strlen(v->name), NULL, NULL, True) +
data/subtle-0.11.3224-xi/src/subtle/panel.c:354:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p->keychain->keys, strlen(p->keychain->keys));
data/subtle-0.11.3224-xi/src/subtle/panel.c:389:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(c->name);
data/subtle-0.11.3224-xi/src/subtle/panel.c:397:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf, strlen(buf));
data/subtle-0.11.3224-xi/src/subtle/panel.c:454:60: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
STYLE_TOP((s)), s.fg, s.bg, v->name, strlen(v->name));
data/subtle-0.11.3224-xi/src/subtle/panel.c:668:63: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sublets[idx] = (char *)subSharedMemoryAlloc(strlen(buf) + 1,
data/subtle-0.11.3224-xi/src/subtle/panel.c:670:19: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(sublets[idx++], buf, strlen(buf));
data/subtle-0.11.3224-xi/src/subtle/panel.c:670:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(sublets[idx++], buf, strlen(buf));
data/subtle-0.11.3224-xi/src/subtle/ruby.c:2694:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(name);
data/subtle-0.11.3224-xi/src/subtle/ruby.c:3064:58: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
else rb_str_cat(string, item->data.string, strlen(item->data.string));
data/subtle-0.11.3224-xi/src/subtle/ruby.c:3939:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf[strlen(buf) - (strlen(entries[i]->d_name) + 1)] = '\0';
data/subtle-0.11.3224-xi/src/subtle/ruby.c:3939:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf[strlen(buf) - (strlen(entries[i]->d_name) + 1)] = '\0';
data/subtle-0.11.3224-xi/src/subtle/style.c:65:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(s1->separator->string), NULL, NULL, True);
data/subtle-0.11.3224-xi/src/subtle/tag.c:152:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(pattern && 0 != strlen(pattern))
data/subtle-0.11.3224-xi/src/subtle/text.c:93:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(tok), &left, &right, False);
data/subtle-0.11.3224-xi/src/subtle/text.c:179:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->data.string, strlen(item->data.string));
data/subtle-0.11.3224-xi/src/subtlext/gravity.c:56:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*name = (char *)subSharedMemoryAlloc(strlen(buf) + 1,
data/subtle-0.11.3224-xi/src/subtlext/gravity.c:58:19: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(*name, buf, strlen(buf));
data/subtle-0.11.3224-xi/src/subtlext/gravity.c:58:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(*name, buf, strlen(buf));
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:556:3: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(12000);
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:698:11: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(12000);
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1248:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(wminstance) + 1, sizeof(char));
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1249:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(*name, wminstance, strlen(wminstance));
data/subtle-0.11.3224-xi/src/subtlext/subtlext.c:1249:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strncpy(*name, wminstance, strlen(wminstance));
ANALYSIS SUMMARY:
Hits = 105
Lines analyzed = 24733 in approximately 0.55 seconds (45259 lines/second)
Physical Source Lines of Code (SLOC) = 14703
Hits@level = [0] 105 [1] 39 [2] 43 [3] 10 [4] 13 [5] 0
Hits@level+ = [0+] 210 [1+] 105 [2+] 66 [3+] 23 [4+] 13 [5+] 0
Hits/KSLOC@level+ = [0+] 14.2828 [1+] 7.1414 [2+] 4.48888 [3+] 1.56431 [4+] 0.884173 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.