Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/tkdesk-2.0/blt/blt.h
Examining data/tkdesk-2.0/blt/bltBgexec.c
Examining data/tkdesk-2.0/blt/bltBusy.c
Examining data/tkdesk-2.0/blt/bltChain.c
Examining data/tkdesk-2.0/blt/bltChain.h
Examining data/tkdesk-2.0/blt/bltConfig.c
Examining data/tkdesk-2.0/blt/bltDnd.c
Examining data/tkdesk-2.0/blt/bltInit.c
Examining data/tkdesk-2.0/blt/bltInt.h
Examining data/tkdesk-2.0/blt/bltList.c
Examining data/tkdesk-2.0/blt/bltList.h
Examining data/tkdesk-2.0/blt/bltText.c
Examining data/tkdesk-2.0/blt/bltText.h
Examining data/tkdesk-2.0/blt/bltTkInt.h
Examining data/tkdesk-2.0/blt/bltUnixDnd.c
Examining data/tkdesk-2.0/blt/bltUnixPipe.c
Examining data/tkdesk-2.0/blt/bltUtil.c
Examining data/tkdesk-2.0/blt/bltWait.h
Examining data/tkdesk-2.0/blt/bltWindow.c
Examining data/tkdesk-2.0/tkAppInit.c
Examining data/tkdesk-2.0/libdesk/init.c
Examining data/tkdesk-2.0/libdesk/libdesk.h
Examining data/tkdesk-2.0/libdesk/ot.h
Examining data/tkdesk-2.0/libdesk/util.c
Examining data/tkdesk-2.0/libdesk/misc.c
Examining data/tkdesk-2.0/libdesk/o_FileListbox.c
Examining data/tkdesk-2.0/libdesk/ot.c
Examining data/tkdesk-2.0/libdesk/tixImgXpm.c
Examining data/tkdesk-2.0/libdesk/dsk_ls.c
Examining data/tkdesk-2.0/netscape-remote/ClientWin.c
Examining data/tkdesk-2.0/netscape-remote/netscape_remote.c
Examining data/tkdesk-2.0/tkdeskclient/tkdeskclient.c
FINAL RESULTS:
data/tkdesk-2.0/libdesk/dsk_ls.c:377:8: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
len = readlink (fe->path, linkname + 4, MAXPATHLEN - 4);
data/tkdesk-2.0/blt/bltBgexec.c:781:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(newPtr, sinkPtr->byteArr);
data/tkdesk-2.0/blt/bltBusy.c:499:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(name, fmt, Tk_Name(refTkWin));
data/tkdesk-2.0/blt/bltConfig.c:709:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(string, "%s %d", Tk_NameOfColor(shadowPtr->color),
data/tkdesk-2.0/blt/bltList.c:148:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(entryPtr->key.string, key);
data/tkdesk-2.0/blt/bltUnixPipe.c:454:2: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(argv[0], &argv[0]);
data/tkdesk-2.0/blt/bltUtil.c:67:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, argList);
data/tkdesk-2.0/blt/bltUtil.c:475:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(newPtr, string);
data/tkdesk-2.0/libdesk/dsk_ls.c:290:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (nametcbuf, fe->name);
data/tkdesk-2.0/libdesk/dsk_ls.c:291:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (nametcbuf, fe->tc);
data/tkdesk-2.0/libdesk/dsk_ls.c:440:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(permstr, modes[j]);
data/tkdesk-2.0/libdesk/dsk_ls.c:524:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (name, pw->pw_name);
data/tkdesk-2.0/libdesk/dsk_ls.c:526:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (name, itoa ((int) uid));
data/tkdesk-2.0/libdesk/dsk_ls.c:547:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (name, gr->gr_name);
data/tkdesk-2.0/libdesk/dsk_ls.c:549:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (name, itoa((int) gid));
data/tkdesk-2.0/libdesk/dsk_ls.c:587:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (timestr, itoa (filetm.tm_year + 1900));
data/tkdesk-2.0/libdesk/dsk_ls.c:614:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buf, np);
data/tkdesk-2.0/libdesk/dsk_ls.c:616:6: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, fe->tc);
data/tkdesk-2.0/libdesk/dsk_ls.c:621:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buf, np);
data/tkdesk-2.0/libdesk/dsk_ls.c:623:6: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, fe->tc);
data/tkdesk-2.0/libdesk/dsk_ls.c:627:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, itoa ((int) fe->sb.st_size));
data/tkdesk-2.0/libdesk/dsk_ls.c:629:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, file_time (fe->sb.st_mtime));
data/tkdesk-2.0/libdesk/dsk_ls.c:631:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, get_user(fe->sb.st_uid));
data/tkdesk-2.0/libdesk/dsk_ls.c:633:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, get_group(fe->sb.st_gid));
data/tkdesk-2.0/libdesk/dsk_ls.c:635:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, perm_string (fe));
data/tkdesk-2.0/libdesk/dsk_ls.c:637:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, itoa (fe->sb.st_nlink));
data/tkdesk-2.0/libdesk/dsk_ls.c:639:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, linked_file(fe));
data/tkdesk-2.0/libdesk/dsk_ls.c:1071:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (nfe->path, buf);
data/tkdesk-2.0/libdesk/dsk_ls.c:1229:2: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (dsk_interp->result, "no such file or dir: %s", path);
data/tkdesk-2.0/libdesk/dsk_ls.c:1246:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buffer, path);
data/tkdesk-2.0/libdesk/dsk_ls.c:1247:7: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buffer, dir->d_name);
data/tkdesk-2.0/libdesk/dsk_ls.c:1251:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buffer, path);
data/tkdesk-2.0/libdesk/dsk_ls.c:1252:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buffer, dir->d_name);
data/tkdesk-2.0/libdesk/dsk_ls.c:1256:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buffer, path);
data/tkdesk-2.0/libdesk/dsk_ls.c:1257:13: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buffer, dir->d_name);
data/tkdesk-2.0/libdesk/dsk_ls.c:1290:6: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (dsk_interp->result, "no such file or dir: %s", par_path);
data/tkdesk-2.0/libdesk/dsk_ls.c:1295:6: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (dsk_interp->result, "no such file or dir: %s", par_path);
data/tkdesk-2.0/libdesk/dsk_ls.c:1381:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (dsk_interp->result, USAGE);
data/tkdesk-2.0/libdesk/dsk_ls.c:1385:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (par_mask, argv[i]);
data/tkdesk-2.0/libdesk/dsk_ls.c:1404:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (dsk_interp->result, USAGE);
data/tkdesk-2.0/libdesk/dsk_ls.c:1421:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (dsk_interp->result,
data/tkdesk-2.0/libdesk/dsk_ls.c:1434:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (dsk_interp->result, "Don't understand: -%c\n%s",
data/tkdesk-2.0/libdesk/dsk_ls.c:1440:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (dsk_interp->result, USAGE);
data/tkdesk-2.0/libdesk/dsk_ls.c:1443:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (par_path, argv[i]);
data/tkdesk-2.0/libdesk/dsk_ls.c:1450:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (dsk_interp->result, USAGE);
data/tkdesk-2.0/libdesk/misc.c:88:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(instr, argv[2]);
data/tkdesk-2.0/libdesk/misc.c:94:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(instr, argv[1]);
data/tkdesk-2.0/libdesk/misc.c:102:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (outstr, instr);
data/tkdesk-2.0/libdesk/misc.c:128:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (interp->result, outstr);
data/tkdesk-2.0/libdesk/misc.c:277:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buf, itoa((long)((double)fs.f_blocks/(1024./fs.f_frsize))));
data/tkdesk-2.0/libdesk/misc.c:279:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buf, itoa((long)((double)fs.f_blocks/(1024./fs.f_bsize))));
data/tkdesk-2.0/libdesk/misc.c:283:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, itoa((long)((double)fs.f_bavail/(1024./fs.f_frsize))));
data/tkdesk-2.0/libdesk/misc.c:285:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, itoa((long)((double)fs.f_bavail/(1024./fs.f_bsize))));
data/tkdesk-2.0/libdesk/misc.c:289:6: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (buf, itoa((long)((double)fs.f_bavail
data/tkdesk-2.0/libdesk/o_FileListbox.c:150:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (this, thisP); /* need to save this for Tcl 8.x */
data/tkdesk-2.0/libdesk/o_FileListbox.c:190:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (annobuf, argv[1]);
data/tkdesk-2.0/libdesk/o_FileListbox.c:195:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buf, itoa(i));
data/tkdesk-2.0/libdesk/o_FileListbox.c:232:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (annobuf+strlen(argv[1]), fnametc);
data/tkdesk-2.0/libdesk/o_FileListbox.c:311:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (buf, interp->result);
data/tkdesk-2.0/libdesk/ot.c:109:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (interp->result, buf);
data/tkdesk-2.0/libdesk/ot.c:266:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (interp->result, "invalid command name \"%s\"", argv[0]);
data/tkdesk-2.0/libdesk/tixImgXpm.c:893:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(useName, colorName);
data/tkdesk-2.0/libdesk/tixImgXpm.c:899:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(useName, colorName);
data/tkdesk-2.0/libdesk/tixImgXpm.c:905:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(useName, colorName);
data/tkdesk-2.0/libdesk/tixImgXpm.c:911:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(useName, colorName);
data/tkdesk-2.0/libdesk/tixImgXpm.c:918:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(useName, colorName);
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:69:6: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (fpath, dir->d_name);
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:72:10: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access (fpath, R_OK) == 0) {
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:86:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (key, buf);
data/tkdesk-2.0/blt/bltInt.h:719:15: [3] (random) drand48:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
extern double drand48 _ANSI_ARGS_((void));
data/tkdesk-2.0/blt/bltUnixPipe.c:127:5: [3] (tmpfile) tmpnam:
Temporary file race condition (CWE-377).
tmpnam(fileName);
data/tkdesk-2.0/tkAppInit.c:76:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv ("DISPLAY") == NULL) {
data/tkdesk-2.0/blt/bltBgexec.c:286:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char staticSpace[DEF_BUFFER_SIZE]; /* Static space */
data/tkdesk-2.0/blt/bltBgexec.c:472:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[20];
data/tkdesk-2.0/blt/bltBgexec.c:474:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(string, "%d", signalNum);
data/tkdesk-2.0/blt/bltBgexec.c:1261:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *mesg, mesgStr[200];
data/tkdesk-2.0/blt/bltBgexec.c:1322:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(mesgStr, "child completed with unknown status 0x%x",
data/tkdesk-2.0/blt/bltBusy.c:995:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
(char *)busyPtr, argv[3], 0);
data/tkdesk-2.0/blt/bltBusy.c:1039:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
(char *)busyPtr, argv[3], 0);
data/tkdesk-2.0/blt/bltConfig.c:591:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[200];
data/tkdesk-2.0/blt/bltConfig.c:593:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(string, "%d %d", padPtr->side1, padPtr->side2);
data/tkdesk-2.0/blt/bltConfig.c:707:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[200];
data/tkdesk-2.0/blt/bltConfig.c:863:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[200];
data/tkdesk-2.0/blt/bltConfig.c:870:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(string, "%d", (int)dashesPtr->valueArr[i]);
data/tkdesk-2.0/blt/bltDnd.c:599:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAX_PROP_SIZE + 1];
data/tkdesk-2.0/blt/bltDnd.c:1037:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[200];
data/tkdesk-2.0/blt/bltDnd.c:1042:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%d", tokenPtr->active);
data/tkdesk-2.0/blt/bltDnd.c:1158:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[200];
data/tkdesk-2.0/blt/bltDnd.c:1163:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(string, "dd-token%d", ++nextTokenId);
data/tkdesk-2.0/blt/bltDnd.c:2095:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char verbatim[3];
data/tkdesk-2.0/blt/bltDnd.c:2521:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
(char *)srcPtr, argv[3], 0);
data/tkdesk-2.0/blt/bltInit.c:197:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char libPath[1024] =
data/tkdesk-2.0/blt/bltInt.h:513:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char valueArr[12];
data/tkdesk-2.0/blt/bltList.c:154:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(entryPtr->key.words, key, keySize);
data/tkdesk-2.0/blt/bltList.h:43:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[4]; /* String for key. The actual size
data/tkdesk-2.0/blt/bltUnixDnd.c:3295:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[200];
data/tkdesk-2.0/blt/bltUnixDnd.c:3315:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(string, "0x%x", eventFlags);
data/tkdesk-2.0/blt/bltUnixDnd.c:3380:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char verbatim[3];
data/tkdesk-2.0/blt/bltUnixDnd.c:3533:67: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
return Tk_ConfigureValue(interp, dndPtr->tkwin, configSpecs, (char *)dndPtr,
data/tkdesk-2.0/blt/bltUnixDnd.c:3566:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
(char *)dndPtr, argv[3], flags);
data/tkdesk-2.0/blt/bltUnixDnd.c:4288:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
(char *)tokenPtr, argv[3], flags);
data/tkdesk-2.0/blt/bltUnixDnd.c:4534:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *nameArr[XDND_MAX_TYPES + 1];
data/tkdesk-2.0/blt/bltUnixPipe.c:84:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(fname, mode, 0666);
data/tkdesk-2.0/blt/bltUnixPipe.c:123:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fileName[L_tmpnam];
data/tkdesk-2.0/blt/bltUnixPipe.c:414:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errSpace[200];
data/tkdesk-2.0/blt/bltUnixPipe.c:444:6: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(errSpace, "%dforked process can't set up input/output: ",
data/tkdesk-2.0/blt/bltUnixPipe.c:455:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(errSpace, "%dcan't execute \"%.150s\": ", errno, argv[0]);
data/tkdesk-2.0/blt/bltUtil.c:241:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[200];
data/tkdesk-2.0/blt/bltUtil.c:246:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(string, " %f %f", firstFract, lastFract);
data/tkdesk-2.0/blt/bltUtil.c:592:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char stringRep[200];
data/tkdesk-2.0/blt/bltUtil.c:598:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(stringRep, "%d", value);
data/tkdesk-2.0/blt/bltWindow.c:173:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cursorString[20]; /* Used to store a cursor id string. */
data/tkdesk-2.0/libdesk/dsk_ls.c:124:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tc[2]; /* type character */
data/tkdesk-2.0/libdesk/dsk_ls.c:162:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char par_path[MAXPATHLEN] = ""; /* path for which to list files */
data/tkdesk-2.0/libdesk/dsk_ls.c:163:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char par_mask[64] = "";
data/tkdesk-2.0/libdesk/dsk_ls.c:372:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char linkname[MAXPATHLEN];
data/tkdesk-2.0/libdesk/dsk_ls.c:376:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (linkname, " -> ");
data/tkdesk-2.0/libdesk/dsk_ls.c:397:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char permstr[12];
data/tkdesk-2.0/libdesk/dsk_ls.c:519:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char name[32];
data/tkdesk-2.0/libdesk/dsk_ls.c:542:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char name[32];
data/tkdesk-2.0/libdesk/dsk_ls.c:568:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char timestr[32];
data/tkdesk-2.0/libdesk/dsk_ls.c:604:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lbuf[512], *np, *buf;
data/tkdesk-2.0/libdesk/dsk_ls.c:935:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy ((char *)fl->fe_array, fea1, num_dir * sizeof (FILE_ENTRY *));
data/tkdesk-2.0/libdesk/dsk_ls.c:936:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy ((char *)fl->fe_array + num_dir * sizeof (FILE_ENTRY *),
data/tkdesk-2.0/libdesk/dsk_ls.c:939:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy ((char *)fl->fe_array, fea2, num_oth * sizeof (FILE_ENTRY *));
data/tkdesk-2.0/libdesk/dsk_ls.c:940:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy ((char *)fl->fe_array + num_oth * sizeof (FILE_ENTRY *),
data/tkdesk-2.0/libdesk/dsk_ls.c:1051:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *np, *ls, buf[BUFSIZ];
data/tkdesk-2.0/libdesk/dsk_ls.c:1222:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAXPATHLEN];
data/tkdesk-2.0/libdesk/dsk_ls.c:1472:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (dsk_interp->result,
data/tkdesk-2.0/libdesk/misc.c:79:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char instr[TCL_RESULT_SIZE], outstr[TCL_RESULT_SIZE];
data/tkdesk-2.0/libdesk/misc.c:82:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (interp->result, "usage: dsk_striptc ?-keep? string");
data/tkdesk-2.0/libdesk/misc.c:90:13: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (interp->result, "usage: dsk_striptc ?-keep? string");
data/tkdesk-2.0/libdesk/misc.c:147:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (interp->result, "usage: dsk_esc string chars");
data/tkdesk-2.0/libdesk/misc.c:152:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
buf = (char *) ckalloc (strlen (argv[1]) * 2);
data/tkdesk-2.0/libdesk/misc.c:179:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (interp->result, "usage: dsk_unesc string");
data/tkdesk-2.0/libdesk/misc.c:184:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
buf = (char *) ckalloc (strlen (argv[1]) * 2);
data/tkdesk-2.0/libdesk/misc.c:211:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[10];
data/tkdesk-2.0/libdesk/misc.c:216:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%02d ", ts->tm_sec);
data/tkdesk-2.0/libdesk/misc.c:218:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%02d ", ts->tm_min);
data/tkdesk-2.0/libdesk/misc.c:220:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%02d ", ts->tm_hour);
data/tkdesk-2.0/libdesk/misc.c:223:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%d ", ts->tm_mday);
data/tkdesk-2.0/libdesk/misc.c:225:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%d ", ts->tm_mon);
data/tkdesk-2.0/libdesk/misc.c:227:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%d ", ts->tm_year % 100);
data/tkdesk-2.0/libdesk/misc.c:230:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%d ", ts->tm_wday);
data/tkdesk-2.0/libdesk/misc.c:232:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%d ", ts->tm_yday);
data/tkdesk-2.0/libdesk/misc.c:234:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%d ", ts->tm_isdst);
data/tkdesk-2.0/libdesk/misc.c:259:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[64];
data/tkdesk-2.0/libdesk/misc.c:262:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (interp->result, "usage: dskC_statfs path?/file?");
data/tkdesk-2.0/libdesk/misc.c:298:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (interp->result, "Error %d", errno);
data/tkdesk-2.0/libdesk/o_FileListbox.c:129:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fnametc[256], **maskv, *mask, maskbuf[64], buf[256], *thisP, **lsargv,
data/tkdesk-2.0/libdesk/o_FileListbox.c:142:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (interp->result, "usage: dskC_ls_and_tag path");
data/tkdesk-2.0/libdesk/ot.c:93:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32], *vp;
data/tkdesk-2.0/libdesk/ot.c:105:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (buf, "%f", curtm);
data/tkdesk-2.0/libdesk/ot.c:120:6: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (interp->result, "%f", curtm - lasttm);
data/tkdesk-2.0/libdesk/tixImgXpm.c:643:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fileId = open(fileName, O_RDONLY, 0);
data/tkdesk-2.0/libdesk/tixImgXpm.c:1156:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(interp->result,
data/tkdesk-2.0/libdesk/tixImgXpm.c:1172:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
(char *) masterPtr, argv[2], 0);
data/tkdesk-2.0/libdesk/tixImgXpm.c:1180:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
configSpecs, (char *) masterPtr, argv[2], 0);
data/tkdesk-2.0/libdesk/util.c:108:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char str[16];
data/tkdesk-2.0/netscape-remote/netscape_remote.c:322:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char value[256];
data/tkdesk-2.0/netscape-remote/netscape_remote.c:323:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(value, "0x%08x", (int) w);
data/tkdesk-2.0/netscape-remote/netscape_remote.c:504:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char value[256];
data/tkdesk-2.0/netscape-remote/netscape_remote.c:539:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(value, "0x%08x", (int) w);
data/tkdesk-2.0/netscape-remote/netscape_remote.c:872:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lock_data[255];
data/tkdesk-2.0/netscape-remote/netscape_remote.c:886:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(lock_data, "TkApp-pid%d@", getpid());
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:50:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fpath[64], buf[80];
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:68:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (fpath, "/tmp/");
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:81:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen (fpath, "r");
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:83:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi (buf);
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:101:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[80], c, buf[256+1], key[40];
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:116:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (hostname, "localhost");
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:133:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&sin.sin_addr, hp->h_addr, hp->h_length);
data/tkdesk-2.0/blt/bltBgexec.c:78:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#define read(fd, buf, size) Blt_AsyncRead((fd),(buf),(size))
data/tkdesk-2.0/blt/bltBgexec.c:847:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
nBytes = read(sinkPtr->fd, array, bytesLeft - 1);
data/tkdesk-2.0/blt/bltBusy.c:476:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(Tk_Name(refTkWin));
data/tkdesk-2.0/blt/bltConfig.c:200:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(string);
data/tkdesk-2.0/blt/bltDnd.c:583:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
propInfo.prefixSize = strlen(atom);
data/tkdesk-2.0/blt/bltDnd.c:828:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
8, PropModeReplace, (unsigned char *)data, strlen(data) + 1);
data/tkdesk-2.0/blt/bltDnd.c:2513:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(argv[3]);
data/tkdesk-2.0/blt/bltDnd.c:2716:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(argv[1]);
data/tkdesk-2.0/blt/bltList.c:136:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
keySize = strlen(key) + 1;
data/tkdesk-2.0/blt/bltUnixDnd.c:869:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
8, PropModeReplace, (unsigned char *)data, strlen(data) + 1);
data/tkdesk-2.0/blt/bltUnixPipe.c:125:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t length = (contents == NULL) ? 0 : strlen(contents);
data/tkdesk-2.0/blt/bltUnixPipe.c:446:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(fd, errSpace, (size_t) strlen(errSpace));
data/tkdesk-2.0/blt/bltUnixPipe.c:456:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(fd, errSpace, (size_t) strlen(errSpace));
data/tkdesk-2.0/blt/bltUnixPipe.c:474:13: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
count = read(fd, errSpace, (size_t) (sizeof(errSpace) - 1));
data/tkdesk-2.0/blt/bltUtil.c:178:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(argv[0]);
data/tkdesk-2.0/blt/bltUtil.c:185:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(argv[2]);
data/tkdesk-2.0/blt/bltUtil.c:335:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(operation);
data/tkdesk-2.0/blt/bltUtil.c:422:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(string);
data/tkdesk-2.0/blt/bltUtil.c:473:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newPtr = (char *)malloc(sizeof(char) * (strlen(string) + 1));
data/tkdesk-2.0/libdesk/dsk_ls.c:228:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (par_path, path, MAXPATHLEN);
data/tkdesk-2.0/libdesk/dsk_ls.c:381:10: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
return (strcpy (linkname, ""));
data/tkdesk-2.0/libdesk/dsk_ls.c:578:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (timestr, ctime (&filetime) + 4, 12);
data/tkdesk-2.0/libdesk/dsk_ls.c:586:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (timestr, " ");
data/tkdesk-2.0/libdesk/dsk_ls.c:618:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, " ");
data/tkdesk-2.0/libdesk/dsk_ls.c:625:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, " ");
data/tkdesk-2.0/libdesk/dsk_ls.c:626:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, "\t");
data/tkdesk-2.0/libdesk/dsk_ls.c:628:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, "\t");
data/tkdesk-2.0/libdesk/dsk_ls.c:630:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, "\t");
data/tkdesk-2.0/libdesk/dsk_ls.c:632:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, "\t");
data/tkdesk-2.0/libdesk/dsk_ls.c:634:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, "\t");
data/tkdesk-2.0/libdesk/dsk_ls.c:636:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, "\t");
data/tkdesk-2.0/libdesk/dsk_ls.c:638:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, "\t");
data/tkdesk-2.0/libdesk/dsk_ls.c:1062:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
np = (char *) dsk_malloc (strlen(name) * 2, "new_file_entry 2");
data/tkdesk-2.0/libdesk/dsk_ls.c:1287:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (par_path[strlen (par_path) - 1] == '/' && !par_one_file) {
data/tkdesk-2.0/libdesk/dsk_ls.c:1313:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (par_path, "/");
data/tkdesk-2.0/libdesk/misc.c:152:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf = (char *) ckalloc (strlen (argv[1]) * 2);
data/tkdesk-2.0/libdesk/misc.c:184:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
buf = (char *) ckalloc (strlen (argv[1]) * 2);
data/tkdesk-2.0/libdesk/misc.c:281:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, " ");
data/tkdesk-2.0/libdesk/misc.c:287:2: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, " ");
data/tkdesk-2.0/libdesk/misc.c:292:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (buf, "0");
data/tkdesk-2.0/libdesk/misc.c:304:5: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy (interp->result, "");
data/tkdesk-2.0/libdesk/o_FileListbox.c:232:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strcpy (annobuf+strlen(argv[1]), fnametc);
data/tkdesk-2.0/libdesk/o_FileListbox.c:233:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
annobuf[strlen(annobuf) - 1] = '\0';
data/tkdesk-2.0/libdesk/tixImgXpm.c:656:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
size = read(fileId, cmdBuffer, (size_t) statBuf.st_size);
data/tkdesk-2.0/libdesk/tixImgXpm.c:876:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
colorName = (char*)ckalloc(strlen(colorDefn));
data/tkdesk-2.0/libdesk/tixImgXpm.c:877:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
useName = (char*)ckalloc(strlen(colorDefn));
data/tkdesk-2.0/libdesk/tixImgXpm.c:928:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(colors[i].cstring, masterPtr->data[i+lOffset],
data/tkdesk-2.0/libdesk/tixImgXpm.c:1162:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(argv[1]);
data/tkdesk-2.0/netscape-remote/netscape_remote.c:644:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(unsigned char *) command, strlen(command));
data/tkdesk-2.0/netscape-remote/netscape_remote.c:887:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (gethostname(lock_data + strlen(lock_data), 100) == -1) {
data/tkdesk-2.0/netscape-remote/netscape_remote.c:925:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(lock_data));
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:143:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write (s, key, strlen(key));
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:145:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((rc = read (s, buf, 256)) < 0) {
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:155:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write (s, argv[i], strlen (argv[i]));
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:161:14: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = fgetc (stdin)) != EOF)
data/tkdesk-2.0/tkdeskclient/tkdeskclient.c:167:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((rc = read(s, buf, 256)) == 256)
ANALYSIS SUMMARY:
Hits = 228
Lines analyzed = 26546 in approximately 0.76 seconds (34902 lines/second)
Physical Source Lines of Code (SLOC) = 16236
Hits@level = [0] 64 [1] 56 [2] 100 [3] 3 [4] 68 [5] 1
Hits@level+ = [0+] 292 [1+] 228 [2+] 172 [3+] 72 [4+] 69 [5+] 1
Hits/KSLOC@level+ = [0+] 17.9847 [1+] 14.0429 [2+] 10.5937 [3+] 4.43459 [4+] 4.24982 [5+] 0.0615915
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.