Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/tuxcmd-modules-0.6.70+ds/gvfs/gvfs.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipExport.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCrc32Cryptograph.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/trees.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zlib.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inffast.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/crc32.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/uncompr.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zconf.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inftrees.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/infback.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/trees.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/deflate.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/adler32.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inflate.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inffast.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inffixed.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inflate.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/crc32.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inftrees.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/compress.c Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/deflate.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/DeflateCompressor.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_stl.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_mfc.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/FileInfo.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipStringStoreSettings.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipExtraField.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipMutex.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipMemFile.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipAesCryptograph.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPathComponent_win.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/DirEnumerator.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCompatibility.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/FileFilter.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCollections_mfc.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_win.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCrc32Cryptograph.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipAbstractFile.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCallback.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipExtraData.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipBaseException.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Wildcard.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipArchive.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Hmac.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCallbackProvider.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFile.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/DeflateCompressor.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipAutoBuffer.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_lnx.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipException.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Hmac.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipStorage.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BaseLibCompressor.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileMapping.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BaseLibCompressor.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFile_stl.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCollections.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/_platform.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileMapping_win.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCentralDir.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BytesWriter.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipArchive.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Aes.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/RandomPool.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/FileFilter.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/DirEnumerator.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Wildcard.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/std_mfc.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/resource.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCompressor.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipMutex_win.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipAutoBuffer.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Bzip2Compressor.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatformComm.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileMapping_lnx.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPathComponent_lnx.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFile_mfc.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipExtraData.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFile_mfc.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFile_stl.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Sha1.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipException.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipMutex_lnx.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipAesCryptograph.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/std_stl.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCryptograph.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Bzip2Compressor.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Aes.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipStorage.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCompatibility.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipMemFile.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCentralDir.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPathComponent.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/_features.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/RandomPool.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCompressor.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCryptograph.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/Sha1.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString.cpp Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipExtraField.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCollections_stl.h Examining data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/stdafx.h Examining data/tuxcmd-modules-0.6.70+ds/zip/zip.cpp Examining data/tuxcmd-modules-0.6.70+ds/libarchive/libarchive.c Examining data/tuxcmd-modules-0.6.70+ds/common/vfs_types.h Examining data/tuxcmd-modules-0.6.70+ds/common/strutils.h Examining data/tuxcmd-modules-0.6.70+ds/common/treepathutils.h Examining data/tuxcmd-modules-0.6.70+ds/common/treepath_vfs.h Examining data/tuxcmd-modules-0.6.70+ds/common/vfsutils.h Examining data/tuxcmd-modules-0.6.70+ds/common/treepathutils.c Examining data/tuxcmd-modules-0.6.70+ds/common/strutils.c Examining data/tuxcmd-modules-0.6.70+ds/common/treepath_vfs.c Examining data/tuxcmd-modules-0.6.70+ds/common/vfsutils.c FINAL RESULTS: data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_lnx.cpp:111:9: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. return chmod(lpFileName, uAttr) == 0; data/tuxcmd-modules-0.6.70+ds/common/strutils.h:30:23: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define log(msg...) printf(msg) data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_win.cpp:184:6: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(lpszName, 0) == 0) data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_stl.h:36:13: [4] (format) _vsntprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. #ifndef _vsntprintf data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_stl.h:38:11: [4] (format) _vsntprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. #define _vsntprintf _vsnwprintf data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_stl.h:40:11: [4] (format) _vsntprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. #define _vsntprintf _vsnprintf data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_stl.h:43:16: [4] (format) _vsntprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. #elif !defined(_vsntprintf) data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_stl.h:44:16: [4] (format) _vsntprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. #define _vsntprintf vsnprintf data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_stl.h:44:28: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. #define _vsntprintf vsnprintf data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipString_stl.h:170:13: [4] (format) _vsntprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. uTotal = _vsntprintf(pBuf, nChars - 1, lpszFormat, arguments); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:199:18: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. # if !defined(vsnprintf) && !defined(NO_vsnprintf) data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:200:15: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. # define vsnprintf _vsnprintf data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:246:39: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define Trace(x) {if (z_verbose>=0) fprintf x ;} data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:247:39: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define Tracev(x) {if (z_verbose>0) fprintf x ;} data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:248:40: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define Tracevv(x) {if (z_verbose>1) fprintf x ;} data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:249:48: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define Tracec(c,x) {if (z_verbose>0 && (c)) fprintf x ;} data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:250:49: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define Tracecv(c,x) {if (z_verbose>1 && (c)) fprintf x ;} data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCrc32Cryptograph.cpp:39:2: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(UINT(time(NULL))); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_win.cpp:101:8: [3] (tmpfile) GetTempFileName: Temporary file race condition in certain cases (e.g., if run as SYSTEM in many versions of Windows) (CWE-377). if (!GetTempFileName(tempPath, _T("ZAR"), 0, tempName.GetBuffer(_MAX_PATH))) data/tuxcmd-modules-0.6.70+ds/libarchive/libarchive.c:517:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (Append) fd = open(sDstName, O_APPEND | O_WRONLY); data/tuxcmd-modules-0.6.70+ds/libarchive/libarchive.c:518:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). else fd = open(sDstName, O_CREAT | O_WRONLY | O_TRUNC, data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BytesWriter.h:56:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&uDestination, pSource, iCount); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BytesWriter.h:62:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&uDestination, pSource, iCount); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BytesWriter.h:70:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&iDestination, pSource, iCount); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BytesWriter.h:89:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(pDestination, &uSource, 2); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BytesWriter.h:94:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(pDestination, &uSource, iCount); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/BytesWriter.h:100:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(pDestination, &uSource, iCount); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/DeflateCompressor.cpp:87:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_stream.next_out, m_stream.next_in, uToCopy); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/DeflateCompressor.cpp:196:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_stream.next_out, m_stream.next_in, uToCopy); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipArchive.cpp:2876:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char localInfo[4]; data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipArchive.cpp:2882:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&uExtraFieldSize, localInfo + 2, 2); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipArchive.cpp:2926:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((char*)buf + 2, &uExtraFieldSize, 2); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipArchive.cpp:2927:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((char*)buf + 4, pHeader->m_pszFileNameBuffer, uNewFileNameLen); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipAutoBuffer.cpp:81:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_pBuffer, buffer.m_pBuffer, buffer.m_iSize); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipAutoBuffer.cpp:92:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_pBuffer, buffer.m_pBuffer, buffer.m_iSize); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCentralDir.cpp:563:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(pBuf, m_gszSignature, 4); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCentralDir.cpp:571:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(pBuf + 22, m_pInfo->m_pszComment, uCommentSize); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCompatibility.cpp:180:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(szString.GetBuffer(iLen), buf.GetBuffer(), iLen); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCompatibility.cpp:185:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(szString.GetBuffer(iLen), buffer.GetBuffer(), iLen); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCompatibility.cpp:199:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, lpszString, (size_t)iLen); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipExtraData.cpp:32:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_data, buffer + 4, size); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipExtraData.cpp:41:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer + 4, m_data, size); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipExtraData.h:76:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_data, extra.m_data, uSize); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:145:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buffer, pExtra->m_data + offset, iFileNameSize); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:235:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(data + offset, buffer, buffer.GetSize()); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:272:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, m_gszSignature, 4); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:290:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest + 46, m_pszFileNameBuffer, uFileNameSize); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:296:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest + 46 + uFileNameSize + uExtraFieldSize, m_pszComment, uCommentSize); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:308:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[LOCALFILEHEADERSIZE]; data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:448:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest, m_gszLocalSignature, 4); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:458:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(dest + 30, m_pszFileNameBuffer, m_uLocalFileNameSize); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFileHeader.cpp:757:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf, CZipStorage::m_gszExtHeaderSignat, 4); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipMemFile.cpp:59:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(lpBuf, m_lpBuf + m_nPos, nToRead); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipMemFile.cpp:72:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_lpBuf + m_nPos, lpBuf, nCount); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPathComponent_win.cpp:30:2: [2] (buffer) TCHAR: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. TCHAR szDrive[_MAX_DRIVE]; data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPathComponent_win.cpp:32:2: [2] (buffer) TCHAR: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. TCHAR szDir[32767]; data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPathComponent_win.cpp:34:2: [2] (buffer) TCHAR: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. TCHAR szDir[_MAX_DIR]; data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPathComponent_win.cpp:36:2: [2] (buffer) TCHAR: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. TCHAR szFname[_MAX_FNAME]; data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPathComponent_win.cpp:37:2: [2] (buffer) TCHAR: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. TCHAR szExt[_MAX_EXT]; data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_lnx.cpp:88:15: [2] (tmpfile) mkstemp: Potential for temporary file vulnerability in some circumstances. Some older Unix-like systems create temp files with permission to write by all by default, so be sure to set the umask to override this. Also, some older Unix systems might fail to use O_EXCL when opening the file, so make sure that O_EXCL is used by the library (CWE-377). int handle = mkstemp(tempPath.GetBuffer(tempPath.GetLength())); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_lnx.cpp:255:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). return open(lpszFileName, iMode, S_IRUSR | S_IWUSR | S_IRGRP |S_IROTH ); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_win.cpp:230:13: [2] (buffer) MultiByteToWideChar: Requires maximum length in CHARACTERS, not bytes (CWE-120). int iLen = MultiByteToWideChar(cpIn, MB_PRECOMPOSED, buffer, size, NULL, 0); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_win.cpp:235:9: [2] (buffer) MultiByteToWideChar: Requires maximum length in CHARACTERS, not bytes (CWE-120). iLen = MultiByteToWideChar(cpIn, MB_PRECOMPOSED, buffer, size, lpszWide, iLen); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_win.cpp:337:13: [2] (buffer) MultiByteToWideChar: Requires maximum length in CHARACTERS, not bytes (CWE-120). int iLen = MultiByteToWideChar(uCodePage, dwFlags, szIn.GetBuffer(), singleLen, NULL, 0); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_win.cpp:340:10: [2] (buffer) MultiByteToWideChar: Requires maximum length in CHARACTERS, not bytes (CWE-120). iLen = MultiByteToWideChar(uCodePage, dwFlags, szIn.GetBuffer(), singleLen, data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipStorage.cpp:485:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((char*)m_pWriteBuffer + m_uBytesInWriteBuffer, pBuf + uWritten, uToCopy); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/crc32.c:161:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). out = fopen("crc32.h", "w"); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inflate.c:572:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char hbuf[4]; /* buffer for gzip header crc calculation */ data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/inflate.c:1267:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[4]; /* to restore bit buffer to byte string */ data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/trees.c:332:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *header = fopen("trees.h", "w"); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.c:14:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. const char * const z_errmsg[10] = { data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:53:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. extern const char * const z_errmsg[10]; /* indexed by 2-zlib_error */ data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:111:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fopen((name), (mode), "mbc=60", "ctx=stm", "rfm=fix", "mrs=512") data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:173:30: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). # define F_OPEN(name, mode) fopen((name), (mode)) data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/zlib/zutil.h:230:21: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. # define zmemcpy memcpy data/tuxcmd-modules-0.6.70+ds/common/strutils.c:31:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strcmp(APath + strlen(APath) - 1, "/") != 0) { data/tuxcmd-modules-0.6.70+ds/common/strutils.c:32:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ANewPath = (char*)malloc(strlen(APath) + 2); data/tuxcmd-modules-0.6.70+ds/common/strutils.c:33:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). snprintf(ANewPath, strlen(APath) + 2, "%s/", APath); data/tuxcmd-modules-0.6.70+ds/common/strutils.c:43:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((strcmp(APath + strlen(APath) - 1, "/") == 0) && (strlen(APath) > 1)) { data/tuxcmd-modules-0.6.70+ds/common/strutils.c:43:57: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((strcmp(APath + strlen(APath) - 1, "/") == 0) && (strlen(APath) > 1)) { data/tuxcmd-modules-0.6.70+ds/common/strutils.c:44:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ANewPath = (char*)malloc(strlen(APath)); data/tuxcmd-modules-0.6.70+ds/common/strutils.c:45:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). snprintf(ANewPath, strlen(APath), "%s", APath); // The number of bytes copied includes the trailing \0 data/tuxcmd-modules-0.6.70+ds/common/strutils.c:56:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ANewPath = (char*)malloc(strlen(APath) + 2); data/tuxcmd-modules-0.6.70+ds/common/strutils.c:57:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). snprintf(ANewPath, strlen(APath) + 2, "/%s", APath); // The number of bytes copied includes the trailing \0 data/tuxcmd-modules-0.6.70+ds/common/strutils.c:129:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memmove (start, start+i, strlen (start+i)+1); data/tuxcmd-modules-0.6.70+ds/common/strutils.c:137:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memmove (p, p+1, strlen (p+1)+1); data/tuxcmd-modules-0.6.70+ds/common/strutils.c:150:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memmove (p, q, strlen (q)+1); data/tuxcmd-modules-0.6.70+ds/common/strutils.c:171:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memmove (p, q, strlen (q)+1); data/tuxcmd-modules-0.6.70+ds/common/treepath_vfs.c:220:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(ANewPath) <= 0) ANewPath = strdup("/"); data/tuxcmd-modules-0.6.70+ds/common/treepathutils.c:145:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(pos + 1) > 0) last_part = strdup(pos + 1); data/tuxcmd-modules-0.6.70+ds/common/treepathutils.c:199:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(pos + 1) > 0) last_part = strdup(pos + 1); data/tuxcmd-modules-0.6.70+ds/common/treepathutils.c:368:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((strlen(path) == 1) && (IS_DIR_SEP(*path))) data/tuxcmd-modules-0.6.70+ds/libarchive/libarchive.c:577:53: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((sSrcName == NULL) || (sDstName == NULL) || (strlen(sSrcName) < 1) || (strlen(sDstName) < 1)) { data/tuxcmd-modules-0.6.70+ds/libarchive/libarchive.c:577:79: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((sSrcName == NULL) || (sDstName == NULL) || (strlen(sSrcName) < 1) || (strlen(sDstName) < 1)) { data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipCompatibility.cpp:196:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int iLen = (int)strlen(lpszString); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipException.cpp:79:3: [1] (buffer) wcsncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). wcsncpy(lpszError, lpsz, iLen); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipException.cpp:81:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(lpszError, lpsz, iLen); data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipFile_stl.h:39:16: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). #define _read read data/tuxcmd-modules-0.6.70+ds/zip/ZipArchive/ZipPlatform_win.cpp:307:19: [1] (buffer) wcslen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t wideLen = wcslen(lpszIn); data/tuxcmd-modules-0.6.70+ds/zip/zip.cpp:547:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((sDirName == NULL) || (strlen(sDirName) < 1)) { data/tuxcmd-modules-0.6.70+ds/zip/zip.cpp:551:8: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((strlen(sDirName) < 1) || (strcmp(sDirName, "/") == 0)) { data/tuxcmd-modules-0.6.70+ds/zip/zip.cpp:617:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((strlen(AFile3) > 0) && (strcmp(AFile3, "/") != 0)) { data/tuxcmd-modules-0.6.70+ds/zip/zip.cpp:882:53: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((sSrcName == NULL) || (sDstName == NULL) || (strlen(sSrcName) < 1) || (strlen(sDstName) < 1)) { data/tuxcmd-modules-0.6.70+ds/zip/zip.cpp:882:79: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((sSrcName == NULL) || (sDstName == NULL) || (strlen(sSrcName) < 1) || (strlen(sDstName) < 1)) { data/tuxcmd-modules-0.6.70+ds/zip/zip.cpp:955:53: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((sSrcName == NULL) || (sDstName == NULL) || (strlen(sSrcName) < 1) || (strlen(sDstName) < 1)) { data/tuxcmd-modules-0.6.70+ds/zip/zip.cpp:955:79: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((sSrcName == NULL) || (sDstName == NULL) || (strlen(sSrcName) < 1) || (strlen(sDstName) < 1)) { ANALYSIS SUMMARY: Hits = 106 Lines analyzed = 35612 in approximately 0.87 seconds (40776 lines/second) Physical Source Lines of Code (SLOC) = 20339 Hits@level = [0] 187 [1] 31 [2] 56 [3] 2 [4] 16 [5] 1 Hits@level+ = [0+] 293 [1+] 106 [2+] 75 [3+] 19 [4+] 17 [5+] 1 Hits/KSLOC@level+ = [0+] 14.4058 [1+] 5.21166 [2+] 3.6875 [3+] 0.934166 [4+] 0.835833 [5+] 0.0491666 Symlinks skipped = 19 (--allowlink overrides but see doc for security issue) Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.