Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/vdr-plugin-live-2.3.1/cache.h
Examining data/vdr-plugin-live-2.3.1/epg_events.cpp
Examining data/vdr-plugin-live-2.3.1/epg_events.h
Examining data/vdr-plugin-live-2.3.1/epgsearch.cpp
Examining data/vdr-plugin-live-2.3.1/epgsearch.h
Examining data/vdr-plugin-live-2.3.1/epgsearch/services.h
Examining data/vdr-plugin-live-2.3.1/exception.h
Examining data/vdr-plugin-live-2.3.1/filecache.cpp
Examining data/vdr-plugin-live-2.3.1/filecache.h
Examining data/vdr-plugin-live-2.3.1/grab.cpp
Examining data/vdr-plugin-live-2.3.1/grab.h
Examining data/vdr-plugin-live-2.3.1/i18n.cpp
Examining data/vdr-plugin-live-2.3.1/i18n.h
Examining data/vdr-plugin-live-2.3.1/live.cpp
Examining data/vdr-plugin-live-2.3.1/live.h
Examining data/vdr-plugin-live-2.3.1/livefeatures.cpp
Examining data/vdr-plugin-live-2.3.1/livefeatures.h
Examining data/vdr-plugin-live-2.3.1/md5.cpp
Examining data/vdr-plugin-live-2.3.1/md5.h
Examining data/vdr-plugin-live-2.3.1/osd_status.cpp
Examining data/vdr-plugin-live-2.3.1/osd_status.h
Examining data/vdr-plugin-live-2.3.1/preload.cpp
Examining data/vdr-plugin-live-2.3.1/preload.h
Examining data/vdr-plugin-live-2.3.1/recman.cpp
Examining data/vdr-plugin-live-2.3.1/recman.h
Examining data/vdr-plugin-live-2.3.1/setup.cpp
Examining data/vdr-plugin-live-2.3.1/setup.h
Examining data/vdr-plugin-live-2.3.1/status.cpp
Examining data/vdr-plugin-live-2.3.1/status.h
Examining data/vdr-plugin-live-2.3.1/stdext.h
Examining data/vdr-plugin-live-2.3.1/tasks.cpp
Examining data/vdr-plugin-live-2.3.1/tasks.h
Examining data/vdr-plugin-live-2.3.1/thread.cpp
Examining data/vdr-plugin-live-2.3.1/thread.h
Examining data/vdr-plugin-live-2.3.1/timerconflict.cpp
Examining data/vdr-plugin-live-2.3.1/timerconflict.h
Examining data/vdr-plugin-live-2.3.1/timers.cpp
Examining data/vdr-plugin-live-2.3.1/timers.h
Examining data/vdr-plugin-live-2.3.1/tntconfig.cpp
Examining data/vdr-plugin-live-2.3.1/tntconfig.h
Examining data/vdr-plugin-live-2.3.1/tntfeatures.h
Examining data/vdr-plugin-live-2.3.1/tools.cpp
Examining data/vdr-plugin-live-2.3.1/tools.h
Examining data/vdr-plugin-live-2.3.1/users.cpp
Examining data/vdr-plugin-live-2.3.1/users.h
FINAL RESULTS:
data/vdr-plugin-live-2.3.1/md5.cpp:80:3: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncat(chBuffer, chEach, sizeof(chEach));
data/vdr-plugin-live-2.3.1/recman.cpp:149:50: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
cRecordingUserCommand::InvokeCommand(*cString::sprintf("rename \"%s\"", *strescape(oldname.c_str(), "\\\"$'")), newname.c_str());
data/vdr-plugin-live-2.3.1/recman.cpp:201:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (0 == access(dvdFile.c_str(), R_OK)) {
data/vdr-plugin-live-2.3.1/recman.cpp:205:12: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (0 == access(hddFile.c_str(), R_OK)) {
data/vdr-plugin-live-2.3.1/setup.cpp:331:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(m_adminLogin, vdrlive::LiveSetup().GetAdminLogin().c_str());
data/vdr-plugin-live-2.3.1/setup.cpp:396:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(m_adminPassword, m_tmpPassword);
data/vdr-plugin-live-2.3.1/setup.cpp:399:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(m_tmpPassword, strHidden.c_str());
data/vdr-plugin-live-2.3.1/tools.cpp:56:8: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
if ( snprintf(result, sizeof(result), format, hours, minutes) < 0 ) {
data/vdr-plugin-live-2.3.1/setup.cpp:67:22: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ( ( optchar = getopt_long( argc, argv, "p:i:l:e:s:c:", opts, &optind ) ) != -1 ) {
data/vdr-plugin-live-2.3.1/tools.cpp:41:10: [3] (random) setstate:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
is.setstate( ios::badbit );
data/vdr-plugin-live-2.3.1/tools.cpp:47:8: [3] (random) setstate:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
is.setstate( ios::badbit );
data/vdr-plugin-live-2.3.1/livefeatures.cpp:22:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_version += atoi( parts[ i ].c_str() ) * factors[ i ];
data/vdr-plugin-live-2.3.1/md5.cpp:42:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char PADDING[64] =
data/vdr-plugin-live-2.3.1/md5.cpp:70:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char chBuffer[256];
data/vdr-plugin-live-2.3.1/md5.cpp:71:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char chEach[10];
data/vdr-plugin-live-2.3.1/md5.cpp:79:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(chEach, "%02x", md5Digest[nCount]);
data/vdr-plugin-live-2.3.1/md5.cpp:134:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy( &m_Buffer[index], chInput, partLen );
data/vdr-plugin-live-2.3.1/md5.cpp:146:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy( &m_Buffer[index], &chInput[i], nInputLen-i );
data/vdr-plugin-live-2.3.1/setup.cpp:69:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
case 'p': m_serverPort = atoi( optarg ); break;
data/vdr-plugin-live-2.3.1/setup.cpp:73:31: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
case 's': m_serverSslPort = atoi( optarg ); break;
data/vdr-plugin-live-2.3.1/setup.cpp:107:60: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ( strcmp( name, "LastChannel" ) == 0 ) m_lastChannel = atoi( value );
data/vdr-plugin-live-2.3.1/setup.cpp:108:79: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "ScreenshotInterval" ) == 0 ) m_screenshotInterval = atoi( value );
data/vdr-plugin-live-2.3.1/setup.cpp:109:57: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "UseAuth" ) == 0 ) m_useAuth = atoi( value );
data/vdr-plugin-live-2.3.1/setup.cpp:120:61: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "ShowLogo" ) == 0 ) { m_showLogo = atoi(value); }
data/vdr-plugin-live-2.3.1/setup.cpp:121:59: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "UseAjax" ) == 0 ) { m_useAjax = atoi(value); }
data/vdr-plugin-live-2.3.1/setup.cpp:122:67: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "ShowInfoBox" ) == 0 ) { m_showInfoBox = atoi(value); }
data/vdr-plugin-live-2.3.1/setup.cpp:123:69: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "UseStreamdev" ) == 0 ) { m_useStreamdev = atoi(value); }
data/vdr-plugin-live-2.3.1/setup.cpp:124:71: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "StreamdevPort" ) == 0 ) { m_streamdevPort = atoi(value); }
data/vdr-plugin-live-2.3.1/setup.cpp:126:81: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "ScreenShotInterval" ) == 0 ) { m_screenshotInterval = atoi(value); }
data/vdr-plugin-live-2.3.1/setup.cpp:127:61: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "ShowIMDb" ) == 0 ) { m_showIMDb = atoi(value); }
data/vdr-plugin-live-2.3.1/setup.cpp:128:89: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
else if ( strcmp( name, "ShowChannelsWithoutEPG" ) == 0 ) { m_showChannelsWithoutEPG = atoi(value); }
data/vdr-plugin-live-2.3.1/setup.cpp:181:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* f = fopen("/proc/sys/net/ipv6/bindv6only", "r");
data/vdr-plugin-live-2.3.1/setup.h:161:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char m_adminLogin[20];
data/vdr-plugin-live-2.3.1/setup.h:162:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char m_adminPassword[20];
data/vdr-plugin-live-2.3.1/setup.h:163:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char m_tmpPassword[20];
data/vdr-plugin-live-2.3.1/tools.cpp:55:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char result[ 32 ];
data/vdr-plugin-live-2.3.1/tools.cpp:73:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char result[ 256 ];
data/vdr-plugin-live-2.3.1/users.cpp:57:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char value[MAXVALUELEN];
data/vdr-plugin-live-2.3.1/users.cpp:154:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (user->Id() == atoi(Id.c_str()))
data/vdr-plugin-live-2.3.1/filecache.cpp:30:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ifs.read( &data[0], size );
data/vdr-plugin-live-2.3.1/md5.cpp:90:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int nLen = strlen(szString);
data/vdr-plugin-live-2.3.1/setup.cpp:184:12: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int c = fgetc(f);
data/vdr-plugin-live-2.3.1/setup.cpp:337:2: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(m_adminPassword, "");
data/vdr-plugin-live-2.3.1/setup.cpp:374:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(value) == strlen(ItemValue))
data/vdr-plugin-live-2.3.1/setup.cpp:374:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(value) == strlen(ItemValue))
data/vdr-plugin-live-2.3.1/setup.cpp:384:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ItemText && strlen(ItemText) > 0 && strstr(ItemText, tr("Admin password")) == ItemText)
data/vdr-plugin-live-2.3.1/setup.cpp:391:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (ItemText && strlen(ItemText) > 0 && strstr(ItemText, tr("Admin password")) == ItemText)
data/vdr-plugin-live-2.3.1/setup.cpp:398:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
string strHidden(strlen(m_adminPassword), '*');
data/vdr-plugin-live-2.3.1/setup.cpp:405:3: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(m_tmpPassword, "");
data/vdr-plugin-live-2.3.1/users.cpp:60:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pos_next = pos + strlen(pos);
data/vdr-plugin-live-2.3.1/users.cpp:68:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pos_next = pos + strlen(pos);
ANALYSIS SUMMARY:
Hits = 51
Lines analyzed = 7829 in approximately 0.22 seconds (35174 lines/second)
Physical Source Lines of Code (SLOC) = 5859
Hits@level = [0] 1 [1] 12 [2] 28 [3] 3 [4] 7 [5] 1
Hits@level+ = [0+] 52 [1+] 51 [2+] 39 [3+] 11 [4+] 8 [5+] 1
Hits/KSLOC@level+ = [0+] 8.87523 [1+] 8.70456 [2+] 6.65643 [3+] 1.87745 [4+] 1.36542 [5+] 0.170678
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.