Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/xdrawchem-1.11.0/xdrawchem/CDXConstants.h
Examining data/xdrawchem-1.11.0/xdrawchem/aa_xpm.h
Examining data/xdrawchem-1.11.0/xdrawchem/application.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/application.h
Examining data/xdrawchem-1.11.0/xdrawchem/application_ob.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/application_ring.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/arrow.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/arrow.h
Examining data/xdrawchem-1.11.0/xdrawchem/arrows.h
Examining data/xdrawchem-1.11.0/xdrawchem/atom.h
Examining data/xdrawchem-1.11.0/xdrawchem/biotools.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/biotools.h
Examining data/xdrawchem-1.11.0/xdrawchem/bond.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/bond.h
Examining data/xdrawchem-1.11.0/xdrawchem/bondedit.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/bondedit.h
Examining data/xdrawchem-1.11.0/xdrawchem/boshcp.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/boshcp.h
Examining data/xdrawchem-1.11.0/xdrawchem/bracket.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/bracket.h
Examining data/xdrawchem-1.11.0/xdrawchem/brackets.h
Examining data/xdrawchem-1.11.0/xdrawchem/cdx2cdxml.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/cdxml_reader.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/cdxml_reader.h
Examining data/xdrawchem-1.11.0/xdrawchem/charsel.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/charsel.h
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata.h
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_cdx.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_cdxml.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_cml.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_edit.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_event.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_mdl.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_rw.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_rxn.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_tools.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_xdc.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/chemdata_xml.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/clipboard.h
Examining data/xdrawchem-1.11.0/xdrawchem/cml.h
Examining data/xdrawchem-1.11.0/xdrawchem/colorbutton.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/colorbutton.h
Examining data/xdrawchem-1.11.0/xdrawchem/crings_dialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/crings_dialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/cubicbezier.h
Examining data/xdrawchem-1.11.0/xdrawchem/curvearrow.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/curvearrow.h
Examining data/xdrawchem-1.11.0/xdrawchem/defs.h
Examining data/xdrawchem-1.11.0/xdrawchem/dpoint.h
Examining data/xdrawchem-1.11.0/xdrawchem/drawable.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/drawable.h
Examining data/xdrawchem-1.11.0/xdrawchem/dyk.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/dyk.h
Examining data/xdrawchem-1.11.0/xdrawchem/fixeddialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/fixeddialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/gobject.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/gobject.h
Examining data/xdrawchem-1.11.0/xdrawchem/graphdata.h
Examining data/xdrawchem-1.11.0/xdrawchem/graphdialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/graphdialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/graphwidget.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/graphwidget.h
Examining data/xdrawchem-1.11.0/xdrawchem/helpwindow.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/helpwindow.h
Examining data/xdrawchem-1.11.0/xdrawchem/http.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/http.h
Examining data/xdrawchem-1.11.0/xdrawchem/ioiface.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/ioiface.h
Examining data/xdrawchem-1.11.0/xdrawchem/main.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/moldata.h
Examining data/xdrawchem-1.11.0/xdrawchem/molecule.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/molecule.h
Examining data/xdrawchem-1.11.0/xdrawchem/molecule_1h_nmr.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/molecule_obmol.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/molecule_smiles.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/molecule_sssr.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/molecule_sssr.h
Examining data/xdrawchem-1.11.0/xdrawchem/molecule_tools_1.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/molecule_tools_2.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/molinfodialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/molinfodialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/myfiledialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/myfiledialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/na_xpm.h
Examining data/xdrawchem-1.11.0/xdrawchem/netaccess.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/netaccess.h
Examining data/xdrawchem-1.11.0/xdrawchem/netchoosedialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/netchoosedialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/netdialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/netdialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/ngw.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/ngw.h
Examining data/xdrawchem-1.11.0/xdrawchem/pagesetupdialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/pagesetupdialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/paintable.h
Examining data/xdrawchem-1.11.0/xdrawchem/peak.h
Examining data/xdrawchem-1.11.0/xdrawchem/peptidebuilder.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/peptidebuilder.h
Examining data/xdrawchem-1.11.0/xdrawchem/prefs.h
Examining data/xdrawchem-1.11.0/xdrawchem/previewwidget.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/previewwidget.h
Examining data/xdrawchem-1.11.0/xdrawchem/render2d.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/render2d.h
Examining data/xdrawchem-1.11.0/xdrawchem/render2d_draw.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/render2d_event.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/render2d_print.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/render2d_select.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/render2d_text.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/renderarea.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/renderarea.h
Examining data/xdrawchem-1.11.0/xdrawchem/retro.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/ring.h
Examining data/xdrawchem-1.11.0/xdrawchem/ring_xpm.h
Examining data/xdrawchem-1.11.0/xdrawchem/ringdialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/ringdialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/sdg.h
Examining data/xdrawchem-1.11.0/xdrawchem/setofrings.h
Examining data/xdrawchem-1.11.0/xdrawchem/smilesdialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/smilesdialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/sorf.h
Examining data/xdrawchem-1.11.0/xdrawchem/sugar_xpm.h
Examining data/xdrawchem-1.11.0/xdrawchem/symbol.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/symbol.h
Examining data/xdrawchem-1.11.0/xdrawchem/symbol_xpm.h
Examining data/xdrawchem-1.11.0/xdrawchem/text.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/text.h
Examining data/xdrawchem-1.11.0/xdrawchem/textshapedialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/textshapedialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/to3d.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/tool_13c_nmr.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/tool_13c_nmr.h
Examining data/xdrawchem-1.11.0/xdrawchem/tool_1h_nmr.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/tool_1h_nmr.h
Examining data/xdrawchem-1.11.0/xdrawchem/tool_2d3d.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/tool_2d3d.h
Examining data/xdrawchem-1.11.0/xdrawchem/tool_ir.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/tool_ir.h
Examining data/xdrawchem-1.11.0/xdrawchem/tooldialog.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/tooldialog.h
Examining data/xdrawchem-1.11.0/xdrawchem/xdc_event.h
Examining data/xdrawchem-1.11.0/xdrawchem/xdc_textedit.h
Examining data/xdrawchem-1.11.0/xdrawchem/xdc_toolbutton.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/xdc_toolbutton.h
Examining data/xdrawchem-1.11.0/xdrawchem/xml_cml.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/xml_cml.h
Examining data/xdrawchem-1.11.0/xdrawchem/xml_reader.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/xml_reader.h
Examining data/xdrawchem-1.11.0/xdrawchem/xruler.cpp
Examining data/xdrawchem-1.11.0/xdrawchem/xruler.h
FINAL RESULTS:
data/xdrawchem-1.11.0/xdrawchem/application.cpp:790:24: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
passfail = system(exportName.toLatin1());
data/xdrawchem-1.11.0/xdrawchem/application.cpp:796:24: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
passfail = system(exportName.toLatin1());
data/xdrawchem-1.11.0/xdrawchem/application_ob.cpp:151:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(realchar, tmpchar);
data/xdrawchem-1.11.0/xdrawchem/application_ob.cpp:259:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(realchar, tmpchar);
data/xdrawchem-1.11.0/xdrawchem/ioiface.cpp:268:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(type, tmp_atom->baseElement().toLatin1());
data/xdrawchem-1.11.0/xdrawchem/main.cpp:158:66: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
translator.load(QString::fromLatin1("xdrawchem_") + QLocale::system().name(), RingDir);
data/xdrawchem-1.11.0/xdrawchem/molecule_obmol.cpp:217:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(type, tmp_atom->baseElement().toLatin1());
data/xdrawchem-1.11.0/xdrawchem/chemdata_tools.cpp:123:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
serverName = getenv("XDC_SERVER");
data/xdrawchem-1.11.0/xdrawchem/main.cpp:120:15: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
HomeDir = getenv("HOME");
data/xdrawchem-1.11.0/xdrawchem/netdialog.cpp:35:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
serverName = getenv("XDC_SERVER");
data/xdrawchem-1.11.0/xdrawchem/render2d.cpp:867:5: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand(QTime::currentTime().second());
data/xdrawchem-1.11.0/xdrawchem/to3d.cpp:70:5: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand((int)time(0));
data/xdrawchem-1.11.0/xdrawchem/application_ob.cpp:106:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::ReadOnly)) {
data/xdrawchem-1.11.0/xdrawchem/cdx2cdxml.cpp:158:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::ReadOnly))
data/xdrawchem-1.11.0/xdrawchem/chemdata_cdx.cpp:39:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::WriteOnly)) {
data/xdrawchem-1.11.0/xdrawchem/chemdata_cdx.cpp:57:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::WriteOnly)) {
data/xdrawchem-1.11.0/xdrawchem/chemdata_cml.cpp:32:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!xmlFile.open(QIODevice::ReadOnly))
data/xdrawchem-1.11.0/xdrawchem/chemdata_cml.cpp:546:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::WriteOnly)) {
data/xdrawchem-1.11.0/xdrawchem/chemdata_rw.cpp:32:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::ReadOnly)) {
data/xdrawchem-1.11.0/xdrawchem/chemdata_rw.cpp:38:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cookie[9];
data/xdrawchem-1.11.0/xdrawchem/chemdata_rw.cpp:99:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::ReadOnly))
data/xdrawchem-1.11.0/xdrawchem/chemdata_xdc.cpp:263:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::WriteOnly)) {
data/xdrawchem-1.11.0/xdrawchem/chemdata_xml.cpp:29:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!f.open(QIODevice::ReadOnly)) {
data/xdrawchem-1.11.0/xdrawchem/ioiface.cpp:258:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char type[5];
data/xdrawchem-1.11.0/xdrawchem/ioiface.h:39:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char symbol[110][4];
data/xdrawchem-1.11.0/xdrawchem/main.cpp:129:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (f1.open(QIODevice::ReadOnly) == false) {
data/xdrawchem-1.11.0/xdrawchem/main.cpp:142:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (f1.open(QIODevice::ReadOnly) == false) {
data/xdrawchem-1.11.0/xdrawchem/molecule.h:195:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char symbol[110][4];
data/xdrawchem-1.11.0/xdrawchem/molecule_obmol.cpp:207:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char type[5];
data/xdrawchem-1.11.0/xdrawchem/netaccess.cpp:229:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
buffer->open(QIODevice::ReadOnly);
data/xdrawchem-1.11.0/xdrawchem/prefs.h:73:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (fin.open(QIODevice::ReadOnly) == false)
data/xdrawchem-1.11.0/xdrawchem/prefs.h:166:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (fout.open(QIODevice::WriteOnly) == false)
data/xdrawchem-1.11.0/xdrawchem/retro.cpp:62:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (fin.open(QIODevice::ReadOnly) == false)
data/xdrawchem-1.11.0/xdrawchem/to3d.cpp:212:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!fout.open(QIODevice::WriteOnly)) {
data/xdrawchem-1.11.0/xdrawchem/chemdata_rw.cpp:40:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
f.read(cookie, 8);
ANALYSIS SUMMARY:
Hits = 35
Lines analyzed = 42272 in approximately 1.25 seconds (33728 lines/second)
Physical Source Lines of Code (SLOC) = 31437
Hits@level = [0] 1 [1] 1 [2] 22 [3] 5 [4] 7 [5] 0
Hits@level+ = [0+] 36 [1+] 35 [2+] 34 [3+] 12 [4+] 7 [5+] 0
Hits/KSLOC@level+ = [0+] 1.14515 [1+] 1.11334 [2+] 1.08153 [3+] 0.381716 [4+] 0.222668 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.