Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/xdx-2.5.0/src/hyperlink.c
Examining data/xdx-2.5.0/src/history.h
Examining data/xdx-2.5.0/src/types.h
Examining data/xdx-2.5.0/src/cmd_opts.c
Examining data/xdx-2.5.0/src/gtksourceiter.h
Examining data/xdx-2.5.0/src/gui_exitdialog.c
Examining data/xdx-2.5.0/src/gui_settingsdialog.h
Examining data/xdx-2.5.0/src/hyperlink.h
Examining data/xdx-2.5.0/src/preferences.h
Examining data/xdx-2.5.0/src/text.h
Examining data/xdx-2.5.0/src/gtksourceiter.c
Examining data/xdx-2.5.0/src/gui_logdialog.h
Examining data/xdx-2.5.0/src/gui_closedialog.c
Examining data/xdx-2.5.0/src/gui_aboutdialog.c
Examining data/xdx-2.5.0/src/gui_closedialog.h
Examining data/xdx-2.5.0/src/gui_exitdialog.h
Examining data/xdx-2.5.0/src/utils.c
Examining data/xdx-2.5.0/src/gui_logdialog.c
Examining data/xdx-2.5.0/src/net.h
Examining data/xdx-2.5.0/src/text.c
Examining data/xdx-2.5.0/src/history.c
Examining data/xdx-2.5.0/src/gui_opendialog.c
Examining data/xdx-2.5.0/src/utils.h
Examining data/xdx-2.5.0/src/gui_aboutdialog.h
Examining data/xdx-2.5.0/src/save.h
Examining data/xdx-2.5.0/src/cmd_opts.h
Examining data/xdx-2.5.0/src/net.c
Examining data/xdx-2.5.0/src/save.c
Examining data/xdx-2.5.0/src/gui_manualdialog.c
Examining data/xdx-2.5.0/src/gui_opendialog.h
Examining data/xdx-2.5.0/src/gui_manualdialog.h
Examining data/xdx-2.5.0/src/preferences.c
Examining data/xdx-2.5.0/src/main.c
Examining data/xdx-2.5.0/src/gui_settingsdialog.c
Examining data/xdx-2.5.0/src/gui.c
Examining data/xdx-2.5.0/src/gui.h
FINAL RESULTS:
data/xdx-2.5.0/src/gui.c:1323:17: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(hamlibstr);
data/xdx-2.5.0/src/history.c:52:13: [4] (buffer) fscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
if (fscanf(fp, "%s", history) == EOF)
data/xdx-2.5.0/src/preferences.c:165:17: [4] (buffer) fscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
if (fscanf(fp, "%s %s", label, value) == EOF) break;
data/xdx-2.5.0/src/cmd_opts.c:85:20: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
next_opt = getopt_long(*argc, *argv, s_opts, l_opts, NULL);
data/xdx-2.5.0/src/preferences.c:73:53: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
gui->preferencesdir = g_strdup_printf("%s/.%s", g_get_home_dir(), PACKAGE);
data/xdx-2.5.0/src/text.c:1124:19: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
cty_env = getenv("XDX_CTY");
data/xdx-2.5.0/src/gui.c:1319:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
setf = atoi(fsplit[0]) * 1000 + atoi(fsplit[1]) * 100;
data/xdx-2.5.0/src/gui.c:1319:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
setf = atoi(fsplit[0]) * 1000 + atoi(fsplit[1]) * 100;
data/xdx-2.5.0/src/gui_logdialog.c:104:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = fopen(filename, "r");
data/xdx-2.5.0/src/gui_manualdialog.c:97:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
in = fopen(helpfile, "r");
data/xdx-2.5.0/src/history.c:47:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(historyfile, "r");
data/xdx-2.5.0/src/history.c:84:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(historyfile, "w");
data/xdx-2.5.0/src/main.c:310:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_tree_view_column_set_fixed_width(column, atoi(wsplit[0]));
data/xdx-2.5.0/src/main.c:317:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_tree_view_column_set_fixed_width(column, atoi(wsplit[1]));
data/xdx-2.5.0/src/main.c:324:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_tree_view_column_set_fixed_width(column, atoi(wsplit[2]));
data/xdx-2.5.0/src/main.c:331:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_tree_view_column_set_fixed_width(column, atoi(wsplit[3]));
data/xdx-2.5.0/src/main.c:338:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_tree_view_column_set_fixed_width(column, atoi(wsplit[4]));
data/xdx-2.5.0/src/main.c:345:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_tree_view_column_set_fixed_width(column, atoi(wsplit[5]));
data/xdx-2.5.0/src/main.c:352:54: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_tree_view_column_set_fixed_width(column, atoi(wsplit[6]));
data/xdx-2.5.0/src/net.c:144:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
claddress.sin_port = htons(atoi(cluster->port));
data/xdx-2.5.0/src/net.c:145:5: [2] (buffer) bcopy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
bcopy(clhostent->h_addr, &claddress.sin_addr, clhostent->h_length);
data/xdx-2.5.0/src/preferences.c:161:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(preferencesfile, "r");
data/xdx-2.5.0/src/preferences.c:168:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.x = atoi(value);
data/xdx-2.5.0/src/preferences.c:170:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.y = atoi(value);
data/xdx-2.5.0/src/preferences.c:172:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.width = atoi(value);
data/xdx-2.5.0/src/preferences.c:174:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.height = atoi(value);
data/xdx-2.5.0/src/preferences.c:178:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.autologin = atoi(value);
data/xdx-2.5.0/src/preferences.c:185:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.savedx = atoi(value);
data/xdx-2.5.0/src/preferences.c:187:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.savewwv = atoi(value);
data/xdx-2.5.0/src/preferences.c:189:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.savetoall = atoi(value);
data/xdx-2.5.0/src/preferences.c:191:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.savewx = atoi(value);
data/xdx-2.5.0/src/preferences.c:193:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.hamlib = atoi(value);
data/xdx-2.5.0/src/preferences.c:207:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.col0visible = atoi(value);
data/xdx-2.5.0/src/preferences.c:209:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.col1visible = atoi(value);
data/xdx-2.5.0/src/preferences.c:211:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.col2visible = atoi(value);
data/xdx-2.5.0/src/preferences.c:213:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.col3visible = atoi(value);
data/xdx-2.5.0/src/preferences.c:215:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.col4visible = atoi(value);
data/xdx-2.5.0/src/preferences.c:217:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.col5visible = atoi(value);
data/xdx-2.5.0/src/preferences.c:219:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.col6visible = atoi(value);
data/xdx-2.5.0/src/preferences.c:227:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.localecho = atoi(value);
data/xdx-2.5.0/src/preferences.c:229:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.handlebarpos = atoi(value);
data/xdx-2.5.0/src/preferences.c:273:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.sidebar = atoi(value);
data/xdx-2.5.0/src/preferences.c:275:36: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.fbox = atoi(value);
data/xdx-2.5.0/src/preferences.c:277:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.reconnect = atoi(value);
data/xdx-2.5.0/src/preferences.c:279:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.playsound = atoi(value);
data/xdx-2.5.0/src/preferences.c:281:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferences.keepalive = atoi(value);
data/xdx-2.5.0/src/preferences.c:335:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(preferencesfile, "w");
data/xdx-2.5.0/src/save.c:44:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(savedxfile, "a");
data/xdx-2.5.0/src/save.c:102:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(wwvfile, "a");
data/xdx-2.5.0/src/save.c:119:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(wwvfile, "a");
data/xdx-2.5.0/src/save.c:147:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(toallfile, "a");
data/xdx-2.5.0/src/save.c:169:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(wxfile, "a");
data/xdx-2.5.0/src/text.c:730:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((atoi(temp) != 0) || (!strcmp(temp, "0000"))) {
data/xdx-2.5.0/src/text.c:932:47: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
pxstr = change_area(split[0], atoi(split[1]));
data/xdx-2.5.0/src/text.c:1151:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(cty_location, "r")) == NULL) {
data/xdx-2.5.0/src/text.c:1201:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dxcc_add(split[0], atoi(split[1]), atoi(split[2]), split[3],
data/xdx-2.5.0/src/text.c:1201:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
dxcc_add(split[0], atoi(split[1]), atoi(split[2]), split[3],
data/xdx-2.5.0/src/utils.c:287:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(f, "a");
data/xdx-2.5.0/src/gtksourceiter.c:103:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
needle_len = strlen(needle);
data/xdx-2.5.0/src/gtksourceiter.c:156:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
needle_len = strlen(needle);
data/xdx-2.5.0/src/gtksourceiter.c:199:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len_s1 = strlen(normalized_s1);
data/xdx-2.5.0/src/gtksourceiter.c:200:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len_s2 = strlen(normalized_s2);
data/xdx-2.5.0/src/gtksourceiter.c:315:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (g_utf8_caselessnmatch(line_text, *lines, strlen(line_text),
data/xdx-2.5.0/src/gtksourceiter.c:316:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(*lines)))
data/xdx-2.5.0/src/gtksourceiter.c:407:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (g_utf8_caselessnmatch(line_text, *lines, strlen(line_text),
data/xdx-2.5.0/src/gtksourceiter.c:408:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(*lines)))
data/xdx-2.5.0/src/gtksourceiter.c:468:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
guint delimiter_len = strlen(delimiter);
data/xdx-2.5.0/src/gtksourceiter.c:475:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(new_string, string, len);
data/xdx-2.5.0/src/gui.c:1226:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(temp) > 0) {
data/xdx-2.5.0/src/gui_settingsdialog.c:748:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(str) == 0)
data/xdx-2.5.0/src/gui_settingsdialog.c:764:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(str) == 0)
data/xdx-2.5.0/src/gui_settingsdialog.c:813:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(str) == 0)
data/xdx-2.5.0/src/gui_settingsdialog.c:821:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(str) == 0)
data/xdx-2.5.0/src/gui_settingsdialog.c:828:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(str) == 0)
data/xdx-2.5.0/src/gui_settingsdialog.c:835:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(str) == 0)
data/xdx-2.5.0/src/hyperlink.c:46:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = linktocheck + strlen(linktocheck);
data/xdx-2.5.0/src/hyperlink.c:67:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(split[i]) < 2) toshort = TRUE;
data/xdx-2.5.0/src/net.c:330:25: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(500000);
data/xdx-2.5.0/src/save.c:90:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fprintf(fpointer, "\t%s", tmp + strlen(item));
data/xdx-2.5.0/src/text.c:171:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = str + strlen(str);
data/xdx-2.5.0/src/text.c:202:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = str + strlen(str);
data/xdx-2.5.0/src/text.c:229:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = str + strlen(str);
data/xdx-2.5.0/src/text.c:258:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = str + strlen(str);
data/xdx-2.5.0/src/text.c:293:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = str + strlen(str);
data/xdx-2.5.0/src/text.c:321:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = str + strlen(str);
data/xdx-2.5.0/src/text.c:701:59: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (g_utf8_strlen(temp, -1) > strlen(preferences.callsign) + 4) {
data/xdx-2.5.0/src/text.c:702:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*(temp + strlen(preferences.callsign) + 4) = '\0';
data/xdx-2.5.0/src/text.c:885:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = callsign + strlen(callsign);
data/xdx-2.5.0/src/text.c:919:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((strlen(split[1]) > 1) && (strlen(split[1]) < strlen(split[0])))
data/xdx-2.5.0/src/text.c:919:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((strlen(split[1]) > 1) && (strlen(split[1]) < strlen(split[0])))
data/xdx-2.5.0/src/text.c:919:63: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((strlen(split[1]) > 1) && (strlen(split[1]) < strlen(split[0])))
data/xdx-2.5.0/src/text.c:928:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if ((strlen(split[1]) == 1) &&
data/xdx-2.5.0/src/text.c:952:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = exception + strlen(exception);
data/xdx-2.5.0/src/text.c:988:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
end = pfx + strlen(pfx);
data/xdx-2.5.0/src/text.c:1023:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (ipx = strlen(px); ipx > 0; ipx--) {
data/xdx-2.5.0/src/text.c:1174:18: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ch = fgetc(fp);
ANALYSIS SUMMARY:
Hits = 96
Lines analyzed = 8507 in approximately 0.22 seconds (38006 lines/second)
Physical Source Lines of Code (SLOC) = 5900
Hits@level = [0] 74 [1] 38 [2] 52 [3] 3 [4] 3 [5] 0
Hits@level+ = [0+] 170 [1+] 96 [2+] 58 [3+] 6 [4+] 3 [5+] 0
Hits/KSLOC@level+ = [0+] 28.8136 [1+] 16.2712 [2+] 9.83051 [3+] 1.01695 [4+] 0.508475 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.