Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/xmbmon-2.05/smbuses.h
Examining data/xmbmon-2.05/smbuses.c
Examining data/xmbmon-2.05/smbus_amd.c
Examining data/xmbmon-2.05/io_cpu.h
Examining data/xmbmon-2.05/pci_pm.h
Examining data/xmbmon-2.05/getMB-smb.c
Examining data/xmbmon-2.05/sens_it87.c
Examining data/xmbmon-2.05/sens_via686.c
Examining data/xmbmon-2.05/smbus_piix4.c
Examining data/xmbmon-2.05/getMB-isa.c
Examining data/xmbmon-2.05/tyan_tiger.c
Examining data/xmbmon-2.05/sens_gl52.c
Examining data/xmbmon-2.05/getMB-smb_ioctl.c
Examining data/xmbmon-2.05/testhwm.c
Examining data/xmbmon-2.05/sens_lm90.c
Examining data/xmbmon-2.05/smbus_amd8.c
Examining data/xmbmon-2.05/pci_smb.c
Examining data/xmbmon-2.05/sensors.h
Examining data/xmbmon-2.05/sens_wl784.c
Examining data/xmbmon-2.05/sens_winbond.h
Examining data/xmbmon-2.05/smb_extemp.c
Examining data/xmbmon-2.05/smb_extemp.h
Examining data/xmbmon-2.05/sens_wl784.h
Examining data/xmbmon-2.05/getMB-via.c
Examining data/xmbmon-2.05/testpci.c
Examining data/xmbmon-2.05/testsmb.c
Examining data/xmbmon-2.05/pci_pm.c
Examining data/xmbmon-2.05/sens_lm85.c
Examining data/xmbmon-2.05/mbmon_small.c
Examining data/xmbmon-2.05/xmbmon.c
Examining data/xmbmon-2.05/methods.h
Examining data/xmbmon-2.05/sens_lm75.c
Examining data/xmbmon-2.05/getMBinfo.c
Parsing failed to find end of parameter list; semicolon terminated it in (stderr, " * SMB monitor(s)[ioctl:%s]:\n",
#else /* SMBus direct access routines */
fprintf(stderr, " * SMB monitor(s)[%s]:\n",
#endif
chk_smb_chip(chip));
fprintf(stderr, " ** %s fou
Parsing failed to find end of parameter list; semicolon terminated it in (stderr, "Using SMBus-ioctl access method[%s]!!\n",
#else /* SMBus direct access routines */
fprintf(stderr, "Using SMBus access method[%s]!!\n",
#endif
chk_smb_chip(chip));
}
return 0;
}
Examining data/xmbmon-2.05/mbmon.h
Examining data/xmbmon-2.05/sens_winbond.c
Examining data/xmbmon-2.05/sens_lm80.c
Examining data/xmbmon-2.05/sensors.c
Examining data/xmbmon-2.05/io_static.c
Examining data/xmbmon-2.05/smbus_ali.c
Examining data/xmbmon-2.05/mbmon.c
FINAL RESULTS:
data/xmbmon-2.05/getMB-smb_ioctl.c:52:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, smb_devfile + 5);
data/xmbmon-2.05/getMB-smb_ioctl.c:62:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, smb_devfile + 5);
data/xmbmon-2.05/getMB-smb_ioctl.c:148:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, smb_devfile + 5);
data/xmbmon-2.05/getMB-smb_ioctl.c:181:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buf, smb_devfile + 5);
data/xmbmon-2.05/mbmon.c:545:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(timebuf, "%2d/%2d/%4d;%2d:%02d:%02d %s",
data/xmbmon-2.05/mbmon.c:558:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(curdata->data,
data/xmbmon-2.05/mbmon.c:570:4: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(log, prtdata->data);
data/xmbmon-2.05/sens_gl52.c:141:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buff, gl52chip[gl52chipid]);
data/xmbmon-2.05/sens_lm85.c:202:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buff, lm85chip[lm85chipid]);
data/xmbmon-2.05/sens_lm90.c:121:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buff, lm90chip[lm90chipid]);
data/xmbmon-2.05/sens_winbond.c:293:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buff, winbchip[wbdchipid]);
data/xmbmon-2.05/sens_wl784.c:169:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(wl784.Name, wlchip[wbdchipid]);
data/xmbmon-2.05/xmbmon.c:370:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(dum, p);
data/xmbmon-2.05/xmbmon.c:382:2: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, \
data/xmbmon-2.05/xmbmon.c:581:3: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(c_rdv[id], c_rdp[id], cur_val[id]);
data/xmbmon-2.05/xmbmon.c:741:3: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(c_rdv[id], c_rdp[id], cur_val[id]);
data/xmbmon-2.05/xmbmon.c:900:3: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(c_rdv[id], c_rdp[id], cur_val[id]);
data/xmbmon-2.05/mbmon.c:319:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((ch = getopt(argc,argv,"VSIAfdDYe:p:s:c:T:F:tunNirh")) != -1) {
data/xmbmon-2.05/mbmon.c:321:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((ch = getopt(argc,argv,"VSIAfdDYe:p:c:T:F:tunNirhP:")) != -1) {
data/xmbmon-2.05/mbmon_small.c:30:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((ch = getopt(argc,argv,"VSIAfdDYe:p:s:")) != -1) {
data/xmbmon-2.05/mbmon_small.c:32:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((ch = getopt(argc,argv,"VSIAfdDYe:p:")) != -1) {
data/xmbmon-2.05/getMB-smb_ioctl.c:39:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buf[128];
data/xmbmon-2.05/getMB-smb_ioctl.c:50:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((iosmb = open(smb_devfile, 000)) < 0) {
data/xmbmon-2.05/getMB-smb_ioctl.c:51:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "ioctl(");
data/xmbmon-2.05/getMB-smb_ioctl.c:53:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf, ":open)");
data/xmbmon-2.05/getMB-smb_ioctl.c:61:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "ioctl(");
data/xmbmon-2.05/getMB-smb_ioctl.c:63:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf, ":read Reg.0x47)");
data/xmbmon-2.05/getMB-smb_ioctl.c:147:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "ioctl(");
data/xmbmon-2.05/getMB-smb_ioctl.c:149:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf, ":writebyte)");
data/xmbmon-2.05/getMB-smb_ioctl.c:180:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buf, "ioctl(");
data/xmbmon-2.05/getMB-smb_ioctl.c:182:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf, ":writeword)");
data/xmbmon-2.05/io_cpu.h:27:30: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
#define SET_IOPL() (iofl = open("/dev/io",000))
data/xmbmon-2.05/mbmon.c:89:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char file_buf[1024];
data/xmbmon-2.05/mbmon.c:167:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(PROC_LOADAVG, O_RDONLY)) == -1) {
data/xmbmon-2.05/mbmon.c:196:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char domainname[MAXHOSTNAMELEN], hostname[MAXHOSTNAMELEN];
data/xmbmon-2.05/mbmon.c:213:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p, hostname[MAXHOSTNAMELEN];
data/xmbmon-2.05/mbmon.c:268:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open("/dev/null", O_RDWR)) == -1) {
data/xmbmon-2.05/mbmon.c:297:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256];
data/xmbmon-2.05/mbmon.c:359:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
n = atoi(optarg);
data/xmbmon-2.05/mbmon.c:367:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
n = atoi(optarg);
data/xmbmon-2.05/mbmon.c:375:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = atoi (optarg);
data/xmbmon-2.05/mbmon.c:381:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
count = atoi(optarg);
data/xmbmon-2.05/mbmon.c:386:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
temperature = atoi(optarg);
data/xmbmon-2.05/mbmon.c:391:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
fanspeed = atoi(optarg);
data/xmbmon-2.05/mbmon.c:426:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((n = atoi(argv[0])) > 0) {
data/xmbmon-2.05/mbmon.c:447:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
log = fopen(LOGFILE, "w");
data/xmbmon-2.05/mbmon.c:499:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&rd_fdset, &mstfdset, sizeof(fd_set));
data/xmbmon-2.05/mbmon.c:530:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char timebuf[24];
data/xmbmon-2.05/mbmon.c:552:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
log = fopen(LOGFILE, "w");
data/xmbmon-2.05/mbmon_small.c:58:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
n = atoi(optarg);
data/xmbmon-2.05/mbmon_small.c:66:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
n = atoi(optarg);
data/xmbmon-2.05/mbmon_small.c:95:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if ((n = atoi(argv[0])) > 0) {
data/xmbmon-2.05/sens_gl52.c:57:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buff[BUFF_LEN];
data/xmbmon-2.05/sens_gl52.c:128:2: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buff, "Genesys Logic ");
data/xmbmon-2.05/sens_lm85.c:76:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buff[BUFF_LEN];
data/xmbmon-2.05/sens_lm90.c:54:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buff[BUFF_LEN];
data/xmbmon-2.05/sens_winbond.c:103:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buff[BUFF_LEN];
data/xmbmon-2.05/sens_winbond.c:330:4: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(winbond.Name, "+LM75");
data/xmbmon-2.05/sens_wl784.c:66:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buff[BUFF_LEN];
data/xmbmon-2.05/xmbmon.c:95:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *l_color[NUM_DATA];
data/xmbmon-2.05/xmbmon.c:100:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ctmin[C_LBL], ctmax[C_LBL];
data/xmbmon-2.05/xmbmon.c:101:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cvmin[C_LBL], cvmax[C_LBL];
data/xmbmon-2.05/xmbmon.c:103:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *c_rdv[NUM_DATA], *c_rdg[NUM_DATA];
data/xmbmon-2.05/xmbmon.c:104:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *c_rdp[NUM_DATA] = {"%4.1f", "%4.1f", "%4.1f", "%4.2f"};
data/xmbmon-2.05/xmbmon.c:467:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
n_count = atoi(DEFAULT_COUNT);
data/xmbmon-2.05/xmbmon.c:470:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
interval_sec = atoi(DEFAULT_CSEC);
data/xmbmon-2.05/xmbmon.c:473:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
w_sec = atoi(DEFAULT_WSEC);
data/xmbmon-2.05/xmbmon.c:488:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
n_tick = atoi(DEFAULT_TICK);
data/xmbmon-2.05/xmbmon.c:541:7: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
n = atoi(app_resources.smbdev);
data/xmbmon-2.05/xmbmon.c:760:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ctmin, "%2.0f", tmin);
data/xmbmon-2.05/xmbmon.c:761:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ctmax, "%2.0f", tmax);
data/xmbmon-2.05/xmbmon.c:762:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(cvmin, "%3.1f", vmin);
data/xmbmon-2.05/xmbmon.c:763:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(cvmax, "%3.1f", vmax);
data/xmbmon-2.05/mbmon.c:173:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((bytes = read(fd, file_buf, sizeof file_buf - 1)) < 0) {
data/xmbmon-2.05/sens_winbond.c:202:3: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(30000);
data/xmbmon-2.05/xmbmon.c:369:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dum = (char *) malloc(strlen(p) + 1);
data/xmbmon-2.05/xmbmon.c:582:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cv_width[i] = XTextWidth(fontstr, c_rdv[id], strlen(c_rdv[id]));
data/xmbmon-2.05/xmbmon.c:625:55: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
XDrawString(disp, win, gclb, x_lb, c_lb - 2, label, strlen(label));
data/xmbmon-2.05/xmbmon.c:630:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
c_rdg[id], strlen(c_rdg[id]));
data/xmbmon-2.05/xmbmon.c:632:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
c_rdv[id], strlen(c_rdv[id]));
data/xmbmon-2.05/xmbmon.c:635:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
XDrawString(disp, win, gct, 0, hh+1, ctmin, strlen(ctmin));
data/xmbmon-2.05/xmbmon.c:636:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
XDrawString(disp, win, gct, 0, cm_height, ctmax, strlen(ctmax));
data/xmbmon-2.05/xmbmon.c:637:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
XDrawString(disp, win, gct, ww-cm_width, hh+1, cvmin, strlen(cvmin));
data/xmbmon-2.05/xmbmon.c:638:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
XDrawString(disp, win, gct, ww-cm_width, cm_height, cvmax, strlen(cvmax));
data/xmbmon-2.05/xmbmon.c:742:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cg_width[i] = XTextWidth(fontstr, c_rdg[id], strlen(c_rdg[id]));
data/xmbmon-2.05/xmbmon.c:743:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cv_width[i] = XTextWidth(fontstr, c_rdv[id], strlen(c_rdv[id]));
data/xmbmon-2.05/xmbmon.c:757:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
lb_width = XTextWidth(lb_fontstr, label, strlen(label));
data/xmbmon-2.05/xmbmon.c:816:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cm_width = XTextWidth(fontstr, cvmin, strlen(cvmin)) - 1;
data/xmbmon-2.05/xmbmon.c:902:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
c_rdv[id], strlen(c_rdv[id]));
ANALYSIS SUMMARY:
Hits = 89
Lines analyzed = 8126 in approximately 0.24 seconds (34425 lines/second)
Physical Source Lines of Code (SLOC) = 6086
Hits@level = [0] 236 [1] 16 [2] 52 [3] 4 [4] 17 [5] 0
Hits@level+ = [0+] 325 [1+] 89 [2+] 73 [3+] 21 [4+] 17 [5+] 0
Hits/KSLOC@level+ = [0+] 53.4012 [1+] 14.6237 [2+] 11.9947 [3+] 3.45054 [4+] 2.7933 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.