Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/yad-0.40.0/src/util.c
Examining data/yad-0.40.0/src/form.c
Examining data/yad-0.40.0/src/dnd.c
Examining data/yad-0.40.0/src/option.c
Examining data/yad-0.40.0/src/calendar.c
Examining data/yad-0.40.0/src/picture.c
Examining data/yad-0.40.0/src/scale.c
Examining data/yad-0.40.0/src/multi-progress.c
Examining data/yad-0.40.0/src/html.c
Examining data/yad-0.40.0/src/paned.c
Examining data/yad-0.40.0/src/list.c
Examining data/yad-0.40.0/src/progress.c
Examining data/yad-0.40.0/src/main.c
Examining data/yad-0.40.0/src/file.c
Examining data/yad-0.40.0/src/print.c
Examining data/yad-0.40.0/src/notebook.c
Examining data/yad-0.40.0/src/font.c
Examining data/yad-0.40.0/src/color.c
Examining data/yad-0.40.0/src/about.c
Examining data/yad-0.40.0/src/entry.c
Examining data/yad-0.40.0/src/text.c
Examining data/yad-0.40.0/src/browser.c
Examining data/yad-0.40.0/src/notification.c
Examining data/yad-0.40.0/src/icons.c
Examining data/yad-0.40.0/src/yad.h
FINAL RESULTS:
data/yad-0.40.0/src/entry.c:72:16: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
pf = popen (cmd, "r");
data/yad-0.40.0/src/html.c:54:11: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
realpath (uri, afn);
data/yad-0.40.0/src/calendar.c:36:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen (options.calendar_data.details, "r");
data/yad-0.40.0/src/color.c:63:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen (filename, "r")) == NULL)
data/yad-0.40.0/src/form.c:318:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_range_set_value (GTK_RANGE (w), atoi (value));
data/yad-0.40.0/src/list.c:928:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gint num = atoi (cnum[i]);
data/yad-0.40.0/src/list.c:962:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gint num = atoi (cnum[i]);
data/yad-0.40.0/src/list.c:996:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gint num = atoi (cnum[i]);
data/yad-0.40.0/src/main.c:655:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
xf = fopen (options.xid_file, "w");
data/yad-0.40.0/src/multi-progress.c:84:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
num = atoi (value[0]) - 1;
data/yad-0.40.0/src/multi-progress.c:134:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
percentage = atoi (value[1]);
data/yad-0.40.0/src/multi-progress.c:253:70: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_progress_bar_set_fraction (GTK_PROGRESS_BAR (w), atoi (options.extra_data[i]) / 100.0);
data/yad-0.40.0/src/multi-progress.c:261:72: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gtk_progress_bar_set_pulse_step (GTK_PROGRESS_BAR (w), atoi (options.extra_data[i]) / 100.0);
data/yad-0.40.0/src/option.c:1050:30: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.scale_data.value = atoi (value);
data/yad-0.40.0/src/option.c:1129:23: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.data.posx = atol (value);
data/yad-0.40.0/src/option.c:1136:23: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
options.data.posy = atol (value);
data/yad-0.40.0/src/progress.c:117:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
percentage = atoi (string->str);
data/yad-0.40.0/src/text.c:385:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen (options.common_data.uri, "r");
data/yad-0.40.0/src/util.c:451:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (res + i, "\\n");
data/yad-0.40.0/src/util.c:455:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (res + i, "\\t");
data/yad-0.40.0/src/util.c:459:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (res + i, "\\\\");
data/yad-0.40.0/src/util.c:490:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (res + i, "\\\"");
data/yad-0.40.0/src/calendar.c:51:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen (buf) > 0)
data/yad-0.40.0/src/file.c:94:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (options.common_data.uri[strlen (options.common_data.uri) - 1] != '/')
data/yad-0.40.0/src/icons.c:303:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = strlen (ent->command); i > 0; i--)
data/yad-0.40.0/src/list.c:159:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pos = strlen (key);
data/yad-0.40.0/src/main.c:687:7: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (1000);
data/yad-0.40.0/src/main.c:871:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen (buf);
data/yad-0.40.0/src/notebook.c:89:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (1000);
data/yad-0.40.0/src/notebook.c:141:7: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (1000);
data/yad-0.40.0/src/paned.c:78:5: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (1000);
data/yad-0.40.0/src/paned.c:119:7: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (1000);
data/yad-0.40.0/src/util.c:443:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen (str);
data/yad-0.40.0/src/util.c:483:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen (str);
data/yad-0.40.0/src/yad.h:630:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gint nl = strlen (str) - 1;
ANALYSIS SUMMARY:
Hits = 35
Lines analyzed = 11769 in approximately 0.29 seconds (40373 lines/second)
Physical Source Lines of Code (SLOC) = 9519
Hits@level = [0] 3 [1] 13 [2] 20 [3] 1 [4] 1 [5] 0
Hits@level+ = [0+] 38 [1+] 35 [2+] 22 [3+] 2 [4+] 1 [5+] 0
Hits/KSLOC@level+ = [0+] 3.99202 [1+] 3.67686 [2+] 2.31117 [3+] 0.210106 [4+] 0.105053 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.