Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/zita-rev1-0.2.2/source/pareq.h
Examining data/zita-rev1-0.2.2/source/zita-rev1.cc
Examining data/zita-rev1-0.2.2/source/jclient.h
Examining data/zita-rev1-0.2.2/source/jclient.cc
Examining data/zita-rev1-0.2.2/source/global.h
Examining data/zita-rev1-0.2.2/source/guiclass.cc
Examining data/zita-rev1-0.2.2/source/mainwin.cc
Examining data/zita-rev1-0.2.2/source/pareq.cc
Examining data/zita-rev1-0.2.2/source/guiclass.h
Examining data/zita-rev1-0.2.2/source/styles.h
Examining data/zita-rev1-0.2.2/source/png2img.h
Examining data/zita-rev1-0.2.2/source/mainwin.h
Examining data/zita-rev1-0.2.2/source/rotary.h
Examining data/zita-rev1-0.2.2/source/reverb.h
Examining data/zita-rev1-0.2.2/source/styles.cc
Examining data/zita-rev1-0.2.2/source/png2img.cc
Examining data/zita-rev1-0.2.2/source/rotary.cc
Examining data/zita-rev1-0.2.2/source/reverb.cc
FINAL RESULTS:
data/zita-rev1-0.2.2/source/guiclass.cc:49:16: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
if (_form) snprintf (p, n, _form, _value);
data/zita-rev1-0.2.2/source/guiclass.cc:115:16: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
if (_form) snprintf (p, n, _form, _value);
data/zita-rev1-0.2.2/source/mainwin.cc:44:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (s, "%s", jclient->jname ());
data/zita-rev1-0.2.2/source/mainwin.cc:37:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s [256];
data/zita-rev1-0.2.2/source/png2img.cc:38:9: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
F = fopen (file, "r");
data/zita-rev1-0.2.2/source/rotary.h:36:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char _lncol [4];
data/zita-rev1-0.2.2/source/zita-rev1.cc:33:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
#define CP (char *)
data/zita-rev1-0.2.2/source/reverb.cc:309:23: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
t = 0.3f * _vdelay0.read ();
data/zita-rev1-0.2.2/source/reverb.cc:310:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x0 = _diff1 [0].process (_delay [0].read () + t);
data/zita-rev1-0.2.2/source/reverb.cc:311:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x1 = _diff1 [1].process (_delay [1].read () + t);
data/zita-rev1-0.2.2/source/reverb.cc:312:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x2 = _diff1 [2].process (_delay [2].read () - t);
data/zita-rev1-0.2.2/source/reverb.cc:313:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x3 = _diff1 [3].process (_delay [3].read () - t);
data/zita-rev1-0.2.2/source/reverb.cc:314:23: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
t = 0.3f * _vdelay1.read ();
data/zita-rev1-0.2.2/source/reverb.cc:315:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x4 = _diff1 [4].process (_delay [4].read () + t);
data/zita-rev1-0.2.2/source/reverb.cc:316:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x5 = _diff1 [5].process (_delay [5].read () + t);
data/zita-rev1-0.2.2/source/reverb.cc:317:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x6 = _diff1 [6].process (_delay [6].read () - t);
data/zita-rev1-0.2.2/source/reverb.cc:318:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x7 = _diff1 [7].process (_delay [7].read () - t);
data/zita-rev1-0.2.2/source/reverb.h:103:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
float read (void)
data/zita-rev1-0.2.2/source/reverb.h:136:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
float read (void)
ANALYSIS SUMMARY:
Hits = 19
Lines analyzed = 2525 in approximately 0.06 seconds (39678 lines/second)
Physical Source Lines of Code (SLOC) = 1709
Hits@level = [0] 18 [1] 12 [2] 4 [3] 0 [4] 3 [5] 0
Hits@level+ = [0+] 37 [1+] 19 [2+] 7 [3+] 3 [4+] 3 [5+] 0
Hits/KSLOC@level+ = [0+] 21.6501 [1+] 11.1176 [2+] 4.09596 [3+] 1.75541 [4+] 1.75541 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.